Looks good. -- Chris On Jun 19, 2013, at 8:31 AM, Mandy Chung <mandy.ch...@oracle.com> wrote:
> Thanks. I have revised the exception message and the test: > http://cr.openjdk.java.net/~mchung/jdk7u/8014925/webrev.01/ > > Mandy > > On 6/19/2013 4:36 AM, Alan Bateman wrote: >> On 19/06/2013 06:58, Mandy Chung wrote: >>> Alan, Chris, >>> >>> Can you review the fix for >>> [1] 8014925: Disable sun.reflect.Reflection.getCallerClass(int) with a >>> temporary switch to re-enable it >>> [2] 8016814: sun.reflect.Reflection.getCallerClass returns the wrong stack >>> frame >>> >>> Webrev at: >>> http://cr.openjdk.java.net/~mchung/jdk7u/8014925/webrev.00/ >> >> I agree with Jeroen's comment that the wording in the UOE message could be >> clearer. You could drop "However" too. >> >> Otherwise looks good to me. >> >> -Alan. >
