Nicolas,
Thanks for reporting the problem. I am curious if you have collected
any profiling data that shows
sun.util.logging.PlatformLogger.redirectPlatformLoggers() is the cause
of the performance degradation. This redirection is done as part of the
logging initialization before JFrame is
Vote: yes
Mandy
Thumbs up.
Mandy
On Feb 8, 2013, at 5:25 PM, Seán Coffey wrote:
> Nice work Stuart. Approved but please get someone with reviewer status to
> review before pushing change.
>
> regards,
> Sean.
>
> On 09/02/2013 00:51, Stuart Marks wrote:
>> Hi all,
>>
>> A simple request for code review *an
On 2/11/13 3:02 PM, Stuart Marks wrote:
http://cr.openjdk.java.net/~smarks/reviews/8007515/webrev.1/
Looks okay to me.
Mandy
You didn't include jdk_management test target in your jprt job and your
test was not run at all. jdk_management is not included in the default
due to its test reliability issue. Sounds like you didn't run the new
shell tests via jtreg on your local machine to make sure it passes
before you sub
Vote: yes
This is to request backport of the following bug fixes in 7u-dev:
8011380: FX dependency on PlatformLogger broken by 8010309
8010309: Improve PlatformLogger.isLoggable performance by direct mapping
from an integer to Level
7163898: add isLoggable() check to doLog()
Webrev at:
http://cr.ope
Changeset: edf084032dc3
Author:anthony
Date: 2012-04-24 19:12 +0400
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/edf084032dc3
7163898: add isLoggable() check to doLog()
Summary: Add the check and return immediately if it's false
Reviewed-by: anthony, mchung, sla
Contribut
Alan, Chris,
Can you review the fix for
[1] 8014925: Disable sun.reflect.Reflection.getCallerClass(int) with a
temporary switch to re-enable it
[2] 8016814: sun.reflect.Reflection.getCallerClass returns the wrong
stack frame
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk7u/8014925/webre
allow the code to work on future 7 update
releases."
Mandy
Otherwise the change looks good (I'm not an official reviewer).
Regards,
Jeroen
-Original Message-
From: jdk7u-dev-boun...@openjdk.java.net [mailto:jdk7u-dev-
boun...@openjdk.java.net] On Behalf Of Mandy Chung
Sen
On 6/18/2013 11:50 PM, John Rose wrote:
On Jun 18, 2013, at 11:28 PM, Mandy Chung wrote:
On 6/18/2013 11:12 PM, Jeroen Frijters wrote:
Hi Mandy,
Part of the exception message is a bit confusing:
"Update code properly using this method to allow the code"
Thanks Jeroen. I should
Thanks. I have revised the exception message and the test:
http://cr.openjdk.java.net/~mchung/jdk7u/8014925/webrev.01/
Mandy
On 6/19/2013 4:36 AM, Alan Bateman wrote:
On 19/06/2013 06:58, Mandy Chung wrote:
Alan, Chris,
Can you review the fix for
[1] 8014925: Disable
On 6/19/13 11:30 AM, Iris Clark wrote:
Hi, Mandy.
This looks good.
If you're still looking to shorten up the UOE, what about the following:
Replace "namespace. Such methods are not"
with "namespace so it is not"?
Replace "As a temporary measure, the 7u40 release notes describe a mechanism"
This is to request 7u40 phase 2 approval for:
8014925: Disable sun.reflect.Reflection.getCallerClass(int) with a
temporary switch to re-enable it
8016814: sun.reflect.Reflection.getCallerClass returns the wrong stack
frame
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014925
http://bugs
On 6/21/13 10:50 AM, Seán Coffey wrote:
Mandy,
Assuming you've run sufficient testing on this for 7u40 integration
purposes.
Yes - I ran JPRT on all core tests.
Approved for 7u40-dev.
Thanks
Mandy
regards,
Sean.
On 21/06/13 16:48, Mandy Chung wrote:
This is to request 7u40 ph
Sean, Iris,
Looks like the jdk7u40-dev-gate and jdk7u40-dev have different heads
that I can't push the changeset via the gate repo:
$ hg push
pushing to ssh://mch...@hg.openjdk.java.net/jdk7u/jdk7u40-dev-gate/jdk
searching for changes
abort: push creates new remote head 3e0468ae745a!
(you shou
6/13 23:31, Mandy Chung wrote:
Sean, Iris,
Looks like the jdk7u40-dev-gate and jdk7u40-dev have different heads
that I can't push the changeset via the gate repo:
$ hg push
pushing to ssh://mch...@hg.openjdk.java.net/jdk7u/jdk7u40-dev-gate/jdk
searching for changes
abort: push creates
Changeset: ee18d5c46468
Author:mchung
Date: 2013-06-25 16:12 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jdk/rev/ee18d5c46468
8016814: sun.reflect.Reflection.getCallerClass returns the frame off by 1
Reviewed-by: jrose, alanb, chegar, twisti
! src/share/classes/sun/refl
Changeset: 6bf5fa233df0
Author:mchung
Date: 2013-07-02 13:23 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jdk/rev/6bf5fa233df0
8014925: Disable sun.reflect.Reflection.getCallerClass(int) with a temporary
switch to re-enable it
Reviewed-by: jrose, alanb, chegar, twisti
!
Sean, Michael,
Can you please review this fix? WPTG doesn't translate all capitalized
words due to its current policy. 7175367 "NLS: 7u6 message drop10
integration" caused this regression in 7u5 but I uncovered recently.
Michael agrees to restore the translated version of
logging_xx.proper
Changeset: 69e208814cab
Author:mchung
Date: 2013-07-12 01:12 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jdk/rev/69e208814cab
8020228: Restore the translated version of logging_xx.properties
Reviewed-by: mfang, coffeys
! src/share/classes/sun/util/logging/resources/logg
Vote: yes
Mandy
Looks okay to me.
Mandy
On 8/19/2013 11:16 AM, Erik Gahlin wrote:
Thanks Andreas,
Here is an updated webrev with an updated copyright header.
http://cr.openjdk.java.net/~egahlin/7023754_2/
The same issue was fixed with
"8016531: jconsole-plugin script demo does not work with nashorn"
http://c
This is to request backport for a regression fix to 7u-dev:
8027943: serial version of
com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl
changed in 7u45
JBS bug:
https://bugs.openjdk.java.net/browse/JDK-8027943
It's a straight import of the changeset from jdk8/corba repo:
Daniel,
The fix looks good and approved.
I think this test may be good to be included in JDK 9 (backport to 8u).
But I'd like to get rid of its dependency on awt. I wonder if this can
be modified to create its own implementation of JavaAWTAccess in a
similar way of the new tests you added.
This is to request approval to backport 8027351 to 7u60.
https://bugs.openjdk.java.net/browse/JDK-8027351
Other than the makefile change, the patch is straight backport from JDK
8 changeset [1].
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk7u/webrevs/8027351/webrev.00/
The build and t
Changeset: fa00be1579b8
Author:mchung
Date: 2013-12-13 16:11 -0800
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/fa00be1579b8
8027351: (ref) Private finalize method invoked in preference to protected
superclass method
Reviewed-by: alanb, dholmes, mr, plevart, psandoz
! m
Changeset: ad8490675e4c
Author:mchung
Date: 2013-12-18 16:45 -0800
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/ad8490675e4c
8021368: Launch of Java Web Start app fails with ClassCircularityError
exception in 7u25
Reviewed-by: alanb, plevart, jfranck
! make/java/java/ma
This is (retrospectively) to request approval for:
https://bugs.openjdk.java.net/browse/JDK-8021368
The fix has been reviewed and approved [1]. I happily pushed the
changeset yesterday [2] and later realized that I missed to request a
formal approval (sorry about that and thanks to Sean for c
On 10/6/2014 4:35 AM, Ivan Gerasimov wrote:
Hello!
This is a 7u-only fix.
Some users complain about the ProxyGenerator not creating the
intermediate directories when asked to keep the generated files.
It throws an IO exception instead
The fix is essentially a part of JDK-8004260.
That was a
test. Nit: I suggest to remove the directory
"a" at the beginning rather than throwing a RuntimeException so that you
can run the test multiple times manually.
Mandy
Sincerely yours,
Ivan
On 07.10.2014 9:47, Mandy Chung wrote:
On 10/6/2014 4:35 AM, Ivan Gerasimov wrote:
Hello
http://cr.openjdk.java.net/~igerasim/8059563/3/webrev/
I reviewed v3 version. Looks good.
Mandy
On 12/3/2014 1:00 PM, Ivan Gerasimov wrote:
WEBREV: http://cr.openjdk.java.net/~igerasim/8065765/0/webrev/
Another alternative is to use Files.newDirectoryStream(path, "*.jar")
and increment the count. What you have is okay too.
Mandy
Thumbs up.
Mandy
On 12/4/2014 12:44 AM, Seán Coffey wrote:
Looks good. Hopefully Mandy can give the thumbs up before you push.
Approved.
regards,
Sean.
On 04/12/2014 07:29, Ivan Gerasimov wrote:
On 04.12.2014 2:44, Mandy Chung wrote:
On 12/3/2014 1:00 PM, Ivan Gerasimov wrote:
WEBREV
This is to request approval to backport the fix for 7068328 to
jdk7u-dev/jdk:
7068328: BufferPoolMXBean and PlatformLoggingMXBean getObjectName
may return null
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7068328
Changeset in jdk8 (and see [1] for the discussion):
http://hg
Changeset: 55cd74a4d575
Author:mchung
Date: 2011-08-23 10:35 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/55cd74a4d575
7068328: BufferPoolMXBean and PlatformLoggingMXBean getObjectName may return
null
Reviewed-by: alanb
Contributed-by: spo...@uk.ibm.com
! src/shar
37 matches
Mail list logo
