Re: Warning Fixes from LJC Hack Session

2012-02-02 Thread Stuart Marks
Good stuff! It looks like others have chimed in already with good advice. I'll take a look at the portion of the patches posted on core-libs-dev. s'marks On 2/2/12 1:05 AM, Michael Barker wrote: Hi, Attached is a patch that was a result of our work at the LJC OpenJDK Hack session on Tuesday.

hg: jdk8/jdk8/langtools: Added tag jdk8-b24 for changeset 6c9d21ca92c4

2012-02-02 Thread david . katleman
Changeset: 5a784dab75f1 Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/5a784dab75f1 Added tag jdk8-b24 for changeset 6c9d21ca92c4 ! .hgtags

hg: jdk8/jdk8/jdk: Added tag jdk8-b24 for changeset 34029a0c69bb

2012-02-02 Thread david . katleman
Changeset: 8da468cf037b Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/8da468cf037b Added tag jdk8-b24 for changeset 34029a0c69bb ! .hgtags

hg: jdk8/jdk8/jaxws: Added tag jdk8-b24 for changeset e0d90803439b

2012-02-02 Thread david . katleman
Changeset: b376d901e006 Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/b376d901e006 Added tag jdk8-b24 for changeset e0d90803439b ! .hgtags

hg: jdk8/jdk8/jaxp: Added tag jdk8-b24 for changeset 7836655e2495

2012-02-02 Thread david . katleman
Changeset: bb694c151fc7 Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/bb694c151fc7 Added tag jdk8-b24 for changeset 7836655e2495 ! .hgtags

hg: jdk8/jdk8/hotspot: Added tag jdk8-b24 for changeset a80fd4f45d7a

2012-02-02 Thread david . katleman
Changeset: 905945c5913e Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/905945c5913e Added tag jdk8-b24 for changeset a80fd4f45d7a ! .hgtags

hg: jdk8/jdk8: Added tag jdk8-b24 for changeset 1a5f1d6b98d6

2012-02-02 Thread david . katleman
Changeset: 5350cd6e0cc0 Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/5350cd6e0cc0 Added tag jdk8-b24 for changeset 1a5f1d6b98d6 ! .hgtags

hg: jdk8/jdk8/corba: Added tag jdk8-b24 for changeset b98f0e6dddf9

2012-02-02 Thread david . katleman
Changeset: e45d6b406d5f Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/e45d6b406d5f Added tag jdk8-b24 for changeset b98f0e6dddf9 ! .hgtags

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Kelly O'Hair
Vote: Yes -kto

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread David Katleman
Vote: yes

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Mike Duigou
Vote: Yes - Mike On Feb 2 2012, at 06:15 , Alan Bateman wrote: > > I hereby nominate Kurchi Subhra Hazra to jdk8 Committer. > > Kurchi graduated from the University of Illinois, Urbana Champaign with a > M.Sc. in Computer Science last summer, joining Oracle in July 2011 to work on > the JDK

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Xueming Shen
vote: yes On 02/02/2012 06:15 AM, Alan Bateman wrote: I hereby nominate Kurchi Subhra Hazra to jdk8 Committer. Kurchi graduated from the University of Illinois, Urbana Champaign with a M.Sc. in Computer Science last summer, joining Oracle in July 2011 to work on the JDK with a focus on netwo

Re: Warning Fixes from LJC Hack Session

2012-02-02 Thread Phil Race
On 2/2/2012 6:10 AM, Chris Hegarty wrote: Michael, I see others have guessed submitting separate code reviews. I can wait till then for a formal review, but here are a few specific comments: ICC_Profile.java You can use ICC_Profile as the generic type for the PrivilegedAction rather than O

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Jim Holmlund
Vote: yes

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Bradford Wetmore
Vote: Yes. Brad

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Joe Darcy
Vote: Yes -Joe

CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Abhijit Saha
Vote: Yes

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Mandy Chung
Vote: yes

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Chris Hegarty
Vote: yes -Chris.

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Sean Mullan
Vote: yes

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Daniel D. Daugherty
Vote: yes Dan On 2/2/12 7:15 AM, Alan Bateman wrote: I hereby nominate Kurchi Subhra Hazra to jdk8 Committer. Kurchi graduated from the University of Illinois, Urbana Champaign with a M.Sc. in Computer Science last summer, joining Oracle in July 2011 to work on the JDK with a focus on netw

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Artem Ananiev
Vote: yes. Artem On 2/2/2012 6:15 PM, Alan Bateman wrote: I hereby nominate Kurchi Subhra Hazra to jdk8 Committer. Kurchi graduated from the University of Illinois, Urbana Champaign with a M.Sc. in Computer Science last summer, joining Oracle in July 2011 to work on the JDK with a focus on n

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Kumar Srinivasan
Vote: Yes

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Michael McMahon
Vote: Yes - Michael

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Xiomara Jayasena
Vote: yes -Xiomara On 2/2/12 6:15 AM, Alan Bateman wrote: I hereby nominate Kurchi Subhra Hazra to jdk8 Committer. Kurchi graduated from the University of Illinois, Urbana Champaign with a M.Sc. in Computer Science last summer, joining Oracle in July 2011 to work on the JDK with a focus o

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Vincent Ryan
Vote: Yes On 02/ 2/12 02:15 PM, Alan Bateman wrote: > > I hereby nominate Kurchi Subhra Hazra to jdk8 Committer. > > Kurchi graduated from the University of Illinois, Urbana Champaign with a > M.Sc. > in Computer Science last summer, joining Oracle in July 2011 to work on the > JDK > with a f

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Weijun Wang
Vote: Yes -Weijun

CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Alan Bateman
I hereby nominate Kurchi Subhra Hazra to jdk8 Committer. Kurchi graduated from the University of Illinois, Urbana Champaign with a M.Sc. in Computer Science last summer, joining Oracle in July 2011 to work on the JDK with a focus on networking and libraries. To date Kurchi has contributed sev

Re: Warning Fixes from LJC Hack Session

2012-02-02 Thread Chris Hegarty
Michael, I see others have guessed submitting separate code reviews. I can wait till then for a formal review, but here are a few specific comments: ICC_Profile.java You can use ICC_Profile as the generic type for the PrivilegedAction rather than Object. --- a/src/share/classes/java/awt/c

Re: Warning Fixes from LJC Hack Session

2012-02-02 Thread Michael Barker
> > I deliberately did not make these changes yet as they will cause TCK > failures due to the signatures and will do this as part of the JDBC 4.2 > work and align it with the TCK team > > I would prefer to hold off on this change for now. > No problem, I'll drop them out when I resubmit to the se

Re: AIX and OpenJDK

2012-02-02 Thread Steve Poole
On 02/02/2012 10:43, Alan Bateman wrote: On 01/02/2012 18:26, Volker Simonis wrote: I think the prerequisite for a port can not be that there exists access to it on "x86 hardware". With this constraint there will never be an OpenJDK port to other architectures like PPC/Itanium/ARM to name just

Re: Warning Fixes from LJC Hack Session

2012-02-02 Thread Lance Andersen - Oracle
On Feb 2, 2012, at 5:58 AM, Michael Barker wrote: >> Michael - I skimmed through this and see a couple of API changes and a few >> methods in java.sql.Date deprecated. I'm sure Stuart will go through >> everything in detail but just to mention that some of changes may be a bit >> out of scope. >

Re: Warning Fixes from LJC Hack Session

2012-02-02 Thread Michael Barker
> Michael - I skimmed through this and see a couple of API changes and a few > methods in java.sql.Date deprecated. I'm sure Stuart will go through > everything in detail but just to mention that some of changes may be a bit > out of scope. These were cases where the methods were already marked as

Re: AIX and OpenJDK

2012-02-02 Thread Andrew Haley
On 02/02/2012 10:43 AM, Alan Bateman wrote: > This thread highlights that we need to figure out how OpenJDK can > accommodate additional ports going forward. I would be interested to > hear how other projects do this. I've heard of projects that have a > core set of platforms and then additional te

Re: AIX and OpenJDK

2012-02-02 Thread Alan Bateman
On 01/02/2012 18:26, Volker Simonis wrote: I think the prerequisite for a port can not be that there exists access to it on "x86 hardware". With this constraint there will never be an OpenJDK port to other architectures like PPC/Itanium/ARM to name just a few. (By the way, there once upon a time

Re: Warning Fixes from LJC Hack Session

2012-02-02 Thread Alan Bateman
On 02/02/2012 09:05, Michael Barker wrote: Hi, Attached is a patch that was a result of our work at the LJC OpenJDK Hack session on Tuesday. They are all warning fixes, based on the same rules as the big warning cleanup day from last year. I rolled it up into a single patch, but I can split it

Re: Warning Fixes from LJC Hack Session

2012-02-02 Thread Rémi Forax
On 02/02/2012 10:05 AM, Michael Barker wrote: Hi, Attached is a patch that was a result of our work at the LJC OpenJDK Hack session on Tuesday. They are all warning fixes, based on the same rules as the big warning cleanup day from last year. I rolled it up into a single patch, but I can split

Warning Fixes from LJC Hack Session

2012-02-02 Thread Michael Barker
Hi, Attached is a patch that was a result of our work at the LJC OpenJDK Hack session on Tuesday. They are all warning fixes, based on the same rules as the big warning cleanup day from last year. I rolled it up into a single patch, but I can split it by packages or classes if that is preferred.