RFR: 8022746: List of spelling errors in API doc

Hello, Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8022746 I've replaced all typos with correct words in all documentations and comments. Our technical writer has already checked it. Thanks

Re: RFR: 8022746: List of spelling errors in API doc

10.2013 17:05, Alan Bateman wrote: On 22/10/2013 13:22, sergey malenkov wrote: Hello, Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8022746 I've replaced all typos with correct words in all docu

Re: RFR: 8022746: List of spelling errors in API doc

22/10/2013 13:22, sergey malenkov wrote: Hello, Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8022746 I've replaced all typos with correct words in all documentations and comments. Our tech

Re: RFR: 8022746: List of spelling errors in API doc

supported ProtocolList. Other than that, I reviewed all the security/crypto changes and they look good to me. BTW, "accommodate, "occurred" and "preferred" are commonly misspelt ;) --Sean On 10/22/2013 08:22 AM, sergey malenkov wrote: Hello, Could you please revi

Re: RFR: 8022746: List of spelling errors in API doc

Thank you for this information. I'll remove *.1 files from the webrev. Regards, SAM On 22.10.2013 19:46, Jonathan Gibbons wrote: On 10/22/2013 05:22 AM, sergey malenkov wrote: Hello, Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/802274

Re: RFR: 8022746: List of spelling errors in API doc

anumerics". In fact it's not a typo, as "alphanum" is defined in BCP 47 standard. Naoto On 10/22/13 5:22 AM, sergey malenkov wrote: Hello, Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ bug:https://bugs.openjdk.java.net/brows

Re: RFR: 8022746: List of spelling errors in API doc

Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8022746 The second version of the fix is here: http://cr.openjdk.java.net/~malenkov/8022746.8.1/

Reminder: RFR: 8022746: List of spelling errors in API doc

Any objections? SAM On 23.10.2013 19:05, sergey malenkov wrote: Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8022746 The second version of the fix is here: http://cr.openjdk.java.net

RFR: 8026491: Typos in string literals

Hello, Could you please review the following fix: fix:http://cr.openjdk.java.net/~malenkov/8026491.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8026491 I've replaced all typos with correct words in all string literals. This is a second part of the previous fix (8022746: List of spelling er

Re: RFR: 8026491: Typos in string literals

Unfortunately the webrev's wdiff is failed, so I've prepared the following page for your convenience: http://cr.openjdk.java.net/~malenkov/8026491.8.0/diff.html <http://cr.openjdk.java.net/%7Emalenkov/8026491.8.0/diff.html> Thanks, SAM On 30.10.2013 15:43, sergey malenkov w

Re: RFR: 8026491: Typos in string literals

rep before and after? -- Jon On 10/30/2013 01:17 PM, Stuart Marks wrote: The changes look good. It looks like "occured" is the most common spelling error. I wonder how many instances of this misspelling will remain in the codebase after your fixes. s'marks On 10/30/13 4:43 AM, se

Re: RFR: 8026491: Typos in string literals

Agree, I didn't changed that line. The attached list contains only false alarms. Thanks, SAM On 01.11.2013 6:16, Weijun Wang wrote: On 10/31/2013 5:58 AM, sergey malenkov wrote: Hi Stuart, I've attached a file with all typos which had been left after the fix. There are no any occu

Re: CFV: New JDK8 Reviewer: Petr Pchelko

Vote: Yes SAM On 19.11.2013 17:11, Artem Ananiev wrote: I hereby nominate Petr Pchelko (OpenJDK user name: pchelko) to JDK8 Reviewer. Petr is one of the most active contributors to AWT and Swing. He is currently a JDK8 Committer, voting for JDK7u Committer is in progress. The list of Petr

Re: CFV: New jdk8 Reviewer: Stuart Marks

Vote: YES SAM On 22.11.2013 17:47, Alan Bateman wrote: I hereby nominate Stuart Marks to jdk8 Reviewer. Stuart has Committer role in the jdk8, jdk7u and lambda projects. He has been contributing changes to OpenJDK for almost 3 years. He is author to more than 60 changes in the jdk8 forest a

Re: CFV: New JDK8 Committer: Jonathan Lu

Vote: YES On 14.06.2012 17:49, Artem Ananiev wrote: I hereby nominate Jonathan Lu (OpenJDK user name: luchsh) to JDK8 Committer. Jonathan has contributed a number of changes to different JDK areas: http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=luchsh Votes are due by Jun 28, 2012. Only cu

Re: CFV: New JDK8 Committer: Leonid Romanov

Vote: YES Thanks, SAM On 21.08.2012 14:37, Artem Ananiev wrote: I hereby nominate Leonid Romanov (OpenJDK user name: leonidr) to JDK8 Committer. Leonid is a member of AWT group. He has contributed many changes to AWT and Swing code into 7u and 8, mostly for Mac OS X platform: http://hg.openj

Re: CFV: New JDK8 Reviewer: Sergey Bylokhov

Vote:YES On 04.12.2012 18:13, Artem Ananiev wrote: I hereby nominate Sergey Bylokhov (OpenJDK user name: serb) to Reviewer in JDK8 project. Sergey is a member of AWT group at Oracle and committer in JDK6, JDK7, JDK7u, and JDK8 projects. He has contributed a number of very non-trivial changes t

Re: CFV: New JDK8 Reviewer: Alexander Scherbatiy

Vote: YES SAM On 12.12.2012 19:01, Artem Ananiev wrote: I hereby nominate Alexander Scherbatiy (OpenJDK user name: alexsch) to Reviewer in JDK8 project. Alexander is a member of AWT and Swing groups at Oracle. He has committed 50+ changesets to JDK7u and JDK8. He is also an active participant

Re: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

Hi Fredrik, Looks OK to me. But there are a lot of images in the make/tools/swing-beans/beaninfo/images folder. Could you please check the make/javax/swing/beaninfo/SwingBeans.gmk file to ensure that the dt.jar library will be packed correctly? Also I think that moving of java files from t

Re: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

(by default) classes. Second, *BeanInfo java files are generated automatically. They are not well-formatted and well-documented. Thanks, SAM On 07.01.2013 19:59, Fredrik Öhrström wrote: 2012/12/18 Sergey Malenkov : Looks OK to me. But there are a lot of images in the make/tools/swing-bea

Re: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

Hi Fredrik, Thanks! It looks good to me. Regards, SAM On 09.01.2013 16:07, Fredrik Öhrström wrote: 2013/1/9 Sergey Malenkov : First, *BeanInfo classes must be packed to dt.jar, not rt.jar. So, it will be strange to provide sources for nonexistent (by default) classes. Second, *BeanInfo java

Re: CFV: New JDK8 Committer: Konstantin Shefov

Vote: YES On 18.01.2013 14:17, Artem Ananiev wrote: I hereby nominate Konstantin Shefov (OpenJDK user name: kshefov) to JDK8 Committer. Konstantin is a member of Client SQE team at Oracle. He has been making AWT, Swing, and Java2D tests more better and more reliable. A number of Konstantin's c

Re: CFV: New JDK8 Committer: Petr Pchelko

Vote: Yes SAM On 12.04.2013 13:16, Artem Ananiev wrote: I hereby nominate Petr Pchelko (OpenJDK user name: pchelko) to JDK8 Committer. Petr is a member of AWT/Swing and JavaFX teams at Oracle. Here is the list of his contributions to JDK (JavaFX list is to come!): http://hg.openjdk.java.

Re: CFV : New jdk8 Reviewer : Brian Goetz

Vote: YES On 21.05.2013 3:41, Mike Duigou wrote: I hereby nominate Brian Goetz to jdk8 project Reviewer. Brian is the Java Language Architect at Oracle and has been leading the Lambda language and library efforts (JSR-335). Much of this work was recently integrated into the JDK 8 repositories

Re: CFV: New JDK8 Committer: Vladislav Karnaukhov

Vote: yes On 05.06.2013 20:54, Alexander Potochkin wrote: I hereby nominate Vladislav Karnaukhov to jdk8 Committer. Vlad has been a member of the Java SE sustaining team for five years. He has spent most of that time working on customer escalations. He has contributed several changes to jdk8

Re: CFV: New JDK8 Committer: Anton Litvinov

Vote: Yes On 25.06.2013 19:22, Alexander Potochkin wrote: I hereby nominate Anton Litvinov to jdk8 Committer. Anton has been a member of the Java SE sustaining team for more then a year. He has spent most of that time working on client issues. He has contributed several changes to jdk8 so far

Fwd: [8] Review request for 8010782 : clean up source files containing carriage return characters

containing carriage return characters Date: Wed, 17 Jul 2013 18:19:42 +0400 From: sergey malenkov To: swing-...@openjdk.java.net Hello, Could you please review the following fix: fix: http://cr.openjdk.java.net/~malenkov/8010782.8.0/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id

Re: CFV: New JDK8 Reviewer: Anton Tarasov

Vote: Yes SAM On 02.08.2013 14:32, Artem Ananiev wrote: I hereby nominate Anton Tarasov (OpenJDK user name: ant) to JDK8 Reviewer. Anton is currently a Committer in JDK7, 7u, 8, and OpenJFX projects. He is a member of AWT/Swing and JavaFX groups at Oracle, now working on JavaFX/Swing and

Re: CFV: New JDK8 Committer Brian Burkhalter (bpb)

Vote: Yes SAM On 15.08.2013 1:23, Mike Duigou wrote: I hereby nominate Brian Burkhalter to jdk8 Committer. Brian joined the Oracle OpenJDK team a couple of months ago and has quickly become a very active contributor to the long neglected numerics area. In addition to contributing a number of