[ http://issues.apache.org/jira/browse/JDO-139?page=all ]
Michael Bouschen resolved JDO-139:
--
Resolution: Fixed
I removed class GetOptimistic and updated the assertion spreadsheet.
I also updated class Rollback to not refer the query test class
Issues with tck20 test case transaction.GetOptimistic
-
Key: JDO-139
URL: http://issues.apache.org/jira/browse/JDO-139
Project: JDO
Type: Bug
Components: tck20
Reporter: Michael Bouschen
Assigned to:
[ http://issues.apache.org/jira/browse/JDO-51?page=all ]
Michael Bouschen resolved JDO-51:
-
Resolution: Fixed
I added new goals to the top level maven.xml to clean and build jdo11, jdo20
and tck20 projects:
jdo11.build - builds all JDO1 projects
[ http://issues.apache.org/jira/browse/JDO-51?page=all ]
Michael Bouschen reassigned JDO-51:
---
Assign To: Michael Bouschen (was: Michelle Caisse)
Improve documentation on build dependencies
---
Key:
[ http://issues.apache.org/jira/browse/JDO-142?page=all ]
Michael Bouschen resolved JDO-142:
--
Resolution: Fixed
Checked in query test repackaging (see revision 290687).
Restructure query test packages
---
[ http://issues.apache.org/jira/browse/JDO-92?page=all ]
Michael Bouschen updated JDO-92:
Attachment: JDO92.patch
Attached you find a patch removing the GUI test runner (SwingTestRunner), class
TestListSuite and the outdated list of test classes
[ http://issues.apache.org/jira/browse/JDO-153?page=all ]
Michael Bouschen updated JDO-153:
-
Attachment: springUpgrade.patch
Attached you find a patch upgrading to stringframework version 1.2.5.
Upgrade springframework version used in tck20/tck11
[ http://issues.apache.org/jira/browse/JDO-153?page=all ]
Michael Bouschen resolved JDO-153:
--
Resolution: Fixed
With version 1.2 springframework introduced a new separate jar for the bean
factory classes. So I needed to add a dependency for the
[
http://issues.apache.org/jira/browse/JDO-156?page=comments#action_12331810 ]
Michael Bouschen commented on JDO-156:
--
The patch looks good, just a few comments:
QueryElementHolder:
- I propose to change the constructor arguments specifying the range
[
http://issues.apache.org/jira/browse/JDO-156?page=comments#action_12331876 ]
Michael Bouschen commented on JDO-156:
--
Two minors:
- QueryElementHolder: there is a private method rangeToString to create the
range element for a single string query. I
[
http://issues.apache.org/jira/browse/JDO-157?page=comments#action_12331882 ]
Michael Bouschen commented on JDO-157:
--
Just some minor comments:
Class CompanyModelReader
- The CompanyModelReader change is already checked in as part of patch 156.
[
http://issues.apache.org/jira/browse/JDO-158?page=comments#action_12331885 ]
Michael Bouschen commented on JDO-158:
--
- A14.6.2-40: modulo operator.
The current implementation uses a QueryElementHolder to run a modulo query as
API query and single
[
http://issues.apache.org/jira/browse/JDO-157?page=comments#action_12331895 ]
Michael Bouschen commented on JDO-157:
--
Looks good!
Implement new JDO 2 query tests cases concerning keywords.
--
[
http://issues.apache.org/jira/browse/JDO-158?page=comments#action_12331969 ]
Michael Bouschen commented on JDO-158:
--
Looks good, ship it!
Implement new JDO 2 query tests cases concerning new operators.
[
http://issues.apache.org/jira/browse/JDO-159?page=comments#action_12331973 ]
Michael Bouschen commented on JDO-159:
--
A few comments.
Class SupportedStringMethods:
- Typo (Map instead of String) in the title: Supported Map methods
- How about using
[
http://issues.apache.org/jira/browse/JDO-160?page=comments#action_12332218 ]
Michael Bouschen commented on JDO-160:
--
Some comments about JDO-160.patch:
OrderOfParameters:
- I propose to add a second test query that switches the order of param1 and
[ http://issues.apache.org/jira/browse/JDO-178?page=all ]
Michael Bouschen updated JDO-178:
-
Component: api11
api20
javax.jdo.spi.I18NHelper causes NullPointerException
[
http://issues.apache.org/jira/browse/JDO-154?page=comments#action_12332371 ]
Michael Bouschen commented on JDO-154:
--
I looked at the patch. I just have one question: would it make sense to call
putUserObject a second time for the same key and verify
[
http://issues.apache.org/jira/browse/JDO-160?page=comments#action_12332464 ]
Michael Bouschen commented on JDO-160:
--
Two comments:
- Class OrderOfParameters defines queries using explicilty declared parameters
. I propose to change this to implicit
[
http://issues.apache.org/jira/browse/JDO-161?page=comments#action_12355946 ]
Michael Bouschen commented on JDO-161:
--
Some comments:
datastoreidentity/schema.sql:
- The patch replaces table JDOQLKeywordsAsFieldNames with table NoExtent.
instad of
[
http://issues.apache.org/jira/browse/JDO-162?page=comments#action_12355947 ]
Michael Bouschen commented on JDO-162:
--
Some comments about the patch
CharacterAndStringLiterals.java:
- I propose to change the filter of the invalid query to charNotNull
[
http://issues.apache.org/jira/browse/JDO-161?page=comments#action_12356056 ]
Michael Bouschen commented on JDO-161:
--
The new patch looks good.
Just one comment: I think support for unconstrained variables is optional, so
classes
[
http://issues.apache.org/jira/browse/JDO-188?page=comments#action_12356278 ]
Michael Bouschen commented on JDO-188:
--
The patch looks good.
Just one remark: the localSetUp method creates a second PM which is not closed
in the test case. Should we
[ http://issues.apache.org/jira/browse/JDO-36?page=all ]
Michael Bouschen closed JDO-36:
---
Implement JDOQLQueryFactory proposal
Key: JDO-36
URL: http://issues.apache.org/jira/browse/JDO-36
[ http://issues.apache.org/jira/browse/JDO-139?page=all ]
Michael Bouschen closed JDO-139:
Issues with tck20 test case transaction.GetOptimistic
-
Key: JDO-139
URL:
[ http://issues.apache.org/jira/browse/JDO-153?page=all ]
Michael Bouschen closed JDO-153:
Upgrade springframework version used in tck20/tck11
---
Key: JDO-153
URL:
[
http://issues.apache.org/jira/browse/JDO-163?page=comments#action_12356501 ]
Michael Bouschen commented on JDO-163:
--
A lot of new test cases. They look good, just a few comments:
QueryTest:
The new method takes an expected result and assumes an
[
http://issues.apache.org/jira/browse/JDO-163?page=comments#action_12357022 ]
Michael Bouschen commented on JDO-163:
--
The second patch looks good.
Implement new JDO 2 query tests cases concerning query API Extensions
[
http://issues.apache.org/jira/browse/JDO-204?page=comments#action_12357741 ]
Michael Bouschen commented on JDO-204:
--
I understand the scenario that the user wants to store instances of different
PC types in the collection. This means even with JDK 5
[
http://issues.apache.org/jira/browse/JDO-216?page=comments#action_12357969 ]
Michael Bouschen commented on JDO-216:
--
Look s good, just a few comments:
QueryTest
- Methods getCompanyModelInstances and getMylibInstances are deprecated, but we
might
[
http://issues.apache.org/jira/browse/JDO-164?page=comments#action_12358151 ]
Michael Bouschen commented on JDO-164:
--
The patch looks good. Class Unique has the comment talking about avoiding file
I/O which we can remove.
Implement new JDO 2 query
[
http://issues.apache.org/jira/browse/JDO-165?page=comments#action_12358359 ]
Michael Bouschen commented on JDO-165:
--
Looks good. Some comments:
ShapeOfResult:
- I guess the C in the comment of the first two queries in VALID_SQL_QUERIES
means
[
http://issues.apache.org/jira/browse/JDO-165?page=comments#action_12358396 ]
Michael Bouschen commented on JDO-165:
--
Looks good, no comments!
Implement new JDO 2 query tests cases concerning SQL queries.
[
http://issues.apache.org/jira/browse/JDO-223?page=comments#action_12358620 ]
Michael Bouschen commented on JDO-223:
--
Looks good!
SupportedMapMethods miss queries calling isEmpty() and size().
SupportedCollectionMethods must be extended by queries
[
http://issues.apache.org/jira/browse/JDO-224?page=comments#action_12358621 ]
Michael Bouschen commented on JDO-224:
--
Looks good!
Adapt ResultClassRequirements to new wording in spec concerning assertion
A14.6.12-1.
[
http://issues.apache.org/jira/browse/JDO-226?page=comments#action_12358783 ]
Michael Bouschen commented on JDO-226:
--
Looks good!
DistintCandidateInstances.testCollectionQueries typo
[
http://issues.apache.org/jira/browse/JDO-166?page=comments#action_12359034 ]
Michael Bouschen commented on JDO-166:
--
Looks good.
However, I propose to update the comments in DeleteQueryElements, because I
think some of them are misleading, e.g.
[
http://issues.apache.org/jira/browse/JDO-147?page=comments#action_12359142 ]
Michael Bouschen commented on JDO-147:
--
Oops, I forgot two comments:
- Class StringConcatenation defines a field parameters for the actual
parameters of the test queries.
[
http://issues.apache.org/jira/browse/JDO-147?page=comments#action_12359141 ]
Michael Bouschen commented on JDO-147:
--
Oops, I forgot two comments:
- Class StringConcatenation defines a field parameters for the actual
parameters of the test queries.
[
http://issues.apache.org/jira/browse/JDO-228?page=comments#action_12359718 ]
Michael Bouschen commented on JDO-228:
--
The patch looks good!
Enhancer error message for org/apache/jdo/tck/pc/mylib/PCClass.jdo
[
http://issues.apache.org/jira/browse/JDO-229?page=comments#action_12359720 ]
Michael Bouschen commented on JDO-229:
--
The second patch looks good.
Class DeleteCallback must not assume managed relationships.
[
http://issues.apache.org/jira/browse/JDO-167?page=comments#action_12359737 ]
Michael Bouschen commented on JDO-167:
--
Looks good!
Inheritance mapping 2 needs to be changed to support polymorphic
relationships to Employees
Timing bug in TCK test case ThreadSafe
--
Key: JDO-238
URL: http://issues.apache.org/jira/browse/JDO-238
Project: JDO
Type: Bug
Components: tck11, tck20
Reporter: Michael Bouschen
Assigned to: Martin Zaun
Priority:
[
http://issues.apache.org/jira/browse/JDO-230?page=comments#action_12359873 ]
Michael Bouschen commented on JDO-230:
--
The patch looks good, no comments.
Fix order of makePersistent() and addTearDownClass() in localSetUp methods
[
http://issues.apache.org/jira/browse/JDO-243?page=comments#action_12360314 ]
Michael Bouschen commented on JDO-243:
--
my $0.02:
I think it is dangerous to automatically add the field to the grouping, because
this changes the semantics of the query as
[
http://issues.apache.org/jira/browse/JDO-256?page=comments#action_12360316 ]
Michael Bouschen commented on JDO-256:
--
Both xml files companyNoRelationships and companyAllRelationships define the
same pc instances, but companyNoRelationships does not
[ http://issues.apache.org/jira/browse/JDO-206?page=all ]
Michael Bouschen updated JDO-206:
-
Attachment: JDO-206.patch
I agree with Erik that there is a problem with derby since it converts the
float value to a double when storing. However, this test
[ http://issues.apache.org/jira/browse/JDO-244?page=all ]
Michael Bouschen updated JDO-244:
-
Attachment: JDO-244.patch
I agree we should changet the query. The attached patch changes the query to
SELECT department, SUM(salary) FROM
[ http://issues.apache.org/jira/browse/JDO-206?page=all ]
Michael Bouschen updated JDO-206:
-
Attachment: JDO-206.patch2
Attached you find a new patch (JDO-206.patch2) for review.
The patch changes the schema for derby and uses the coumn type REAL for
[
http://issues.apache.org/jira/browse/JDO-194?page=comments#action_12360951 ]
Michael Bouschen commented on JDO-194:
--
Interesting! Yes, I'm using Windows. I think it has to do with queries using a
variable with the same name as a class (modulo case).
[
http://issues.apache.org/jira/browse/JDO-244?page=comments#action_12361068 ]
Michael Bouschen commented on JDO-244:
--
I checked in the updated patch (revision 358395).
However, the test org.apache.jdo.tck.query.result.Having still fails, because
it
[
http://issues.apache.org/jira/browse/JDO-264?page=comments#action_12361124 ]
Michael Bouschen commented on JDO-264:
--
The patch looks good.
About your question: I'm not sure whether we still need the property
iut.enhancer.classpath. Especially
[ http://issues.apache.org/jira/browse/JDO-194?page=all ]
Michael Bouschen reassigned JDO-194:
Assign To: Michael Bouschen (was: Erik Bengtson)
JPOX does not support implicit variables.
-
Key:
[
http://issues.apache.org/jira/browse/JDO-194?page=comments#action_12361212 ]
Michael Bouschen commented on JDO-194:
--
Sorry Andy, this seems to be a JRE problem when running on Windows. I tried,
but the problem remains:
at
[
http://issues.apache.org/jira/browse/JDO-257?page=comments#action_12361527 ]
Michael Bouschen commented on JDO-257:
--
Checked in the patch (modified according to Craig's comment); see revision
365353.
Change return type of makePersistent from void
[
http://issues.apache.org/jira/browse/JDO-245?page=comments#action_12361607 ]
Michael Bouschen commented on JDO-245:
--
The negative test is only testing whether the JDO implementation throws an
exception for the invalid HAVING clause. It does not
[ http://issues.apache.org/jira/browse/JDO-244?page=all ]
Michael Bouschen resolved JDO-244:
--
Resolution: Fixed
Good point Andy! Actually the generated SQL is correct.
I know what the problem is: the JDOQL query is not valid. It accesses a field
[
http://issues.apache.org/jira/browse/JDO-245?page=comments#action_12361678 ]
Michael Bouschen commented on JDO-245:
--
A lot of comments, I'll try to give answers.
CLR: There is only one thing wrong with this query: the HAVING clause is not a
[
http://issues.apache.org/jira/browse/JDO-269?page=comments#action_12361685 ]
Michael Bouschen commented on JDO-269:
--
The patch looks good.
One question: with the patch 0 cannot be used as valid id, because the code
interprets id=0 as undefined id.
[ http://issues.apache.org/jira/browse/JDO-242?page=all ]
Michael Bouschen resolved JDO-242:
--
Resolution: Fixed
This is the same as described in JDO-244 and JDO-271: the JDOQL query is not
valid, because it uses a field from the subclass. Craig
[ http://issues.apache.org/jira/browse/JDO-245?page=all ]
Michael Bouschen updated JDO-245:
-
Summary: JPOX must throw JDOUserException for a query using a non grouping
expr w/o aggregates in the HAVING clause. (was: JPOX must throw
JDOUserException
[ http://issues.apache.org/jira/browse/JDO-258?page=all ]
Michael Bouschen updated JDO-258:
-
Summary: Write tests for new persistent-nontransactional-dirty lifecycle
assertions (was: Write tests for attach/detach lifecycle assertions)
Write tests for
[ http://issues.apache.org/jira/browse/JDO-259?page=all ]
Michael Bouschen reopened JDO-259:
--
Reopened.
The title is misleading: it talks about detach/attach where the issue is about
persistent-nontransactional-dirty.
Write tests for
[ http://issues.apache.org/jira/browse/JDO-64?page=all ]
Michael Bouschen reassigned JDO-64:
---
Assign To: Martin Zaun
Enhancer test cases must be adapted to JDO2.
Key: JDO-64
URL:
[ http://issues.apache.org/jira/browse/JDO-275?page=all ]
Michael Bouschen updated JDO-275:
-
Fix Version: JDO 2 beta
Split out alltests.conf into several, smaller configurations
[
http://issues.apache.org/jira/browse/JDO-277?page=comments#action_12362681 ]
Michael Bouschen commented on JDO-277:
--
The patch looks good. You might want to take a look at the other company model
test data xml files, because they might define the
[ http://issues.apache.org/jira/browse/JDO-279?page=all ]
Michael Bouschen updated JDO-279:
-
Attachment: distrib.patch2
Attached you find a new patch distrib.patch2.
- I think any groupId changes should be part of of JDO-278, so I removed any
groupId
[
http://issues.apache.org/jira/browse/JDO-278?page=comments#action_12363038 ]
Michael Bouschen commented on JDO-278:
--
Looks good, just a few comments:
- All the default goals in the maven.xml files now call jar:install instead of
[ http://issues.apache.org/jira/browse/JDO-279?page=all ]
Michael Bouschen updated JDO-279:
-
Attachment: mavenDistSupport.patch
Andy proposed to use 'maven dist' for the distribution. There is not need to
add our own distrib goal to tck20, so forget
[
http://issues.apache.org/jira/browse/JDO-279?page=comments#action_12363463 ]
Michael Bouschen commented on JDO-279:
--
I checked in the patch mavenDistSupport-2.patch ino the trunk and into
branches/2.0-beta (see revision 370910).
Release tck20 as
[ http://issues.apache.org/jira/browse/JDO-279?page=all ]
Michael Bouschen updated JDO-279:
-
Attachment: mavenDistSupport-3.patch
The new patch mavenDistSupport-3.patch adds the directories assertions and
iut_jars to the jdo2-tck distribution.
I
[
http://issues.apache.org/jira/browse/JDO-279?page=comments#action_12363537 ]
Michael Bouschen commented on JDO-279:
--
Hi Craig,
I did not intent to include the content of iut_jars, just the empty directory:
include name=iut_jars/
exclude
[
http://issues.apache.org/jira/browse/JDO-279?page=comments#action_12363541 ]
Michael Bouschen commented on JDO-279:
--
Checked in, see revision 371128.
Release tck20 as source with a binary dependency on other projects
[ http://issues.apache.org/jira/browse/JDO-284?page=all ]
Michael Bouschen updated JDO-284:
-
Attachment: JDO-284.patch
Attached you find a patch (JDO-284.patch) that updates the dist:build-src
preGoald to include the build.properties into the
[ http://issues.apache.org/jira/browse/JDO-284?page=all ]
Michael Bouschen reassigned JDO-284:
Assign To: Michael Bouschen
build.properties is missing from distribution
-
Key: JDO-284
[ http://issues.apache.org/jira/browse/JDO-284?page=all ]
Michael Bouschen resolved JDO-284:
--
Fix Version: JDO 2 beta
Resolution: Fixed
Thanks Michelle! I cheched in the changes plus removing the generated build.xml
from the distribution
[
http://issues.apache.org/jira/browse/JDO-246?page=comments#action_12364631 ]
Michael Bouschen commented on JDO-246:
--
Here is the JDOQL:
SELECT e.manager.lastname FROM org.apache.jdo.tck.pc.company.Department
WHERE employees.contains(e) VARIABLES
[
http://issues.apache.org/jira/browse/JDO-246?page=comments#action_12364667 ]
Michael Bouschen commented on JDO-246:
--
Section 14.6.9 Specifying the Result of a Query (Projections, Aggregates)
explicitly defines a different behavior in case a variable
[
http://issues.apache.org/jira/browse/JDO-246?page=comments#action_12364812 ]
Michael Bouschen commented on JDO-246:
--
I'm a little confused about the term intersection. Just for my understanding:
do you mean Cartesian product?
Here is my
[ http://issues.apache.org/jira/browse/JDO-297?page=all ]
Michael Bouschen updated JDO-297:
-
Attachment: jdo11.patch
I agree, we should use SNAPSHOT in the trunk. The attached patch jdo11.patch
changes the version in api11, ri11 and tck11 to SNAPSHOT
[ http://issues.apache.org/jira/browse/JDO-297?page=all ]
Michael Bouschen reassigned JDO-297:
Assign To: Michael Bouschen
RI11 doesn't run
Key: JDO-297
URL: http://issues.apache.org/jira/browse/JDO-297
[ http://issues.apache.org/jira/browse/JDO-297?page=all ]
Michael Bouschen resolved JDO-297:
--
Resolution: Fixed
Checked in patch jdo11.patch.
RI11 doesn't run
Key: JDO-297
URL:
[
http://issues.apache.org/jira/browse/JDO-303?page=comments#action_12366030 ]
Michael Bouschen commented on JDO-303:
--
Looks good!
NPE in ResultSummary if no tests were run
-
Key: JDO-303
[ http://issues.apache.org/jira/browse/JDO-202?page=all ]
Michael Bouschen updated JDO-202:
-
Attachment: schemaValidation-060212.patch
The attached patch schemaValidation-060212.patch adds a new test XMLTest.
orm.xsd and unit tests for xsd are missing
Remove keyword IMPORTS from TCK query test classes
--
Key: JDO-305
URL: http://issues.apache.org/jira/browse/JDO-305
Project: JDO
Type: Bug
Components: tck20
Versions: JDO 2 beta
Reporter: Michael
[ http://issues.apache.org/jira/browse/JDO-305?page=all ]
Michael Bouschen updated JDO-305:
-
Attachment: JDO-305.patch
The attached patch JDO-305.patch for review fixes the two classes
SingleStringQuery and QueryElementHolder and removes the 'IMPORTS'
TCK query test VariableInResult fails with JDODataStoreException
Key: JDO-310
URL: http://issues.apache.org/jira/browse/JDO-310
Project: JDO
Type: Bug
Components: tck20
Reporter: Michael
[
http://issues.apache.org/jira/browse/JDO-313?page=comments#action_12367578 ]
Michael Bouschen commented on JDO-313:
--
I renamed my .maven directory and did a maven tck20.build in the trunk. It
works! It regenerated the plugin cache, downloaded tons
Enhance api20 XMLTest so that users can check their own .jdo .orm, and
.jdoquery files
--
Key: JDO-319
URL: http://issues.apache.org/jira/browse/JDO-319
Project: JDO
Type:
Add negative query test for projecting a map and collection field to tck20
--
Key: JDO-320
URL: http://issues.apache.org/jira/browse/JDO-320
Project: JDO
Type: Test
Components: tck20
[ http://issues.apache.org/jira/browse/JDO-319?page=all ]
Michael Bouschen updated JDO-319:
-
Attachment: JDO-319-060225.patch
The attached patch JDO-219-060225.patch includes the first version of the
XMLTest enhancement for discussion.
It adds a new
Add test queries accessing a public static final field declared in a company
model class
Key: JDO-321
URL: http://issues.apache.org/jira/browse/JDO-321
Project: JDO
Type: Test
[
http://issues.apache.org/jira/browse/JDO-316?page=comments#action_12368278 ]
Michael Bouschen commented on JDO-316:
--
Th patch looks good!
Just one comment: should we give the new path a better name than 'jndi'?. This
path can include any third
[
http://issues.apache.org/jira/browse/JDO-324?page=comments#action_12368352 ]
Michael Bouschen commented on JDO-324:
--
I agree, the test is not correct.
I think we do not need multiple threads to test the assertion. Here is what I
think the test
[ http://issues.apache.org/jira/browse/JDO-321?page=all ]
Michael Bouschen updated JDO-321:
-
Attachment: JDO-321.patch
Attached you find aptach JDO-321.patch for review. It adds a public static
final field to class Department and three new query test
[ http://issues.apache.org/jira/browse/JDO-320?page=all ]
Michael Bouschen reassigned JDO-320:
Assign To: Erik Bengtson (was: Michael Bouschen)
Checked in the patch which adds two negative test queries to class
[ http://issues.apache.org/jira/browse/JDO-321?page=all ]
Michael Bouschen reassigned JDO-321:
Assign To: Erik Bengtson (was: Michael Bouschen)
Checked in the patch adding new query tests accessing public static fields (see
revision 383192).
[
http://issues.apache.org/jira/browse/JDO-309?page=comments#action_12369322 ]
Michael Bouschen commented on JDO-309:
--
Hi Martin,
the ThreadExceptionHandler changes look good.
I looked at the RougueBarriere class. It's small, but still takes some
[
http://issues.apache.org/jira/browse/JDO-190?page=comments#action_12369527 ]
Michael Bouschen commented on JDO-190:
--
Looks good.
Just a minor comment: I would move method localSetUp after method main.
Add test for
[
http://issues.apache.org/jira/browse/JDO-272?page=comments#action_12369552 ]
Michael Bouschen commented on JDO-272:
--
Looks good.
Create tests for section 12.6.8, detachment behavior
1 - 100 of 1071 matches
Mail list logo