Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-13 Thread Jesse Glick
On Thu, Dec 13, 2018 at 1:55 PM Paul Smith wrote: > ‘PR’, ‘WIP’ are probably blindingly obvious to you but they’re not to me I’m > afraid. Sorry. “pull request”, “work in progress” There are integration tests for the Maven plugin which verify basic functionality in controlled Docker images,

Re: Any idea how to release https://github.com/jenkinsci/xstream-fork

2018-12-13 Thread Jesse Glick
On Thu, Dec 13, 2018 at 11:47 AM Matt Sicker wrote: > If upstream doesn't want to support our features, is there any way to > refactor said features into its own library that works with an unpatched > upstream xstream? I think wherever that is possible, we are already doing it in core.

Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-13 Thread Devin Nusbaum
What versions of Maven, Java, and Ubuntu are you running? I would run `mvn --version` to see what it tells you. You want Java 8 and Maven 3.5+. Maybe if you have a really old Maven version you could be getting those kinds of errors, but I’m not sure. Regarding the `work` directory, that is the

Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-13 Thread Devin Nusbaum
> I'm trying to create a plug-in and started from the external-jobs plugin. > Unfortunately this had a very obsolete pom.xml so I've tried updating it > following some help given elsewhere in this group but I'm stuff no this error > when I try to run 'mvn hpi:run' For what it’s worth, there

RE: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-13 Thread Paul Smith
Baptiste, Thanks for the help that you have offered. I won’t be offended if you treat me like an idiot because I’m not at all fluent in Java/Maven/Jenkins so ‘PR’, ‘WIP’ are probably blindingly obvious to you but they’re not to me I’m afraid. Anyway, I looked at your proposed POM and it looks

Re: Zulip Plugin Adoption

2018-12-13 Thread Oleg Nenashev
Hi, Just to follow-up on the hosting request, a new plugin hosting may be preferable here. See https://github.com/jenkins-infra/repository-permissions-updater/pull/941#issuecomment-447059980 BR, Oleg On Thursday, December 13, 2018 at 7:13:04 PM UTC+1, tab...@zulipchat.com wrote: > > Hi, > >

Re: Zulip Plugin Adoption

2018-12-13 Thread tabbott
Hi, I just wanted to check in on this -- we'd really love to get Milan approved to manage this project. He recently did a very nice rewrite of the Zulip Jenkins plugin (fixing all open issues), and it'd be awesome to get that release out. Thanks! -Tim Abbott On Tuesday, November 27, 2018

Re: Any idea how to release https://github.com/jenkinsci/xstream-fork

2018-12-13 Thread Matt Sicker
If upstream doesn't want to support our features, is there any way to refactor said features into its own library that works with an unpatched upstream xstream? Otherwise, I suppose if we maintained a fork that was regularly merged with upstream would be better than just forking a version at one

Re: Java 11 Preview availability in Weekly releases. Status update (JEP-211)

2018-12-13 Thread Oleg Nenashev
It was fixed slightly differently in https://github.com/jenkinsci/plugin-compat-tester/pull/93 . Overriding argline is not cool, but it does the job for a tool like PCT. We still hit a number of issues while running PCT with Java 11 in Docker (especially the "Stream stdin corrupted. Expected

Re: Any idea how to release https://github.com/jenkinsci/xstream-fork

2018-12-13 Thread Oleg Nenashev
I think it is useful, we just need to update the documentation to clarify what is the purpose of the repo. It seems that we will have to go forward with a custom for of XStream in meantime, but upstreaming our patches totally makes sense (ones which can be upstreamed). BR, Oleg On Tuesday,