Re: JEP-200? azure-vm-agents PR issue

2019-04-29 Thread Tim Jacomb
Sorted Jessie pointed me in the right direction (Thanks!) WARNING o.jvnet.hudson.test.JenkinsRule#before: Jenkins.theInstance was not cleared by a previous test, doing that now This commit fixed it:

Re: Wrapping Gitlab API into a separate plugin

2019-04-29 Thread Jesse Glick
On Mon, Apr 29, 2019 at 12:38 PM Matt Sicker wrote: > The main advantage to using an API plugin is to allow the library to > be reused by other plugins Technical details if you are interested:

Re: Wrapping Gitlab API into a separate plugin

2019-04-29 Thread Parichay Barpanda
Thanks Matt that was helpful. :) On Mon, Apr 29, 2019 at 10:08 PM Matt Sicker wrote: > The main advantage to using an API plugin is to allow the library to > be reused by other plugins without each plugin needing to maintain > updates to the dependencies manually. Instead, the API plugin is

Re: Wrapping Gitlab API into a separate plugin

2019-04-29 Thread Matt Sicker
The main advantage to using an API plugin is to allow the library to be reused by other plugins without each plugin needing to maintain updates to the dependencies manually. Instead, the API plugin is used for those libraries which reduces maintenance burden, especially whenever CVEs are

JEP-200? azure-vm-agents PR issue

2019-04-29 Thread Tim Jacomb
Hi I'm having an issue adding configuration-as-code support to the azure-vm-agents plugin (On Mac, linux all tests pass, and on windows when run through intellij they also pass) On windows when run on the command line a couple of unit tests fail with: "Refusing to marshal