Re: JDK installer for AdoptOpenJDK

2019-05-03 Thread Devin Nusbaum
Interesting! Assuming your approach is robust I’d vote for just putting this directly in jdk-tool (and then very visibly deprecating the existing installer for Oracle Java) and adding you as a maintainer. You might be able to reuse the platform

JDK installer for AdoptOpenJDK

2019-05-03 Thread Mads Mohr Christensen
As a fun project and because it might be useful I’ve been working on a JDK installer plugin for installing OpenJDK from AdoptOpenJDK.net . It still needs some work in order to be released as an actual plugin but perhaps someone would like to have a look now?

Re: Jenkins version - minimum dependency in pom vs. test harness required dependency

2019-05-03 Thread Ullrich Hafner
Since the dependency is only required to make the test framework happy, I thought it is worth to see why it is not working as expected (since it works in maven I assumed that it is just a quick fix). But you are right, for me as developer it is easier to increase the jenkins version (as this

Re: Jenkins version - minimum dependency in pom vs. test harness required dependency

2019-05-03 Thread Jesse Glick
Is this time well spent, compared to just saying that anyone who wants _new features_ from your plugin had also better be running a recent LTS of core (or newer weekly)—not even necessarily the line with the current security patches? Also see the discussion here:

Re: [INFRA-2086] - Switching ci.jenkins.io builds to AdoptOpenJDK

2019-05-03 Thread Jesse Glick
On Fri, May 3, 2019 at 4:37 AM Robert Sandell wrote: > If I read the migration guide on the AdoptOpenJDK correctly it states that > there is no Java Web start replacement for Java 8. don't we have some Java > Web Start code at least in core for agent launching? Yes, but this is gone in newer

Re: Jenkins version - minimum dependency in pom vs. test harness required dependency

2019-05-03 Thread Ullrich Hafner
While the tests now work in maven they still not work in IntelliJ. Seems that the option -Djenkins.version is working in maven but not in IntelliJ. When I debug the WAR extraction in IntelliJ (class WarExploder) then it always extracts the version that is used in the pom as dependency. The

Re: [INFRA-2086] - Switching ci.jenkins.io builds to AdoptOpenJDK

2019-05-03 Thread Oleg Nenashev
Hi, We do not use Java Web Start in the Jenkins infrastructure. Indeed it may become an issue for some users who want to fully migrate to AdoptOpenJDK and who connect agents from WebUI, but it would not be a big issue for us even if we decided to change the base image for our official Jenkins

Re: [INFRA-2086] - Switching ci.jenkins.io builds to AdoptOpenJDK

2019-05-03 Thread Robert Sandell
If I read the migration guide on the AdoptOpenJDK correctly it states that there is no Java Web start replacement for Java 8. don't we have some Java Web Start code at least in core for agent launching? Or maybe that's not a compile time dependency? /B Den fre 3 maj 2019 kl 08:36 skrev Joseph P

[INFRA-2086] - Switching ci.jenkins.io builds to AdoptOpenJDK

2019-05-03 Thread Joseph P
Sounds perfectly reasonable to me  We use AdoptOpenJDK at work too. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to