Re: Jenkins.getInstance().getAllItems(ParameterizedJob.class) slow in large installations

2024-05-24 Thread 'Jesse Glick' via Jenkins Developers
On Thu, May 23, 2024 at 2:12 PM 'Winter, Markus' via Jenkins Developers < jenkinsci-dev@googlegroups.com> wrote: > when posting an xml to update a job the ItemListener.onUpdated is not > called. Only the Saveablelistener is called > I have noticed this as well and it feels like a bug. The

Re: Maven flatten plugin in incrementals profile

2024-05-22 Thread 'Jesse Glick' via Jenkins Developers
On Tue, May 21, 2024 at 2:04 PM Ullrich Hafner wrote: > SpotBugs extracts the filter XML into an empty file. (Not every time but > sometimes, so this might be a race condition somewhere). > Weird. Running, say, `mvn clean verify` from a shell? No IDE, mvnd involved? -- You received this

Re: Adopt fail-the-build-plugin.

2024-05-20 Thread 'Jesse Glick' via Jenkins Developers
On Sat, May 18, 2024 at 7:16 AM Abdelatif Ait Bara < aitbaraabdelati...@gmail.com> wrote: > I would like to adopt a plugin: > > Link: https://github.com/jenkinsci/fail-the-build-plugin > For freestyle projects I guess? For Pipeline it would be better to do JENKINS-27092. -- You received

Re: Maven flatten plugin in incrementals profile

2024-05-20 Thread 'Jesse Glick' via Jenkins Developers
On Sat, May 18, 2024 at 2:43 PM Ullrich Hafner wrote: > It seems that the Maven SpotBugs and the Maven Flatten plugin are not > compatible when used together. They are in general. I am using a SpotBugs exclusion filter from another jar file and SpotBugs > seems to create a zero length copy of

Re: Coding a new type of agent

2024-05-17 Thread 'Jesse Glick' via Jenkins Developers
On Fri, May 17, 2024 at 3:24 PM Ivan Pavlović wrote: > Can you please share more details about your suggestion? Code examples? > Best to study the `kubernetes` plugin. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe

Re: Coding a new type of agent

2024-05-17 Thread 'Jesse Glick' via Jenkins Developers
On Thu, May 16, 2024 at 2:26 PM Carlos Sanchez wrote: > It's been a while but I believe that for the declarative agent > definition you need something like KubernetesDeclarativeAgent > Yes, but better to start by getting everything to work in Scripted syntax by having a `Cloud` able to

Re: Way to have launcher.getChannel().call() use an idle executor?

2024-05-08 Thread 'Jesse Glick' via Jenkins Developers
On Tue, May 7, 2024 at 1:47 PM Michael Carter wrote: > To put simply I'm creating a security scan into my plugin that I want to > run independent of jobs but run on the nodes. > > I want to have it show up on screen it's running on the node > I suppose it should be possible. You would need to

Re: SCM plugin with Multi-Branch Pipeline throwing InaccessibleObjectException

2024-04-22 Thread 'Jesse Glick' via Jenkins Developers
How are you running Jenkins when you see this? Should not occur when either using `mvn hpi:run` nor `mvn test` on a `JenkinsRule`-based test so far as I know. https://github.com/jenkinsci/plugin-pom/blob/692c7757f468ea6b1ecf52a39edb8379020816c3/pom.xml#L65-L70 and associated setup should be

Re: GitHub repo configuration for PR and CI?

2024-04-17 Thread 'Jesse Glick' via Jenkins Developers
On Wed, Apr 17, 2024 at 10:22 AM Antoine Musso wrote: > I would like to ensure CI passes before a pull request is merged. To do > so, I have added a rule to request the change to be updated (== rebased) If you mean *Require branches to be up to date before merging* then I would not recommend

Re: Jenkins.getInstance().getAllItems(ParameterizedJob.class) slow in large installations

2024-04-15 Thread 'Jesse Glick' via Jenkins Developers
On Sat, Apr 13, 2024 at 1:13 AM Tomas Bjerre wrote: > - Is there a faster way > to Jenkins.getInstance().getAllItems(ParameterizedJob.class); ? > Yes, https://javadoc.jenkins.io/hudson/model/ItemGroup.html#allItems(java.lang.Class) is faster since it avoids the need to sort. Also if this code

Re: Modernize core dependency json-lib library

2024-04-11 Thread 'Jesse Glick' via Jenkins Developers
On Wed, Apr 10, 2024 at 6:27 PM Basil Crow wrote: > Even if we did want to migrate core and plugins to […] a different JSON > library […], we'd have to continue to support JSON-lib under the net.sf > package namespace during the transition period at the very least. > I think it is worse than

Re: Windows-arm64 native support

2024-04-04 Thread 'Jesse Glick' via Jenkins Developers
On Thu, Mar 28, 2024 at 8:02 AM Pierrick Bouvier < pierrick.bouv...@linaro.org> wrote: > for winp, I'm not sure what we are missing by not being able to load this > DLL (less control on processes launched?) > I think it would be worthwhile to search for usages of winp in @jenkinsci—probably

Re: Stop publishing fat plugin aws-java-sdk

2024-03-21 Thread 'Jesse Glick' via Jenkins Developers
On Thu, Mar 21, 2024 at 9:20 AM Vincent Latombe wrote: > prompt any remaining plugin that may depend on the fat plugin to do the > right thing, and implement option 2. > Did you already file PRs for _all_ `@jenkinsci` plugins using the fat dep? Otherwise it might not be apparent that an update

Re: Exclusive JEP-229 CD mode announcement

2023-12-14 Thread 'Jesse Glick' via Jenkins Developers
I guess this should be mentioned in https://www.jenkins.io/doc/developer/publishing/releasing-cd/#enable-cd-permissions and/or https://www.jenkins.io/doc/developer/publishing/releasing-cd/#fallback ? -- You received this message because you are subscribed to the Google Groups "Jenkins

Re: Banned dependencies error compiling SAML plugin PR

2023-12-13 Thread 'Jesse Glick' via Jenkins Developers
On Wed, Dec 13, 2023 at 5:56 AM Ullrich Hafner wrote: > I think our tool chain will accept Java 17 dependencies if you explicitly > declare it as supported by setting the java.version in you pom. > If you meant java.level, no, this is gone as of

Re: License for library plugins

2023-12-12 Thread 'Jesse Glick' via Jenkins Developers
On Tue, Dec 12, 2023 at 7:44 AM Mark Waite wrote: > The changes made to wrap the library into the plugin are usually not very > large Well. In

Re: bitbucket-plugin - why didn't my PR got released

2023-12-11 Thread 'Jesse Glick' via Jenkins Developers
On Sun, Dec 10, 2023 at 12:09 PM Mark Waite wrote: > Apply the label to the existing pull request and then run the cd action > from the "Actions" menu of the repository. > > That's worked for me in the past. > Please update https://www.jenkins.io/doc/developer/publishing/releasing-cd/#releasing

Re: GetStatic Jelly Tag

2023-12-07 Thread 'Jesse Glick' via Jenkins Developers
On Thu, Dec 7, 2023 at 11:44 AM Bryan Stopp wrote: > I'm making the assumption here that the classloader functions the same > when running stand-alone vs mvn hpi:run > Probably an invalid assumption. I would advise never using the

Re: repeatable with selector and items to be hidden or visible on selection

2023-11-29 Thread 'Jesse Glick' via Jenkins Developers
On Wed, Nov 29, 2023 at 7:32 AM Cinemo IT wrote: > Anyway, basically i want to have a repeatable with add button that has a > drop down menu for example with set of selections, once a selection is made > a few other fields should either show up or get invisible, and on save and > reload for

Re: How can I test my plugin in pipeline?

2023-11-16 Thread 'Jesse Glick' via Jenkins Developers
In other words, write some basic tests using JenkinsRule first. If you then want to test interactively to check UI and so on, use mvn hpi:run Since the relevant Pipeline plugins (minimally `workflow-job` + `workflow-cps`, usually also `workflow-basic-steps` + `workflow-durable-task-step`,

Re: How can I test my plugin in pipeline?

2023-11-16 Thread 'Jesse Glick' via Jenkins Developers
On Thu, Nov 16, 2023 at 9:58 AM tzach solomon wrote: > I want to test [my new plugin] in pipeline > https://github.com/jenkinsci/archetypes/blob/282d79c14f8453bdffe1c74d5010dfdcf776ed9f/hello-world/src/main/resources/archetype-resources/src/test/java/HelloWorldBuilderTest.java#L64-L74 -- You

Re: Config list of simple strings?

2023-10-24 Thread 'Jesse Glick' via Jenkins Developers
On Tue, Oct 24, 2023 at 5:55 PM Bryan Stopp wrote: > I can't seem to find any examples of repeatableHeteroProperty that don't > use a some custom class, where as i just want to store a String. > Because it is not supported: https://issues.jenkins.io/browse/JENKINS-27901 -- You received this

Re: Backporting for LTS 2.414.3 has started

2023-10-18 Thread 'Jesse Glick' via Jenkins Developers
On Fri, Oct 13, 2023 at 11:42 AM 'Alexander Brandes' via Jenkins Developers wrote: > a remoting PR has been labeled as “backporting-candidate” > Reminder (since I am not sure if this is mentioned in the backporting guide): if and when this is selected for backporting, the technique is to create

Re: Splitting a plugin into a legacy and supported part

2023-10-13 Thread 'Jesse Glick' via Jenkins Developers
On Fri, Oct 13, 2023 at 2:38 AM Ullrich Hafner wrote: > there might be still some users that use the old and deprecated steps > Like, Pipeline steps? So you cannot confidently delete this code without potentially breaking user workflows? > Move the old code to a new plugin with new plugin id.

Re: Backporting for LTS 2.414.3 has started

2023-10-02 Thread 'Jesse Glick' via Jenkins Developers
On Mon, Oct 2, 2023 at 1:49 AM Kris Stern wrote: > Fixed: > https://issues.jenkins.io/browse/JENKINS-71479?jql=labels%20%3D%202.414.3-fixed > I think you meant to link to https://issues.jenkins.io/issues/?jql=labels%20%3D%202.414.3-fixed ? -- You received this message because you are

Re: GitHub Packages access

2023-09-28 Thread 'Jesse Glick' via Jenkins Developers
On Thursday, September 28, 2023 at 9:43:59 AM UTC-4 Vladimir Belousov wrote: We also thought about publishing *exhort-java-api* to Jenkins Artifactory. Best to discuss in a new ticket: https://github.com/jenkins-infra/helpdesk/issues/new/choose -- You received this message because you are

Re: GitHub Packages access

2023-09-28 Thread 'Jesse Glick' via Jenkins Developers
On Thu, Sep 28, 2023 at 4:37 AM Vladimir Belousov wrote: > We use dependencies that are hosted on GitHub Packages in our plugin. I guess you mean https://github.com/jenkinsci/redhat-dependency-analytics-plugin/blob/f4b606b8b509795917edc2f2915c6a3322a85e4d/pom.xml#L212-L215 to access

Re: [Information] Release block "Beta" program

2023-09-28 Thread 'Jesse Glick' via Jenkins Developers
On Thu, Sep 28, 2023 at 4:11 AM 'wfoll...@cloudbees.com' via Jenkins Developers wrote: > I would like to get more opinions on the topic before investing time on it > as the current version seems to be satifsactory for the beta testers. > FWIW the current system has been very reassuring for me.

Re: remove j-interop and jcifs from core?

2023-09-18 Thread 'Jesse Glick' via Jenkins Developers
On Mon, Sep 18, 2023 at 7:22 AM 'jn...@cloudbees.com' via Jenkins Developers wrote: > The ability to install Jenkins as a service[1] when it is running (by java > -jar) on a windows machine > > I forgot to mention - which potentially valid - I would argue that the > user should just download the

Re: bitbucket plugin - JENKINS-65697 - How to inject environment variable into WorkflowMultiBranchProject (buildEnvironment isn't called...)

2023-07-25 Thread 'Jesse Glick' via Jenkins Developers
On Tue, Jul 25, 2023 at 2:24 AM tzach solomon wrote: > get build from the Queue Item > I am not sure what that means. You are going to need to be more specific, preferably with code references, ideally a JenkinsRule-based test failing in the “right” way. -- You received this message because

Re: Can't see plugin name in build steps plugin list.

2023-07-25 Thread 'Jesse Glick' via Jenkins Developers
Maybe you are trying to run the plugin in a nonstandard way that is skipping the required annotation processor. From a shell: mvn clean hpi:run -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop

Re: bitbucket plugin - JENKINS-65697 - How to inject environment variable into WorkflowMultiBranchProject (buildEnvironment isn't called...)

2023-07-24 Thread 'Jesse Glick' via Jenkins Developers
On Mon, Jul 24, 2023 at 1:58 AM tzach solomon wrote: > I've checked the code and it looks like the triggered job is of class > *WorkflowMultiBranchProject*. The future job I'm getting once scheduled > OK is *jenkins.branch.MultiBranchProject$BranchIndexing*. > > I've tried to inject environment

Re: How to get listener from the Run object

2023-07-19 Thread 'Jesse Glick' via Jenkins Developers
On Wed, Jul 19, 2023 at 10:25 AM Michael Carter wrote: > I'm in an area where all I've got is the Run object. > > Where do I need to go to get the TaskListener so I can write to the logs? > Well, for Pipeline you could use

Re: GitSCM is marked as Serializable but can't be serialized because of GitSCM.extensions

2023-07-18 Thread 'Jesse Glick' via Jenkins Developers
I guess the question is prompted by https://github.com/jenkinsci/git-push-plugin/blob/5c9525da6da7bed8fd70e8a45d62eafd1daad3f1/src/main/java/io/jenkins/plugins/git_push/GitPushStep.java#L109 which is odd because while `StepExecution` in general is `Serializable`, a

Re: Adopting the github-oauth-plugin plugin

2023-07-13 Thread 'Jesse Glick' via Jenkins Developers
On Thu, Jul 13, 2023 at 9:33 AM Kris Stern wrote: > In case there is anything else I have missed > https://groups.google.com/g/jenkinsci-dev/c/iZz5-GqKw-8/m/RKQr3qXTBQAJ :-) -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To

Re: TaskListenerDecorator/Factory on agents

2023-06-28 Thread 'Jesse Glick' via Jenkins Developers
On Fri, Jun 23, 2023 at 11:45 AM Alexis Tual wrote: > we're trying to parse any pipeline logs with TaskListenerDecorator to > detect some pattern and report with a custom action attached to the run. > It's working fine on agents by default but not when > >

Re: Jenkins 2.387.3 LTS RC testing started

2023-04-24 Thread 'Jesse Glick' via Jenkins Developers
I discovered what seems to be a regression in the RC (and weeklies): https://issues.jenkins.io/browse/JENKINS-71139 -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an

Re: Help needed with simple AutoComplete -- Here's my code, what's wrong?

2023-04-20 Thread 'Jesse Glick' via Jenkins Developers
On Wed, Apr 19, 2023 at 6:32 PM Tamás Mucs wrote: > jellys of ParameterDefinitions don't normally have forms around their > controls as I see. > Sure they do—the configuration form for a project (named `config`). -- You received this message because you are subscribed to the Google Groups

Re: Help needed with simple AutoComplete -- Here's my code, what's wrong?

2023-04-19 Thread 'Jesse Glick' via Jenkins Developers
On Wed, Apr 19, 2023 at 7:29 AM Tamás Mucs wrote: > is there something off with my code > It is pretty odd. You are using form controls not inside a form, to start with. Perhaps you meant to use `GlobalConfiguration`? (There is a Maven archetype to help.) -- You received this message because

Re: How to retrieve sensitive data in Jenkins agent node

2023-04-13 Thread 'Jesse Glick' via Jenkins Developers
On Thu, Apr 13, 2023 at 12:55 PM d...@kinneartech.com wrote: > How can we pass those sensitive args to Jenkins agent machine without > getting disclosed. We already tried adding them to envVars but there seems > to be an issue that the envVars are disclosed in a parallel job in a > different

Re: [Regression] Non-unique IDs

2023-04-07 Thread 'Jesse Glick' via Jenkins Developers
https://github.com/jenkinsci/jenkins/pull/7823 is a straightforward fix addressing at least one reported case of regression, with no need to revert anything or modify plugins. There could of course be unrelated issues. -- You received this message because you are subscribed to the Google Groups

Re: script to configure repository labels

2023-03-31 Thread 'Jesse Glick' via Jenkins Developers
On Fri, Mar 31, 2023 at 10:01 AM Tim Jacomb wrote: > It can be setup at the org level as a repository default, Gavin also had > an app where you could click a button and it would set it all up for your > repository > If there is something that works to at least copy labels from

Re: Form validation in Action? doCheck of Descriptor is not called before form submission.

2023-03-23 Thread 'Jesse Glick' via Jenkins Developers
On Thu, Mar 23, 2023 at 12:25 PM Tamás Mucs wrote: > doSubmit() is called before any validation would happen. I tried to add > the following method to my *descriptor *but it is *not *called > Form validation is advisory; it can display a warning message but does not block save.

Re: one-shot-executor-plugin

2023-03-15 Thread 'Jesse Glick' via Jenkins Developers
That experiment was indeed abandoned. Use https://javadoc.jenkins.io/plugin/durable-task/org/jenkinsci/plugins/durabletask/executors/OnceRetentionStrategy.html -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group

Re: *-api-plugin (tests downstream plugins)?

2023-02-21 Thread 'Jesse Glick' via Jenkins Developers
On Sun, Feb 19, 2023 at 4:50 PM Olivier Lamy wrote: > I'm not quite sure how to implement this technically because > downstream plugins may use the api-plugin as direct dependency with > version or using the bom so this means we would have to inject an > incremental bom or change version. >

Re: How does /monitoring skip starting splash page?

2023-02-08 Thread 'Jesse Glick' via Jenkins Developers
On Wed, Feb 8, 2023 at 8:55 AM 'Daniel Beck' via Jenkins Developers < jenkinsci-dev@googlegroups.com> wrote: > PluginImpl#start adds… > Yes, as I wrote, but please bear in mind that `Plugin.start` is deprecated—use `@Initializer` instead. -- You received this message because you are subscribed

Re: How does /monitoring skip starting splash page?

2023-02-08 Thread 'Jesse Glick' via Jenkins Developers
It may be possible by calling `PluginServletFilter` in an `@Initializer`, as filters will be consulted before the request is even routed to Stapler (where the `HudsonIsLoading` object is installed until startup completes and it is replaced with the `Jenkins` singleton). Remember that, among other

Re: Plugin POM inheritance

2023-01-20 Thread 'Jesse Glick' via Jenkins Developers
On Thu, Jan 19, 2023 at 6:19 PM Basil Crow wrote: > I think such a change, while not trivial, is likely feasible. > +1, thanks for reviewing & classifying the bits we would not want to inherit (or which are obsolete). -- You received this message because you are subscribed to the Google

Re: Towards new kubernetes-client 6.x

2023-01-05 Thread 'Jesse Glick' via Jenkins Developers
On Thu, Jan 5, 2023 at 2:35 PM Vincent Latombe wrote: > the package on fabric8 side is not updated to a new one, so both plugins > wouldn't be able to co-exist in the classpath. > You can simultaneously run multiple wrapper plugins with the same package, so long as any given caller’s transitive

Re: Migration to Java11 and modules

2023-01-03 Thread 'Jesse Glick' via Jenkins Developers
On Tue, Jan 3, 2023 at 8:08 AM Ullrich Hafner wrote: > Do we already have some guidelines on how to migrate a plugin to Java 11? Yes; normally there is very little to do. > Do we need to create module-info.java files for plugins? No. > How do we access libraries that use modules? >

Re: User.CanonicalIdResolver extension point "context"

2023-01-03 Thread 'Jesse Glick' via Jenkins Developers
On Fri, Dec 30, 2022 at 8:17 AM Cristian Morales Vega wrote: > I am looking at https://issues.jenkins.io/browse/JENKINS-70342, but > I'm not sure how the "context" in CanonicalIdResolver is supposed to > be used. The only thing I have seen in the docs is "Can be used (for > example) to

Re: Renaming a plugin

2022-12-21 Thread 'Jesse Glick' via Jenkins Developers
On Sun, Dec 18, 2022 at 7:47 AM Alexander Brandes wrote: > take a look at the RPU documentation > > how > to do that. > I think this doc should be made to emphasize that you *really really* should not ever do

Re: Solving “failing Parent Pom upgrade from 4.51 to 4.52 build” cheatsheet

2022-12-14 Thread 'Jesse Glick' via Jenkins Developers
On Wed, Dec 14, 2022 at 4:10 PM Ullrich Hafner wrote: > increment the MAJOR version when you make incompatible API changes > It is a nice theory, but in practice nearly any change *could* be incompatible when the “API” is defined with less than mathematical precision. 4.52 obviously *was*

Re: Next baseline shift

2022-12-01 Thread 'Jesse Glick' via Jenkins Developers
On Wed, Nov 30, 2022 at 2:41 PM James Nord wrote: > this would affect plugins that have less active development more, which > means users are probably less familiar with our tooling to begin with > Right. Maybe safer to leave the default as is, but formally deprecate running `buildPlugin`

Re: Servlet container support (was: Nov 28, 2022 Governance Board Agenda)

2022-11-29 Thread 'Jesse Glick' via Jenkins Developers
On Tue, Nov 29, 2022 at 6:29 PM James Nord wrote: > if you can not use tomcat or $container then Jenkins must not be a war, > which has a large overlap but is subtly different > Interesting…so if the basic Jenkins download were to physically switch format somehow, then it would no longer be

Re: Next baseline shift

2022-11-29 Thread 'Jesse Glick' via Jenkins Developers
On Tue, Nov 29, 2022 at 6:19 PM James Nord wrote: > This bytecode difference trips up spotbugs (causing several new false > positives) > Mm, OK, that sounds like a real risk that would preclude changing the default any time soon. Ideally a plugin repository would pin a version of the library,

Re: Next baseline shift

2022-11-28 Thread 'Jesse Glick' via Jenkins Developers
On Mon, Nov 28, 2022 at 2:53 PM Basil Crow wrote: > > Independently of that, we can consider switching the default JDK for > ci.jenkins.io `buildPlugin` from 8 to 11. > > I am not sure to whom you are referring when you write "we". Is this > something you are planning to implement, something you

Re: Next baseline shift

2022-11-28 Thread 'Jesse Glick' via Jenkins Developers
Your proposal sounds great to me, and thanks for volunteering to implement the changes. I think a late-2022 timeline (sometime after 2.375.1 has been released) makes sense—if there is some advantage in waiting longer, I do not get what. The only likely drawback for plugin maintainers who

Servlet container support (was: Nov 28, 2022 Governance Board Agenda)

2022-11-28 Thread 'Jesse Glick' via Jenkins Developers
On Mon, Nov 28, 2022 at 9:29 AM Mark Waite wrote: > Mark Waite to propose a pull request documenting the web application > server support policy […] > >- > - > - > > Many people are saying that “should work” but we don’t test them > […] > - > >

Re: BOM compiles plugins with target 11

2022-11-10 Thread 'Jesse Glick' via Jenkins Developers
On Thu, Nov 10, 2022 at 2:03 AM Ullrich Hafner wrote: > This causes a failure of: > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-cli) > on project checks-api: Execution default-cli of goal >

Re: Adoption request for junit-attachments-plugin

2022-11-09 Thread 'Jesse Glick' via Jenkins Developers
Also, is there a particular reason you are proposing to adopt the plugin? https://github.com/jenkinsci/junit-attachments-plugin/pulls shows no open PRs with user-visible changes. Adoption is generally used to move forward development when there has been no maintainer able to review proposed

Re: Adoption request for junit-attachments-plugin

2022-11-09 Thread 'Jesse Glick' via Jenkins Developers
The links here do not match the text; please resend with corrections. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: Graceful job termination / cleanup before abort

2022-11-04 Thread 'Jesse Glick' via Jenkins Developers
While you could probably intercept this somehow on the Jenkins plugin side, Jenkins should be sending SIGTERM (on Unix; not sure about Windows) so it would seem most appropriate to have the native command handle that gracefully. You would need to ask in another forum how best to do that in C#. --

Re: Folder Credential by credentialId not found using credentials API

2022-10-31 Thread 'Jesse Glick' via Jenkins Developers
I suspect you wanted https://javadoc.jenkins.io/plugin/credentials/com/cloudbees/plugins/credentials/CredentialsProvider.html#findCredentialById(java.lang.String,java.lang.Class,hudson.model.Run,com.cloudbees.plugins.credentials.domains.DomainRequirement...) which should take into account the

Re: Help upgrading acegi-security to spring-security

2022-10-23 Thread 'Jesse Glick' via Jenkins Developers
At least start by reading https://github.com/jenkinsci/reverse-proxy-auth-plugin/pull/40 and https://github.com/jenkinsci/ldap-plugin/pull/49. https://github.com/jenkinsci/reverse-proxy-auth-plugin/pull/37 would perhaps help. The root problem is the lack of a general way in Jenkins to compose

Re: XStream Serialization: SortedSet vs. NavigableSet vs. TreeSet

2022-10-17 Thread 'Jesse Glick' via Jenkins Developers
On Mon, Oct 17, 2022 at 5:43 AM Ullrich Hafner wrote: > Shouldn’t XStream always pick the correct dynamic type (and not the static > type) when serializing things? > As far as I know it does, but then again the representation for exotic collection types is complex. You should declare the

Re: Trying to automate release of Plugin

2022-09-15 Thread 'Jesse Glick' via Jenkins Developers
On Thu, Sep 15, 2022 at 7:52 AM Karl Henselin wrote: > I didn't know that github had a jenkins action, which apparently it does, > or something causes it to find a jenkinsfile and know that means to run > some github actions. > No, these things are decoupled. ci.jenkins.io notices the

Re: Trying to automate release of Plugin

2022-09-09 Thread 'Jesse Glick' via Jenkins Developers
On Fri, Sep 9, 2022 at 1:13 PM Karl Henselin wrote: > I followed the CD automation guide for Jenkins plugins, and I think that I > was successful with all the steps. > However, when I make a pull request, it never releases a new version. > I tried running the CD job with debug logging turned on,

Re: Add a GitHub App to allow marking pull request dependant on another

2022-09-07 Thread 'Jesse Glick' via Jenkins Developers
On Wed, Sep 7, 2022 at 6:42 AM 'Herve Le Meur' via Jenkins Developers < jenkinsci-dev@googlegroups.com> wrote: > I think it could be useful on the jenkinsci and jenkins-infra GitHub > organizations, WDYT? > Sure, assuming it passes some sort of security review. As someone who frequently creates

Re: Merging multiple build steps into one (with nested Describables)

2022-08-30 Thread 'Jesse Glick' via Jenkins Developers
On Sun, Aug 14, 2022 at 12:14 PM Tim Van Holder wrote: > there seems to be no checking that such a symbol is valid/usable, neither > at build time nor at run time. […] It would certainly be useful to get a > diagnostic for that at maintenance/build time Might be possible at runtime. I'm using

Re: Advanced button issue

2022-08-12 Thread 'Jesse Glick' via Jenkins Developers
On Fri, Aug 12, 2022 at 6:52 AM Nikhil Bhoski wrote: > I am keeping my configure-advanced.jelly in the same folder as of my > action class next to config.jelly >

Re: Storing the results for git cache maintenance tasks

2022-08-12 Thread 'Jesse Glick' via Jenkins Developers
On Thu, Aug 11, 2022 at 11:49 PM Mark Waite wrote: > effective and reasonable ways to store the most recent results of a task > and present the most recent results of tasks to the administrator > There is no standard technique for this. Branch indexing copies a bunch of code from `Run` and

Re: Script-security

2022-07-26 Thread 'Jesse Glick' via Jenkins Developers
https://github.com/jenkinsci/bmc-change-manager-imstm-plugin/blob/929fd09178bb30bce1787fe4844a75fcf6751444/src/main/java/com/bmc/ims/BmcDlpBuilder.java#L445-L447 is not how this API is designed to be used at all. From

Re: Action disappears after restart

2022-07-26 Thread 'Jesse Glick' via Jenkins Developers
On Mon, Jul 25, 2022 at 5:38 PM Nozim Islamov < mukhammadnozim.isla...@gmail.com> wrote: > I use transient Run > If by that you mean you have a `transient` field of type `Run` in your `RunAction2`, that is normal and correct, not the source of your issues. In general, for this sort of question

Re: Parent pom 4.43.1 message from validate?

2022-07-19 Thread 'Jesse Glick' via Jenkins Developers
I did not see any such message in `priority-sorter-plugin`. Is there a way to reproduce? -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: Let renovate handle dependency updates in jenkinsci/jenkins

2022-07-19 Thread 'Jesse Glick' via Jenkins Developers
Also +1 on Renovate for JS deps (at least unless and until Dependabot improves in this area) so long as Dependabot is retained for other (mainly Java) deps. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group

Re: Releasing a new plugin fails due to 'Check interesting categories' failure

2022-07-19 Thread 'Jesse Glick' via Jenkins Developers
https://github.com/jenkinsci/bmc-change-manager-imstm-plugin/releases seems to be working now? -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: Parent pom 4.43.1 message from validate?

2022-07-19 Thread 'Jesse Glick' via Jenkins Developers
On Sat, Jul 16, 2022 at 8:09 AM Mark Waite wrote: > for artifact: > org.jenkins-ci.main:jenkins-test-harness:jar:1802.v9de0d87365d2 > > from the specified remote repositories: > central (https://repo.maven.apache.org/maven2, releases=true, > snapshots=false) > It is of course not in

Re: Changing build status after it finished

2022-07-19 Thread 'Jesse Glick' via Jenkins Developers
On Fri, Jul 15, 2022 at 2:03 PM Nozim Islamov < mukhammadnozim.isla...@gmail.com> wrote: > I wanted to change the color of build status after the build is completed > You cannot change the status of a completed build. -- You received this message because you are subscribed to the Google Groups

Re: Periodic rebuilding of core PRs on ci.jenkins.io through branch indexing

2022-07-07 Thread 'Jesse Glick' via Jenkins Developers
By the way, we could try running a GitHub merge queue for the `jenkins@master` branch. I experimented with it recently. It does prevent the possibility of an undetected logical conflict, without requiring a person to be standing by manually updating each PR and waiting for CI to be green before

Re: Periodic rebuilding of core PRs on ci.jenkins.io through branch indexing

2022-07-06 Thread 'Jesse Glick' via Jenkins Developers
On Sun, Jul 3, 2022 at 5:13 AM Alexander Brandes wrote: > Maybe I'm missing something, but I can see downsides only for this > [PR-merge] strategy > The upside is that the commit status will reflect whether the PR would allow trunk to continue passing if it were merged *now*. With the simpler

Re: pipeline-syntax/generateSnippet: java.lang.IllegalArgumentException: Unable to convert to class java.lang.Object

2022-07-06 Thread 'Jesse Glick' via Jenkins Developers
On Sat, Jul 2, 2022 at 9:11 AM Shihaaz Buhary wrote: > We have been using a boolean variable in our plugin (Pipeline type). Now > we have decided to include more options and decided to go ahead with > something like 0, 1, 2 String/Integer as well. Meanwhile we want to > preserve the backward

Re: Is there interest for GitHub issues in core components?

2022-07-01 Thread 'Jesse Glick' via Jenkins Developers
On Fri, Jul 1, 2022 at 3:22 AM 'Daniel Beck' via Jenkins Developers < jenkinsci-dev@googlegroups.com> wrote: > we have 130k users in Jira. While many are probably not legitimate users > of Jira […or] haven't been logged in in years > If we expect and even encourage that most plugins switch to

Re: Jenkins Test Harness with existing Jenkins instance?

2022-06-28 Thread 'Jesse Glick' via Jenkins Developers
On Tue, Jun 28, 2022 at 12:51 PM steven...@gmail.com < steventerr...@gmail.com> wrote: > testing scenarios where your controller is running on kubernetes with > agents. > https://github.com/jenkinsci/kubernetes-plugin/blob/908e7db10d06671abf69e592d8b64e8b46cdc58e/kind.sh#L18-L31

Re: Jenkins Test Harness with existing Jenkins instance?

2022-06-28 Thread 'Jesse Glick' via Jenkins Developers
On Mon, Jun 27, 2022 at 4:37 PM steven...@gmail.com wrote: > Does anyone know if it's possible to configure the Jenkins Test Harness to > forego standing up an ephemeral Jenkins instance and instead use a > controller at a given URL with authentication? > No, it is not designed for that. I'm

Re: Pipeline RunAction2 class integration to side-panel

2022-06-15 Thread 'Jesse Glick' via Jenkins Developers
https://www.jenkins.io/doc/developer/plugin-development/pipeline-integration/ generally. There is no Pipeline equivalent to https://javadoc.jenkins.io/hudson/model/JobProperty.html#perform(hudson.model.AbstractBuild,hudson.Launcher,hudson.model.BuildListener) specifically; you can offer a `Step`.

Re: Question about SSHUserPrivateKey snapshots and git checkouts

2022-06-13 Thread 'Jesse Glick' via Jenkins Developers
On Mon, Jun 13, 2022 at 12:58 PM James Robson wrote: > I had created set of vms on my laptop just for this work > I would strongly recommended writing an integration test using Testcontainers to do things like retrieve an SSH private key from Vault running in a Docker container (using a

Re: BOM build errors due to conflict of baseline 2.319.3 and 2.319.1

2022-06-13 Thread 'Jesse Glick' via Jenkins Developers
On Mon, Jun 13, 2022 at 12:43 PM Ullrich Hafner wrote: > Shouldn’t the BOM also follow our guidelines and support only > releases 2.303.3 and 2.319.3 and newer? > Perhaps. The current guideline for the plugin BOM is stated here: https://github.com/jenkinsci/bom/#lts-lines -- You received this

Re: Is there interest for GitHub issues in core components?

2022-06-13 Thread 'Jesse Glick' via Jenkins Developers
On Mon, Jun 13, 2022 at 10:02 AM 'Daniel Beck' via Jenkins Developers < jenkinsci-dev@googlegroups.com> wrote: > On Mon, Jun 13, 2022 at 3:55 PM Tim Jacomb wrote: > >> The barrier to entry on Jira is a lot higher than on GitHub, many people >> struggle to report issues. >> > > Is people not

Re: Plugin Updates

2022-05-25 Thread 'Jesse Glick' via Jenkins Developers
On Wed, May 25, 2022 at 1:37 PM priya jagyasi wrote: > Can anyone please let me know how much time it takes to have the plugin > under 'Updates' in the Jenkins update center for any instance after the > GitHub workflow release is completed successfully? Is it immediate or any > approximate time?

Re: 409 errr on plugin release

2022-05-24 Thread 'Jesse Glick' via Jenkins Developers
https://github.com/jenkinsci/lightstep-incident-response-plugin/pull/6 -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: 409 errr on plugin release

2022-05-24 Thread 'Jesse Glick' via Jenkins Developers
On Tue, May 24, 2022 at 1:09 PM priya jagyasi wrote: > could you please let me know what needs to be done to enable CD on my > plugin. > Please read the instructions. https://www.jenkins.io/doc/developer/publishing/releasing-cd/#update-maven-pom-and-config -- You received this message because

Re: 409 errr on plugin release

2022-05-23 Thread 'Jesse Glick' via Jenkins Developers
On Sat, May 21, 2022 at 4:21 PM 'Daniel Beck' via Jenkins Developers < jenkinsci-dev@googlegroups.com> wrote: > You are trying to release a plugin using JEP-229 CD without having it > configured correctly > As mentioned in

Re: Configure release drafter

2022-05-19 Thread 'Jesse Glick' via Jenkins Developers
> > On Thursday, May 19, 2022 at 5:26:51 AM UTC-6 Priya wrote: > >> The step here >> https://www.jenkins.io/doc/developer/publishing/releasing-cd/#configure-release-drafter >> > Are you intending to configure your plugin for continuous delivery? says to include *_extends: .github* on >>

Re: Guidance on whether/where to file issues for build warnings

2022-05-13 Thread 'Jesse Glick' via Jenkins Developers
On Fri, May 13, 2022 at 5:50 PM Tim Van Holder wrote: > I don't have any direct references to either of these. Is this a bug in > the BOM? > Or the parent POM, or something. If you manage to track down the root cause, please file a PR to fix it. And these warnings went away when using Maven

Re: Moving ATH tests closer to the code under test

2022-04-26 Thread 'Jesse Glick' via Jenkins Developers
On Tue, Apr 26, 2022 at 12:28 PM Basil Crow wrote: > I wonder if we could design a system such that for the common case only a > single Maven project is needed Sounds tricky. `acceptance-test-harness` has a bunch of dependencies some of which clash with those in Jenkins core or some plugins,

Re: get all agents used by a build

2022-04-22 Thread 'Jesse Glick' via Jenkins Developers
On Fri, Apr 22, 2022 at 11:18 AM Mathieu DELROCQ wrote: > get the duration of the stage wich use the agent > Should be possible to calculate given https://javadoc.jenkins.io/plugin/workflow-api/org/jenkinsci/plugins/workflow/actions/TimingAction.html -- You received this message because you

Re: get all agents used by a build

2022-04-20 Thread 'Jesse Glick' via Jenkins Developers
On Wed, Apr 20, 2022 at 4:03 AM Mathieu DELROCQ wrote: > I have a Run object and I would like to get all agents used in this run. > For `AbstractBuild` (traditional job types), there is a getter. For Pipeline (`FlowExecutionOwner.Executable`) you would need to iterate the `FlowNode`s looking

Re: Checking whether a step from a plugin is in actual use in an instance

2022-04-18 Thread 'Jesse Glick' via Jenkins Developers
On Mon, Apr 18, 2022 at 3:16 PM 'Daniel Beck' via Jenkins Developers < jenkinsci-dev@googlegroups.com> wrote: > Potentially doable via readResolve as well. > > Unfortunately you cannot do this sort of thing via `readResolve` so far as I know. Ideally there would be some API which you could call

Re: Checking whether a step from a plugin is in actual use in an instance

2022-04-18 Thread 'Jesse Glick' via Jenkins Developers
On Mon, Apr 18, 2022 at 4:38 AM Tim Van Holder wrote: > Can a plugin include code that will update a freestyle project that uses > the DotNetFoo builder to use the DotNet builder with a Foo argument instead? > It is possible with an `@Initializer`. I'd have to keep them around for pipeline use

  1   2   >