Re: Backporting for 1.651.2 has started

2016-04-28 Thread Stephen Connolly
The fix is a rather serious memory leak for anyone with long running active slaves. I would argue that it is low risk to include it on the basis of the testing I performed on this code and an analysis of the actual change. If it misses the boat, fair enough, but we should try and get it on the

Re: Backporting for 1.651.2 has started

2016-04-28 Thread Oliver Gondža
I doubt this is .2 material. Stephen, are you ok with .3? On 04/28/2016 10:09 AM, Oleg Nenashev wrote: I'll ping him again about it On Apr 28, 2016 10:07, "Stephen Connolly" > wrote: I think we need a 2.58 release

Re: Backporting for 1.651.2 has started

2016-04-28 Thread Oleg Nenashev
I'll ping him again about it On Apr 28, 2016 10:07, "Stephen Connolly" wrote: > I think we need a 2.58 release from KK to include the memory leak fix > > On 27 April 2016 at 14:26, ogondza wrote: > >> I have backported remoting 2.57 to fix

Re: Backporting for 1.651.2 has started

2016-04-28 Thread Stephen Connolly
I think we need a 2.58 release from KK to include the memory leak fix On 27 April 2016 at 14:26, ogondza wrote: > I have backported remoting 2.57 to fix JENKINS-28289, JENKINS-33999 and > JENKINS-32980. In case it incorporates another problems I have miss, let me > now here

Re: Backporting for 1.651.2 has started

2016-04-27 Thread ogondza
I have backported remoting 2.57 to fix JENKINS-28289, JENKINS-33999 and JENKINS-32980. In case it incorporates another problems I have miss, let me now here or on the meeting. -- oliver -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

Re: Backporting for 1.651.2 has started

2016-04-25 Thread Arnaud Héritier
I missed the project meeting but based on all feedbacks I'm also in favor to create a stable branch based on 2.55 with all possible fixes included. On Mon, Apr 25, 2016 at 8:23 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > There was more to fix and if I'd been able to attend

Re: Backporting for 1.651.2 has started

2016-04-25 Thread Stephen Connolly
There was more to fix and if I'd been able to attend the meeting or been advised up front of the agenda (what happened to the idea of sending a reminder mail to the list dev 24h before the meeting) I would have argued strongly in favour of a stable remoting. In any case I will be landing

Re: Backporting for 1.651.2 has started

2016-04-25 Thread ogondza
I have backported the nobrainers but the remoting related stuff deserves another look tomorow. -- oliver -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: Backporting for 1.651.2 has started

2016-04-25 Thread Daniel Beck
> On 25.04.2016, at 13:11, Arnaud Héritier wrote: > > I think no. JNLP3 shouldn't land and we should try to propose others fixes > without it. I proposed a 'stable' release of remoting in that project meeting, an idea that wasn't embraced enthusiastically. Maybe now

Re: Backporting for 1.651.2 has started

2016-04-25 Thread Arnaud Héritier
I think no. JNLP3 shouldn't land and we should try to propose others fixes without it. On Mon, Apr 25, 2016 at 1:06 PM, Daniel Beck wrote: > > > On 25.04.2016, at 12:22, Arnaud Héritier wrote: > > > > +1000 for JENKINS-34213 + TLS certificate fixes > >

Re: Backporting for 1.651.2 has started

2016-04-25 Thread Daniel Beck
> On 25.04.2016, at 12:22, Arnaud Héritier wrote: > > +1000 for JENKINS-34213 + TLS certificate fixes Has anything changed since the March 30 project meeting, in which we determined that JENKINS-33886[1] is serious enough to not include newer remoting versions? I see no

Re: Backporting for 1.651.2 has started

2016-04-25 Thread Arnaud Héritier
+1000 for JENKINS-34213 + TLS certificate fixes On Mon, Apr 25, 2016 at 10:14 AM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > JENKINS-34213 needs to be on that list. As that requires a remoting > release, and it would be nice to actually have a remoting release with the > TLS

Re: Backporting for 1.651.2 has started

2016-04-25 Thread Stephen Connolly
JENKINS-34213 needs to be on that list. As that requires a remoting release, and it would be nice to actually have a remoting release with the TLS certificate fixes that I contributed that were accidentally yanked with the revert of the JNLPProtocol3 stuff, what do we want to do w.r.t. the

Re: Backporting for 1.651.2 has started

2016-04-23 Thread ogondza
Consider https://github.com/jenkinsci/jenkins/pull/2283 once merged. -- oliver -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Backporting for 1.651.2 has started

2016-04-23 Thread ogondza
Hi, Backporting for next LTS release is on. The RC will be published 2016-04-27. Candidates: https://issues.jenkins-ci.org/issues/?filter=12146 Fixed: