Re: Scope of hudson.remoting.ClassFilter file added to whitelist the class? (Jenkins JEP-200 issue)

2018-04-27 Thread Jesse Glick
On Fri, Apr 27, 2018 at 5:22 AM, Oleg Nenashev wrote: > My recommendation would be to rather rework the closure to a > Callable/Runnable class Better to write the affected code in Java. Save the Groovy for something else. -- You received this message because you are

Re: Scope of hudson.remoting.ClassFilter file added to whitelist the class? (Jenkins JEP-200 issue)

2018-04-27 Thread Oleg Nenashev
Hi Sandesh, Whitelisting of "groovy.lang.Closure" is a bad idea IMHO, because it will whitelist this class everywhere within Jenkins Remoting and XStream serialization. My recommendation would be to rather rework the closure to a Callable/Runnable class and whitelist this particular

Scope of hudson.remoting.ClassFilter file added to whitelist the class? (Jenkins JEP-200 issue)

2018-04-27 Thread Sandesh Wani
Hi, [ERROR] Failed to deserialize response to UserRequest:com.abc.jenkins.plugins.xyz.pqr.vuw@494947d9: java.lang.SecurityException: Rejected: groovy.lang.Closure; see https://jenkins.io/redirect/class-filter/ I got the above error while building mixed groovy-java project in jenkins. As

Re: jep-200 issue

2018-04-12 Thread Eugen Horovitz
Thanks a lot Jesse. We will consider all these things when upgrading . Kind Regards, Eugen On Wed, Apr 11, 2018 at 7:51 PM, Jesse Glick wrote: > On Wed, Apr 11, 2018 at 10:54 AM, Eugen Horovitz > wrote: > > The rule violations :

Re: jep-200 issue

2018-04-11 Thread Jesse Glick
On Wed, Apr 11, 2018 at 10:54 AM, Eugen Horovitz wrote: > The rule violations : > https://gist.github.com/eugenhoro/44e1495ff8d182c8760edeec0982d020 Some of those would be corrected by just, say, updating the `maven-plugin` dep. Others look like real

Re: jep-200 issue

2018-04-11 Thread Eugen Horovitz
Now it compiles fine and it seems to "play" :) ! Thanks Jesse .I really appreciate the effort. The rule violations : https://gist.github.com/eugenhoro/44e1495ff8d182c8760edeec0982d020 On Wed, Apr 11, 2018 at 3:49 PM, Jesse Glick wrote: > On Wed, Apr 11, 2018 at 9:21 AM,

Re: jep-200 issue

2018-04-11 Thread Jesse Glick
On Wed, Apr 11, 2018 at 9:21 AM, Eugen Horovitz wrote: > Failed to execute goal > org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce > (display-info) on project whitesource: Some Enforcer rules have failed. Look > above for specific messages

Re: jep-200 issue

2018-04-11 Thread Eugen Horovitz
https://gist.github.com/eugenhoro/f73f4d666c64ea809e6a6711a0e40ed3 On Wed, Apr 11, 2018 at 3:21 PM, Eugen Horovitz < eugen.horov...@whitesourcesoftware.com> wrote: > @Jesse , @Oleg, @Daniel, @Slide. Thank you very much guys .It really helps > me going forward solving this .. > After doing all

Re: jep-200 issue

2018-04-11 Thread Eugen Horovitz
@Jesse , @Oleg, @Daniel, @Slide. Thank you very much guys .It really helps me going forward solving this .. After doing all the changes, still having some issues compiling .. Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce (display-info) on project

Re: jep-200 issue

2018-04-10 Thread Slide
Why are you skipping the enforcer? On Tue, Apr 10, 2018 at 8:30 AM Eugen Horovitz < eugen.horov...@whitesourcesoftware.com> wrote: > Hi Jesse , > > I did all the changes and still got the same errors.. > I am probably still missing some important stuff... I am newbie in > jenkins plugin

Re: jep-200 issue

2018-04-10 Thread Eugen Horovitz
Hi Jesse , I did all the changes and still got the same errors.. I am probably still missing some important stuff... I am newbie in jenkins plugin development and I will be greatfull if you can have a look. https://gist.github.com/eugenhoro/f73f4d666c64ea809e6a6711a0e40ed3 maven fails to build

Re: jep-200 issue

2018-04-10 Thread Jesse Glick
On Tue, Apr 10, 2018 at 2:25 AM, Eugen Horovitz wrote: > Could not resolve dependencies for project > org.jenkins-ci.plugins:whitesource:hpi:18.2.1-SNAPSHOT: > Failure to find org.jenkins-ci.main:jenkins-war:executable-war:2.102 in >

Re: jep-200 issue

2018-04-10 Thread Eugen Horovitz
Hi Jesse, Thanks a lot for your reply . now getting different error : Could not resolve dependencies for project org.jenkins-ci.plugins:whitesource:hpi:18.2.1-SNAPSHOT: Failure to find org.jenkins-ci.main:jenkins-war:executable-war:2.102 in https://repo.jenkins-ci.org/public/ was cached in the

Re: jep-200 issue

2018-04-09 Thread Jesse Glick
On Mon, Apr 9, 2018 at 12:28 PM, wrote: > mvn test -Djenkins.version=2.102 -Denforcer.skip=true > > but this fails with "Failure to find > org.jenkins-ci.main:jenkins-war:jar:war-for-test:2.102 " You need to use a newer parent POM—at least 2.30. -- You

jep-200 issue

2018-04-09 Thread eugen . horovitz
Hi , I am trying to make our plugin working with latest jenkins release (2.107.1) and encountered some issue. Reading the blog about the security hardening here : https://jenkins.io/blog/2018/01/13/jep-200/ there is an instruction to run maven command to check compatibility mvn test