Re: plugin parent 4.0

2020-04-23 Thread Tim Jacomb
2.164.x is fine, the bom sample plugin is using it on this version On Thu, 23 Apr 2020 at 08:53, Ullrich Hafner wrote: > > > Am 23.04.2020 um 01:06 schrieb 'Gavin Mogan' via Jenkins Developers < > jenkinsci-dev@googlegroups.com>: > > I'll update to 2.164, or tell dependabot to ignore this dep.

Re: plugin parent 4.0

2020-04-23 Thread Ullrich Hafner
> Am 23.04.2020 um 01:06 schrieb 'Gavin Mogan' via Jenkins Developers > : > > I'll update to 2.164, or tell dependabot to ignore this dep. I think you need to update to at 2.204 (I got errors for older versions). But it is also safe to ignore the plugin pom 4.x updates. > > On Wed, Apr

Re: plugin parent 4.0

2020-04-22 Thread 'Gavin Mogan' via Jenkins Developers
Oh, i think my eyes automatically glaze over the start of these things after looking at recipe sites. That or italics. My bad, I'll update to 2.164, or tell dependabot to ignore this dep. On Wed, Apr 22, 2020 at 4:02 PM Oleg Nenashev wrote: > There is a *"Note: Jenkins 2.164.x is the minimum

Re: plugin parent 4.0

2020-04-22 Thread Oleg Nenashev
There is a *"Note: Jenkins 2.164.x is the minimum supported version as it's the first version that includes the Jenkins bom" *warning in release notes https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.0 For older core versions we can still release the 3.x Plugin POM versions on-demand.

Re: plugin parent 4.0

2020-04-22 Thread 'Gavin Mogan' via Jenkins Developers
Are there version limits to the parent pom now? Is there a way to disable the bom stuff for older jenkins? https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fgraphql-server-plugin/detail/dependabot%2Fmaven%2Forg.jenkins-ci.plugins-plugin-4.1/1/pipeline/ Caused by:

Re: plugin parent 4.0

2020-04-22 Thread Jesse Glick
On Wed, Apr 22, 2020 at 4:41 AM Ullrich Hafner wrote: >> occasions wasted plenty of time trying to track down cryptic `LinkageError`s >> caused by mismatched dependencies. > > Was that while developing plugins or core? Plugins. > even if the enforcer finds something during compile it might be

Re: plugin parent 4.0

2020-04-22 Thread Ullrich Hafner
> Am 21.04.2020 um 19:05 schrieb Jesse Glick : > > On Mon, Apr 20, 2020 at 6:11 PM Ullrich Hafner > wrote: >> The enforcer never found a real bug up to now > > Interesting, before using `RequireUpperBoundDeps` I had on numerous > occasions wasted plenty of time trying to track down cryptic

Re: plugin parent 4.0

2020-04-22 Thread Ullrich Hafner
I think Tim fixed that already yesterday (https://github.com/jenkins-infra/jenkins.io/commit/fdfec966fcc6048cfd2703ec2baded40eddd1db8 ) > Am 22.04.2020 um 00:26 schrieb James Nord : > >>

Re: plugin parent 4.0

2020-04-21 Thread James Nord
> What I do not understand yet: do I still need to set the profile > -Duse-jenkins-bom no. is that still documented somewhere? if so I need to remove it -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and

Re: plugin parent 4.0

2020-04-21 Thread James Nord
my experience is the same as Ulli. never had an issue with linkage or class not found, and spend a lot of time fixing upper bounds to keep the enforcer rule happy (probably wrongly but if it keeps it happy) (hence the introduction of the jenkins BOM) -- You received this message because

Re: plugin parent 4.0

2020-04-21 Thread Jesse Glick
On Mon, Apr 20, 2020 at 6:11 PM Ullrich Hafner wrote: > The enforcer never found a real bug up to now Interesting, before using `RequireUpperBoundDeps` I had on numerous occasions wasted plenty of time trying to track down cryptic `LinkageError`s caused by mismatched dependencies. -- You

Re: plugin parent 4.0

2020-04-20 Thread Ullrich Hafner
Ok, I found the problem: maven-enforcer considered harmful. I don’t know how many hours I already spent fixing maven-enforcer library problems. The enforcer never found a real bug up to know, it is causing only confusion and so many lost hours of my valuable coding time :-( The problem was the

Re: plugin parent 4.0

2020-04-20 Thread Jesse Glick
On Mon, Apr 20, 2020 at 12:41 PM Ullrich Hafner wrote: > Is this a core problem or is this just an incompatibility in one of the > plugins I am loading in my integration test? Offhand smells like an incompatibility between one of your plugins and a newer core version. -- You received this

Re: plugin parent 4.0

2020-04-20 Thread Ullrich Hafner
After updating HtmlUnit to 2.39.0 the problem still appears:. I think the error actually is somewhere else, when I open the config page I get: /jenkins-core/2.204.4/jenkins-core-2.204.4.jar!/lib/form/optionalBlock.jelly:80:23: d:invokeBody

Re: plugin parent 4.0

2020-04-20 Thread Matt Sicker
One of the main backward-incompatible changes in pom 4.x is the HtmlUnit upgrade, so I'd guess that you've discovered one of said incompatibilities. On Mon, Apr 20, 2020 at 9:20 AM Ullrich Hafner wrote: > > Seems there is a problem (but this is probably more related to the Jenkins > baseline

Re: plugin parent 4.0

2020-04-20 Thread Ullrich Hafner
Seems there is a problem (but this is probably more related to the Jenkins baseline update to Jenkins 2.204.4): one of my integration tests fails now with: A JavaScript exception occured at: HtmlPage(http://localhost:50637/jenkins/job/test0/configure)@768414821 === EXCEPTION START

Re: plugin parent 4.0

2020-04-20 Thread Oleg Nenashev
Thanks James and Tim for the release! It is great to see it to be finally released. I updated the changelog a bit to make it shorter for duplicated dependencies and so on. Hopefully it will improve developer experience for plugin

Re: plugin parent 4.0

2020-04-20 Thread Ullrich Hafner
I updated all my plugins now, everything is looking good! Only problem: I needed to switch the minimum baseline to 2.204.4. I tried 2.190.4 but got a lot of errors. I’m not sure if this BOM version is expected to work as well. What I do not understand yet: do I still need to set the profile

Re: plugin parent 4.0

2020-04-19 Thread James Nord
many thanks Tim /James -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web

Re: plugin parent 4.0

2020-04-16 Thread Tim Jacomb
Hi plugin pom 4 is now released, Full release notes including all beta versions: https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.0 Thanks Tim On Wed, 15 Apr 2020 at 19:52, Tim Jacomb wrote: > This seems not to have happened, I'm happy to do it Oleg if you're too > busy? > >

Re: plugin parent 4.0

2020-04-15 Thread Tim Jacomb
This seems not to have happened, I'm happy to do it Oleg if you're too busy? Thanks Tim On Mon, 6 Apr 2020 at 09:55, Oleg Nenashev wrote: > Hi all, > > There was no new breaking changes coming in, and I think it is time to go > ahead and release a 4.0 version. > I plan to do so tomorrow if

Re: plugin parent 4.0

2020-04-06 Thread Oleg Nenashev
Hi all, There was no new breaking changes coming in, and I think it is time to go ahead and release a 4.0 version. I plan to do so tomorrow if there is no negative feedback. It would be great if somebody could write a blogpost with a summary of the changes in the new major release P.S: 4.0

Re: plugin parent 4.0

2020-03-29 Thread Mark Waite
I applied 4.0-beta-6 to the git client plugin as part preparation to set Jenkins 2.204.1 as the new required minimum version. Worked great. No issues detected. On Thu, Mar 26, 2020 at 8:38 AM Jeff Thompson wrote: > +1 > > I don't remember if I've pushed any commits that use the beta parent,

Re: plugin parent 4.0

2020-03-26 Thread Jeff Thompson
+1 I don't remember if I've pushed any commits that use the beta parent, but I've tried it out on a variety of different plugins I've investigated. I've found it to work better than any of the other earlier versions and can't think of any issues I've encountered. Jeff On 3/26/20 3:20 AM,