Re: Unit tests failing during dependabot merge (junit upgrade)

2022-02-25 Thread 'Gavin Mogan' via Jenkins Developers
Not sure why previous ones didn't fall, I suspect they do.

I think it's referring to the Java compiler level

https://github.com/jenkinsci/global-post-script-plugin/blob/master/pom.xml#L26

That should be 8 (1.8 is now 8). Also your parent pom is really old. I
believe that's covered in one of marks videos

On Fri., Feb. 25, 2022, 11:10 p.m. Mohammed Abdullah, 
wrote:

> Hi All,
>
>   I am trying to merge my first PR , given by dependabot.
>
>   Its a tiny change from junit from 4.11 to 4.13.1 on the pom.xml but the
> unit tests are failing , please see this link
> .
>
>   It looks like more changes may be required to actually make the above
> change. Please see below example and let me know how to proceed:
>
> [2020-10-13T04:59:05.594Z] [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:2.5:compile
> (default-compile) on project global-post-script: Compilation failure:
> Compilation failure:
>
>
> [2020-10-13T04:59:05.594Z]
> [ERROR] error: Source option 5 is no longer supported. Use 6 or later.
>
>
> [2020-10-13T04:59:05.594Z]
> [ERROR] error: Target option 1.5 is no longer supported. Use 1.6 or later.
>
> Thanks,
> Mohammed
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/29c85be8-cb83-4d89-abc5-58366b2090a5n%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Duv8r4pAHD_XB2J6Dju9OWfreAVx-Ba9sB8d%2BGiycE4B2w%40mail.gmail.com.


Unit tests failing during dependabot merge (junit upgrade)

2022-02-25 Thread Mohammed Abdullah
Hi All,

  I am trying to merge my first PR , given by dependabot.

  Its a tiny change from junit from 4.11 to 4.13.1 on the pom.xml but the 
unit tests are failing , please see this link 
.

  It looks like more changes may be required to actually make the above 
change. Please see below example and let me know how to proceed:

[2020-10-13T04:59:05.594Z] [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5:compile 
(default-compile) on project global-post-script: Compilation failure: 
Compilation failure: 

[2020-10-13T04:59:05.594Z]
 
[ERROR] error: Source option 5 is no longer supported. Use 6 or later. 

[2020-10-13T04:59:05.594Z]
 
[ERROR] error: Target option 1.5 is no longer supported. Use 1.6 or later.

Thanks,
Mohammed

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/29c85be8-cb83-4d89-abc5-58366b2090a5n%40googlegroups.com.


Re: Jenkins 2.332.1 LTS RC testing started

2022-02-25 Thread Mark Waite
On Friday, February 25, 2022 at 6:19:30 AM UTC-7 Tim Jacomb wrote:

> It'll be update center dynamic update sites most likely.
> We've had similar issues before from what I remember with RCs
>
>
Thanks.  I've confirmed that support core plugin 2.81 loads into 2.332.1-rc 
correctly 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/24578f05-3470-4217-bce5-d97ec69e48e4n%40googlegroups.com.


Re: Automated plugin release failing on 'check interesting categories' step

2022-02-25 Thread Alex
I had a chat with a GitHub staff member earlier:

Hi Alex,
>
> Thank you for your patience with this issue.
>
> Our team verified today that a releases feature flag that was enabled
> yesterday caused the experienced behavior with accessing draft releases
> from API calls authenticated with GITHUB_TOKEN.
>
> This flag was disabled earlier today, so accessing draft releases via API
> should work as expected again. This flag will remain disabled until our
> engineering team investigates and addresses the impact it had on using
> GITHUB_TOKEN.
>
> Please let us know if there is anything else we can help out with. Thank
> you again for writing in about this behavior!
>

I can verify it works again, however, if you have several release drafts,
you should get rid of them nevertheless. Only the newest entry is edited,
as supposed to be.

~Alex


Am Fr., 25. Feb. 2022 um 19:02 Uhr schrieb José Lamas Ríos :

> Thank you all for your comments and help.
>
> tl;dr: seems to be working now (last PR merge resulted in a new release)
>
> FTR: some notes about what I did:
>
>1. Last night I manually ran the workflow to see if it made any
>difference that there was already a release draft.
>   1. It created an additional release draft
>   
> https://github.com/jenkinsci/genexus-plugin/releases/tag/untagged-1934fa52b049ad8ace3d
>   in addition to the previous one at
>   
> https://github.com/jenkinsci/genexus-plugin/releases/tag/untagged-7aa3d1fa5d120e7a8b1a.
>   Both are shown as created Dec 10 2021, though it might simply be a 
> problem
>   with the web site logic fetching the date for release with that 'next' 
> name
>   and getting the data for the old one (name is not unique).
>- The check interesting categories did return true, the release was
>   triggered, although it failed for some reason I could not understand 
> (the
>   build shows as success but at the end it says the "Process completed 
> with
>   exit code 4".
>   
> https://github.com/jenkinsci/genexus-plugin/runs/5326733932?check_suite_focus=true
>   - An additional release dr
>2. Then this morning tried:
>   - Deleted the release drafts mentioned above
>   - Also deleted that old 'next' release that was actually published.
>   - Fired the workflow again (
>   
> https://github.com/jenkinsci/genexus-plugin/runs/5333860868?check_suite_focus=true
>   )
>   - A new release draft was created, which again shows the Dec 10
>   2021 date and references the commit at that time (
>   
> https://github.com/jenkinsci/genexus-plugin/commit/a6dbd90e9ec54c3b9ca1e3f9888cc8a2e9f1ebc5
>   )
>   - The package was created at
>   
> https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/genexus/294.v9475d0bc3504/
>   but then the release failed with a 403 error when trying to transfer it 
> to
>   maven.jenkins-ci.org.
>3. Later:
>   - Delete the latest release draft.
>   - Delete the git tag 'next'
>   - Fired workflow (
>   https://github.com/jenkinsci/genexus-plugin/actions/runs/1899441015)
>   - The new draft was correctly created (no date, no tag)
>   
> https://github.com/jenkinsci/genexus-plugin/releases/tag/untagged-298c04db8291690da8f9
>   - Release failed again with same 403 error.
>4. Last:
>   - Merged a PR from dependabot (Bumps actions/setup-java from 2.5.0
>   to 3) https://github.com/jenkinsci/genexus-plugin/pull/30
>   - CD was automatically fired and completed without errors (
>   https://github.com/jenkinsci/genexus-plugin/actions/runs/1899746441)
>   resulting in
>   - New release published
>   
> https://github.com/jenkinsci/genexus-plugin/releases/tag/296.v7ea4debe37c9
>
>
>
> On Fri, Feb 25, 2022 at 6:05 AM Alex  wrote:
>
>> Looks like others had the same idea like me and got it working with a
>> PAT:
>> https://github.com/release-drafter/release-drafter/issues/1081#issuecomment-1050099868
>>
>> Or locally like it does work for you.
>>
>> timja...@gmail.com schrieb am Freitag, 25. Februar 2022 um 09:36:38
>> UTC+1:
>>
>>> Weirdly if I run all the steps locally from the GitHub action I'm
>>> getting the right results =/
>>>
>>>
>>> https://github.com/jenkinsci/jenkins-infra-test-plugin/runs/5330785488?check_suite_focus=true
>>>
>>> On Thu, 24 Feb 2022 at 23:37, Alex  wrote:
>>>
 I got it working by exchanging the GitHub token in the workflow with a
 PAT:
 https://github.com/jenkinsci/purge-build-queue-plugin/commit/3e0e709bf62ec15a84d5bf4e2e81a98ace7b79bf

 I guess, GitHub either changed or broke something (both I'm currently
 unaware of), because the regular GH token suffices and grants read/write
 perms to all scopes, unless you change the workflow permission to read only
 for content, but that doesn't apply here.
 Alex schrieb am Donnerstag, 24. Februar 2022 um 23:57:39 UTC+1:

> To amend my comment on the dark-theme-plugin 

Re: Automated plugin release failing on 'check interesting categories' step

2022-02-25 Thread José Lamas Ríos
Thank you all for your comments and help.

tl;dr: seems to be working now (last PR merge resulted in a new release)

FTR: some notes about what I did:

   1. Last night I manually ran the workflow to see if it made any
   difference that there was already a release draft.
  1. It created an additional release draft
  
https://github.com/jenkinsci/genexus-plugin/releases/tag/untagged-1934fa52b049ad8ace3d
  in addition to the previous one at
  
https://github.com/jenkinsci/genexus-plugin/releases/tag/untagged-7aa3d1fa5d120e7a8b1a.
  Both are shown as created Dec 10 2021, though it might simply be
a problem
  with the web site logic fetching the date for release with that
'next' name
  and getting the data for the old one (name is not unique).
   - The check interesting categories did return true, the release was
  triggered, although it failed for some reason I could not understand (the
  build shows as success but at the end it says the "Process completed with
  exit code 4".
  
https://github.com/jenkinsci/genexus-plugin/runs/5326733932?check_suite_focus=true
  - An additional release dr
   2. Then this morning tried:
  - Deleted the release drafts mentioned above
  - Also deleted that old 'next' release that was actually published.
  - Fired the workflow again (
  
https://github.com/jenkinsci/genexus-plugin/runs/5333860868?check_suite_focus=true
  )
  - A new release draft was created, which again shows the Dec 10 2021
  date and references the commit at that time (
  
https://github.com/jenkinsci/genexus-plugin/commit/a6dbd90e9ec54c3b9ca1e3f9888cc8a2e9f1ebc5
  )
  - The package was created at
  
https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/genexus/294.v9475d0bc3504/
  but then the release failed with a 403 error when trying to
transfer it to
  maven.jenkins-ci.org.
   3. Later:
  - Delete the latest release draft.
  - Delete the git tag 'next'
  - Fired workflow (
  https://github.com/jenkinsci/genexus-plugin/actions/runs/1899441015)
  - The new draft was correctly created (no date, no tag)
  
https://github.com/jenkinsci/genexus-plugin/releases/tag/untagged-298c04db8291690da8f9
  - Release failed again with same 403 error.
   4. Last:
  - Merged a PR from dependabot (Bumps actions/setup-java from 2.5.0 to
  3) https://github.com/jenkinsci/genexus-plugin/pull/30
  - CD was automatically fired and completed without errors (
  https://github.com/jenkinsci/genexus-plugin/actions/runs/1899746441)
  resulting in
  - New release published
  https://github.com/jenkinsci/genexus-plugin/releases/tag/296.v7ea4debe37c9



On Fri, Feb 25, 2022 at 6:05 AM Alex  wrote:

> Looks like others had the same idea like me and got it working with a PAT:
> https://github.com/release-drafter/release-drafter/issues/1081#issuecomment-1050099868
>
> Or locally like it does work for you.
>
> timja...@gmail.com schrieb am Freitag, 25. Februar 2022 um 09:36:38 UTC+1:
>
>> Weirdly if I run all the steps locally from the GitHub action I'm getting
>> the right results =/
>>
>>
>> https://github.com/jenkinsci/jenkins-infra-test-plugin/runs/5330785488?check_suite_focus=true
>>
>> On Thu, 24 Feb 2022 at 23:37, Alex  wrote:
>>
>>> I got it working by exchanging the GitHub token in the workflow with a
>>> PAT:
>>> https://github.com/jenkinsci/purge-build-queue-plugin/commit/3e0e709bf62ec15a84d5bf4e2e81a98ace7b79bf
>>>
>>> I guess, GitHub either changed or broke something (both I'm currently
>>> unaware of), because the regular GH token suffices and grants read/write
>>> perms to all scopes, unless you change the workflow permission to read only
>>> for content, but that doesn't apply here.
>>> Alex schrieb am Donnerstag, 24. Februar 2022 um 23:57:39 UTC+1:
>>>
 To amend my comment on the dark-theme-plugin PR, I got the action
 somewhat of working by wiping the additional drafts and keeping one that
 covers all.
 I'm using release-drafter via GitHub actions outside of Jenkins too and
 have repositories with several drafts with different entries, so I'm not
 sure whether that is an actual issue with CD or GH actions/release-drafter
 itself.
 However, I didn't make it as far as Tim, because the "release" step
 fails with a 403 on deployment for me. That failure creates a new draft and
 we're basically back at step one.


 timja...@gmail.com schrieb am Donnerstag, 24. Februar 2022 um 23:18:30
 UTC+1:

> We were just discussing this here:
>
> https://github.com/jenkinsci/dark-theme-plugin/pull/170#issuecomment-1050263227
>
> By using a manual trigger to bypass the interesting category check and
> publishing the release notes myself I was able to get the release out
>
> On Thu, 24 Feb 2022 at 22:06, José Lamas Ríos 
> wrote:
>
>> Maybe unrelated but I've just noticed that the 

Re: Jenkins Security Scan now generally available

2022-02-25 Thread 'Daniel Beck' via Jenkins Developers
On Fri, Feb 25, 2022 at 2:43 PM Jean-Marc Meessen 
wrote:

>
> In the meantime, I will (try) to turn code scanning off so that I can get
> the PRs through CI.
>

Removing
https://github.com/jenkinsci/.github/blob/011201ac97f9e2757cca0415590952eaee704e5b/workflow-templates/jenkins-security-scan.yaml#L6-L7
should do it. The rest still works.

Sorry for the inconvenience. The existence of a single documented upload
API and an action to do the upload tricked me into thinking this just works
:(

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtJTtAR%2B0vCKOEZjWBB%2B73Vn8RWDVH%2BC7rpZ1tMEdXFRHA%40mail.gmail.com.


Re: Jenkins Security Scan now generally available

2022-02-25 Thread Jean-Marc Meessen
Thanks for looking into this, Daniel, and let us know about the status.
Looks trickier than expected.

In the meantime, I will (try) to turn code scanning off so that I can get
the PRs through CI.

/- Jmm

Le ven. 25 févr. 2022 à 11:50, 'Daniel Beck' via Jenkins Developers <
jenkinsci-dev@googlegroups.com> a écrit :

>
>
> On Wed, Feb 23, 2022 at 10:03 PM Daniel Beck  wrote:
>
>>
>> Interesting. It probably happens because it's a PR from a fork and the
>> GITHUB_TOKEN used only has read permission for SecurityEvents. I'll look
>> into solutions tomorrow.
>>
>
> It looks like GitHub's action can do what I cannot because it uses an
> undocumented API.
>
>
> I'll update this thread once it works, meanwhile you can watch
> https://github.com/jenkins-infra/jenkins-security-scan/issues/3
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtKKZVTPDQG%3D_zYbf3NHgasJm1weaPBs5TTdTtsreuaHXw%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CABLvyXwG_YGR1SS4GjoCAJUgktNteHPgfDM_CBDQJ_cXR6vyeQ%40mail.gmail.com.


Re: Jenkins 2.332.1 LTS RC testing started

2022-02-25 Thread Tim Jacomb
It'll be update center dynamic update sites most likely.
We've had similar issues before from what I remember with RCs

On Fri, 25 Feb 2022 at 12:22, Mark Waite  wrote:

> I'm perplexed by a behavior of the plugin manager or the update center
> code (not sure which).
>
> The support core plugin 2.81 has Jenkins 2.332 as its minimum Jenkins
> version.  I've confirmed it installs as expected on Jenkins 2.332.
>
> When running the Jenkins 2.332.1 release candidate build (version
> 2.332.1-rc32020.b_93520067d8c), support core plugin 2.80 is offered with
> the note in the plugin manager that support core plugin 2.81 is released
> but is not available to be installed.
>
> It seems that 2.332.1-rc is not considered to be greater or equal to
> 2.332.  Is that expected?
>
> I assume that the release of 2.332.1 will be considered to be greater or
> equal to 2.332.  Is that a correct assumption?
>
> Mark Waite
>
> On Wednesday, February 23, 2022 at 12:03:43 PM UTC-7 jn...@cloudbees.com
> wrote:
>
>> I found https://issues.jenkins.io/browse/JENKINS-67885 and have filed
>> https://github.com/jenkinsci/jenkins/pull/6305
>>
>>
>>
>> On Wednesday, February 23, 2022 at 6:20:09 PM UTC Cathy Chan wrote:
>>
>>> Hello everyone,
>>>
>>> Latest LTS RC was made public and it is ready to be tested. Final
>>> release is scheduled for 2022-03-09.
>>>
>>> Please, report your findings in this thread.
>>>
>>> Download the release from
>>> https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/main/jenkins-war/2.332.1-rc32020.b_93520067d8c/jenkins-war-2.332.1-rc32020.b_93520067d8c.war
>>>
>>> Thanks!
>>>
>>> - Cathy.
>>>
>> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/0be19194-2436-4f99-9187-94241653b720n%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bif47YORBi5hSyx7apKuXfe%3DP0y_W9ZbtFHL-ZkuC2iMWw%40mail.gmail.com.


Re: Governance meeting Feb 23, 2022

2022-02-25 Thread Mark Waite
On Wednesday, February 23, 2022 at 3:42:50 PM UTC-7 Jesse Glick wrote:

Version number to 3.x when we require Java 11 or newer?
>
>
> Rather not, because this implies that the upgrade is incompatible for most 
> users and a giant change in behavior, whereas it is just a newer version of 
> a runtime dependency.
>

Thanks for the insights.  I agree.  The change of major version risks that 
people expect dramatic changes in functionality and this is not 
dramatically changing functionality.

Someone also shared that my examples (JGit, Jetty) were libraries that 
needed to communicate breaking changes in their API's through a change of 
major number.  We're not making breaking changes in the API's as part of 
requiring Java 11 or newer, so it does not justify increasing the major 
number.

I'm pulling back from the idea of making the Jenkins version that requires 
Java 11 be a new major version.  I think we should stay with 2.x.

Mark Waite

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/24adde8c-570b-4917-a879-6fc360951400n%40googlegroups.com.


Is there any plugin that provides necessary API that I can build a customized UI on top of it

2022-02-25 Thread Weihong Xu
A lot of Jenkins page, like /flowGraphTable is rendered by server side. I 
was wondering is there any rest API that allow me to build customized UI 
with?

I try to search through the internet and only found a very simple one
jenkinsci/pipeline-restful-api-plugin: Provide the API endpoint for Jenkins 
CLI (github.com) 

I know that BlueOcean uses the  separated backend and frontend design. But 
it also claim that  `The Blue Ocean REST API is a "private API" designed 
for the Blue Ocean user interface. It may change without notice at any time`
blueocean-plugin/blueocean-rest at master · jenkinsci/blueocean-plugin 
(github.com) 


It would be great to have a general purpose APIs that we can use to get 
necessary data to build our own UI. It would be appreciated to shed me some 
light.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/81aebbf7-3879-45c7-8eca-8ca9d420fab3n%40googlegroups.com.


Re: Jenkins 2.332.1 LTS RC testing started

2022-02-25 Thread Mark Waite
I'm perplexed by a behavior of the plugin manager or the update center code 
(not sure which).

The support core plugin 2.81 has Jenkins 2.332 as its minimum Jenkins 
version.  I've confirmed it installs as expected on Jenkins 2.332.

When running the Jenkins 2.332.1 release candidate build (version 
2.332.1-rc32020.b_93520067d8c), support core plugin 2.80 is offered with 
the note in the plugin manager that support core plugin 2.81 is released 
but is not available to be installed.

It seems that 2.332.1-rc is not considered to be greater or equal to 
2.332.  Is that expected?

I assume that the release of 2.332.1 will be considered to be greater or 
equal to 2.332.  Is that a correct assumption?

Mark Waite

On Wednesday, February 23, 2022 at 12:03:43 PM UTC-7 jn...@cloudbees.com 
wrote:

> I found https://issues.jenkins.io/browse/JENKINS-67885 and have filed 
> https://github.com/jenkinsci/jenkins/pull/6305
>
>
>
> On Wednesday, February 23, 2022 at 6:20:09 PM UTC Cathy Chan wrote:
>
>> Hello everyone,
>>
>> Latest LTS RC was made public and it is ready to be tested. Final release 
>> is scheduled for 2022-03-09.
>>
>> Please, report your findings in this thread.
>>
>> Download the release from 
>> https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/main/jenkins-war/2.332.1-rc32020.b_93520067d8c/jenkins-war-2.332.1-rc32020.b_93520067d8c.war
>>
>> Thanks!
>>
>> - Cathy.
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/0be19194-2436-4f99-9187-94241653b720n%40googlegroups.com.


Re: Jenkins Security Scan now generally available

2022-02-25 Thread 'Daniel Beck' via Jenkins Developers
On Wed, Feb 23, 2022 at 10:03 PM Daniel Beck  wrote:

>
> Interesting. It probably happens because it's a PR from a fork and the
> GITHUB_TOKEN used only has read permission for SecurityEvents. I'll look
> into solutions tomorrow.
>

It looks like GitHub's action can do what I cannot because it uses an
undocumented API.


I'll update this thread once it works, meanwhile you can watch
https://github.com/jenkins-infra/jenkins-security-scan/issues/3

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtKKZVTPDQG%3D_zYbf3NHgasJm1weaPBs5TTdTtsreuaHXw%40mail.gmail.com.


Re: Automated plugin release failing on 'check interesting categories' step

2022-02-25 Thread Alex
Looks like others had the same idea like me and got it working with a 
PAT: 
https://github.com/release-drafter/release-drafter/issues/1081#issuecomment-1050099868
 
Or locally like it does work for you.

timja...@gmail.com schrieb am Freitag, 25. Februar 2022 um 09:36:38 UTC+1:

> Weirdly if I run all the steps locally from the GitHub action I'm getting 
> the right results =/
>
>
> https://github.com/jenkinsci/jenkins-infra-test-plugin/runs/5330785488?check_suite_focus=true
>
> On Thu, 24 Feb 2022 at 23:37, Alex  wrote:
>
>> I got it working by exchanging the GitHub token in the workflow with a 
>> PAT: 
>> https://github.com/jenkinsci/purge-build-queue-plugin/commit/3e0e709bf62ec15a84d5bf4e2e81a98ace7b79bf
>>
>> I guess, GitHub either changed or broke something (both I'm currently 
>> unaware of), because the regular GH token suffices and grants read/write 
>> perms to all scopes, unless you change the workflow permission to read only 
>> for content, but that doesn't apply here. 
>> Alex schrieb am Donnerstag, 24. Februar 2022 um 23:57:39 UTC+1:
>>
>>> To amend my comment on the dark-theme-plugin PR, I got the action 
>>> somewhat of working by wiping the additional drafts and keeping one that 
>>> covers all.
>>> I'm using release-drafter via GitHub actions outside of Jenkins too and 
>>> have repositories with several drafts with different entries, so I'm not 
>>> sure whether that is an actual issue with CD or GH actions/release-drafter 
>>> itself.
>>> However, I didn't make it as far as Tim, because the "release" step 
>>> fails with a 403 on deployment for me. That failure creates a new draft and 
>>> we're basically back at step one.
>>>
>>>
>>> timja...@gmail.com schrieb am Donnerstag, 24. Februar 2022 um 23:18:30 
>>> UTC+1:
>>>
 We were just discussing this here:

 https://github.com/jenkinsci/dark-theme-plugin/pull/170#issuecomment-1050263227

 By using a manual trigger to bypass the interesting category check and 
 publishing the release notes myself I was able to get the release out

 On Thu, 24 Feb 2022 at 22:06, José Lamas Ríos  wrote:

> Maybe unrelated but I've just noticed that the release draft 
> 
>  
> that was just created and is listed as the most recent one but shows a 
> Dec 
> 10 2021 date...
>
> There is in fact another release 
>  on 
> that date that is not in draft state but (probably due to some error on 
> my 
> part) got published while keeping the 'next' tag / name.
>
> I'll later try renaming or deleting the old release and check if that 
> fixes the problem. 
>
>
>
>
> On Thursday, February 24, 2022 at 6:52:46 PM UTC-3 José Lamas Ríos 
> wrote:
>
>> Hi, 
>>
>> I'm having problems with the automated release workflow for 
>> genexus-plugin .
>>
>> For instance, this CD run at 
>> https://github.com/jenkinsci/genexus-plugin/runs/5325279945
>>
>> After the successful build it gets to create the release draft, but 
>> then seems to fail at finding it with an interesting category, so the 
>> release is not fired.
>>
>> The draft release was created at 
>> https://github.com/jenkinsci/genexus-plugin/releases/tag/untagged-1934fa52b049ad8ace3d
>>  
>> and running these commands on my terminal does seem to work:
>>
>> McJLR:~jlr$ RESULT=$(gh api /repos/jenkinsci/genexus-plugin/releases 
>> | jq -e -r '.[] | select(.draft == true and .name == "next") | .body' | 
>> egrep "$INTERESTING_CATEGORIES" || echo 'failed')
>>
>> McJLR:~ jlr$ echo $RESULT
>>
>> ##  Bug fixes
>>
>>
>> Any ideas?
>>
>> Thanks in advance,
>>
>>
>>
>>
>> -- 
> You received this message because you are subscribed to the Google 
> Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send 
> an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/c742b7c1-e2e2-456a-a6ab-d2a56f76fb36n%40googlegroups.com
>  
> 
> .
>
 -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com.
>>
> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/badbb90d-1358-48c4-809a-0462c08c9c00n%40googlegroups.com
>>  
>> 

Re: Automated plugin release failing on 'check interesting categories' step

2022-02-25 Thread Tim Jacomb
Weirdly if I run all the steps locally from the GitHub action I'm getting
the right results =/

https://github.com/jenkinsci/jenkins-infra-test-plugin/runs/5330785488?check_suite_focus=true

On Thu, 24 Feb 2022 at 23:37, Alex  wrote:

> I got it working by exchanging the GitHub token in the workflow with a
> PAT:
> https://github.com/jenkinsci/purge-build-queue-plugin/commit/3e0e709bf62ec15a84d5bf4e2e81a98ace7b79bf
>
> I guess, GitHub either changed or broke something (both I'm currently
> unaware of), because the regular GH token suffices and grants read/write
> perms to all scopes, unless you change the workflow permission to read only
> for content, but that doesn't apply here.
> Alex schrieb am Donnerstag, 24. Februar 2022 um 23:57:39 UTC+1:
>
>> To amend my comment on the dark-theme-plugin PR, I got the action
>> somewhat of working by wiping the additional drafts and keeping one that
>> covers all.
>> I'm using release-drafter via GitHub actions outside of Jenkins too and
>> have repositories with several drafts with different entries, so I'm not
>> sure whether that is an actual issue with CD or GH actions/release-drafter
>> itself.
>> However, I didn't make it as far as Tim, because the "release" step fails
>> with a 403 on deployment for me. That failure creates a new draft and we're
>> basically back at step one.
>>
>>
>> timja...@gmail.com schrieb am Donnerstag, 24. Februar 2022 um 23:18:30
>> UTC+1:
>>
>>> We were just discussing this here:
>>>
>>> https://github.com/jenkinsci/dark-theme-plugin/pull/170#issuecomment-1050263227
>>>
>>> By using a manual trigger to bypass the interesting category check and
>>> publishing the release notes myself I was able to get the release out
>>>
>>> On Thu, 24 Feb 2022 at 22:06, José Lamas Ríos  wrote:
>>>
 Maybe unrelated but I've just noticed that the release draft
 
 that was just created and is listed as the most recent one but shows a Dec
 10 2021 date...

 There is in fact another release
  on
 that date that is not in draft state but (probably due to some error on my
 part) got published while keeping the 'next' tag / name.

 I'll later try renaming or deleting the old release and check if that
 fixes the problem.




 On Thursday, February 24, 2022 at 6:52:46 PM UTC-3 José Lamas Ríos
 wrote:

> Hi,
>
> I'm having problems with the automated release workflow for
> genexus-plugin .
>
> For instance, this CD run at
> https://github.com/jenkinsci/genexus-plugin/runs/5325279945
>
> After the successful build it gets to create the release draft, but
> then seems to fail at finding it with an interesting category, so the
> release is not fired.
>
> The draft release was created at
> https://github.com/jenkinsci/genexus-plugin/releases/tag/untagged-1934fa52b049ad8ace3d
> and running these commands on my terminal does seem to work:
>
> McJLR:~jlr$ RESULT=$(gh api /repos/jenkinsci/genexus-plugin/releases |
> jq -e -r '.[] | select(.draft == true and .name == "next") | .body' | 
> egrep
> "$INTERESTING_CATEGORIES" || echo 'failed')
>
> McJLR:~ jlr$ echo $RESULT
>
> ##  Bug fixes
>
>
> Any ideas?
>
> Thanks in advance,
>
>
>
>
> --
 You received this message because you are subscribed to the Google
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to jenkinsci-de...@googlegroups.com.
 To view this discussion on the web visit
 https://groups.google.com/d/msgid/jenkinsci-dev/c742b7c1-e2e2-456a-a6ab-d2a56f76fb36n%40googlegroups.com
 
 .

>>> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/badbb90d-1358-48c4-809a-0462c08c9c00n%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit