Re: Decouple BuildSelector from Copy Artifact plugin into a separate repo

On Wed, Jul 13, 2016 at 8:20 AM, martinda wrote: >> choosing that pattern makes it impossible to use >> _Snippet Generator_ to get syntax examples. Generally recommend that >> step parameters be simple types like `String`, `int`, or collections >> of some `Describable`

Re: Decouple BuildSelector from Copy Artifact plugin into a separate repo

See my question in-line below. On Tuesday, July 12, 2016 at 11:36:15 PM UTC-4, Jesse Glick wrote: > > > > // this is a step specific to the External Workspace Manager Plugin, > that > > accepts as input a RunWrapper object. > > def extWorksace = exwsAllocate selectedRun: run > > Possible,

Re: Decouple BuildSelector from Copy Artifact plugin into a separate repo

On Mon, Jul 11, 2016 at 11:27 AM, Alexandru Somai wrote: > def run = step([$class: 'RunSelectorWrapper', upstream: 'upstream-name', > selector: [$class: ['PermalinkRunSelector'], id: 'lastStableBuild']]) `RunSelectorWrapper` is a poor name as it suggests

Re: Decouple BuildSelector from Copy Artifact plugin into a separate repo

Hello everyone, I have some concerns about how a specific build from the upstream job should be selected in the case of the plugin that I am currently developing: https://github.com/jenkinsci/external-workspace-manager-plugin. Please note that the plugin focus is mainly on Pipeline jobs. Based

Re: Decouple BuildSelector from Copy Artifact plugin into a separate repo

On Tue, Jul 5, 2016 at 8:08 AM, Alexandru Somai wrote: > One of the features that I need is to allow the user to choose a > specific build from the upstream job. For this, I was thinking to integrate > the BuildSelector from the Copy Artifact plugin. As discussed in

Re: Decouple BuildSelector from Copy Artifact plugin into a separate repo

> We can start without CopyArtifactPermissionProperty. I found that `CopyArtifactPermissionProperty` works only for job selection, and does nothing for run selection. (Copyartifact2.0 doesn't yet support permissions of runs. Related: https://issues.jenkins-ci.org/browse/JENKINS-22460 ) No

Re: Decouple BuildSelector from Copy Artifact plugin into a separate repo

Hello. Thanks for the repository. I don't have so much time to participate in the development, and alexsomai is the maintainer of this plugin. I'll participate in the development only by sending a pull request. >> CopyArtifactPermissionProperty. I think it shouldn't moved to >>

Re: Decouple BuildSelector from Copy Artifact plugin into a separate repo

Hello, Thank you Oleg for setting-up the repo. The first step that I'll do is to remove the deprecated features and code that was inherited from the Copy Artifact plugin. I'll create a PR as soon as I'm done with this. Afterwards, I think that we should rename the packages and classes.

Re: Decouple BuildSelector from Copy Artifact plugin into a separate repo

Hello, The code has been copied to https://github.com/jenkinsci/run-selector-plugin . I decided not to do perform a GitHub fork in order to avoid future links between two plugins in history search and Github's diff interfaces. Can convert it to fork if there are strong opinions. alexsomai and

Re: Decouple BuildSelector from Copy Artifact plugin into a separate repo

Hello, If required, I could create a clone of the plugin directly in the jenkinsci > organization and make you both plugin developers. > This would be useful. I think that the PR #71 from Copy Artifact plugin should be also merged as it is into the new repository. Afterwards, we can start

Re: Decouple BuildSelector from Copy Artifact plugin into a separate repo

Hi, The approach looks good to me. We really have much plugins, which may benefit from the Build Selector functionality. If required, I could create a clone of the plugin directly in the jenkinsci organization and make you both plugin developers. >From the terminology perspective, maybe makes

Re: Decouple BuildSelector from Copy Artifact plugin into a separate repo

Hello, Alex. > What do you think about the idea of moving the *BuildSelector* extension point to a separate plugin repository? Sounds good to me. As you pointed, the build selection feature of CopyArtifact is also useful for other plugins. Though CopyArtifact 2.0 is still in progress (for

Decouple BuildSelector from Copy Artifact plugin into a separate repo

Hello, Currently I'm working to add more features to the External Workspace Manager plugin . One of the features that I need is to allow the user to choose a specific build from the upstream job. For this, I was thinking to