Re: Updates to plugin code without consulting maintainers

2014-09-03 Thread Jesse Glick
On Wed, Sep 3, 2014 at 6:27 AM, FredG fred.g...@googlemail.com wrote: Unfortunately Github does not sent notifications for simple commits. This has been bothering me recently too. Have thought about a solution but lack time to implement. (There is a commit alias for @jenkinsci, but it

Re: Updates to plugin code without consulting maintainers

2014-08-26 Thread Christopher Orr
On 26/08/14 07:05, Stephen Connolly wrote: On Monday, 25 August 2014, Slide slide.o@gmail.com mailto:slide.o@gmail.com wrote: There have been a couple times recently where someone from Cloudbees has made changes to email-ext without consulting with me as the maintainer of

Re: Updates to plugin code without consulting maintainers

2014-08-26 Thread Tom Fennelly
Okay... really sorry about that... I did make those changes on a branch but I should have done it on a fork. I actually did create a fork after seeing there was a build tracking branches. Let me know if I should delete the branch I created - I won't touch anything until you let me know what

Re: Updates to plugin code without consulting maintainers

2014-08-26 Thread Slide
Not a big deal, I've wondered why all branches are tracked on jenkins.ci.cloudbees, I would think only master would be tracked. Don't worry about deleting the branch. If you have specific things you would like added, pull requests are great. On Tue, Aug 26, 2014 at 3:22 AM, Tom Fennelly

Re: Updates to plugin code without consulting maintainers

2014-08-26 Thread Jesse Glick
On Tue, Aug 26, 2014 at 9:01 AM, Slide slide.o@gmail.com wrote: I've wondered why all branches are tracked on jenkins.ci.cloudbees, I would think only master would be tracked. Not sure but I suspect this is necessary for the pull request builder. It is annoying though that when you have a

Updates to plugin code without consulting maintainers

2014-08-25 Thread Slide
There have been a couple times recently where someone from Cloudbees has made changes to email-ext without consulting with me as the maintainer of email-ext. Just recently tfennelly made a change to the parent pom version with no consultation. I consider this to be unacceptable. Any changes to

Re: Updates to plugin code without consulting maintainers

2014-08-25 Thread Slide
After looking at it again (I was only looking at the CI job that was failing) I notice that the work is being done in a separate branch. I would still prefer that any work be done in someone's own fork and pull requests created for any desired updates. On Mon, Aug 25, 2014 at 2:21 PM, Slide

Re: Updates to plugin code without consulting maintainers

2014-08-25 Thread Jesse Glick
On Mon, Aug 25, 2014 at 5:23 PM, Slide slide.o@gmail.com wrote: I notice that the work is being done in a separate branch. I would still prefer that any work be done in someone's own fork and pull requests created for any desired updates. Sure. BTW it is possible (and sometimes useful) to

Re: Updates to plugin code without consulting maintainers

2014-08-25 Thread Stephen Connolly
On Monday, 25 August 2014, Slide slide.o@gmail.com wrote: There have been a couple times recently where someone from Cloudbees has made changes to email-ext without consulting with me as the maintainer of email-ext. Just recently tfennelly made a change to the parent pom version with no