Re: JenkinsRule tests sometimes timeout

2018-04-09 Thread Jacob Keller


On Monday, April 9, 2018 at 1:26:23 PM UTC-7, Jesse Glick wrote:
>
> On Mon, Apr 9, 2018 at 2:44 PM, Jacob Keller  > wrote: 
> > I discovered that it could take a significantly long 
> > time for the SSHD server to start. It turns out that JenkinsRule 
> defaults to 
> > the 1.651.2 jenkins-war which does not disable the server by default.  
>
`JenkinsRule` is _built_ against some older version of Jenkins core. 
> What you _run_ against is specified by `jenkins.version` in your POM. 
> Select something newish, and SSHD will not be started by default, and 
> your problem is solved. 
>
>
Ok, that fixes the cases for testing against newer versions of Jenkins. I 
think the git plugin still wants to point against older versions.
 

> > attempting to debug why the sshd-module can sometimes take forever. 
> > (It's possible it's platform/OS related?) 
>
> Sure, maybe. 


I'm not exactly sure how to do that, but I suppose I could at least add 
more logging statements to sshd-module and build a version of Jenkins that 
includes those. Ultimately, it won't resolve the issue if building against 
older versions (unless we backport such a fix to maintenance branches?)
 

> > modifying the JenkinsRule to not start the timeout countdown until after 
> > initialization 
>
> No, this would allow tests which genuinely hang in e.g. `@LocalData` 
> to never terminate. 


Ok this makes sense to avoid.

Thanks,
Jake

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/2ba7c950-e950-40f5-b1a6-097aa76c5cf7%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: JenkinsRule tests sometimes timeout

2018-04-09 Thread Jesse Glick
On Mon, Apr 9, 2018 at 2:44 PM, Jacob Keller  wrote:
> I discovered that it could take a significantly long
> time for the SSHD server to start. It turns out that JenkinsRule defaults to
> the 1.651.2 jenkins-war which does not disable the server by default.

`JenkinsRule` is _built_ against some older version of Jenkins core.
What you _run_ against is specified by `jenkins.version` in your POM.
Select something newish, and SSHD will not be started by default, and
your problem is solved.

> attempting to debug why the sshd-module can sometimes take forever.
> (It's possible it's platform/OS related?)

Sure, maybe.

> modifying the JenkinsRule to not start the timeout countdown until after
> initialization

No, this would allow tests which genuinely hang in e.g. `@LocalData`
to never terminate.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0etuyQnSW6g9EsE93mRbQx1HkxcaFK9%2B%2BW7bCN3XuPDA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.