Re: jep-200 issue

[Eugen Horovitz]

Thanks a lot Jesse.
We will consider all these things when upgrading .

Kind Regards,
Eugen



On Wed, Apr 11, 2018 at 7:51 PM, Jesse Glick  wrote:

> On Wed, Apr 11, 2018 at 10:54 AM, Eugen Horovitz
>  wrote:
> > The rule violations : https://gist.github.com/eugenhoro/
> 44e1495ff8d182c8760edeec0982d020
>
> Some of those would be corrected by just, say, updating the
> `maven-plugin` dep. Others look like real mistakes in your
> dependencies. For example, you are declaring an explicit dependency on
> a version of `wss-agent-api-client` older than what your other
> dependency `whitesource-fs-agent` claims to require, which could
> result in linkage errors at runtime. Anyway, something to address when
> next updating your parent POM.
>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/jenkinsci-dev/NI533mCeKgc/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/CANfRfr28u45aKvK53-PbN8MRYnOAoxRUa7-O%
> 2BGLMm0fDKS_Q-g%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
*Eugen Horovitz*

*Senior software engineer*



*WhiteSource  **empowers businesses
to develop better software *
*by harnessing the power of open source*




-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BZxFhd41qyWrLOqMphHd5R5dwJ1HGO6t72NyPjHfJsEBSZV2g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: jep-200 issue

[Jesse Glick]

On Wed, Apr 11, 2018 at 10:54 AM, Eugen Horovitz
 wrote:
> The rule violations : 
> https://gist.github.com/eugenhoro/44e1495ff8d182c8760edeec0982d020

Some of those would be corrected by just, say, updating the
`maven-plugin` dep. Others look like real mistakes in your
dependencies. For example, you are declaring an explicit dependency on
a version of `wss-agent-api-client` older than what your other
dependency `whitesource-fs-agent` claims to require, which could
result in linkage errors at runtime. Anyway, something to address when
next updating your parent POM.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr28u45aKvK53-PbN8MRYnOAoxRUa7-O%2BGLMm0fDKS_Q-g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: jep-200 issue

[Eugen Horovitz]

Now it compiles fine and it seems to "play" :) ! Thanks Jesse .I really
appreciate the effort.
The rule violations :
https://gist.github.com/eugenhoro/44e1495ff8d182c8760edeec0982d020


On Wed, Apr 11, 2018 at 3:49 PM, Jesse Glick  wrote:

> On Wed, Apr 11, 2018 at 9:21 AM, Eugen Horovitz
>  wrote:
> > Failed to execute goal org.apache.maven.plugins:
> maven-enforcer-plugin:3.0.0-M1:enforce (display-info) on project
> whitesource: Some Enforcer rules have failed. Look above for specific
> messages explaining why the rule failed.
>
> You did not tell us which rule violations were displayed, but anyway
> perhaps this time you forgot to include `-Denforcer.skip`?
>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/jenkinsci-dev/NI533mCeKgc/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/CANfRfr2LZ471NQX15K0m2mjpN3piv
> xy3MmX10Ny9K3UR5n5enA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
*Eugen Horovitz*

*Senior software engineer*



*WhiteSource  **empowers businesses
to develop better software *
*by harnessing the power of open source*




-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BZxFhfHUK5muWNJ8PvRfyVVwo2u3_RB0Yw3t7K2UdY8ys2zdA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: jep-200 issue

[Jesse Glick]

On Wed, Apr 11, 2018 at 9:21 AM, Eugen Horovitz
 wrote:
> Failed to execute goal 
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce 
> (display-info) on project whitesource: Some Enforcer rules have failed. Look 
> above for specific messages explaining why the rule failed.

You did not tell us which rule violations were displayed, but anyway
perhaps this time you forgot to include `-Denforcer.skip`?

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr2LZ471NQX15K0m2mjpN3pivxy3MmX10Ny9K3UR5n5enA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: jep-200 issue

[Eugen Horovitz]

https://gist.github.com/eugenhoro/f73f4d666c64ea809e6a6711a0e40ed3


On Wed, Apr 11, 2018 at 3:21 PM, Eugen Horovitz <
eugen.horov...@whitesourcesoftware.com> wrote:

> @Jesse , @Oleg, @Daniel, @Slide. Thank you very much guys .It really helps
> me going forward solving this ..
> After doing all the changes, still having some issues compiling ..
>
> Failed to execute goal org.apache.maven.plugins:
> maven-enforcer-plugin:3.0.0-M1:enforce (display-info) on project
> whitesource: Some Enforcer rules have failed. Look above for specific
> messages explaining why the rule failed.
> with some rules details.. I guess I will need to fix the dependencies
> version and try again (?)
>
> Thanks a lot guys again  !
>
> Eugen
>
> On Wed, Apr 11, 2018 at 7:00 AM, Oleg Nenashev 
> wrote:
>
>> I did all the changes and still got the same errors..
>>>
>>
>> Hi Eugen,
>>
>> Your pom.xml still explicitly defines the macen-hpi-plugin version (line
>> 150 in your gist).
>> To build the plugin you need to either remove it or change to the version
>> provided by the parent POM.
>>
>> P.S: Maven Release Plugin and FindBugs Plugin definitions could be also
>> removed, new Plugin POM bundles them. But it should not block the build
>>
>> Best regards,
>> Oleg
>>
>>
>> On Tuesday, April 10, 2018 at 10:16:54 PM UTC+2, Daniel Beck wrote:
>>>
>>>
>>> > On 10. Apr 2018, at 17:44, Slide  wrote:
>>> >
>>> > Why are you skipping the enforcer?
>>>
>>> It's the recommendation from https://jenkins.io/blog/2018/0
>>> 1/13/jep-200/#testing-plugins-against-jenkins-2-102-and-above
>>>
>>> I think this is specific to testing against a newer core, otherwise
>>> there would be a ton of unnecessary problems.
>>>
>>> --
>> You received this message because you are subscribed to a topic in the
>> Google Groups "Jenkins Developers" group.
>> To unsubscribe from this topic, visit https://groups.google.com/d/to
>> pic/jenkinsci-dev/NI533mCeKgc/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to
>> jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/ms
>> gid/jenkinsci-dev/a87c0bf0-c2a9-4c73-aca2-a82d9120c3f3%40googlegroups.com
>> 
>> .
>>
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> --
> *Eugen Horovitz*
>
> *Senior software engineer*
>
>
>
> *WhiteSource  **empowers businesses
> to develop better software *
> *by harnessing the power of open source*
> 
> 
> 
>



-- 
*Eugen Horovitz*

*Senior software engineer*



*WhiteSource  **empowers businesses
to develop better software *
*by harnessing the power of open source*




-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BZxFheDSh_xHKQAGqmBO4N8Nu%3DNT6cedT02nZoP7Y5YMhgUDA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: jep-200 issue

[Eugen Horovitz]

@Jesse , @Oleg, @Daniel, @Slide. Thank you very much guys .It really helps
me going forward solving this ..
After doing all the changes, still having some issues compiling ..

Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce
(display-info) on project whitesource: Some Enforcer rules have failed.
Look above for specific messages explaining why the rule failed.
with some rules details.. I guess I will need to fix the dependencies
version and try again (?)

Thanks a lot guys again  !

Eugen

On Wed, Apr 11, 2018 at 7:00 AM, Oleg Nenashev 
wrote:

> I did all the changes and still got the same errors..
>>
>
> Hi Eugen,
>
> Your pom.xml still explicitly defines the macen-hpi-plugin version (line
> 150 in your gist).
> To build the plugin you need to either remove it or change to the version
> provided by the parent POM.
>
> P.S: Maven Release Plugin and FindBugs Plugin definitions could be also
> removed, new Plugin POM bundles them. But it should not block the build
>
> Best regards,
> Oleg
>
>
> On Tuesday, April 10, 2018 at 10:16:54 PM UTC+2, Daniel Beck wrote:
>>
>>
>> > On 10. Apr 2018, at 17:44, Slide  wrote:
>> >
>> > Why are you skipping the enforcer?
>>
>> It's the recommendation from https://jenkins.io/blog/2018/0
>> 1/13/jep-200/#testing-plugins-against-jenkins-2-102-and-above
>>
>> I think this is specific to testing against a newer core, otherwise there
>> would be a ton of unnecessary problems.
>>
>> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/jenkinsci-dev/NI533mCeKgc/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/a87c0bf0-c2a9-4c73-aca2-a82d9120c3f3%
> 40googlegroups.com
> 
> .
>
> For more options, visit https://groups.google.com/d/optout.
>



-- 
*Eugen Horovitz*

*Senior software engineer*



*WhiteSource  **empowers businesses
to develop better software *
*by harnessing the power of open source*




-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BZxFhcTEnueaR57hoz9BeMJFDfJrhy33vyh3xkJdjEmUP7puQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: jep-200 issue

[Slide]

Why are you skipping the enforcer?

On Tue, Apr 10, 2018 at 8:30 AM Eugen Horovitz <
eugen.horov...@whitesourcesoftware.com> wrote:

> Hi Jesse ,
>
> I did all the changes and still got the same errors..
> I am probably still missing some important stuff... I am newbie in
> jenkins plugin development and I will be greatfull if you can have a
> look.
>
> https://gist.github.com/eugenhoro/f73f4d666c64ea809e6a6711a0e40ed3
>
> maven fails to build and also this
>
> mvn test -Djenkins.version=2.102 -Denforcer.skip=true
>
> from https://jenkins.io/blog/2018/01/13/jep-200/
>
> Thanks a lot
>
> On Tue, Apr 10, 2018 at 3:50 PM, Jesse Glick  wrote:
>
>> On Tue, Apr 10, 2018 at 2:25 AM, Eugen Horovitz
>>  wrote:
>> > Could not resolve dependencies for project
>> org.jenkins-ci.plugins:whitesource:hpi:18.2.1-SNAPSHOT:
>> > Failure to find org.jenkins-ci.main:jenkins-war:executable-war:2.102 in
>> https://repo.jenkins-ci.org/public/
>>
>> Stop overriding the version of `maven-hpi-plugin` in your POM. The old
>> version you are specifying does not work any more. Let it get picked
>> up by the parent.
>>
>> For that matter, there is a bunch of other stuff in your POM which can
>> and should be deleted. The configuration of `maven-compiler-plugin`,
>> for example.
>>
>
>> --
>> You received this message because you are subscribed to a topic in the
>> Google Groups "Jenkins Developers" group.
>> To unsubscribe from this topic, visit
>> https://groups.google.com/d/topic/jenkinsci-dev/NI533mCeKgc/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to
>> jenkinsci-dev+unsubscr...@googlegroups.com.
>>
> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0EozZfCAVRLFMwOLg_Jj1UjPMVb-bpejW7HyQy%2BvrC0w%40mail.gmail.com
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> *Eugen Horovitz*
>
> *Senior software engineer*
>
>
>
> *WhiteSource  **empowers businesses
> to develop better software *
> *by harnessing the power of open source*
> 
> 
> 
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BZxFhfexSVsYBbyA%3DQhGGtSzzPNxNQiqKtEA3Y8gmUqTHJbdA%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVfSazke1dcdPWRDU0gEwakqw9A9yq0-H%3DM4JX7B71n83g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: jep-200 issue

[Eugen Horovitz]

Hi Jesse ,

I did all the changes and still got the same errors..
I am probably still missing some important stuff... I am newbie in jenkins
plugin development and I will be greatfull if you can have a look.

https://gist.github.com/eugenhoro/f73f4d666c64ea809e6a6711a0e40ed3

maven fails to build and also this

mvn test -Djenkins.version=2.102 -Denforcer.skip=true

from https://jenkins.io/blog/2018/01/13/jep-200/

Thanks a lot

On Tue, Apr 10, 2018 at 3:50 PM, Jesse Glick  wrote:

> On Tue, Apr 10, 2018 at 2:25 AM, Eugen Horovitz
>  wrote:
> > Could not resolve dependencies for project org.jenkins-ci.plugins:
> whitesource:hpi:18.2.1-SNAPSHOT:
> > Failure to find org.jenkins-ci.main:jenkins-war:executable-war:2.102 in
> https://repo.jenkins-ci.org/public/
>
> Stop overriding the version of `maven-hpi-plugin` in your POM. The old
> version you are specifying does not work any more. Let it get picked
> up by the parent.
>
> For that matter, there is a bunch of other stuff in your POM which can
> and should be deleted. The configuration of `maven-compiler-plugin`,
> for example.
>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/jenkinsci-dev/NI533mCeKgc/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/CANfRfr0EozZfCAVRLFMwOLg_Jj1UjPMVb-bpejW7HyQy%2BvrC0w%
> 40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
*Eugen Horovitz*

*Senior software engineer*



*WhiteSource  **empowers businesses
to develop better software *
*by harnessing the power of open source*




-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BZxFhfexSVsYBbyA%3DQhGGtSzzPNxNQiqKtEA3Y8gmUqTHJbdA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: jep-200 issue

[Jesse Glick]

On Tue, Apr 10, 2018 at 2:25 AM, Eugen Horovitz
 wrote:
> Could not resolve dependencies for project 
> org.jenkins-ci.plugins:whitesource:hpi:18.2.1-SNAPSHOT:
> Failure to find org.jenkins-ci.main:jenkins-war:executable-war:2.102 in 
> https://repo.jenkins-ci.org/public/

Stop overriding the version of `maven-hpi-plugin` in your POM. The old
version you are specifying does not work any more. Let it get picked
up by the parent.

For that matter, there is a bunch of other stuff in your POM which can
and should be deleted. The configuration of `maven-compiler-plugin`,
for example.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0EozZfCAVRLFMwOLg_Jj1UjPMVb-bpejW7HyQy%2BvrC0w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: jep-200 issue

[Eugen Horovitz]

Hi Jesse,

Thanks a lot for your reply .
now getting different error :

Could not resolve dependencies for project
org.jenkins-ci.plugins:whitesource:hpi:18.2.1-SNAPSHOT:
Failure to find org.jenkins-ci.main:jenkins-war:executable-war:2.102 in
https://repo.jenkins-ci.org/public/
 was cached in the local repository, resolution will not be reattempted
until the update interval of repo.jenkins-ci.org has elapsed or updates are
forced -> [Help 1]

Any ideas ?
Thanks !



On Mon, Apr 9, 2018 at 7:56 PM, Jesse Glick  wrote:

> On Mon, Apr 9, 2018 at 12:28 PM,
>  wrote:
> > mvn test -Djenkins.version=2.102 -Denforcer.skip=true
> >
> > but this fails with "Failure to find
> > org.jenkins-ci.main:jenkins-war:jar:war-for-test:2.102 "
>
> You need to use a newer parent POM—at least 2.30.
>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/jenkinsci-dev/NI533mCeKgc/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/CANfRfr3Qm-msf_LBEJ6xspA3ceVTpMCkikBycjn7Q_
> AgK%3DpKAQ%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
*Eugen Horovitz*

*Senior software engineer*



*WhiteSource  **empowers businesses
to develop better software *
*by harnessing the power of open source*




-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BZxFhe3_z879_oJmHDncjXpB1ruEZXkY2Cj6L72i42qbMChCQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: jep-200 issue

[Jesse Glick]

On Mon, Apr 9, 2018 at 12:28 PM,
 wrote:
> mvn test -Djenkins.version=2.102 -Denforcer.skip=true
>
> but this fails with "Failure to find
> org.jenkins-ci.main:jenkins-war:jar:war-for-test:2.102 "

You need to use a newer parent POM—at least 2.30.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3Qm-msf_LBEJ6xspA3ceVTpMCkikBycjn7Q_AgK%3DpKAQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.