Re: Invoking default methods from a Proxy's InvocationHandler in JDK9

2017-01-02 Thread Alan Bateman
On 03/01/2017 07:17, Remi Forax wrote: I do not think that the workaround to create a Lookup object by reflection works with 9 given that java.lang.invoke is not declared as an open package. John Rose has proposed to add a method to get a private Lookup object through sun.misc.Unsafe but as

Re: Valid characters in a module name

2017-01-02 Thread Alan Bateman
On 02/01/2017 08:38, Ess Kay wrote: My questions relate to module names in the binary form in the module-info.class file. My scenario is a utility that reads Java bytecode files and performs transformations on them as specified by the user in a text script file. In the text script file the

Re: Valid characters in a module name

2017-01-01 Thread Alan Bateman
On 02/01/2017 01:44, Ess Kay wrote: : Sure. However, can you imagine how much work it would be to update a Java source parser to allow identifiers like package and class names to contain escaped semi-colons, single quotes or double quotes? My scenario and that of many others is the same. It

Re: --add-opens for entire module

2016-12-29 Thread Alan Bateman
On 28/12/2016 07:30, Andrew Guibert wrote: In the currently accepted proposal for #ReflectiveAccessToNonExportedTypes [1], it is described that an entire module can be opened with the following example: open module foo.bar { exports com.foo.bar; requires hibernate.core;

Re: Compile error for transitive dependencies

2016-12-29 Thread Alan Bateman
On 29/12/2016 09:44, Nicolai Parlog wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi! If module A requires B and B requires C, A can not be compiled without C on the module path. error: module not found: C 1 error This is a little irritating but maybe it was done

hg: jigsaw/jake/jdk: 78 new changesets

2016-12-28 Thread alan . bateman
Changeset: ddcc67ffde8c Author:weijun Date: 2016-12-16 19:50 +0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ddcc67ffde8c 8171340: HttpNegotiateServer/java test should not use system proxy on Mac Reviewed-by: chegar ! test/sun/security/krb5/auto/HttpNegotiateServer.java

hg: jigsaw/jake/langtools: 22 new changesets

2016-12-28 Thread alan . bateman
Changeset: 376ee1fd40c3 Author:jlahoda Date: 2016-12-16 12:02 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/376ee1fd40c3 8133896: Update javax.lang.model APIs Reviewed-by: darcy, jjg ! src/java.compiler/share/classes/javax/lang/model/util/Elements.java !

hg: jigsaw/jake: 23 new changesets

2016-12-28 Thread alan . bateman
Changeset: 56d1bbe28435 Author:erikj Date: 2016-12-16 10:17 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/56d1bbe28435 8171249: modules_legal from imported modules are not read by the build Reviewed-by: alanb, mchung ! common/autoconf/generated-configure.sh !

hg: jigsaw/jake/jaxp: 4 new changesets

2016-12-28 Thread alan . bateman
Changeset: fc5ce112ac45 Author:fyuan Date: 2016-12-19 11:13 +0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/fc5ce112ac45 8087303: LSSerializer pretty print does not work anymore 8114834: LSSerializerImpl always serializes an entity reference node to" " even if

hg: jigsaw/jake/corba: 3 new changesets

2016-12-28 Thread alan . bateman
Changeset: 9205e980062a Author:prappo Date: 2016-12-19 16:01 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/9205e980062a 8164907: Eliminate dependency on java.naming/com.sun.jndi.toolkit.url Reviewed-by: chegar, rriggs +

hg: jigsaw/jake/jaxws: 2 new changesets

2016-12-28 Thread alan . bateman
Changeset: c48b4d4768b1 Author:lana Date: 2016-12-22 08:26 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/c48b4d4768b1 Added tag jdk-9+150 for changeset 77e4e30d9d11 ! .hgtags Changeset: df3c437e Author:alanb Date: 2016-12-28 11:46 + URL:

hg: jigsaw/jake/nashorn: 6 new changesets

2016-12-28 Thread alan . bateman
Changeset: 6d9a55b33ef0 Author:jwilhelm Date: 2016-12-08 15:49 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/6d9a55b33ef0 Merge Changeset: 2d59818e9755 Author:jwilhelm Date: 2016-12-13 02:04 +0100 URL:

Re: RFR: 8171400: Move checking of duplicate packages in the boot layer to link time

2016-12-19 Thread Alan Bateman
On 19/12/2016 22:41, Mandy Chung wrote: tools/launcher/modules/patch/systemmodules/PatchSystemModules.java needs to be updated since ModuleBootstrap now depends on this new method: diff --git

Re: Review Request: JDK-8168836 Minor clean up on warning/error messages on --add-exports and --add-reads

2016-12-19 Thread Alan Bateman
On 19/12/2016 19:39, Mandy Chung wrote: : What about renaming it to test/lib/testlibrary/ModuleSourceBuilder.java? http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8168836/webrev.01 or maybe a ModuleInfoMaker as it is used to both write a module-info.java and compile to a module-info.class.

Re: RFR: 8171400: Move checking of duplicate packages in the boot layer to link time

2016-12-19 Thread Alan Bateman
On 19/12/2016 18:14, Claes Redestad wrote: Good, thanks. I polished the comment you took issue with further, updated in place: http://cr.openjdk.java.net/~redestad/8171400/webrev.01/ Good to go? Looks good.

Re: Review Request: JDK-8168836 Minor clean up on warning/error messages on --add-exports and --add-reads

2016-12-19 Thread Alan Bateman
On 19/12/2016 01:44, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8168836/webrev.00/ This patch improves the warning/error message to include the option name, emit a warning if unknown module is specified with —-patch-module be consistent with the options. The

Re: RFR: 8171400: Move checking of duplicate packages in the boot layer to link time

2016-12-19 Thread Alan Bateman
On 19/12/2016 13:12, Claes Redestad wrote: I think that'd break things, since we need a logical || here (what you suggest is an &&): If we need to do post resolution checks (due to patching the boot layer or such) we must check (asthe information in SystemModules is now stale), but if we

Re: RFR: 8171400: Move checking of duplicate packages in the boot layer to link time

2016-12-19 Thread Alan Bateman
On 19/12/2016 12:30, Claes Redestad wrote: Hi, this patch adds a check to see if there are any split packages in the system modules at link time, and uses this information to enable us to safely skip a runtime check during bootstrap for the common case that there are none of the sort.

Re: RFR 8170289: Re-examine entry point support in jlink

2016-12-19 Thread Alan Bateman
On 19/12/2016 04:08, Sundararajan Athijegannathan wrote: Fixed. Updated webrev for the record: http://cr.openjdk.java.net/~sundar/8170289/webrev.03 I'm pushing this as you suggested.. cr.openjdk.java.net is currently down so I'm looking at the changes that were pushed to jdk9/dev/jdk. A few

Re: Review Request JDK-8171323: generate dot file for java.se and java.se.ee with only API dependences

2016-12-16 Thread Alan Bateman
On 16/12/2016 16:22, Mandy Chung wrote: A small fix to the GenGraphs tool: diff --git a/make/src/classes/build/tools/jigsaw/GenGraphs.java b/make/src/classes/build/tools/jigsaw/GenGraphs.java --- a/make/src/classes/build/tools/jigsaw/GenGraphs.java +++

hg: jigsaw/jake/jdk: 39 new changesets

2016-12-16 Thread alan . bateman
Changeset: b6d62dc38c36 Author:mli Date: 2016-12-12 17:29 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b6d62dc38c36 8166763: java/rmi/* tests fail intermittently with "Port already in use" in RMID.start() Reviewed-by: chegar !

hg: jigsaw/jake/hotspot: 92 new changesets

2016-12-16 Thread alan . bateman
Changeset: accf1676e416 Author:bchristi Date: 2016-12-13 12:36 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/accf1676e416 8169389: Use a bitmap to control StackTraceElement::toString format and save footprint Reviewed-by: dfuchs, mchung !

hg: jigsaw/jake/jaxp: 7 new changesets

2016-12-16 Thread alan . bateman
Changeset: 6756e8fc6795 Author:mchung Date: 2016-12-12 18:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/6756e8fc6795 8169925: Organize licenses by module in source, JMOD file, and run-time image Reviewed-by: alanb, erikj, ihse, naoto, prr Contributed-by:

hg: jigsaw/jake: 15 new changesets

2016-12-16 Thread alan . bateman
Changeset: 27810b5e38a4 Author:mchung Date: 2016-12-12 18:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/27810b5e38a4 8169925: Organize licenses by module in source, JMOD file, and run-time image Reviewed-by: alanb, erikj, ihse, naoto, prr Contributed-by:

hg: jigsaw/jake/langtools: 12 new changesets

2016-12-16 Thread alan . bateman
Changeset: 44b6ae94e1d5 Author:mchung Date: 2016-12-12 18:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/44b6ae94e1d5 8169925: Organize licenses by module in source, JMOD file, and run-time image Reviewed-by: alanb, erikj, ihse, naoto, prr Contributed-by:

hg: jigsaw/jake/nashorn: 8 new changesets

2016-12-16 Thread alan . bateman
Changeset: 6d1c784a77fc Author:mchung Date: 2016-12-12 18:57 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/6d1c784a77fc 8169925: Organize licenses by module in source, JMOD file, and run-time image Reviewed-by: alanb, erikj, ihse, naoto, prr Contributed-by:

hg: jigsaw/jake/jdk: 2 new changesets

2016-12-15 Thread alan . bateman
Changeset: 190ca89e298e Author:alanb Date: 2016-12-15 21:24 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/190ca89e298e Recorded hashes not preserved when patching ! src/java.base/share/classes/jdk/internal/module/ModulePatcher.java Changeset: c02bcacee98f Author:

Re: 8170987: Module system implementation refresh (12/2016)

2016-12-15 Thread Alan Bateman
On 15/12/2016 14:13, Claes Redestad wrote: The context here, I assume, is the increased startup cost to initialize java.util.regex in 9 (and a few regression fixes related to this that I've done in the area which may have involved avoiding adding a regex-free fast path for trivial but common

hg: jigsaw/jake/jdk: tools/jimage/VerifyJimage.java failing with incubator modules

2016-12-15 Thread alan . bateman
Changeset: fbb8f2c7f236 Author:alanb Date: 2016-12-15 12:35 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/fbb8f2c7f236 tools/jimage/VerifyJimage.java failing with incubator modules ! test/tools/jimage/VerifyJimage.java

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

2016-12-15 Thread Alan Bateman
On 13/12/2016 21:18, Peter Levart wrote: I think this is OK. Just a couple of nits in test: 1. You create a static Path bob = Paths.get("bob") field, but then you don't use it in: 56 try (FileChannel fc = FileChannel.open(Paths.get("bob"), CREATE, WRITE)) { Adding to Peter's

hg: jigsaw/jake/jdk: 45 new changesets

2016-12-15 Thread alan . bateman
Changeset: 4629fe47e826 Author:sherman Date: 2016-12-06 14:44 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4629fe47e826 8170828: test/java/util/zip/ZipFile/TestZipFile needs @modules to work with Method.setAccessible() Reviewed-by: martin, rriggs !

hg: jigsaw/jake: 8 new changesets

2016-12-15 Thread alan . bateman
Changeset: 1620754492a5 Author:stsmirno Date: 2016-12-07 09:23 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/1620754492a5 8170530: bash configure output contains a typo in a suggested library name Reviewed-by: ihse ! common/autoconf/generated-configure.sh !

hg: jigsaw/jake/langtools: 10 new changesets

2016-12-15 Thread alan . bateman
Changeset: 0bdb7cb95c68 Author:lana Date: 2016-12-07 05:58 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/0bdb7cb95c68 8169618: JDK9 message drop interim resource updates - OpenJDK Reviewed-by: rfield, peytoia, joehw, weijun Contributed-by: li.ji...@oracle.com !

hg: jigsaw/jake/hotspot: 5 new changesets

2016-12-15 Thread alan . bateman
Changeset: bdfe30141ef6 Author:ihse Date: 2016-12-07 09:48 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/bdfe30141ef6 8170629: Remove code duplication in test makefiles Reviewed-by: erikj, dholmes ! test/Makefile Changeset: cc0b239d99a9 Author:erikj Date:

hg: jigsaw/jake/jaxp: 6 new changesets

2016-12-15 Thread alan . bateman
Changeset: 1ede1ddbd43a Author:ihse Date: 2016-12-07 09:48 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/1ede1ddbd43a 8170629: Remove code duplication in test makefiles Reviewed-by: erikj, dholmes ! test/Makefile Changeset: 427ce6a2c674 Author:fyuan Date:

hg: jigsaw/jake/corba: 2 new changesets

2016-12-15 Thread alan . bateman
Changeset: 56d764f5b735 Author:lana Date: 2016-12-14 20:23 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/56d764f5b735 Added tag jdk-9+149 for changeset 00b19338e505 ! .hgtags Changeset: c7995982569d Author:alanb Date: 2016-12-15 11:42 + URL:

hg: jigsaw/jake/nashorn: 4 new changesets

2016-12-15 Thread alan . bateman
Changeset: a42ebb5ed04b Author:ihse Date: 2016-12-07 09:48 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/a42ebb5ed04b 8170629: Remove code duplication in test makefiles Reviewed-by: erikj, dholmes ! test/Makefile Changeset: c281306d33d8 Author:lana Date:

Re: 8170987: Module system implementation refresh (12/2016)

2016-12-15 Thread Alan Bateman
On 15/12/2016 01:17, Mandy Chung wrote: I have pushed the change to rename jdk.crypto.pkcs11 and jdk.pack200 and dropped java.compact$N. So module-info.java changes will not be needed when you sync with jdk9/dev. Thank you. I'll do a merge today to see that everything works together. : Not

hg: jigsaw/jake/jdk: 4 new changesets

2016-12-15 Thread alan . bateman
Changeset: bb62b60643d5 Author:alanb Date: 2016-12-15 08:39 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/bb62b60643d5 Tweaks to Lookup::dropLookupMode Contributed-by: john.r.r...@oracle.com ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java !

Re: 8170987: Module system implementation refresh (12/2016)

2016-12-15 Thread Alan Bateman
On 14/12/2016 23:31, Claes Redestad wrote: Hi, I took a quick pass over the jdk changes. It generally looks very good, but I've got some comments: MethodHandles.Lookup.dropLookupMode: The javadoc doesn't really roll of the tongue here. Maybe "Creates a new lookup from the current one where

8170987: Module system implementation refresh (12/2016)

2016-12-14 Thread Alan Bateman
Folks on jigsaw-dev will be aware that we are on yet another mission to bring the changes accumulated in the jake forest to jdk9/dev. The plan this time is to bring the changes to jdk9/dev to make jdk-9+150. The changes in this update are mostly for JSR 376 issues #VersionedDependences and

hg: jigsaw/jake/jdk: ModuleReference equals/hc should not use reader and hash suppliers

2016-12-14 Thread alan . bateman
Changeset: 78a3778bd7b2 Author:alanb Date: 2016-12-14 20:55 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/78a3778bd7b2 ModuleReference equals/hc should not use reader and hash suppliers ! src/java.base/share/classes/jdk/internal/module/ModulePatcher.java !

hg: jigsaw/jake/jdk: Improve warnings for invalid module names at jlink/run time

2016-12-14 Thread alan . bateman
Changeset: d9e238be50b9 Author:alanb Date: 2016-12-14 19:25 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d9e238be50b9 Improve warnings for invalid module names at jlink/run time ! src/java.base/share/classes/jdk/internal/module/Checks.java !

Re: --add-opens on an automatic module ?

2016-12-14 Thread Alan Bateman
On 14/12/2016 17:21, David Hill wrote: I have yet another gradle exception: java.lang.IllegalAccessException: class org.gradle.groovy.scripts.internal.GradleResolveVisitor cannot access a member of class org.codehaus.groovy.control.ClassNodeResolver with modifiers "protected static final"

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

2016-12-14 Thread Alan Bateman
On 14/12/2016 16:51, Rony G. Flatscher wrote: Thanks to everyone who commented and/or shed some light about the situation for objects that need to invoke/access protected members in superclasses. The conclusion is, that nothing will change as protected members are still regarded to be public

Re: Review Request: JDK-8171201 & JDK-8171202: Drop java.compact$N aggregator modules

2016-12-14 Thread Alan Bateman
On 14/12/2016 16:19, Mandy Chung wrote: : Fixed. All looks good to me. -Alan

hg: jigsaw/jake/jdk: 3 new changesets

2016-12-14 Thread alan . bateman
Changeset: 47dc888f6f6c Author:alanb Date: 2016-12-14 16:08 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/47dc888f6f6c javadoc clarification ! src/java.base/share/classes/java/lang/module/ModuleDescriptor.java Changeset: c2f37a058fac Author:alanb Date:

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

2016-12-14 Thread Alan Bateman
On 14/12/2016 14:30, Jochen Theodorou wrote: : I don't intend to get access to hidden API after all... just exported. If you only interested in accessing the types and members that you have access to in these exported packages then you don't need setAccessible of course. We have seen a few

Re: RFR 8171070: Test ModuleNamesOrderTest.java fails

2016-12-14 Thread Alan Bateman
On 14/12/2016 13:44, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8171070/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8171070 Looks okay. -Alan

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

2016-12-14 Thread Alan Bateman
On 14/12/2016 09:56, David Holmes wrote: Sorry I don't follow. Calling setAccessible(true), logically does nothing except set a flag that controls whether reflective use of the member will need to pass an access check -it doesn't (or shouldn't) perform the access check! Best to read the

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

2016-12-14 Thread Alan Bateman
On 14/12/2016 07:30, Peter Levart wrote: Hi David, On 12/14/2016 07:17 AM, David Holmes wrote: But let me explain why .setAccessible(true) can't be allowed for protected members in general. I'm confused as to what is being argued for/against here. Rony asked why .setAccessible(true)

Re: Review Request: JDK-8171201 & JDK-8171202: Drop java.compact$N aggregator modules

2016-12-14 Thread Alan Bateman
On 14/12/2016 06:49, Mandy Chung wrote: JDK-8171201: Drop java.compact$N aggregator modules JDK-8171202: Rename jdk.crypto.pkcs11 and jdk.pack200 to end with Java letters http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8171201%2b8171202/webrev.00/ The hg moves are showing up as new files in

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

2016-12-13 Thread Alan Bateman
On 13/12/2016 15:47, Rony G. Flatscher wrote: : So the current code does not take protected members into account. If protected members (cf. Alex' comment) get added, wouldn't e.g. java.lang.reflect.Method.invoke(...) or java.lang.reflect.Field.get(...) be the place to check in the next

Re: Changed behaviour of ResourceBundle#getBundle()

2016-12-12 Thread Alan Bateman
On 12/12/2016 15:29, Gunnar Morling wrote: : It seems to be related to the fact that the bundle is located in the default package, because the expected exception is raised if the bundle is located in a proper package. Right, resources in the unnamed package or with names that don't map to

hg: jigsaw/jake/langtools: More refactoring to make it easier to add JDK specific attributes

2016-12-12 Thread alan . bateman
Changeset: b47123312ead Author:alanb Date: 2016-12-12 14:30 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b47123312ead More refactoring to make it easier to add JDK specific attributes ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsConfiguration.java

hg: jigsaw/jake/nashorn: More refactoring to make it easier to add JDK specific attributes

2016-12-12 Thread alan . bateman
Changeset: 4d9285514be9 Author:alanb Date: 2016-12-12 14:30 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/4d9285514be9 More refactoring to make it easier to add JDK specific attributes !

hg: jigsaw/jake/jaxp: More refactoring to make it easier to add JDK specific attributes

2016-12-12 Thread alan . bateman
Changeset: 4cbeb5bf31b1 Author:alanb Date: 2016-12-12 14:31 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/4cbeb5bf31b1 More refactoring to make it easier to add JDK specific attributes !

hg: jigsaw/jake/jdk: More refactoring to make it easier to add JDK specific attributes

2016-12-12 Thread alan . bateman
Changeset: b2b4d228af9a Author:alanb Date: 2016-12-12 14:31 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b2b4d228af9a More refactoring to make it easier to add JDK specific attributes ! src/java.base/share/classes/java/lang/StackTraceElement.java !

hg: jigsaw/jake/hotspot: More refactoring to make it easier to add JDK specific attributes

2016-12-12 Thread alan . bateman
Changeset: e345f3ff2907 Author:alanb Date: 2016-12-12 14:31 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/e345f3ff2907 More refactoring to make it easier to add JDK specific attributes ! test/runtime/modules/AccessCheck/ModuleLibrary.java

Re: Changed behaviour of ResourceBundle#getBundle()

2016-12-12 Thread Alan Bateman
On 12/12/2016 13:38, Gunnar Morling wrote: Hi, I'm about to update my blog post on Bean Validation and Jigsaw from a while ago [1] to the latest JDK 9 build. There is one behavioural change that made me curious: ResourceBundle#getBundle() called from within named module "A" now (as of b148)

Re: Module exports for java.base: NIO stuff

2016-12-11 Thread Alan Bateman
On 11/12/2016 22:38, David M. Lloyd wrote: I'm not implementing SelectorProvider, I just want access to all the possible implementations that are available in the current JDK so we can select among them on a case-by-case basis. Are you attempting to wrap the default implementation - I ask

Re: Use cases for java.lang.Module.addExports

2016-12-11 Thread Alan Bateman
On 12/12/2016 06:34, David Holmes wrote: Does addExports only affect reflective access to the module, or does it change all access? I'm trying to determine what the set of actions X will be such that: try { ; } catch () { execute( () -> mod.addExports(...)); // address the problem ;

Re: Module exports for java.base: NIO stuff

2016-12-11 Thread Alan Bateman
On 11/12/2016 11:44, Remi Forax wrote: : No, these are different implementation, they directly use classes from sun.nio.ch and bypass the selector API. Sure, but the SelectorProvider service interface doesn't define anything that allows someone to choose when there are multiple

Re: Sync with jdk9 and ASM alpha 2

2016-12-11 Thread Alan Bateman
On 11/12/2016 13:05, Remi Forax wrote: Hi Alan, if i get it right, the jdk9 b148 (not the jigsaw version) get a refresh of module-info classfile format but did not get the last two changes, version of requires and the two new constant pool entries. Do you plan to push these changes in the jdk9

Re: jlink and automatic modules

2016-12-11 Thread Alan Bateman
On 10/12/2016 22:40, Claes Redestad wrote: The intended behavior is for jlink to operate on any set of modules to support linking images for other platforms, operating systems etc (the java.base jmod shipped with any JDK contains a native JVM), so it may feel more natural to make it explicit

Re: Module exports for java.base: NIO stuff

2016-12-11 Thread Alan Bateman
On 10/12/2016 15:21, David M. Lloyd wrote: Would it be possible to have all available selector provider implementation classes listed in a "provides java.nio.channels.spi with ..." section of java.base's module descriptor? My use case is as follows: Our I/O library (XNIO) relies on the

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

2016-12-11 Thread Alan Bateman
On 10/12/2016 17:11, Chris Hegarty wrote: : How about: Unsafe::deallocate(ByteBuffer directBuffer)? http://cr.openjdk.java.net/~chegar/Unsafe_deallocate/ The alternative is of course: ByteBuffer wrap(long address, int capacity) void unmap(MappedByteBuffer) The wrap method allow be

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

2016-12-10 Thread Alan Bateman
On 10/12/2016 11:09, Peter Levart wrote: : Something like the following? http://cr.openjdk.java.net/~plevart/jdk9-dev/DirectBufferDeallocator/webrev.01/ Sort of although I think the proposal will be more specific, as in unmap(MappedByteBuffer) on an existing class. The other update to JEP

Re: AccessbileObject setAccessible array version vs non-array version

2016-12-10 Thread Alan Bateman
On 10/12/2016 09:13, Jochen Theodorou wrote: Hi all, motivated by the recent "Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch" thead, I thought I ask... there is AcccessibleObject#setAccessible(boolean), which will ask the SecurityManager for permissions and then make

hg: jigsaw/jake/jdk: Updates for #VersionedDependences

2016-12-09 Thread alan . bateman
Changeset: 6743bd89af1f Author:alanb Date: 2016-12-10 05:22 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/6743bd89af1f Updates for #VersionedDependences DEBUG_ADD_OPENS for debugging Misc. cleanups !

hg: jigsaw/jake/langtools: Updates for #VersionedDependences

2016-12-09 Thread alan . bateman
Changeset: 91ebc06d4220 Author:alanb Date: 2016-12-10 05:20 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/91ebc06d4220 Updates for #VersionedDependences Contributed-by: jonathan.gibb...@oracle.com, jan.lah...@oracle.com !

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

2016-12-09 Thread Alan Bateman
On 09/12/2016 23:06, Stephen Felts wrote: I would highly recommend running with _JAVA_OPTIONS=-Dsun.reflect.debugModuleAccessChecks=true It will tell you what add-options are required. One minor downside is that it will produce the warning in cases where the software is already correctly

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

2016-12-09 Thread Alan Bateman
On 09/12/2016 22:32, Uwe Schindler wrote: Hi, I updated our Jenkins server for the JDK 9 preview testing to use build 148. Previously we had build 140 and build 147, which both worked without any issues. But after the update the following stuff goes wrong: (1) Unmapping of direct buffers no

Re: RFR [9] 8170859 : Run time and tool support for ModuleResolution

2016-12-09 Thread Alan Bateman
On 09/12/2016 14:09, Remi Forax wrote: Thanks Alan, so I withdraw my snarky comment. Not a problem. There is cleanup to be done in several areas, this is one. For the short term then we need to get the implementation aligned with the proposals in the JSR and then get the cleanup done before

Re: RFR [9] 8170859 : Run time and tool support for ModuleResolution

2016-12-09 Thread Alan Bateman
On 08/12/2016 14:41, Remi Forax wrote: Chris, this patch is rather ugly. Patching the ModuleDescriptor is not a good idea, maybe it's means that we need a system of metadata associated with a ModuleDescriptor, the hash of a module (which is not part of the module spec but the OpenJDK

hg: jigsaw/jake/jdk: 31 new changesets

2016-12-08 Thread alan . bateman
Changeset: 46b340c4e9bf Author:lana Date: 2016-12-01 21:01 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/46b340c4e9bf Added tag jdk-9+147 for changeset c41140100bf1 ! .hgtags Changeset: 90b5b235e6b0 Author:ihse Date: 2016-12-01 14:52 +0100 URL:

hg: jigsaw/jake/hotspot: 5 new changesets

2016-12-08 Thread alan . bateman
Changeset: fcfe55dc547c Author:lana Date: 2016-12-01 21:01 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/fcfe55dc547c Added tag jdk-9+147 for changeset 132a72c78207 ! .hgtags Changeset: 1e1b85521770 Author:alanb Date: 2016-12-01 15:54 + URL:

hg: jigsaw/jake/nashorn: 8 new changesets

2016-12-08 Thread alan . bateman
Changeset: 1073eb7ab779 Author:lana Date: 2016-12-01 21:01 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/1073eb7ab779 Added tag jdk-9+147 for changeset 9e86d6383456 ! .hgtags Changeset: ba05e6f3d85c Author:sundar Date: 2016-12-01 18:53 +0530 URL:

hg: jigsaw/jake/langtools: 12 new changesets

2016-12-08 Thread alan . bateman
Changeset: 2ac08b8c7966 Author:lana Date: 2016-12-01 21:01 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2ac08b8c7966 Added tag jdk-9+147 for changeset 76389430a13e ! .hgtags Changeset: c007074c847c Author:erikj Date: 2016-12-01 15:10 +0100 URL:

hg: jigsaw/jake: 16 new changesets

2016-12-08 Thread alan . bateman
Changeset: 35b1b931ede8 Author:lana Date: 2016-12-01 21:01 + URL: http://hg.openjdk.java.net/jigsaw/jake/rev/35b1b931ede8 Added tag jdk-9+147 for changeset 5f6920274c48 ! .hgtags Changeset: f34963dc0f1d Author:erikj Date: 2016-12-01 14:40 +0100 URL:

hg: jigsaw/jake/jaxws: 4 new changesets

2016-12-08 Thread alan . bateman
Changeset: d691e34f202b Author:lana Date: 2016-12-01 21:01 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/d691e34f202b Added tag jdk-9+147 for changeset be37411855de ! .hgtags Changeset: c8c9c334743c Author:lana Date: 2016-12-01 21:40 + URL:

hg: jigsaw/jake/jaxp: 5 new changesets

2016-12-08 Thread alan . bateman
Changeset: 67f4b888089a Author:lana Date: 2016-12-01 21:01 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/67f4b888089a Added tag jdk-9+147 for changeset 149559dd882d ! .hgtags Changeset: 95a56328d117 Author:lana Date: 2016-12-01 21:40 + URL:

hg: jigsaw/jake/corba: 4 new changesets

2016-12-08 Thread alan . bateman
Changeset: ac99b127f64b Author:lana Date: 2016-12-01 21:01 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/ac99b127f64b Added tag jdk-9+147 for changeset dc49e0922a8e ! .hgtags Changeset: f95cc86b6ac2 Author:lana Date: 2016-12-01 21:40 + URL:

Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

2016-12-08 Thread Alan Bateman
On 07/12/2016 21:28, Mandy Chung wrote: : Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169925/webrev.00/ I went over the changes to the jmod tool, jlink, and the new plugin to dedup legal notices. It looks straight-forward, I just wondering about the sym links hat

Re: RFR [9] 8166568 & 8169492 jmod extract and bug fix

2016-12-08 Thread Alan Bateman
On 08/12/2016 13:09, Chris Hegarty wrote: : Looks good. I agree with Alan and it’d be good to take the destination directory to which the contents are written. FYI. jimage extract command takes —-dir option. Updated webrev contain a target destination dir:

Re: [9] Review request: JDK-8170485: Switch to building JavaFX with new module-info syntax

2016-12-06 Thread Alan Bateman
On 06/12/2016 16:10, Kevin Rushforth wrote: Chien & Dave, Please review the preliminary webrev to allow building JavaFX with jdk-9+148 and later: https://bugs.openjdk.java.net/browse/JDK-8170485 http://cr.openjdk.java.net/~kcr/8170485/webrev.00/ The updates to the module-info.java

Re: Lokkup.find* do not add read edges like reflection does

2016-12-06 Thread Alan Bateman
On 06/12/2016 19:41, Remi Forax wrote: Hi all, when using Method.invoke, we automatically add a read edge between the current class and the called class when invoking a method by reflection but if one uses methods lookup.find*, he had to add the read edge manually. I think we should harmonize

Re: Fwd: RFR [9] 8166568 & 8169492 jmod extract and bug fix

2016-12-06 Thread Alan Bateman
On 06/12/2016 11:44, Chris Hegarty wrote: [ forwarding to a more appropriate list to review this change ] Begin forwarded message: From: Chris Hegarty Subject: RFR [9] 8166568 & 8169492 jmod extract and bug fix Date: 6 December 2016 at 10:46:08 GMT To:

Re: Reading bootstrap class bytecode from Java 7

2016-12-06 Thread Alan Bateman
On 06/12/2016 02:07, Ess Kay wrote: Are there any code snippets anywhere that demonstrate using Java 9's jrt-fs.jar from within Java 8 to access Java 9 java.lang.Object? Cannot find any using Google. Struggling to make this work. Here's a code fragment that reads the bytes for

Re: Refresh of module system coming to jdk9/dev soon

2016-12-06 Thread Alan Bateman
On 05/12/2016 20:13, Martin Buchholz wrote: Whitebox testing is the most obvious example of code that has a good excuse for poking inside implementation details. For running jsr166 tests, I'm happy to report that the following seems to work: +if:set="modules"/> +if:set="modules"/> + + It

Re: Reading bootstrap class bytecode from Java 7

2016-12-04 Thread Alan Bateman
On 05/12/2016 07:21, Remi Forax wrote: Hi, Object.class.getClassLoader().getResourceAsStream(Object.class.getName().replace('.', '/') + ".class") should work across all jdks. This should work as before (ignoring the issue that Object.class.getClassLoader() will return null :-)) However, as

Re: javap is not able to read the module-info.class if in a jar

2016-12-04 Thread Alan Bateman
On 04/12/2016 00:07, Remi Forax wrote: Hi all, hi Jon, while updating ASM6 to the new classfile format, i think i've found a bug in javap. javap as no trouble to read module-info.class if the class is specified directly $ /usr/jdk/jdk-9-jigsaw/bin/javap module-info.class open module

hg: jigsaw/jake/jdk: 112 new changesets

2016-12-01 Thread alan . bateman
Changeset: b13f370a64f6 Author:skovalev Date: 2016-11-15 15:52 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b13f370a64f6 8169710: com/sun/nio/sctp tests has undeclared dependency on jdk.sctp module Reviewed-by: dfuchs, chegar + test/com/sun/nio/sctp/TEST.properties

hg: jigsaw/jake/langtools: 27 new changesets

2016-12-01 Thread alan . bateman
Changeset: b265444e51db Author:jlahoda Date: 2016-11-16 17:48 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b265444e51db 8169561: jshell tool: double shift-tab on variable crashes tool Summary: Avoid crashe for unknown HTML tags; avoid crash for non-existing

hg: jigsaw/jake: 20 new changesets

2016-12-01 Thread alan . bateman
Changeset: 3039ad3fce6f Author:lana Date: 2016-11-17 22:18 + URL: http://hg.openjdk.java.net/jigsaw/jake/rev/3039ad3fce6f Merge Changeset: 5a206e2ff241 Author:ihse Date: 2016-11-18 15:50 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/5a206e2ff241

hg: jigsaw/jake/jaxp: 12 new changesets

2016-12-01 Thread alan . bateman
Changeset: 87321661fcef Author:lana Date: 2016-11-17 22:19 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/87321661fcef Merge - src/java.xml/share/classes/org/w3c/dom/xpath/COPYRIGHT.html Changeset: 9bbb08fb1e9a Author:fyuan Date: 2016-11-18 10:34 +0800 URL:

hg: jigsaw/jake/corba: 4 new changesets

2016-12-01 Thread alan . bateman
Changeset: 187b26b70a0f Author:ihse Date: 2016-11-28 09:20 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/187b26b70a0f 8031567: Better model for storing source revision information Reviewed-by: erikj ! .hgignore Changeset: 2948e2219a91 Author:alanb Date:

hg: jigsaw/jake/nashorn: 13 new changesets

2016-12-01 Thread alan . bateman
Changeset: 713ce238f9be Author:jjg Date: 2016-11-16 12:35 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/713ce238f9be 8163190: Clarify JavaFileManager use of \"module location\" Reviewed-by: jlahoda !

hg: jigsaw/jake/jdk: More typos and random cleanup

2016-11-30 Thread alan . bateman
Changeset: cc35c0bc4a3c Author:alanb Date: 2016-11-30 21:02 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/cc35c0bc4a3c More typos and random cleanup ! src/java.base/share/classes/java/lang/module/ModuleDescriptor.java !

Re: RFR 8160359: Improve jlink logging for cases when a plugin throws exception

2016-11-30 Thread Alan Bateman
On 30/11/2016 11:05, Sundararajan Athijegannathan wrote: Please review fix for https://bugs.openjdk.java.net/browse/JDK-8160359 jdk webrev: http://cr.openjdk.java.net/~sundar/8160359/webrev.01/ top webrev: http://cr.openjdk.java.net/~sundar/8160359/top/webrev.01/ For the top-level repo

<    6   7   8   9   10   11   12   13   14   15   >