Re: Code review for jigsaw/jake -> jdk9/dev sync up

On 28/11/2016 14:47, Chris Hegarty wrote: : 2) jartool Main.java Maybe concealedPackages should have a comment about its use ( it is used in the Validator, and not by Main at all ). Just on this one, I think this was introduced when Steve added the MR JAR validation, I agree it's ugly

Re: Migrating to uses from an existing module system

On 29/11/2016 22:45, Thomas Watson wrote: I have a usecase where I am attempting to map an existing module system's class loaders to JPMS modules by using the Layer API. In this case the existing module system is OSGi. I have run into an issue when an existing OSGi bundle contains code that

Re: testing for a class having been loaded

On 29/11/2016 21:14, Alan Snyder wrote: Prior to JDK 9, it was possible (using setAccessible) to ask a ClassLoader whether a class with a given name had been loaded without actually forcing it to be loaded. This hack will not work in JDK9, so I am wondering if there is a way to do this? If

Re: #CyclicDependences with ServiceLoader

On 30/11/2016 08:53, Jochen Theodorou wrote: Hi, for my understanding I would like to ask the following: Given: * Module A: uses service S1 and provides service S2 * Module B: uses service S2 and provides service S1 In my understanding this forms a cyclic dependency, but since this is not

hg: jigsaw/jake/jdk: Fixed typo in javadoc

Changeset: 32c356a9f79c Author:alanb Date: 2016-11-29 17:41 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/32c356a9f79c Fixed typo in javadoc ! src/java.instrument/share/classes/java/lang/instrument/Instrumentation.java

hg: jigsaw/jake/jdk: 3 new changesets

Changeset: 364508692927 Author:alanb Date: 2016-11-29 13:59 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/364508692927 jar --print-module-descriptor should handle open module/packages ! src/jdk.jartool/share/classes/sun/tools/jar/Main.java Changeset: 471f9aaac991

Re: Services and Bindings - expected usage scenarios

On 29/11/2016 13:13, Pisarev, Vitaliy wrote: What about the intent behind how are developers supposed to use this tool? For example, when Optional was introduced in Java 8, it was specified that it is intended to be used as a methods return type. And people should not use it as class member

Re: Services and Bindings - expected usage scenarios

On 29/11/2016 11:35, Pisarev, Vitaliy wrote: Another best practices question. I am aware that the ServiceLoader API is not new to Java. What's new in Java 9 is that is has been put forward to the front of the stage and it is now very easy for a service provider to register a service. The

hg: jigsaw/jake/hotspot: JVMTI AddModuleExports/AddModuleOpens should not intern strings

Changeset: 6f8d3c3028bb Author:sspitsyn Date: 2016-11-29 09:18 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/6f8d3c3028bb JVMTI AddModuleExports/AddModuleOpens should not intern strings ! src/share/vm/prims/jvmtiEnv.cpp

Re: Code review for jigsaw/jake -> jdk9/dev sync up

Thanks for going through the changes, a few comment/replies below. On 28/11/2016 22:22, Paul Sandoz wrote: : What happens if you pass a primitive array? I think you need to specify what happens if an array class is passed and how the target class is obtained, and an IAE if the "element

hg: jigsaw/jake/jdk: 4 new changesets

Changeset: 8a69f4602580 Author:alanb Date: 2016-11-28 15:25 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/8a69f4602580 Expand test for open modules and packages ! test/jdk/modules/open/Basic.java Changeset: b71703fea51b Author:alanb Date: 2016-11-28 15:26

Re: Code review for jigsaw/jake -> jdk9/dev sync up

On 27/11/2016 11:15, Peter Levart wrote: Hi Alan, Overall this looks very good. I noticed a couple of nits... Thanks for going through the changes. : So should Provider rather declare the following? Class type(); Or alternatively, should ServiceLoader rather declare the following?

Re: Replacement for JDK8 APIs

On 28/11/2016 10:36, Stéphane Nicoll wrote: Peter, Thanks a lot, that helped! [1] Cheers, S. [1] https://github.com/spring-projects/spring-boot/commit/e15b3e463f312524495349673a16cb67cfaa2eae The reflection has come up a number of things so great that Peter tracked this down. So I'm

Re: Replacement for JDK8 APIs

On 27/11/2016 09:16, Stéphane Nicoll wrote: Hey, Thanks for all the feedback so far. Any idea about the annotation processor question? Is there a dedicated dev list for it maybe? compiler-dev is the place to bring it up. -Alan

hg: jigsaw/jake/jdk: Update ProblemList to list JAX-WS issue

Changeset: bf9c1eda7c6a Author:alanb Date: 2016-11-27 08:32 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/bf9c1eda7c6a Update ProblemList to list JAX-WS issue ! test/ProblemList.txt

hg: jigsaw/jake/langtools: Replace hashes in ModuleHashes with array

Changeset: b5eae0a5878c Author:alanb Date: 2016-11-26 15:15 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b5eae0a5878c Replace hashes in ModuleHashes with array ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/ClassWriter.java !

hg: jigsaw/jake/jdk: 3 new changesets

Changeset: a406b21f7748 Author:alanb Date: 2016-11-26 15:16 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a406b21f7748 Replace hashes in ModuleHashes with array ! src/java.base/share/classes/com/sun/java/util/jar/pack/intrinsic.properties !

Re: Few questions

On 26/11/2016 10:50, Michał Zegan wrote: well, about services, the problem is (probably) that services in jigsaw, last I've checked, were purely static in nature. That is they cannot dynamically appear and disappear and modules cannot be notified about it, that wuld be a reason for a service

Re: Few questions

On 26/11/2016 11:41, Jochen Theodorou wrote: On 25.11.2016 23:21, Michał Zegan wrote: Well, I specifically mean setAccessible usage between modules. If your code really requires setAccessible it is going to break with jigsaw. To be more specific, it will be a problem for code that attempts

Re: Few questions

On 25/11/2016 22:21, Michał Zegan wrote: Well, I specifically mean setAccessible usage between modules. All I can suggest is to read the javadoc, the proposal for #AwkwardStrongEncapsulation [1], and of course try out the EA builds [2]. Another question that comes to mind after reading some

Re: Few questions

On 25/11/2016 19:33, Michał Zegan wrote: Hello. I have a few questions about project jigsaw and things that are related. - Does, or will, the jlink tool allow creating executables? I mean, packing app with the runtime not in a directory, but in an executable file of some sort? Or, will it be

Re: Replacement for JDK8 APIs

On 25/11/2016 12:11, Stéphane Nicoll wrote: : Yes, there is a feature in Spring Boot called devtools that allows you do remote debugging via SSH[1] - Is there any way to achieve the same feature with JDK 9? Nothing has really changed here, it's just that some JDK internal classes have

Re: Replacement for JDK8 APIs

On 24/11/2016 14:22, Stéphane Nicoll wrote: : We use "sun.misc.VMSupport" to retrieve the port being used by the Java remote debugging. You can find the actual code in RemoteDebugPortProvider[3] This class was never intended to be used directly of course. It doesn't exist (or rather it has

hg: jigsaw/jake/jdk: Fixed typos in javadoc

Changeset: 09b3083d7de2 Author:alanb Date: 2016-11-24 16:19 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/09b3083d7de2 Fixed typos in javadoc ! src/java.base/share/classes/java/util/ServiceLoader.java

Re: modules and tests

On 24/11/2016 14:39, Remi Forax wrote: : to Alan: currently you can not get your test framework as a service and you can not declare your test as a provider for a test infrastructure like jenkins (i.e. there is no --uses and --provides). Fair point, uses/provides can't currently be augmented

Code review for jigsaw/jake -> jdk9/dev sync up

Folks on jigsaw-dev will know that we are on a mission to bring the changes accumulated in the jake forest to jdk9/dev. We can think of this as a refresh of the module system in JDK 9, the last big refresh was in May with many small updates since then. The focus this time is to bring the

hg: jigsaw/jake/hotspot: 81 new changesets

Changeset: d5c67c13e5f9 Author:mcberg Date: 2016-10-18 19:08 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/d5c67c13e5f9 8167987: change merge context to clear for mask register usage model Reviewed-by: kvn ! src/cpu/x86/vm/assembler_x86.cpp !

hg: jigsaw/jake/jdk: 20 new changesets

Changeset: 892fde66a95e Author:darcy Date: 2016-11-15 13:31 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/892fde66a95e 8169736: Mark RmiIiopReturnValueTest.java as intermittently failing Reviewed-by: lancea !

hg: jigsaw/jake/jaxp: 5 new changesets

Changeset: 53a255be3abc Author:dfuchs Date: 2016-11-15 17:45 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/53a255be3abc 8169723: remove jaxp/src/java.xml/share/classes/org/w3c/dom/xpath/COPYRIGHT.html Reviewed-by: rriggs -

hg: jigsaw/jake/jaxws: 5 new changesets

Changeset: 26c9b9c51052 Author:aefimov Date: 2016-11-15 23:43 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/26c9b9c51052 8164479: Update JAX-WS RI integration to latest version (2.3.0-SNAPSHOT) Reviewed-by: alanb, joehw, lancea, mchung Contributed-by:

hg: jigsaw/jake/langtools: 2 new changesets

Changeset: d715163cd7c5 Author:lana Date: 2016-11-23 16:16 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d715163cd7c5 Added tag jdk-9+146 for changeset 26f972dc2d17 ! .hgtags Changeset: 7178621e9e1f Author:alanb Date: 2016-11-24 09:14 + URL:

hg: jigsaw/jake/corba: 2 new changesets

Changeset: dc49e0922a8e Author:lana Date: 2016-11-23 16:16 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/dc49e0922a8e Added tag jdk-9+146 for changeset ecd74b41ab65 ! .hgtags Changeset: f02fa6dd4e0b Author:alanb Date: 2016-11-24 09:15 + URL:

hg: jigsaw/jake: 11 new changesets

Changeset: 0ec12d231af9 Author:ehelin Date: 2016-09-28 16:41 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/0ec12d231af9 8166790: Add stress test GCBasher Reviewed-by: dfazunen, dholmes, erikj, tschatzl, lmesnik ! make/jprt.properties Changeset: a26dbefcc658 Author:

hg: jigsaw/jake/nashorn: 5 new changesets

Changeset: 1e7049278c4c Author:sla Date: 2016-10-24 09:07 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/1e7049278c4c 8168483: Remove jtreg timeout handler timeout Reviewed-by: dholmes, tbell ! test/Makefile Changeset: ce057a78b44c Author:jwilhelm Date:

Re: modules and tests

On 24/11/2016 08:46, Remi Forax wrote: : It's not obvious at it seems, it requires javac to be able to merge several module-info.java into one, and because the module descriptor allows to restrict exports or opens, the merging rules* as to be specified. Have you run into anything that isn't

hg: jigsaw/jake/jdk: 2 new changesets

Changeset: 633cacfb9b2f Author:alanb Date: 2016-11-24 12:50 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/633cacfb9b2f Drop implAddExportsPrivate, no longer needed ! src/java.base/share/classes/java/lang/reflect/Module.java Changeset: a27f80d73f0d Author:alanb

Re: uses is useless ?

On 24/11/2016 08:08, fo...@univ-mlv.fr wrote: I've resolved my problem of delegation of uses myself, trying to re-explain my problem, i wanted to provide a method on top of ServiceLoader and force modules that use that API to declare a directive uses. This should work fine, assuming that the

hg: jigsaw/jake/jdk: java/awt/TextArea/TextAreaCaretVisibilityTest/bug7129742.java needs :open

Changeset: c853c037270d Author:alanb Date: 2016-11-24 08:37 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c853c037270d java/awt/TextArea/TextAreaCaretVisibilityTest/bug7129742.java needs :open ! test/java/awt/TextArea/TextAreaCaretVisibilityTest/bug7129742.java

Re: Review Request: JDK-8169816 Move src.zip and jrt-fs.jar under the lib directory

On 22/11/2016 21:07, Mandy Chung wrote: This patch moves src.zip and jrt-fs.jar from the top-level into the `lib` directory in the run-time image as we proposed [1]. Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169816/webrev.00/ This looks good. A minor point in

Re: Moving the changes in jake to jdk9/dev

On 23/11/2016 13:36, Remi Forax wrote: Hi Alan, With my ASM hat, we've planned to make a new beta of ASM as soon as the module class file format patches are merged into jdk9 :) Great. One thing that we've had to do in the JDK copy of ASM is update ClassWriter.visit to be able to take a null

hg: jigsaw/jake/jdk: Rename new attributes to ModuleXXX

Changeset: 6c9428da24a4 Author:alanb Date: 2016-11-23 13:32 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/6c9428da24a4 Rename new attributes to ModuleXXX ! src/java.base/share/classes/com/sun/java/util/jar/pack/intrinsic.properties !

hg: jigsaw/jake/langtools: Rename new attributes to ModuleXXX

Changeset: f3be37a11045 Author:alanb Date: 2016-11-23 13:32 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f3be37a11045 Rename new attributes to ModuleXXX ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/Attribute.java !

Moving the changes in jake to jdk9/dev

We've been accumulating changes in the jake forest that are tied to JSR issues for the last few months. Some of the changes (such as #ClassLoaderNames) have already been pushed upstream to jdk9/dev but we've still sitting on a large patch. We would like to move the changes that we have in

hg: jigsaw/jake/jdk: Residual references to exports-private in tests

Changeset: 73203c93bde8 Author:alanb Date: 2016-11-22 20:50 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/73203c93bde8 Residual references to exports-private in tests ! test/java/awt/patchlib/java.desktop/java/awt/Helper.java !

hg: jigsaw/jake/hotspot: Missing since= in new JVMTI functions

Changeset: 4e2ce42c5ef8 Author:alanb Date: 2016-11-22 17:53 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/4e2ce42c5ef8 Missing since= in new JVMTI functions ! src/share/vm/prims/jvmti.xml

Re: Annotation processors and the --processor-module-path

On 22/11/2016 10:33, Eirik Bjørsnøs wrote: : So again, I added -J-add-modules=java.xml.bind, and now my annotation processor is loading. Given that my annotation processor does require java.xml.bind and I'm using --processor-module-path, my expectation would be that javac would resolve that

hg: jigsaw/jake/langtools: Rename Hashes attribute to jdk.Hashes as it is JDK-specific

Changeset: 52a360826e26 Author:alanb Date: 2016-11-21 14:07 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/52a360826e26 Rename Hashes attribute to jdk.Hashes as it is JDK-specific ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/Attribute.java !

hg: jigsaw/jake/jdk: 2 new changesets

Changeset: c67449fbf341 Author:alanb Date: 2016-11-21 14:07 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c67449fbf341 Rename Hashes attribute to jdk.Hashes as it is JDK-specific ! src/java.base/share/classes/com/sun/java/util/jar/pack/intrinsic.properties !

Re: RFR 8170099: Nashorn test failures with stricter reflection access checks in jake forest

On 21/11/2016 14:14, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8170099/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8170099 This looks okay although you could replace the setAccessible methods in Reflector that take Method and Constructor

Re: Annotation processors and the --processor-module-path

On 21/11/2016 09:46, Eirik Bjørsnøs wrote: Alan, | $ javac --help | -processor [,,...] |Names of the annotation processors to run; bypasses default discovery process Why does the "default discovery process" work with --classpath, but not with --processor-module-path? Is it simply an

Re: Annotation processors and the --processor-module-path

On 21/11/2016 00:22, Eirik Bjørsnøs wrote: : $ javac --processor-module-path ~/.m2/repository/com/example/annotation-processor/1.0-SNAPSHOT/annotation-processor-1.0-SNAPSHOT.jar -sourcepath src/main/java src/main/java/module-info.java src/main/java/com/example/module/SomeClass.java -g -nowarn

Re: javac --add-modules java.xml.bind for annotation processor?

On 20/11/2016 23:22, Remi Forax wrote: It seems to me that all the command line options of the VM before jigsaw doesn't use space as a separator, but with the new option like --module-path or --add-modules, you have to put a space after, so it doesn't work well with the -J option used to take

Re: Configuration checks on uses service is too strict

On 19/11/2016 20:39, Remi Forax wrote: Ok, i may have a found bug. The spec says (section 1.1.3) "The service interface may be declared in the current module or in another module. If the service interface is not declared in the current module, then the service interface must be accessible to

Re: Configuration.resolveRequires want providers of services to be in an exported package

On 19/11/2016 19:19, fo...@univ-mlv.fr wrote: Apart the fact that the method should be called packages(), no :) Also the implementation makes the order of the calls important, i.e. contains() has to be called after all the other methods. If you move the code that checks that a package can not

Re: Configuration.resolveRequires want providers of services to be in an exported package

On 19/11/2016 18:02, fo...@univ-mlv.fr wrote: Ok, find the bug, obvious in retrospect, there is no way to declare a concealed package using the ModuleDescriptor.Builder so my configuration miss concealed packages thus the configuration that i try to verify is ill formed. The builder should

Re: ModuleDescirptor.Builder and open module

On 19/11/2016 14:52, Remi Forax wrote: Hi all (again), as far as i know, it seems there is no way to programmatically using the ModuleDescriptor.Builder API creates an open module. There is a package private method for that but no public visible method. The builder API still needs a bit of

Re: ModuleDescriptor.Builder.provides() is too restrictive

On 19/11/2016 14:44, Remi Forax wrote: Hi all, Currently the spec supports two ways to declare several providers for one service: provides com.github.forax.pro.main.runner.Runner with com.github.forax.pro.main.JSONRunner, com.github.forax.pro.main.JShellRunner; or provides

Re: Configuration.resolveRequires want providers of services to be in an exported package

On 19/11/2016 14:34, Remi Forax wrote: Hi all, hi Alan, With 9-ea+144-jigsaw-nightly-h5735-20161117, it seems that Configuration.resolveRequires() do more checks than necessary, it checks that each provider of a service has its package exported, something which is not required by the spec.

hg: jigsaw/jake/hotspot: Clean-up of JVMTI AddModuleExports/AddModuleOpens

Changeset: e9f9a8d55756 Author:sspitsyn Date: 2016-11-17 10:29 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/e9f9a8d55756 Clean-up of JVMTI AddModuleExports/AddModuleOpens ! make/test/JtregNative.gmk ! src/share/vm/prims/jvmtiEnv.cpp !

Re: uses is useless ?

On 16/11/2016 19:41, fo...@univ-mlv.fr wrote: : My point is that in teory, that's cool but in reality the module-info of java.base (or java.sql) declares a lot of 'uses' making the whole idea moot. To avoid java.base to use 'uses', we need a way to be able to have a way to delegate the power

hg: jigsaw/jake/jdk: Realign --patch-module with JEP 261

Changeset: 01398d0dc8ef Author:alanb Date: 2016-11-16 13:32 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/01398d0dc8ef Realign --patch-module with JEP 261 ! src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java

Re: uses is useless ?

On 16/11/2016 14:00, David M. Lloyd wrote: That's really a usability regression though, isn't it? In the past, I could always use ServiceLoader with a ClassLoader argument to specify on whose behalf I'm loading. In fact we do this quite a lot today. No change to existing code on the

hg: jigsaw/jake/hotspot: Realign --patch-module with JEP 261

Changeset: 5dcc850b3457 Author:alanb Date: 2016-11-16 13:32 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/5dcc850b3457 Realign --patch-module with JEP 261 ! test/runtime/modules/IgnoreModulePropertiesTest.java

hg: jigsaw/jake/jdk: Move parsing of --patch-module to ModuleBootstrap

Changeset: 89cca729dfc1 Author:alanb Date: 2016-11-16 10:57 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/89cca729dfc1 Move parsing of --patch-module to ModuleBootstrap ! src/java.base/share/classes/java/lang/module/ModuleReferences.java !

Re: uses is useless ?

On 16/11/2016 10:25, fo...@univ-mlv.fr wrote: : The whole point of uses is to enable a kind of static analysis on the service dependencies, if 'uses' is not required, if you can easily bypass it or it doesn't provide useful information, then it should be removed from the spec. `uses` is used

hg: jigsaw/jake/jdk: JDI/JDWP CanRead command not needed

Changeset: d6531596d65f Author:alanb Date: 2016-11-16 10:22 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d6531596d65f JDI/JDWP CanRead command not needed Contributed-by: serguei.spit...@oracle.com ! make/data/jdwp/jdwp.spec !

hg: jigsaw/jake/hotspot: JDI/JDWP CanRead command not needed

Changeset: 96d200831568 Author:alanb Date: 2016-11-16 10:22 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/96d200831568 JDI/JDWP CanRead command not needed Contributed-by: serguei.spit...@oracle.com ! test/serviceability/jdwp/AllModulesCommandTest.java -

Re: jlink option --add-modules should be renamed to --add-root-modules

On 16/11/2016 09:53, Remi Forax wrote: Hi all, it's a minor request, but the option --add-modules should be renamed to --add-root-modules because as the doc says it specifies the "Root modules to resolve". Several students of mine had trouble to see the difference between --add-modules and

Re: uses is useless ?

On 16/11/2016 09:48, Remi Forax wrote: Hi guys, sorry for the pun in the title. Last week end, i've taken a big codebase and try to retrofit it to use jigsaw, obviously the code has several (two in fact) cyclic dependencies and in both cases, i was able to break those cycles by changing the

Re: RFR: JDK-8169720 - jimage help message for --include option should be corrected

On 15/11/2016 14:39, Jim Laskey (Oracle) wrote: http://cr.openjdk.java.net/~jlaskey/8169720/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8169720 Looks fine.

hg: jigsaw/jake/jdk: More javadoc fixes/clarifications

Changeset: 9aa5eac9e756 Author:alanb Date: 2016-11-14 10:40 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9aa5eac9e756 More javadoc fixes/clarifications ! src/java.base/share/classes/java/lang/ClassLoader.java !

Re: javassist broken on Jake

On 12/11/2016 14:42, Stephen Felts wrote: It turns out that the trick of using 3.21 doesn't work for Jake any more. So I guess there is no work-around for me on that platform and I won't be working on it. You may find that older versions (maybe 3.20 and older) will work okay with the jake

Re: javassist broken on Jake

On 12/11/2016 13:42, Stephen Felts wrote: I've been trying to get a javassist that works in all environments. For a while, I created a multi release jar file that used Javassist 3.20 for pre-jdk9 and Javassist 3.21 for JDK9/Jake. The JDK team wasn't happy about this use of multi release jar

hg: jigsaw/jake/jdk: 3 new changesets

Changeset: 1901f58d996d Author:alanb Date: 2016-11-11 10:08 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1901f58d996d Temporarily exclude com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java ! test/ProblemList.txt Changeset: cfbc00374eae Author:

hg: jigsaw/jake/corba: java.naming needs to open java.corba com/sun/jndi/cosnaming/jndiprovider.properties

Changeset: 5fa18142554d Author:alanb Date: 2016-11-11 08:45 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/5fa18142554d java.naming needs to open java.corba com/sun/jndi/cosnaming/jndiprovider.properties ! src/java.corba/share/classes/module-info.java

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

On 07/11/2016 13:26, Jim Laskey (Oracle) wrote: Revising to String name = entry.name().toUpperCase(Locale.ENGLISH); return name.startsWith("META-INF/") && name.indexOf('/', 9) == -1 && ( name.endsWith(".SF") ||

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

On 07/11/2016 13:09, Jim Laskey (Oracle) wrote: Thank you. Regarding SIG- I was just followed the spec. I hope Sean or Max can jump in on this, the other question is .EC as I believe the JDK allows this when signing too. -Alan

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

n 07/11/2016 12:29, Jim Laskey (Oracle) wrote: http://cr.openjdk.java.net/~jlaskey/8159393/webrev/test/tools/jlink/JLinkSigningTest.java.html https://bugs.openjdk.java.net/browse/JDK-8159393 I

hg: jigsaw/jake/jdk: sun/security/krb5/ccache/TimeInCCache.java failing

Changeset: 78d0327ac55c Author:alanb Date: 2016-11-05 20:37 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/78d0327ac55c sun/security/krb5/ccache/TimeInCCache.java failing ! test/sun/security/krb5/ccache/TimeInCCache.java

hg: jigsaw/jake/jdk: 2 new changesets

Changeset: 92473a4168e5 Author:alanb Date: 2016-11-04 14:54 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/92473a4168e5 Improve getResourceXXX to avoid scanning all resources in all modules ! src/java.base/share/classes/jdk/internal/loader/BuiltinClassLoader.java

hg: jigsaw/jake/langtools: More clean-up of Provides

Changeset: 258783abd899 Author:alanb Date: 2016-11-04 15:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/258783abd899 More clean-up of Provides ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsConfiguration.java !

Re: RFR 8166286: jmod fails on symlink to directory

On 04/11/2016 11:34, Sundararajan Athijegannathan wrote: Hi, Thanks for the review. Please find the updated webrev: http://cr.openjdk.java.net/~sundar/8166286/webrev.01/ * Reduced line length in JmodTask.java * Removed @bug comment - earlier I attempted a separate test file for this -

Re: The split package problem

On 04/11/2016 13:22, Jochen Theodorou wrote: : well... assume you have an application and it requires the library A, which transitively requires B-1. the application also requires library C, which transitively requires B-2. B-1 and B-2 are not compatible. library A and D leak instances of

Re: RFR 8166286: jmod fails on symlink to directory

On 04/11/2016 10:36, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8166286/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8166286 This is probably okay, if only to be consistent with the other tools. Can you fix the overly long time in

Re: The split package problem

On 04/11/2016 10:04, Jochen Theodorou wrote: : What I see mostly is that all the problems you have now on a per class level, you later have on a per module level again... for example needing two versions of the same library being active at the same time... and the movement away from the

Re: The split package problem

On 04/11/2016 09:22, Jochen Theodorou wrote: On 04.11.2016 09:25, Remi Forax wrote: There are two issues with split packages, - if you have the same class in each part of the package, the behavior of your problem depend on the order in the classpath, i've experienced this kind of bugs with

Re: Unsafe and AwkwardStrongEncapsulation

On 04/11/2016 08:57, Jochen Theodorou wrote: That won´t get me access to private fields and constructors in Unsafe with AwkwardStrongEncapsulation, right? So I see exported, but I don´t know what you mean with "open" here. I thought we do not have open modules yet... if we have, I missed

Re: Unsafe and AwkwardStrongEncapsulation

On 04/11/2016 08:05, Jochen Theodorou wrote: Since Unsafe was mentioned here... All the ways I did know to get to Unsafe required reflection on private members. Afaik #AwkwardStrongEncapsulation will block that. So how can I still use Unsafe in the future or did it get some "proper" public

hg: jigsaw/jake/jdk: Remove CORBA tests from exclude list, get more tests running

Changeset: d370ea60c627 Author:alanb Date: 2016-11-03 06:57 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d370ea60c627 Remove CORBA tests from exclude list, get more tests running ! test/ProblemList.txt ! test/java/security/testlibrary/Proc.java !

hg: jigsaw/jake/jdk: 2 new changesets

Changeset: b189339d80d9 Author:alanb Date: 2016-11-02 13:31 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b189339d80d9 Experimental support for multi-parent configurations ! src/java.base/share/classes/java/lang/module/Configuration.java !

JDK 9 Early Access with Project Jigsaw, build 142 on 10-31-2016 (#5670)

Just a quick mail to say that the EA download [1] has been refreshed. The latest download has the initial implementation of open modules and open packages as detailed in the recent proposal for #ReflectiveAccessToNonExportedTypes [2]. -Alan [1] https://jdk9.java.net/jigsaw/ [2]

Re: How to check for an internal class in another module from java.base?

On 01/11/2016 15:29, Wang Weijun wrote: : There is an issue in JIRA to track change the HTTP protocol handler to use services for authentication mechanism, I don't think anyone has had time to work on that yet. So before making this big change, do you think I can make the small change

Re: New proposal for #ReflectiveAccessToNonExportedTypes: Open modules & open packages

On 01/11/2016 15:32, Jochen Theodorou wrote: : Well... it makes me ask the question: Does #AwkwardStrongEncapsulation impose additional limitations for the redefinition of already loaded classes? No but if the methods in the new class redefinition are doing setAccessible then it's same

Re: How to check for an internal class in another module from java.base?

On 01/11/2016 15:02, Wang Weijun wrote: HTTP Negotiate uses Class.forName("sun.net.www.protocol.http.spnego.NegotiatorImpl", true, null); to check if the implementation in java.security.jgss module is provided. It looks like this call is throwing a ClassNotFoundException now. Shall I

Re: RFR: 8159523. Fix tests depending on absence of -limitmods in VM arguments.

On 01/11/2016 10:23, Alan Bateman wrote: : .addExports("java.base", "jdk.internal.misc=ALL-UNNAMED") .addOpens("java.base", "jdk.internal.misc=m1,m2") Oops, a typo here, I meant this of course: .addExports("java.base/jdk.internal.misc", &qu

Re: RFR: 8159523. Fix tests depending on absence of -limitmods in VM arguments.

On 31/10/2016 21:39, Alexandre (Shura) Iline wrote: : Which syntax would be better? 1. Requiring explicit ALL-UNNAMED .addExports("java.base", “jdk.internal.misc”, ALL_UNNAMED) .addExports("java.base", "jdk.internal.reflect”, ALL_UNNAMED) 2. Treating ALL-UNNAMED as a default

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

On 31/10/2016 21:34, Mandy Chung wrote: On Oct 31, 2016, at 6:51 AM, Alan Bateman <alan.bate...@oracle.com> wrote: if (VM.isModuleSystemInited() && !HashedModules.contains(m)) { Looks okay, an alternative would be to move that that check to L439. What do you think about

hg: jigsaw/jake/langtools: jdk/jshell/PipeInputStreamTest.java failing

Changeset: 8d34e5c09607 Author:alanb Date: 2016-11-01 06:49 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8d34e5c09607 jdk/jshell/PipeInputStreamTest.java failing ! test/jdk/jshell/PipeInputStreamTest.java

hg: jigsaw/jake/jdk: pack200 tests failing

Changeset: 71fa9c880f90 Author:alanb Date: 2016-11-01 06:45 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/71fa9c880f90 pack200 tests failing ! src/java.base/share/classes/com/sun/java/util/jar/pack/intrinsic.properties !

Re: New proposal for #ReflectiveAccessToNonExportedTypes: Open modules & open packages

On 31/10/2016 17:44, Stephen Felts wrote: That means in the next build as of tomorrow the class format is changed and classes need to be re-generated? Yes, any module-info.java from previous builds will need to be re-compiled. There is also an update to the Module attribute to rev the

<    7   8   9   10   11   12   13   14   15   16   >