Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

Looks good to me, +1. It seems correct that it’s the responsibility of the users of Dynalink to add the read edges from their own modules. Attila. > On 12 Oct 2016, at 18:31, Sundararajan Athijegannathan > wrote: > > Updated nashorn webrev: > http://cr.openjdk.java.net/~sundar/8167614/nashor

Re: RFR 8158736: Adapter class loaders can avoid creating named dynamic modules

+1. Echoing Hannes’ sentiment, it’s nice to see that extra code gone. > On 06 Jun 2016, at 02:38, Sundararajan Athijegannathan > wrote: > > Please review: http://cr.openjdk.java.net/~sundar/8158736/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8158736 > > Nashorn creates named, dyn

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

ugh to verify that JDK9 builds fine with these changes. Thanks, Attila. > On Nov 20, 2015, at 4:41 PM, Attila Szegedi wrote: > > Thanks for pointing out these, Mandy; I will make the changes you suggested. > > Attila. > >> On Nov 20, 2015, at 6:10 AM, Mandy Chung wrote:

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

> On Nov 23, 2015, at 4:40 PM, Alan Bateman wrote: > > > > On 23/11/2015 15:27, Attila Szegedi wrote: >> Folks, >> >> I integrated the changes Mandy suggested; please review these (build >> related) changes: >> jdk9 top level: >> <http

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

rs. Since you are on this file, can you move jdk.scripting.nashorn >> to MAIN_MODULES as well? >> >> Mandy >> >>> On Nov 19, 2015, at 3:15 PM, Attila Szegedi wrote: >>> >>> Please review JDK-8141338 "Move jdk.internal.dynalink package to

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

On Nov 20, 2015, at 4:10 PM, Alan Bateman wrote: > > On 19/11/2015 23:15, Attila Szegedi wrote: >> Please review JDK-8141338 "Move jdk.internal.dynalink package to >> jdk.dynalink" for <https://bugs.openjdk.java.net/browse/JDK-8141338>. This >>

Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

Please review JDK-8141338 "Move jdk.internal.dynalink package to jdk.dynalink" for . This is basically the implementation step for integrating JEP 276. This changeset will introduce a new public API that has CCC approval (request 8075866), and is

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

> On Sep 16, 2015, at 2:51 PM, Alan Bateman wrote: > > > > On 16/09/2015 13:28, Magnus Ihse Bursie wrote: >> On 2015-09-11 18:00, Attila Szegedi wrote: >>> Please review the revised changes for JDK-8135251 "Use >>> Unsafe.defineAnonymousClass