Re: RFR 8192986: Inconsistent handling of exploded modules in jlink

+1 > On Dec 7, 2017, at 11:27 PM, Sundararajan Athijegannathan > wrote: > > Hi, > > * On stricter check for missing module-info.class in a directory: There is a > similar check for non-modular jars. > > jlink --add-modules java.base --module-path

Re: RFR: 8175891, 8192892: JrtPath improvements

+1 > On Dec 1, 2017, at 9:34 AM, Claes Redestad wrote: > > Hi, > > please review this patch that resolves two small but sometimes significant > inefficiencies in jdk.internal.jrtfs.JrtPath: > > Improve JrtPath::getResolved fast-path test: >

Re: RFR: 8175561: Memory churn in jimage code affects startup after resource encapsulation changes

My only concern at this point is if Claes and I get hit by a bus, no one will be able to figure this out. I recommend that next release that we switch to character based hash. This means some minor complexity in the C code but I think the java code will be much simpler (and the C not so bad.)

Re: RFR: 8169713: jimage fails with StringIndexOutOfBoundsException when path to the inspected image is an empty string

+1 > On Feb 23, 2017, at 1:34 PM, Claes Redestad wrote: > > Hi, > > please review this fix to make the jimage tool work correctly > for empty string: > > diff -r b2661d26e556 > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java > ---

Re: RFR: 8175010: ImageReader is not thread-safe

+1 > On Feb 15, 2017, at 9:22 AM, Claes Redestad wrote: > > Hi, > > a few intermittent but rare test failures[1] that has appeared > since the latest jake integration, and since one of the changes > in there was to make initialization of the system ImageReader > lazy

Re: RFR 8174718: "Module 's descriptor returns inconsistent package set" confusing

+1 > On Feb 14, 2017, at 9:52 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8174718/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8174718 > > Thanks, > -Sundar

Re: RFR 8174209: Renumber the compress levels

+1 > On Feb 13, 2017, at 1:03 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8174209/webrev/ for > https://bugs.openjdk.java.net/browse/JDK-8174209 > > Thanks, > -Sundar

Re: [9] RFR: 8169715: jimage fails with IAE when attempts to inspect an empty file

+1 > On Feb 13, 2017, at 1:58 PM, Denis Kononenko > wrote: > > > Hi, > > Optimized buffer's capacity checks. > > WEBREV: http://cr.openjdk.java.net/~dkononenko/8169715/webrev.02 > > >> >> Could

Re: RFR 8172864: Remove custom plugin module path

+1 > On Jan 27, 2017, at 2:45 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8172864/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8172864 > > Thanks, > -Sundar

Re: RFR 8172659: PluginException("TargetPlatform attribute is missing ...") - should be ModuleTarget

+1 > On Jan 20, 2017, at 5:06 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8172659/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8172659 > > Thanks, > -Sundar

Re: RFR 8168254: Detect duplicated resources in packaged modules

+1 > On Jan 18, 2017, at 2:03 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8168254/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8168254 > > Thanks, > -Sundar

Re: RFR 8170618: jmod should validate if any exported or open package is missing

+1 > On Dec 21, 2016, at 8:08 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8170618/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8170618 > > Thanks, > -Sundar

Re: RFR 8171316: Add IMPLEMENTOR property to the release file

+1 > On Dec 15, 2016, at 11:32 AM, Sundararajan Athijegannathan > wrote: > > Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8171316 > > top level webrev: http://cr.openjdk.java.net/~sundar/8171316/top/webrev.00/ > jdk webrev:

Re: RFR 8171138: Remove FileCopierPlugin

+1 > On Dec 14, 2016, at 1:02 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8171138/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8171138 > > Piggybacking cleanup: release file generation

Re: RFR 8171070: Test ModuleNamesOrderTest.java fails

+1 > On Dec 14, 2016, at 9:37 AM, Alan Bateman wrote: > > On 14/12/2016 13:44, Sundararajan Athijegannathan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8171070/webrev.00/ for >> https://bugs.openjdk.java.net/browse/JDK-8171070 > Looks okay. > > -Alan

Re: RFR 8168925: MODULES property should be topologically ordered and space-separated list

+1 > On Dec 9, 2016, at 4:49 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8168925/webrev.01/index.html > for https://bugs.openjdk.java.net/browse/JDK-8168925 > > PS. Mandy Chung wrote ModuleSorter for

Re: RFR 8160359: Improve jlink logging for cases when a plugin throws exception

+1 > On Nov 30, 2016, at 7:05 AM, Sundararajan Athijegannathan > wrote: > > Please review fix for https://bugs.openjdk.java.net/browse/JDK-8160359 > > jdk webrev: http://cr.openjdk.java.net/~sundar/8160359/webrev.01/ > > top webrev:

Re: Review Request: JDK-8169816 Move src.zip and jrt-fs.jar under the lib directory

+1 > On Nov 22, 2016, at 5:07 PM, Mandy Chung wrote: > > This patch moves src.zip and jrt-fs.jar from the top-level into > the `lib` directory in the run-time image as we proposed [1]. > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169816/webrev.00/ >

Re: [9] RFR: 8170120: Several new jimage testcases should be excluded due to their failures

+1 > On Nov 22, 2016, at 8:51 AM, Denis Kononenko > wrote: > > > Hi, > > Could someone please review this small fix. > > Recently several failing test cases were delivered into jdk9-dev by my > mistake (https://bugs.openjdk.java.net/browse/JDK-8167240). I've

RFR: JDK-8168256 - Plugin alias options in jlink --help output seems to be in an arbitrary order

Sorts options by full name http://cr.openjdk.java.net/~jlaskey/8168256/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8168256

Re: RFR 8153038: The set of jlink plugins enabled by default should be the same via CLI or jlink API

+1 > On Nov 16, 2016, at 4:30 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8153038/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8153038 > > PS. Pre-existing IntegrationTest.java test

RFR: JDK-8169505 - Update changes by JDK-8159393 to reflect CCC review

http://cr.openjdk.java.net/~jlaskey/8169505/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8169505

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

+1 Really nice, thank you. > On Nov 15, 2016, at 11:16 AM, Denis Kononenko > wrote: > > > Hi, > > Please do re-review for these changes. > > 1) tests for list --include were rewritten accordingly to > https://bugs.openjdk.java.net/browse/JDK-8167384; > 2)

RFR: JDK-8169720 - jimage help message for --include option should be corrected

http://cr.openjdk.java.net/~jlaskey/8169720/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8169720

RFR: JDK-8155756 - Better context for some jlink exceptions

Only 2 of 3 examples still present. http://cr.openjdk.java.net/~jlaskey/8155756/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8155756

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

Suits me. > On Nov 7, 2016, at 12:06 PM, Sean Mullan <sean.mul...@oracle.com> wrote: > > On 11/7/16 9:13 AM, Jim Laskey (Oracle) wrote: >> The bug https://bugs.openjdk.java.net/browse/JDK-8159393 >> <https://bugs.openjdk.java.net/browse/JDK-8159393> is r

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

ear in > the same webrev. If it's already done somewhere else please make sure it is > the same. > > Thanks > Max > >> 在 2016年11月7日，22:11，Jim Laskey (Oracle) <james.las...@oracle.com> 写道： >> >> The security entries are (have been) ignored when bu

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

On Nov 7, 2016, at 10:11 AM, Jim Laskey (Oracle) <james.las...@oracle.com> > wrote: > > The security entries are (have been) ignored when building the image. At > some future date (post-9), we need to decide how to sign an image. > > — Jim > > >> On No

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

gned is correct. > > There is one thing I don't understand, the --strip-signing-information > option. It looks like you will remove the signature-related files if this > option is set. But, where are they stripped? > > Thanks > Max > > On 11/7/2016 9:48 PM, Jim Laskey

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

Apologies for the poor links earlier. http://cr.openjdk.java.net/~jlaskey/8159393/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8159393 > On Nov 7, 2016, at 9:26 AM, Jim Laskey (Oracle) <james.las...@oracle.com> > wrote: > > Revising to > >

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

name.endsWith(".DSA") || name.endsWith(".RSA") || name.endsWith(".EC") || name.startsWith("META-INF/SIG-") ); > On

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

'A' || cc > 'Z') && (cc < '0' || cc > '9')) { return false; } } } return true; // no extension is OK } return false; } > On Nov 7, 2016, at 9:16 AM, Alan Bateman <alan.bate...@o

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

But I need to be more careful with "Note that if such files are located in META-INF subdirectories, they are not considered signature-related.” > On Nov 7, 2016, at 9:09 AM, Jim Laskey (Oracle) <james.las...@oracle.com> > wrote: > > Thank you. Regarding SIG- I was

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

M, Alan Bateman <alan.bate...@oracle.com> wrote: > > > n 07/11/2016 12:29, Jim Laskey (Oracle) wrote: >> http://cr.openjdk.java.net/~jlaskey/8159393/webrev/test/tools/jlink/JLinkSigningTest.java.html >> >> <http://cr.openjdk.java.net/~jlaskey/8159393/webrev/te

RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

http://cr.openjdk.java.net/~jlaskey/8159393/webrev/test/tools/jlink/JLinkSigningTest.java.html https://bugs.openjdk.java.net/browse/JDK-8159393

Re: RFR 8166286: jmod fails on symlink to directory

+1 > On Nov 4, 2016, at 7:36 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8166286/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8166286 > > Thanks, > -Sundar

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

Nice work. +1 > On Nov 3, 2016, at 10:29 AM, Denis Kononenko > wrote: > > Hi, > > I've done some rework accordingly to Alan's and Shura's comments: > > 1) removed overlapped tests from JImageToolTest.java; > > 2) added new tests JImageVerifyTest.java for jimage

Re: RFR 8160063: Provide a means to disable a plugin via the command line

+1 > On Oct 31, 2016, at 12:11 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8160063/webrev.02/ for > https://bugs.openjdk.java.net/browse/JDK-8160063 > > PS. Earlier review thread on slightly different

Re: RFR 8166810: jlink should fail on extra arguments

+1 > On Oct 25, 2016, at 2:37 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8166810/webrev.00/index.html > for https://bugs.openjdk.java.net/browse/JDK-8166810 > > Thanks, > -Sundar

Re: RFR 8168091: jlink should check security permission early when programmatic access is used

+1 > On Oct 17, 2016, at 2:23 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8168091/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8168091 > > Thanks, > > -Sundar >

Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

+1 > On Oct 12, 2016, at 12:11 PM, Sundararajan Athijegannathan > wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8167614 > > jdk webrev: http://cr.openjdk.java.net/~sundar/8167614/jdk/webrev.00/ > > nashorn webrev: >

Re: RFR 8165735: jlink incorrectly accepts multiple --module-path and --limit-modules options

+1 > On Sep 28, 2016, at 7:36 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8165735/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8165735 > > Thanks, > -Sundar

Re: RFR 8160063: Provide a means to disable a plugin via the command line

+1 > On Sep 15, 2016, at 11:31 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8160063/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8160063 > > * Adding --disable- option for any plugin that

Re: RFR 8165772: fix for 8165595 results in failure of jdk/test/tools/launcher/VersionCheck.java

+1 > On Sep 12, 2016, at 9:32 AM, Sundararajan Athijegannathan > wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8165772 > > This VersionCheck.java test failed after main class was added to nashorn > modules. VersionCheck expects all jdk/bin

Re: RFR 8165772: fix for 8165595 results in failure of jdk/test/tools/launcher/VersionCheck.java

+1 > On Sep 9, 2016, at 10:58 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8165772/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8165772 > > Thanks, > > -Sundar >

Re: RFR 8165697: jlink running on Mac with Windows jmods produces non-runnable image

+1 > On Sep 8, 2016, at 11:32 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8165697/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8165697 > > Thanks > > -Sundar >

Re: RFR 8165503: jlink exclude VM plugin's handling of jvmlibs is wrong

+1 > On Sep 7, 2016, at 8:43 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8165503/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8165503 > > Thanks, > > -Sundar >

Re: RFR 8163952: jlink exclude VM plugin does not support static libraries

I missed that as well. Good catch. > On Sep 6, 2016, at 11:50 AM, Anthony Vanelverdinghe > wrote: > > Hi Sundar > > I'm not familiar with the code, but the for-loop at lines 105-107 looks like > a bug, since only the first element is considered: > > 105

Re: RFR 8163952: jlink exclude VM plugin does not support static libraries

+1 > On Sep 6, 2016, at 7:12 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8163952/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8163952 > > Thanks, > > -Sundar >

Re: RFR 8157992: Improve jlink help message on optimization-related options

+1 > On Sep 2, 2016, at 6:10 AM, Sundararajan Athijegannathan > wrote: > > Cleas, Alan: > > Thanks for the reviews. Uploaded updated webrev for the record: > http://cr.openjdk.java.net/~sundar/8157992/webrev.02/ > > And going ahead with push.. > >

Re: RFR 8159004: jlink attempts to create launcher scripts when root/bin dir does not exist

+1 > On Aug 29, 2016, at 9:00 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8159004/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8159004 > > Piggybacking couple of cleanups suggested (but

Re: RFR 8164800: Cross targeting Windows

+1 > On Aug 26, 2016, at 11:54 AM, Sundararajan Athijegannathan > wrote: > > Hi, > > Fixed as suggested: http://cr.openjdk.java.net/~sundar/8164800/webrev.02/ > > * Field name changed to targetOsName > > * Throwing RuntimeException if os name can't

Re: RFR 8159487: Add JAVA_VERSION, OS_NAME, OS_ARCH properties in release file

+1 > On Aug 2, 2016, at 8:39 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8159487/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8159487 > > OS_NAME, OS_ARCH, OS_VERSION properties are

Re: RFR 8162782: jlink ResourcePool.releaseProperties should be removed

+1 > On Jul 29, 2016, at 11:42 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8162782/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8162782 > > Thanks, > > -Sundar >

Re: RFR 8162538: plugin API should avoid read only pool, have module view separated from resource view and have pool builder to modify

+1 > On Jul 26, 2016, at 11:38 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8162538/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8162538 > > Thanks, > > -Sundar >

RFR: JDK-8158407 - jimage: verify should do more extensive test

http://cr.openjdk.java.net/~jlaskey/8158407/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8158407

Re: [9] RFR: 8159214: jlink --include-locales problems

+1 > On Jul 18, 2016, at 12:54 PM, Naoto Sato wrote: > > Ping. > > On 7/14/16 5:42 AM, Naoto Sato wrote: >> Hello, >> >> Please review the fix to the following issue: >> >> https://bugs.openjdk.java.net/browse/JDK-8159214 >> >> The fix is located at: >> >>

Re: RFR: JDK-8161067 - jlink: Enable plugins to use the module pool for class lookup

11, 2016, at 11:09 AM, Paul Sandoz <paul.san...@oracle.com> wrote: >> >> >>> On 11 Jul 2016, at 14:17, Jim Laskey (Oracle) <james.las...@oracle.com> >>> wrote: >>> >>> I’m not sure if we can determine supplied classes vs others unless we >

Re: RFR: JDK-8161067 - jlink: Enable plugins to use the module pool for class lookup

ddition to, the module name. Such functionality is much clearer regarding > the scope of resolution. > > Paul. > > >> On 8 Jul 2016, at 17:53, Jim Laskey (Oracle) <james.las...@oracle.com> wrote: >> >> http://cr.openjdk.java.net/~jlaskey/8161067/webrev/index.html >> https://bugs.openjdk.java.net/browse/JDK-8161067 >> >

RFR: JDK-8161067 - jlink: Enable plugins to use the module pool for class lookup

http://cr.openjdk.java.net/~jlaskey/8161067/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8161067

RFR: JDK-8160829 - Remove ASMPool support from jlink

Much of the removed code seems unnecessary since the same functionality can be accomplished with much simpler code. An example is provided with ClassForNamePlugin.java (temporary.) A shipping byte code optimizer plugin will be supplied later. Additional changes to the plugin API will supply

RFR: JDK-8160348 - jlink should use System.out for usage messages

Trivial patch http://cr.openjdk.java.net/~jlaskey/8160348/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8160348

Re: RFR 8157936: Files.size(Path p) returns 0 if path is from JrtFileSystem with exploded build

+1 > On Jun 27, 2016, at 5:16 AM, Sundararajan Athijegannathan > wrote: > > Thanks for the review. I'll include a space in test and push. > > -Sundar > > > On 6/27/2016 1:42 PM, Paul Sandoz wrote: >>> On 27 Jun 2016, at 09:03, Sundararajan

Re: RFR 8160346: JLinkTest.java should compute exact number of plugins from jdk.jlink module [ was Re: RFR 8153238: Improve test/tools/jlink/JLinkTest.java not to hard code the number of plugins]

+1 > On Jun 27, 2016, at 8:19 AM, Sundararajan Athijegannathan > wrote: > > Sorry I had that test change already. I've filed another bug to track > your suggestions. > > Please review http://cr.openjdk.java.net/~sundar/8160346/webrev.00/ for >

Re: RFR 8147794: Jlink's ModuleEntry.stream can't be consumed more than once and ModuleEntry content should be read only if needed

+1 nice to get this done > On Jun 24, 2016, at 10:12 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8147794/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8147794 > > Thanks, > > -Sundar >

Re: RFR: JDK-8159172 - Update usage of jlink/jimage/jmod to show option patterns

Thank you > On Jun 23, 2016, at 4:33 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 23/06/2016 19:40, Jim Laskey (Oracle) wrote: > >> http://cr.openjdk.java.net/~jlaskey/8159172/webrev/index.html >> <http://cr.openjdk.java.net/~jlaskey/81

Re: RFR 8159593: Plugin Set getType() should return a Category

59 public static boolean isPostProcessor(Category category) { 60 return category.equals(Category.VERIFIER) 61 || category.equals(Category.PROCESSOR) 62 || category.equals(Category.PACKAGER); 63 } 64 65 public static boolean

Re: RFR JDK-8159206 - All jlink tests failing

Webrev updated in place. > On Jun 15, 2016, at 9:50 AM, Jim Laskey (Oracle) <james.las...@oracle.com> > wrote: > > >> On Jun 14, 2016, at 11:51 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: >> >> I reviewed http://cr.openjdk.java.net/~jlaske

Re: RFR JDK-8159206 - All jlink tests failing

> On Jun 14, 2016, at 11:51 PM, Mandy Chung wrote: > > I reviewed http://cr.openjdk.java.net/~jlaskey/8159206/webrev > > Looks much cleaner. Thanks for the update > > 342 StringSharingPlugin(String[] patterns) throws IOException { > 343

RFR JDK-8159206 - All jlink tests failing

http://cr.openjdk.java.net/~jlaskey/8159206/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8159206

Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

I’ll followup shortly. > On Jun 9, 2016, at 11:51 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > > On 09/06/2016 12:00, Jim Laskey (Oracle) wrote: >> : >> I have changes for the make files as well. >> >> diff -r 6a78ef1d1e58 make/Images.gmk >

Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

> On Jun 9, 2016, at 8:52 AM, Chris Hegarty <chris.hega...@oracle.com> wrote: > >> >> On 9 Jun 2016, at 11:16, Alan Bateman <alan.bate...@oracle.com> wrote: >> >> On 08/06/2016 20:45, Jim Laskey (Oracle) wrote: >> >>> Consiste

Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

> On Jun 9, 2016, at 7:16 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 08/06/2016 20:45, Jim Laskey (Oracle) wrote: > >> Consistent use of PathPatterns for jlink, jimage and jmod options. >> >> —optionName=(regex:|glob:|) ?? where => >

RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

Consistent use of PathPatterns for jlink, jimage and jmod options. —optionName=(regex:|glob:|) ?? where => glob: http://cr.openjdk.java.net/~jlaskey/8158402/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8158402

Re: RFR (S) 8158851: MH.publicLookup() init circularity, triggered by custom SecurityManager with String concat and -limitmods java.base

If it’s in the jimage, I/O should not be an issue (defineClass from a direct memory mapped buffer) vs assembling and assigning a byte array. Measure first? > On Jun 7, 2016, at 12:44 PM, Aleksey Shipilev <aleksey.shipi...@oracle.com> > wrote: > > On 06/07/2016 06:09 PM,

Re: RFR (S) 8158851: MH.publicLookup() init circularity, triggered by custom SecurityManager with String concat and -limitmods java.base

Generally I disagree with this kind of hack. It will bite you in the @$$ at some point. Why not just have a class file containing the bytes? Otherwise, you should probably embed some of the ASM constants in the array to handle things like class version? 52 => CLASS_VERSION, et cetera. These

Who is using jlink --exclude-files, --exclude-resources or --order-resources (was RFR: JDK-8156995 - jimage: extract specified contents)

We plan to change these plugins to use regex instead of “*" notation. This requires some coordination with users. https://bugs.openjdk.java.net/browse/JDK-8158402 Speak up. — Jim > On Jun 1, 2016, at 12:56 PM, Jim Laskey (Oracle) <james.las...@oracle.com> > wrote: >

Re: RFR: JDK-8156994 - jimage --help is not helpful

> On Jun 1, 2016, at 12:33 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 01/06/2016 15:47, Jim Laskey (Oracle) wrote: > >> http://cr.openjdk.java.net/~jlaskey/8156994/webrev/index.html >> https://bugs.openjdk.java.net/browse/JDK-8156994 > Good

Re: RFR: JDK-8156995 - jimage: extract specified contents

alan.bate...@oracle.com> wrote: > > On 01/06/2016 15:48, Jim Laskey (Oracle) wrote: > >> http://cr.openjdk.java.net/~jlaskey/8156995/webrev/index.html >> https://bugs.openjdk.java.net/browse/JDK-8156995 > Jim - should this allow regex rather than just "*" ? > > -Alan

RFR: JDK-8156995 - jimage: extract specified contents

http://cr.openjdk.java.net/~jlaskey/8156995/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8156995

Re: RFR 8157931, jdk/internal/jrtfs/Basic.java fails with exploded builds

+1 > On May 26, 2016, at 7:58 AM, Felix Yang wrote: > > Hi there, > >please review the following change. > > Webrev: http://cr.openjdk.java.net/~xiaofeya/8157931/webrev.00/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8157931 > > > The test

Re: RFR: JDK-8156602 - javac crashes again on Windows 32-bit with ClosedChannelException

at start up (reflection or method handles.) I could check version and use different paths on JDK-9 and JDK-8. Other suggestions? — Jim > On May 19, 2016, at 10:46 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 19/05/2016 14:03, Jim Laskey (Oracle) wrot

RFR: JDK-8156602 - javac crashes again on Windows 32-bit with ClosedChannelException

On 32 bit, a shared jimage channel closed by an interrupted thread (ClosedChannelException) disrupts other threads sharing jimage. Fix is to reopen channel on not interrupted thread. http://cr.openjdk.java.net/~jlaskey/8156602/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8156602

RFR: JDK-8156781 - change to jlink has result in test failure

http://cr.openjdk.java.net/~jlaskey/8156781/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8156781

Re: RFR: JDK-8155237 - jlink plugin to order resources should take a class list as input

> On May 11, 2016, at 2:21 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: > >> >> On May 11, 2016, at 10:17 AM, Jim Laskey (Oracle) <james.las...@oracle.com> >> wrote: >> >> >>> On May 11, 2016, at 2:03 PM, Mandy Chung <mandy.ch..

Re: RFR: JDK-8155237 - jlink plugin to order resources should take a class list as input

> On May 11, 2016, at 2:03 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > >> On May 9, 2016, at 10:41 AM, Jim Laskey (Oracle) <james.las...@oracle.com> >> wrote: >> >> Modifies the jlink sort-plugin to accept a classlist to order files in the

Re: RFR: JDK-8155237 - jlink plugin to order resources should take a class list as input

Only that experimentation is still ongoing. I have an agreement with Claes that he will make that change when he is satisfied with an improvement. > On May 11, 2016, at 9:35 AM, Alan Bateman wrote: > > > > On 11/05/2016 13:30, Claes Redestad wrote: >> Updated

RFR: JDK-8155237 - jlink plugin to order resources should take a class list as input

Modifies the jlink sort-plugin to accept a classlist to order files in the jimage. http://cr.openjdk.java.net/~jlaskey/8155237/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8155237

Re: Having problem building jdk9-dev

Mac OS X - reproducible with a clean repo. > On May 9, 2016, at 10:08 AM, Jim Laskey (Oracle) <james.las...@oracle.com> > wrote: > > > > > Generating blacklisted certs > java.lang.ClassNotFoundException: sun.tex

Having problem building jdk9-dev

Generating blacklisted certs java.lang.ClassNotFoundException: sun.text.resources.BreakIteratorRules at jdk.internal.loader.BuiltinClassLoader.loadClass(java.base@9-ea/BuiltinClassLoader.java:366) at

RFR: JDK-8132994 - /modules and /packages should not be parsed by the jimage parser

Changed to special case parse /modules/ and /packages/. Will actually reduce string table size slightly (better common string match.) http://cr.openjdk.java.net/~jlaskey/8132994/webrev/index.html

Re: RFR: JDK-8069079 - jimage extract / list to organize classes by modules

Thank you, changes incorporated. > On Apr 22, 2016, at 2:08 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > Hi Jim, > >> On Apr 22, 2016, at 6:12 AM, Jim Laskey (Oracle) <james.las...@oracle.com> >> wrote: >> >> Listing is by module, extra

Re: RFR: JDK-8154179 - BasicImageReader activating ImageBufferCache when not used

Thank you. > On Apr 24, 2016, at 5:23 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > > > On 22/04/2016 14:12, Jim Laskey (Oracle) wrote: >> The unused cache is being unnecessarily activated (ThreadLocal) when buffers >> are being released. >>

Re: RFR: JDK-8147426 - Missing definition for JIMAGE_NOT_FOUND

JCK change incorporated. Thank you. > On Apr 24, 2016, at 5:22 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > > On 22/04/2016 14:12, Jim Laskey (Oracle) wrote: >> JIMAGE_NOT_FOUND was defined in the hotspot jimage.hpp header but not in the >> jdk jimage.hp

Build craziness

make clean ; make images Building target 'images' in configuration 'macosx-x86_64-normal-server-fastdebug' Building JVM variant 'server' with features 'all-gcs cds compiler1 compiler2 dtrace fprof jni-check jvmci jvmti management nmt services vm-structs' Compiling 8 files for

Re: RFR: JDK-8154090 - Remove support for jimage recreate

Thank you. > On Apr 22, 2016, at 10:53 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > > > On 22/04/2016 14:12, Jim Laskey (Oracle) wrote: >> http://cr.openjdk.java.net/~jlaskey/8154090/webrev/index.html >> <http://cr.openjdk.java.net/~jlaskey

Re: RFR: JDK-8082537 - jimage should print usage when started with no args

Will change. Thank you. > On Apr 22, 2016, at 10:59 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > > > On 22/04/2016 14:54, Jim Laskey (Oracle) wrote: >> It can be outside, does the change add value? >> >> > I think so as it's always been o

Re: RFR: JDK-8082537 - jimage should print usage when started with no args

It can be outside, does the change add value? > On Apr 22, 2016, at 10:12 AM, Jim Laskey (Oracle) <james.las...@oracle.com> > wrote: > > Now prints usage. > > http://cr.openjdk.java.net/~jlaskey/8082537/webrev/index.html > <http://cr.openjdk.java.net/~jla

RFR: JDK-8147634 - Need a JImage API that given a JImageLocationRef returns class name

Implemented as requested by the runtime team. http://cr.openjdk.java.net/~jlaskey/8147634/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8147634

RFR: JDK-8069079 - jimage extract / list to organize classes by modules

Listing is by module, extract has been by module for some time. http://cr.openjdk.java.net/~jlaskey/8069079/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8069079

  1   2   >