Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

2016-10-13 Thread Attila Szegedi
Looks good to me, +1. It seems correct that it’s the responsibility of the users of Dynalink to add the read edges from their own modules. Attila. > On 12 Oct 2016, at 18:31, Sundararajan Athijegannathan > wrote: > > Updated nashorn webrev: >

Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

2016-10-12 Thread Sundararajan Athijegannathan
Updated nashorn webrev: http://cr.openjdk.java.net/~sundar/8167614/nashorn/webrev.01/ Changed to use Layer.boot().findModule. Thanks -Sundar On 10/12/2016 9:42 PM, Alan Bateman wrote: > On 12/10/2016 16:33, Sundararajan Athijegannathan wrote: > >> : >> >> Dynalink used to automatically add

Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

2016-10-12 Thread Alan Bateman
On 12/10/2016 16:33, Sundararajan Athijegannathan wrote: : Dynalink used to automatically add those necessary add edges. With the current change, nashorn adds necessary read edges. CallerSensitive methods are found only in java.base, java.logging, java.sql and java.sql.rowset modules - the

Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

2016-10-12 Thread Sundararajan Athijegannathan
Dynalink normally uses unreflect with publicLookup to get method handles for j.l.reflect.Method objects (found reflectively). But, publicLookup can not be used to unreflect caller sensitive methods. So, dynalink uses specific Lookup object from the callsite - for example, lookup of the Nashorn

Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

2016-10-12 Thread Alan Bateman
On 12/10/2016 16:11, Sundararajan Athijegannathan wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8167614 jdk webrev: http://cr.openjdk.java.net/~sundar/8167614/jdk/webrev.00/ nashorn webrev: http://cr.openjdk.java.net/~sundar/8167614/nashorn/webrev.00/ In

Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

2016-10-12 Thread Jim Laskey (Oracle)
+1 > On Oct 12, 2016, at 12:11 PM, Sundararajan Athijegannathan > wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8167614 > > jdk webrev: http://cr.openjdk.java.net/~sundar/8167614/jdk/webrev.00/ > > nashorn webrev: >

RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

2016-10-12 Thread Sundararajan Athijegannathan
Bug: https://bugs.openjdk.java.net/browse/JDK-8167614 jdk webrev: http://cr.openjdk.java.net/~sundar/8167614/jdk/webrev.00/ nashorn webrev: http://cr.openjdk.java.net/~sundar/8167614/nashorn/webrev.00/ Thanks, -Sundar