On 2/18/19 1:50 AM, Severin Gehwolf wrote:
On Fri, 2019-02-15 at 23:27 -0800, Mandy Chung wrote:
On 2/15/19 8:12 AM, Severin Gehwolf wrote:
Thanks for the review! I've remove the @author tag:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8218913/03/webrev/
Looks good. As Alan said, thi
On Mon, 2019-02-18 at 10:10 +, Alan Bateman wrote:
> On 18/02/2019 09:50, Severin Gehwolf wrote:
> > :
> > Thanks. CSR has been filed here:
> > https://bugs.openjdk.java.net/browse/JDK-8219207
> >
> The interface change is to add --strip-java-debug-attributes so it
> might be better to change
On 18/02/2019 09:50, Severin Gehwolf wrote:
:
Thanks. CSR has been filed here:
https://bugs.openjdk.java.net/browse/JDK-8219207
The interface change is to add --strip-java-debug-attributes so it might
be better to change the synopsis and the summary to make this clearer.
Also in the specificat
On Fri, 2019-02-15 at 23:27 -0800, Mandy Chung wrote:
> On 2/15/19 8:12 AM, Severin Gehwolf wrote:
> > Thanks for the review! I've remove the @author tag:
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8218913/03/webrev/
>
> Looks good. As Alan said, this needs a CSR to document the new plu
On 2/15/19 8:12 AM, Severin Gehwolf wrote:
Thanks for the review! I've remove the @author tag:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8218913/03/webrev/
Looks good. As Alan said, this needs a CSR to document the new plugin
command-line option.
thanks
Mandy
On 15/02/2019 16:12, Severin Gehwolf wrote:
:
Thanks for the review! I've remove the @author tag:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8218913/03/webrev/
Looks good. Are you planning to do submit a CSR for this? (CLI options
are a supported/documented interface).
-Alan
Hi Alan,
On Fri, 2019-02-15 at 15:57 +, Alan Bateman wrote:
> On 15/02/2019 12:15, Severin Gehwolf wrote:
> > :
> > Here is the latest webrev:
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8218913/02/webrev/
> >
> > It uses --strip-java-debug-attributes as discussed in [1]. The --list-
On 15/02/2019 12:15, Severin Gehwolf wrote:
:
Here is the latest webrev:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8218913/02/webrev/
It uses --strip-java-debug-attributes as discussed in [1]. The --list-
plugins output for --strip-debug and --strip-java-debug-attributes
reads as follows:
Hi Mandy,
On Wed, 2019-02-13 at 15:04 -0800, Mandy Chung wrote:
> Hi Severin,
>
> Thanks for doing this. I review the webrev.
Here is the latest webrev:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8218913/02/webrev/
It uses --strip-java-debug-attributes as discussed in [1]. The --list-
pl
On 14/02/2019 16:38, Severin Gehwolf wrote:
:
A bit of clarification would be needed here I think:
1)
The current option is called '--strip-debug', not '--strip-debug-info'.
Did you mean to say to rename --strip-debug to --strip-debug-info too?
Perhaps make '--strip-debug' and alias for '--strip
On 2/14/19 8:38 AM, Severin Gehwolf wrote:
A bit of clarification would be needed here I think:
1)
The current option is called '--strip-debug', not '--strip-debug-info'.
Did you mean to say to rename --strip-debug to --strip-debug-info too?
Perhaps make '--strip-debug' and alias for '--strip-de
On 2/14/19 1:04 AM, Severin Gehwolf wrote:
Hi Mandy,
You add a new DefaultStripDebugPlugin that will do the work.
I have been assuming that this can be implemented as a jlink option
that get translated into --strip-java-debug-symbols during
the command line argument processing.
The reason
Hi Alan,
On Thu, 2019-02-14 at 15:26 +, Alan Bateman wrote:
> On 13/02/2019 11:16, Severin Gehwolf wrote:
> > Hi,
> >
> > As discussed in the RFR thread for JDK-8214796 it was suggested to
> > rename the --strip-debug plugin so that --strip-debug could actually
> > perform java debug symbols
On 13/02/2019 11:16, Severin Gehwolf wrote:
Hi,
As discussed in the RFR thread for JDK-8214796 it was suggested to
rename the --strip-debug plugin so that --strip-debug could actually
perform java debug symbols stripping *and* native debug symbols
stripping at once. That's what this patch does.
Hi Mandy,
On Wed, 2019-02-13 at 15:04 -0800, Mandy Chung wrote:
> Hi Severin,
>
> Thanks for doing this. I review the webrev.
Thanks for the review!
> You add a new DefaultStripDebugPlugin that will do the work.
> I have been assuming that this can be implemented as a jlink option
> that get t
Hi Severin,
Thanks for doing this. I review the webrev.
You add a new DefaultStripDebugPlugin that will do the work.
I have been assuming that this can be implemented as a jlink option
that get translated into --strip-java-debug-symbols during
the command line argument processing.
I'm okay wit
16 matches
Mail list logo
