Re: RFR 8170618: jmod should validate if any exported or open package is missing

2016-12-21 Thread Mandy Chung
> On Dec 21, 2016, at 4:08 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8170618/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8170618 thanks for fixing this Sundar. Minor comment on the

Re: RFR 8170618: jmod should validate if any exported or open package is missing

2016-12-21 Thread Chris Hegarty
On 21/12/16 12:08, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8170618/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8170618 Looks good Sundar. -Chris.

Re: RFR 8170618: jmod should validate if any exported or open package is missing

2016-12-21 Thread Jim Laskey (Oracle)
+1 > On Dec 21, 2016, at 8:08 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8170618/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8170618 > > Thanks, > -Sundar

RFR 8170618: jmod should validate if any exported or open package is missing

2016-12-21 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8170618/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8170618 Thanks, -Sundar

RE: Java module graph png settings?

2016-12-21 Thread Martin Lehmann
Hi Patrick, you might be interested to have a look at a small tool "depvis" which I wrote together with a few colleagues. See https://github.com/accso/java9-jigsaw-depvis Tested with b144 and GraphViz 2.38. DepVis does also create GraphViz DOT files for Jigsaw module relationships and takes