hg: jigsaw/jake/jdk: Update module config to put all of sun.misc in base module.

2013-09-05 Thread alan . bateman
Changeset: d050e294b708 Author:alanb Date: 2013-09-05 16:09 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d050e294b708 Update module config to put all of sun.misc in base module. Moved basic test for setPackageAccess to more sensible location. Add support methods to

hg: jigsaw/jake-gate/hotspot: Improve +TracePackageAccess option

2013-09-06 Thread alan . bateman
Changeset: 6ffe731d2b50 Author:alanb Date: 2013-09-06 14:26 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake-gate/hotspot/rev/6ffe731d2b50 Improve +TracePackageAccess option Allow package access to be set on the unnamed package ! src/share/vm/classfile/classLoaderExports.cpp

hg: jigsaw/jake/hotspot: Improve +TracePackageAccess option

2013-09-06 Thread alan . bateman
Changeset: 6ffe731d2b50 Author:alanb Date: 2013-09-06 14:26 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/6ffe731d2b50 Improve +TracePackageAccess option Allow package access to be set on the unnamed package ! src/share/vm/classfile/classLoaderExports.cpp

hg: jigsaw/jake-gate/jdk: Add -mods option to launcher

2013-09-06 Thread alan . bateman
Changeset: c85c96f85f2a Author:alanb Date: 2013-09-06 14:27 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake-gate/jdk/rev/c85c96f85f2a Add -mods option to launcher Allow package access to be set on the unnamed package ! src/share/bin/emessages.h ! src/share/bin/java.c !

hg: jigsaw/jake: 15 new changesets

2013-09-07 Thread alan . bateman
Changeset: f8405a0fa69c Author:erikj Date: 2013-08-26 13:43 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/f8405a0fa69c 8023216: Feedback on README-builds.html Reviewed-by: anthony, robilad, tbell ! README-builds.html Changeset: 5166118c5917 Author:katleman Date:

hg: jigsaw/jake/jdk: Allow duplicate bugids so that specific patches can be imported

2013-09-07 Thread alan . bateman
Changeset: a6ffcc1eebe5 Author:alanb Date: 2013-09-07 11:43 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a6ffcc1eebe5 Allow duplicate bugids so that specific patches can be imported ! .jcheck/conf

Re: Jigsaw/OSGi interoperability requirements

2014-08-11 Thread Alan Bateman
On 11/08/2014 16:37, David Bosschaert wrote: Hi all, Neil has now asked this question twice on the jigsaw-dev mailing list. I think this is an important question and should not be left unanswered. The old requirements document cited is from 2011. In 2012 then Project Penrose was created to

Re: RFR [9] Modular Source Code

2014-08-27 Thread Alan Bateman
On 27/08/2014 11:57, Anthony Petrov wrote: Hi Magnus, Those look like reasonable suggestions. Could you please file separate bugs for each of these issues? Also, please note that most of them belong to 2D, not AWT (e.g. the font-, color-, d3d-, and opengl-related files) even though they're

Re: JEP 200: The Modular JDK

2014-08-27 Thread Alan Bateman
On 27/08/2014 15:36, David M. Lloyd wrote: The java.sql module seems to export java.logging though I can't find a reason for it. Also it's not super clear that the dependency on java.xml is necessary (though I guess it's probably harmless) since I would say *most* users are not using the

Re: Review Request 8057627: Add org.w3c.dom.ranges and org.w3c.dom.traversal as exported API in modules.xml

2014-09-05 Thread Alan Bateman
On 04/09/2014 23:09, Mandy Chung wrote: org.w3c.dom.ranges and org.w3c.dom.traversal APIs were included in Java SE 6 but the javadoc for these APIs have been missing in the Java SE API documentation. It has been recently fixed (JDK-8023276 [1]). This patch updates modules.xml to export these

Re: RFR: JDK-8058118: Generate modules.list during the build

2014-09-14 Thread Alan Bateman
On 13/09/2014 09:30, Chris Hegarty wrote: : Update jdk part as per Mandy’s comments: http://cr.openjdk.java.net/~chegar/8058118/webrev_jdk.01/webrev/ I looked through the update and it looks good. A minor comment for both ModulesXmlReader and ModulesXmlWriter is that a private no-arg

hg: jigsaw/m2/jdk: Intial load of modular image prototype

2014-09-17 Thread alan . bateman
Changeset: af8024022280 Author:alanb Date: 2014-09-17 20:14 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/af8024022280 Intial load of modular image prototype Contributed-by: james.las...@oracle.com, sundararajan.athijegannat...@oracle.com, mandy.ch...@oracle.com,

hg: jigsaw/m2/jdk: java/net/NetworkInterface/IPv4Only.java failing with jimage, libnet.so loading a bit eariler

2014-09-19 Thread alan . bateman
Changeset: 7a57dc944517 Author:alanb Date: 2014-09-19 12:45 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/7a57dc944517 java/net/NetworkInterface/IPv4Only.java failing with jimage, libnet.so loading a bit eariler ! test/java/net/NetworkInterface/IPv4Only.java

Re: So what is a .jimage?

2014-09-25 Thread Alan Bateman
On 24/09/2014 21:29, Paul Benedict wrote: I haven't been able to find any discussion on this new file type. What's the file format? What's inside of it? It's a container format for storing and indexing modules, classes and resources in the JDK. Think replacement of rt.jar, resources.jar,

hg: jigsaw/m2/jdk: jdk.jfr missing from bootmodules.jimage

2014-09-27 Thread alan . bateman
Changeset: 9e0e4601ef18 Author:alanb Date: 2014-09-27 20:01 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/9e0e4601ef18 jdk.jfr missing from bootmodules.jimage ! make/src/classes/build/tools/module/boot.modules

hg: jigsaw/m2/jdk: sunpkcs11-solaris.cfg missing from Solaris images

2014-09-29 Thread alan . bateman
Changeset: 7d2ba5d1f673 Author:alanb Date: 2014-09-30 02:45 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/7d2ba5d1f673 sunpkcs11-solaris.cfg missing from Solaris images jspawnhelper missing +x on Solaris ! make/copy/Copy-jdk.crypto.pkcs11.gmk !

Re: RFR 8058657: Add @jdk.Exported to com.sun.jarsigner APIs

2014-09-29 Thread Alan Bateman
On 29/09/2014 20:14, Wang Weijun wrote: Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8058657/webrev.00/ It includes both the dev repo and dev/jdk repo. While the change in dev/jdk is useless with today's modules environment, it is included here and will be

hg: jigsaw/m2/jdk: nbexec on modular image leads to recursive initialization

2014-10-03 Thread alan . bateman
Changeset: c537d18df57f Author:alanb Date: 2014-10-04 04:39 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/c537d18df57f nbexec on modular image leads to recursive initialization ! src/java.base/share/classes/java/net/URL.java

hg: jigsaw/m2/hotspot: Update CDS to work with modular image

2014-10-08 Thread alan . bateman
Changeset: 0c40b8773c42 Author:alanb Date: 2014-10-09 01:05 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/0c40b8773c42 Update CDS to work with modular image ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/memory/filemap.cpp

Re: Review Request: JDK-8059083: Remove jdk.compact3 from modules.xml

2014-10-10 Thread Alan Bateman
On 02/10/2014 20:19, Mandy Chung wrote: jdk.compact3 was meant to be removed when we integrated JEP 201: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8059083/webrev.00/ This looks okay to me. -Alan

hg: jigsaw/m2/hotspot: Add compression support to jimage format

2014-10-11 Thread alan . bateman
Changeset: 4cae4548c092 Author:alanb Date: 2014-10-11 14:44 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/4cae4548c092 Add compression support to jimage format Contributed-by: sundararajan.athijegannat...@oracle.com ! src/share/vm/classfile/classLoader.cpp !

hg: jigsaw/m2/jdk: Add compression support to jimage format

2014-10-11 Thread alan . bateman
Changeset: b7eeec9aac5d Author:alanb Date: 2014-10-11 14:44 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/b7eeec9aac5d Add compression support to jimage format Contributed-by: sundararajan.athijegannat...@oracle.com ! make/lib/CoreLibraries.gmk !

Re: m2 images and Freetype on Windows

2014-10-12 Thread Alan Bateman
On 11/10/2014 22:40, Ludovic HOCHET wrote: Hello, In case this was missed, freetype.dll is not copied to either the jdk or the jre bin directories with the new images on Windows. Thanks, it's great to have people trying out these builds. I see that the exploded build is okay, it's just missing

hg: jigsaw/m2/jdk: Missing jdk.snmp

2014-10-12 Thread alan . bateman
Changeset: 256a69aebbd4 Author:alanb Date: 2014-10-12 14:05 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/256a69aebbd4 Missing jdk.snmp ! make/src/classes/build/tools/module/boot.modules

Re: m2 images and Freetype on Windows

2014-10-13 Thread Alan Bateman
On 12/10/2014 21:51, Ludovic HOCHET wrote: Both. That is the netbeans_jdkhome in netbeans.conf points to m2/../images/jdk and the platform of the created Maven project is the default platform (ie the same path). What's having immediate issues though is the later, as changing to a platform

hg: jigsaw/m2/jdk: jimage protocol handler should override getPermission

2014-10-13 Thread alan . bateman
Changeset: 40e633ee8ff3 Author:alanb Date: 2014-10-13 14:33 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/40e633ee8ff3 jimage protocol handler should override getPermission ! src/java.base/share/classes/sun/misc/JImageCache.java !

hg: jigsaw/m2/hotspot: Allow CDS to be enabled on Windows

2014-10-13 Thread alan . bateman
Changeset: 67f27a66271d Author:alanb Date: 2014-10-13 21:14 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/67f27a66271d Allow CDS to be enabled on Windows ! src/share/vm/classfile/sharedPathsMiscInfo.cpp ! src/share/vm/memory/filemap.cpp !

hg: jigsaw/m2/jdk: Exclude tests that will likely be removed or are impacted by ct.sym

2014-10-14 Thread alan . bateman
Changeset: e0c171269a8d Author:alanb Date: 2014-10-14 09:44 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/e0c171269a8d Exclude tests that will likely be removed or are impacted by ct.sym ! test/ProblemList.txt ! test/TEST.groups

hg: jigsaw/m2/jdk: Overriding the default file system provider fails with a modular image

2014-10-15 Thread alan . bateman
Changeset: 24b6436df632 Author:alanb Date: 2014-10-15 19:28 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/24b6436df632 Overriding the default file system provider fails with a modular image ! src/java.base/share/classes/jdk/internal/jimage/ImageFile.java !

hg: jigsaw/m2/jdk: Temporarily exclude sun/security/krb5/config/dns.sh

2014-10-19 Thread alan . bateman
Changeset: 1a85907e23c4 Author:alanb Date: 2014-10-19 20:02 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/1a85907e23c4 Temporarily exclude sun/security/krb5/config/dns.sh ! test/ProblemList.txt

Fwd: i18n dev [9] RFR: 8061382: Separate CLDR locale data from JRE locale data

2014-10-21 Thread Alan Bateman
I think we should examine the module names as the proposed jdk.localedata.cldr does not augment jdk.localedata. Original Message Subject: i18n dev [9] RFR: 8061382: Separate CLDR locale data from JRE locale data Date: Fri, 17 Oct 2014 15:31:08 -0700 From: Naoto Sato

hg: jigsaw/m2/jdk: jrunscript -cp not working

2014-10-23 Thread alan . bateman
Changeset: 6f479c7b439c Author:alanb Date: 2014-10-23 11:12 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/6f479c7b439c jrunscript -cp not working ! src/java.base/share/conf/security/java.security ! src/java.scripting/share/classes/com/sun/tools/script/shell/Main.java !

hg: jigsaw/m2/corba: Update rmic to work a modular image

2014-10-24 Thread alan . bateman
Changeset: 5717b21cb853 Author:alanb Date: 2014-10-24 13:37 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/corba/rev/5717b21cb853 Update rmic to work a modular image Contributed-by: sundararajan.athijegannat...@oracle.com ! make/CompileInterim.gmk !

hg: jigsaw/m2/jdk: *ImageReader and ImageHeader fields should be final

2014-10-26 Thread alan . bateman
Changeset: 48c2ee51c271 Author:alanb Date: 2014-10-26 09:13 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/48c2ee51c271 *ImageReader and ImageHeader fields should be final ! src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java !

Re: Adopt Project Jigsaw @ Bulgarian JUG

2014-10-26 Thread Alan Bateman
On 26/10/2014 12:20, Mitia Alexandrov wrote: Hello folks, I’ve got the sources from here: http://hg.openjdk.java.net/jigsaw/jigsaw On ubuntu 14.04: Make images» with gcc 4.8.1 finished with error: */make[2]: ***

hg: jigsaw/m2: make profiles failing as jdk.compact3 no longer exists

2014-10-29 Thread alan . bateman
Changeset: 1275a5bc4a7d Author:alanb Date: 2014-10-29 08:05 + URL: http://hg.openjdk.java.net/jigsaw/m2/rev/1275a5bc4a7d make profiles failing as jdk.compact3 no longer exists ! make/Images.gmk

hg: jigsaw/m2/jdk: 8061446: sun/tools/jconsole/ResourceCheckTest, to remove jconsole.jar from classpath; ...

2014-10-31 Thread alan . bateman
Changeset: a75a07342199 Author:alanb Date: 2014-10-31 11:32 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/a75a07342199 8061446: sun/tools/jconsole/ResourceCheckTest, to remove jconsole.jar from classpath 8061444: sun/tools/native2ascii/resources/ImmutableResourceTest.sh,

CFV: New Jigsaw Committer: Sundar Athijegannathan

2014-11-03 Thread Alan Bateman
I hereby nominate Sundar Athijegannathan to Jigsaw Committer. Sundar is currently a Reviewer on the jdk9, jdk8u and Nashorn projects. Sundar has been contributing to Project Jigsaw by way of the compression support in jimage container format and also the file system provider implementation,

hg: jigsaw/m2/jdk: Remove special handling of JAR files in JDK image

2014-11-10 Thread alan . bateman
Changeset: 3fbe28d5ae28 Author:alanb Date: 2014-11-10 15:36 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/3fbe28d5ae28 Remove special handling of JAR files in JDK image ! src/java.base/share/classes/java/util/jar/JarFile.java ! src/java.base/share/native/libjava/System.c

hg: jigsaw/m2/jdk: Eliminate use of RandomAccessFile + synchronization in jimage code when running

2014-11-10 Thread alan . bateman
Changeset: 624c2865ef80 Author:alanb Date: 2014-11-10 18:41 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/624c2865ef80 Eliminate use of RandomAccessFile + synchronization in jimage code when running on JDK 9 ! make/Tools.gmk ! make/mapfiles/libjava/mapfile-vers !

hg: jigsaw/m2/jdk: jrtfs classes missing from jrt-fs.jar

2014-11-13 Thread alan . bateman
Changeset: c050acaddcc9 Author:alanb Date: 2014-11-13 10:09 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/c050acaddcc9 jrtfs classes missing from jrt-fs.jar jrtfs tests need to be run in core_tools test group jrtfs needs to detect java.home based on its code source zipfs

hg: jigsaw/m2/jdk: Temporarily include jimagefs in interim jimage classes to avoid needing to

2014-11-13 Thread alan . bateman
Changeset: 606065ade070 Author:alanb Date: 2014-11-13 13:18 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/606065ade070 Temporarily include jimagefs in interim jimage classes to avoid needing to separate service configuration file entries. ! make/Tools.gmk

hg: jigsaw/m2/jdk: pack200 tests failing after jimage tool option change

2014-11-13 Thread alan . bateman
Changeset: 9dc3e498c531 Author:alanb Date: 2014-11-13 16:47 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/9dc3e498c531 pack200 tests failing after jimage tool option change ! test/tools/pack200/Utils.java

hg: jigsaw/m2/jdk: Path::toUri should have an undefined authority component

2014-11-17 Thread alan . bateman
Changeset: 91251850ef59 Author:alanb Date: 2014-11-17 08:52 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/91251850ef59 Path::toUri should have an undefined authority component ! src/java.base/share/classes/jdk/internal/jrtfs/JrtPath.java !

hg: jigsaw/m2/jdk: Paths.get(URI) fails with jrt URI

2014-11-17 Thread alan . bateman
Changeset: ca46e93b45ee Author:alanb Date: 2014-11-17 20:27 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/ca46e93b45ee Paths.get(URI) fails with jrt URI ! src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystemProvider.java ! test/jdk/internal/jrtfs/Basic.java

hg: jigsaw/m2/jdk: jrtfs should create theFileSystem lazily

2014-11-19 Thread alan . bateman
Changeset: d323b3f38ab0 Author:alanb Date: 2014-11-19 12:23 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/d323b3f38ab0 jrtfs should create theFileSystem lazily ! src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystemProvider.java

hg: jigsaw/m2/jdk: rmic -iiop fails with NPE

2014-11-26 Thread alan . bateman
Changeset: 3a208887d9f4 Author:alanb Date: 2014-11-26 14:06 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/3a208887d9f4 rmic -iiop fails with NPE Contributed-by: sundararajan.athijegannat...@oracle.com ! src/jdk.rmic/share/classes/sun/tools/java/ClassPath.java

hg: jigsaw/m2/jdk: Unable to start on Windows when java.home set to short 8.3 format

2014-11-27 Thread alan . bateman
Changeset: ed6f48d53ce2 Author:alanb Date: 2014-11-27 17:01 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/ed6f48d53ce2 Unable to start on Windows when java.home set to short 8.3 format ! src/java.base/share/classes/sun/misc/URLClassPath.java

hg: jigsaw/m2/jdk: Clean-up imports to allow for easier merge

2014-11-28 Thread alan . bateman
Changeset: 00c288ee3f8c Author:alanb Date: 2014-11-28 13:07 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/00c288ee3f8c Clean-up imports to allow for easier merge ! src/java.base/share/classes/sun/misc/Launcher.java ! src/java.base/share/classes/sun/misc/URLClassPath.java

hg: jigsaw/m2/hotspot: Minor clean-up to allow for easier merge

2014-11-28 Thread alan . bateman
Changeset: 01affeae8834 Author:alanb Date: 2014-11-28 13:06 + URL: http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/01affeae8834 Minor clean-up to allow for easier merge ! src/share/vm/classfile/classLoader.cpp

hg: jigsaw/m2/jdk: Closing the ext or app class loader causes UOE to be thrown

2014-11-28 Thread alan . bateman
Changeset: 527ba0f4e133 Author:alanb Date: 2014-11-28 17:10 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/527ba0f4e133 Closing the ext or app class loader causes UOE to be thrown ! src/java.base/share/classes/sun/misc/URLClassPath.java

Re: RFR [JEP 220] Modular Run-Time Images

2014-12-01 Thread Alan Bateman
On 01/12/2014 16:11, Paul Sandoz wrote: : In src/java.base/share/classes/java/util/jar/Attributes.java /** * codeName/code object for codeImplementation-URL/code * manifest attribute used for package versioning. - * @see a

hg: jigsaw/m2/jdk: linux-ppc builds generate jimage in the wrong native format

2014-12-01 Thread alan . bateman
Changeset: 9de3eba82f89 Author:alanb Date: 2014-12-01 19:01 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/9de3eba82f89 linux-ppc builds generate jimage in the wrong native format ! src/java.base/share/classes/jdk/internal/jimage/BasicImageWriter.java

Re: JSR 376 (and Capsule)

2014-12-02 Thread Alan Bateman
On 02/12/2014 13:15, Ron Pressler wrote: Hi! I’m the maintainer of Capsule , which is a simple distribution mechanism for Java applications (basically, executable JARs on steroids, with support for native libs, embedded JARs, and declared Maven dependencies). As such, I’m especially

hg: jigsaw/m2/jdk: Test tools/launcher/VersionCheck.java fails with jigsaw/m2 builds on Windows

2014-12-02 Thread alan . bateman
Changeset: 7bcad191377c Author:alanb Date: 2014-12-02 21:20 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/7bcad191377c Test tools/launcher/VersionCheck.java fails with jigsaw/m2 builds on Windows ! test/tools/launcher/VersionCheck.java

Re: RFR [JEP 220] Modular Run-Time Images

2014-12-03 Thread Alan Bateman
On 01/12/2014 16:11, Paul Sandoz wrote: On Nov 20, 2014, at 10:41 PM, Chris Hegarty chris.hega...@oracle.com wrote: Webrevs: http://cr.openjdk.java.net/~chegar/8061971/00/ Below is a review of JDK code. I did not spot any showstoppers. It's mostly cleanup related with maybe one or two

hg: jigsaw/m2/jdk: Minor clean-up based on review comments

2014-12-03 Thread alan . bateman
Changeset: d66bacd2dba8 Author:alanb Date: 2014-12-03 13:29 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/d66bacd2dba8 Minor clean-up based on review comments ! src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystemProvider.java !

Re: RFR [JEP 220] Modular Run-Time Images - compact profiles footprint

2014-12-04 Thread Alan Bateman
On 04/12/2014 16:38, Naoto Sato wrote: Quick question. Why is jdk.localedata module included in the compact profiles? The data there used to be in lib/ext/localedata.jar and lib/ext/cldrdata.jar which weren't included in those compact profiles. Naoto The profiles make target on JDK 8 (and JDK

Re: RFR(XXS): 8066766: The commands in the modular images are executable by the owner only

2014-12-05 Thread Alan Bateman
On 05/12/2014 16:50, Volker Simonis wrote: Hi Chris, thanks for the fast response. I saw that code in ImageBuilder, but it looked overly complicated to me. What about cleaning that up as well: http://cr.openjdk.java.net/~simonis/webrevs/8066766.v2/ I've just checked that on Solaris

Re: RFR(XXS): 8066766: The commands in the modular images are executable by the owner only

2014-12-05 Thread Alan Bateman
On 05/12/2014 17:26, Volker Simonis wrote: But why do we need an exception if setting the executable flags fails on 'jspawnhelper' and don't need on if it fails on the executables. We'll actually never notice that 'jspawnhelper' isn't executable if we can't execute 'java', right? It is

Re: RFR(XXS): 8066766: The commands in the modular images are executable by the owner only

2014-12-05 Thread Alan Bateman
On 05/12/2014 17:34, Alan Bateman wrote: On 05/12/2014 17:26, Volker Simonis wrote: But why do we need an exception if setting the executable flags fails on 'jspawnhelper' and don't need on if it fails on the executables. We'll actually never notice that 'jspawnhelper' isn't executable if we

Re: Scanning module contents

2015-01-01 Thread Alan Bateman
On 30/12/2014 17:18, Roman Shevchenko wrote: Hi Rémi, do you by any chance know if there is a legitimate way of doing the same from another JVM, not the one the scanning code is loaded into? I've seen your jigsaw-jrtfs, but that patch() part of it feels hacky and (if I got it right) does not

8067867: Subsume module java.xml.soap into module java.xml.ws

2015-01-03 Thread Alan Bateman
There are a number of proposed updates to the module graph that we need reflected in the source code layout (and the module graph in JEP 200 [1] will need to be refreshed too). JDK-8067867 tracks dropping the module java.xml.soap and subsuming the API into the java.xml.ws module. The

Re: module/bootclass troubles with jdk9

2015-02-04 Thread Alan Bateman
On 03/02/2015 23:40, Martin Buchholz wrote: Maybe jrt could be generalized. Instead of simply the java run time of the current jdk, it could additionally be a function jrt(jredir) that somehow gives you the runtime classes of any jre, in a way that javac can understand. This is how we want

Re: A question ad JDK 9 or: how to make all javax.script engines available to all Java apps in JDK 9?

2015-01-19 Thread Alan Bateman
On 19/01/2015 12:28, Rony G. Flatscher wrote: : (Speculation: I would also expect that many of those will only realize the missing of the extension mechanism, once Java 9 gets GA and is planned to be deployed. The alternative for those affected in such a scenario would be to stick to their

Re: Review request: JDK-8069414: Rename oracle.accessbridge to jdk.accessbridge

2015-01-22 Thread Alan Bateman
Thanks looks okay to me. -Alan

Re: Apache Maven JDeps Plugin

2015-02-16 Thread Alan Bateman
On 16/02/2015 18:28, Robert Scholte wrote: Hi Alan, if you are referring to the -R / -recursive option of the jdeps tool, then yes you can. See http://maven.apache.org/plugins-archives/maven-jdeps-plugin-LATEST/maven-jdeps-plugin/jdkinternals-mojo.html#recursive I think jdeps is first of all

Re: Scanning module contents

2015-01-06 Thread Alan Bateman
On 05/01/2015 20:19, Roman Shevchenko wrote: Thanks! Yep, I was looking exactly for the IDE case. Regarding scanning JDK 9 from other JDK 9 - I'm extremly interested in this case too. Is there any way I may be notified once the case is resolved? You are on the right mailing list for any

Re: Modular soruce code resolving

2015-03-20 Thread Alan Bateman
On 19/03/2015 22:42, Edward Nigma wrote: With introduction of jimage, source archive may contain ambiguous entries (multiple version). If jimage allow distribution of multiple module versions then sources in zip should too. Just on this comment, are you specifically talking about src.zip in the

Re: RFR 8047789: auth.login.LoginContext needs to be updated to work with modules

2015-03-20 Thread Alan Bateman
On 20/03/2015 14:39, Wang Weijun wrote: Please review the code changes at http://cr.openjdk.java.net/~weijun/8047789/webrev.03/ LoginContext is updated to use ServiceLoader to load configured LoginModules, and fallback to reflection if it cannot find one. Please notice that the fix does

Re: RFR 8047789: auth.login.LoginContext needs to be updated to work with modules

2015-03-21 Thread Alan Bateman
On 20/03/2015 14:39, Wang Weijun wrote: Please review the code changes at http://cr.openjdk.java.net/~weijun/8047789/webrev.03/ : Compatibility issue: Before this code change, any class that includes the necessary methods (initialize, login, logout, abort, commit) can be configured as a

Re: RFR 8073596 : Add jdk.management.cmm in boot.modules that needs sun.management.spi be exported to it

2015-02-28 Thread Alan Bateman
On 27/02/2015 20:55, Brent Christian wrote: Hi, Please review a small update to the module config files for a new jdk.management.cmm module. Webrev: http://cr.openjdk.java.net/~bchristi/8073596/webrev/ Bug: https://bugs.openjdk.java.net/browse/JDK-8073596 I also found a needed hook missing

Re: Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

2015-03-05 Thread Alan Bateman
On 05/03/2015 02:55, Wang Weijun wrote: - Move keytool to jdk.security.util, it's now in java.base but keytool is not part of Java SE spec (Of course, if that means keytool will be in JDK instead of JRE please stop. But will there will the name difference anymore? I am thinking of an

Re: Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

2015-03-05 Thread Alan Bateman
On 05/03/2015 01:13, Mandy Chung wrote: : Separate webrevs for each issue: 1. pack200, unpack200 to jdk.pack200 http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074428%2b8074429%2b8074430/8074428/webrev.00/ I think this looks okay. In the unshuffle_list (for back/forward porting patches)

Re: Bring your own JRE (BYOJ)

2015-04-20 Thread Alan Bateman
On 19/04/2015 23:45, Stefan Fuchs wrote: : P.S.: Looking at JEP-200 I could not find, to which module all the webstart classes belong. E.g.: What module does export javax.jnlp? Obviously these classes are only needed on desktop platforms and could be omitted on embedded devices and for

Re: JDK 9 build with application class loader changes available?

2015-04-27 Thread Alan Bateman
On 27/04/2015 01:52, Luke Daley wrote: This is a follow on from: http://mail.openjdk.java.net/pipermail/jigsaw-dev/2015-April/004291.html @Mandy: is there a build of 9 available that has the application class loader changes that we can use to test with? If not, any ETA on one? The JDK 9

Re: RFR: Proposed jimage refresh for JDK9

2015-05-18 Thread Alan Bateman
On 15/05/2015 16:45, Jim Laskey (Oracle) wrote: http://cr.openjdk.java.net/~jlaskey/jdk9-jimage/top/ http://cr.openjdk.java.net/~jlaskey/jdk9-jimage/top/ http://cr.openjdk.java.net/~jlaskey/jdk9-jimage/hotspot/ http://cr.openjdk.java.net/~jlaskey/jdk9-jimage/hotspot/

Re: internal API usage: sun.awt.CausedFocusEvent

2015-05-13 Thread Alan Bateman
On 13/05/2015 17:11, Alan Snyder wrote: I have been using sun.awt.CausedFocusEvent to implement special behavior in response to an explicit user-initiated focus traversal to a component. The main point is that I want to inhibit this behavior for all other kinds of focus gained events. Will

Re: OS X 1.9 ea jdeps

2015-04-13 Thread Alan Bateman
On 12/04/2015 17:57, Michael Hall wrote: : Not exactly sure what you mean. But, which java /usr/bin/java which javac /usr/bin/javac locate jdeps /Library/Java/JavaVirtualMachines/jdk1.8.0_20.jdk/Contents/Home/bin/jdeps

Re: RFR: Proposed jimage refresh for JDK9

2015-05-19 Thread Alan Bateman
On 19/05/2015 17:43, Jim Laskey (Oracle) wrote: : jdk.internal.jimage.ExternalFilesWriter 93 private static String nativeDir(String filename) { 94 if (System.getProperty(os.name).startsWith(Windows)) { 95 if (filename.endsWith(.dll) || filename.endsWith(.diz)

Re: Jigsaw Hackday in London - Anything in particular you want us to look at?

2015-06-23 Thread Alan Bateman
On 23/06/2015 10:34, Martijn Verburg wrote: Hi all, As part of the Adoption Group we're planning on holding a Hackday in London for the July/Aug timeframe, primarily as an education/awareness piece around Jigsaw (there's lots to catch up on). Is there anything in particular you'd like a group

Re: Review Request 8074432: Move jdeps to jdk.compiler module

2015-05-27 Thread Alan Bateman
On 27/05/2015 07:00, Mandy Chung wrote: We discussed this offline and revised the proposal to group javap and classfile library together with jdeps in jdk.jdeps module for static analysis tools to live. The jdk.compiler module will contain the compiler and a couple of small tools. Moving

Re: jdeps -jdkinternals com.apple

2015-07-04 Thread Alan Bateman
On 04/07/2015 01:28, Michael Hall wrote: Trying jeeps out on a 3rd party jar that I make some use of, the only things it flags are classes like - com.apple.eawt.AppEvent (JDK internal API (java.desktop))”; I don’t see any com.apple listed on…

Re: Module container format

2015-07-03 Thread Alan Bateman
On 03/07/2015 05:16, offbynull-jig...@offbynull.com wrote: We're not there yet but eventually it should be possible to run a tool on JDK 9 to access another JDK 9 run-time image (maybe it has a different set of modules) or run on JDK 9 to access a JDK 10 run-time image. It's disappointing,

Re: Where to find jlink?

2015-07-03 Thread Alan Bateman
On 03/07/2015 07:08, Adib Saikali wrote: Hi, I have been seeing references to jlink in a variety of conference talks / blog posts / new articles covering Java 9 for the past few years. However, I can't seem to find it anywhere in the JDK Early access release b70 on Mac OS X. Is there a plan

Re: Module container format

2015-07-02 Thread Alan Bateman
On 02/07/2015 20:01, offbynull-jig...@offbynull.com wrote: The JEP says that the module container format is implementation-specific and subject to change without notice. My concern is that this is going to end up screwing over tool maintainers, such as myself. I maintain an opensource tool

Re: Should this work?

2015-08-02 Thread Alan Bateman
On 01/08/2015 21:57, Michael Hall wrote: I can’t tell from that though what produced the requirement for java.desktop. -module options didn’t seem to show this either on a class by class basis. Have you tried -verbose:class to print class-level dependences? Generally I have used

Re: Should this work?

2015-08-02 Thread Alan Bateman
On 02/08/2015 12:58, Michael Hall wrote: You may of missed here that I had switched to testing with the trivial test class I posted earlier. Shown below. That simply does… javax.swing.UIManager.setLookAndFeel(javax.swing.UIManager.getSystemLookAndFeelClassName()); No QuaQua involved. I

Re: Should this work?

2015-07-31 Thread Alan Bateman
On 31/07/2015 00:08, Michael Hall wrote: jdeps -v -dotoutput ~/dotfiles jrt:/java.desktop/com/apple/laf/AquaBorder.class or what would be a good way to determine the dependencies for a Swing LF? Running jdeps against the application jar for a Swing application shows no look and feel

Re: RFR(XS): 8132475 : The commands in the modular images are executable by the owner only (once again)

2015-07-28 Thread Alan Bateman
On 28/07/2015 19:32, Volker Simonis wrote: Hi, could you please review this tiny change: http://cr.openjdk.java.net/~simonis/webrevs/2015/8132475/ https://bugs.openjdk.java.net/browse/JDK-8132475 After 8080511: Refresh of jimage support the executable commands in jdk/bin and jre/bin are only

Re: jrt file system now has /package and /modules directories

2015-07-26 Thread Alan Bateman
On 26/07/2015 01:29, Michael Hall wrote: On Jul 25, 2015, at 12:10 PM, Alan Bateman alan.bate...@oracle.com wrote: Just a heads-up that jdk9-b74 has a refresh of the jimage and jrt file system implementation. Have mostly just been following along on this a little with the early access

Re: Review for JDK-8132335

2015-07-25 Thread Alan Bateman
On 24/07/2015 17:19, Jean-Francois Denise wrote: I forget to add details on the fix. The fileName formatting was not correct, the call to getRoot() was not right. I replaced it with getFileName() + removal of .jimage extension. JF Are you planning to add a test for this? I realize jimage

jrt file system now has /package and /modules directories

2015-07-25 Thread Alan Bateman
Just a heads-up that jdk9-b74 has a refresh of the jimage and jrt file system implementation. For IDEs and other tools that are using the jrt file system then an important change in this build is the addition of the /packages and /modules top-level directories in the file system. Details in

Re: JMX agents and Jigsaw

2015-07-20 Thread Alan Bateman
On 20/07/2015 11:51, Ron Pressler wrote: Hi. I need to start a local JMX agent on the current JVM and obtain its secret address; I cannot rely on tools.jar being present so I can't use the attach mechanism. The attach API (meaning com.sun.tools.attach) is a JDK-specific/supported API. It

Re: JMX agents and Jigsaw

2015-07-21 Thread Alan Bateman
On 21/07/2015 06:49, Ron Pressler wrote: : That's really good (esp. startLocalManagementAgent), but does it require tools.jar to be available, which means a JDK, rather than JRE installation? VMSupport and Agent are available on any JRE. Perhaps com.sun.tools.attach should be included in

Re: Review for 8131317

2015-07-15 Thread Alan Bateman
On 15/07/2015 13:34, Jean-Francois Denise wrote: Hi, please review fix for: https://bugs.openjdk.java.net/browse/JDK-8131317 I took the opportunity of this fix to simplify ImageResourcesTree.java a bit. http://cr.openjdk.java.net/~jfdenise/8131317/ Thanks. JF This looks okay to me. -Alan

Re: JavaFX9 on Debian Wheezy (was Re: InternalError on Class.getPackage())

2015-10-21 Thread Alan Bateman
On 21/10/2015 16:11, Kevin Rushforth wrote: Hi Chris, Thanks for the info. And sorry about the misleading error message. The latest bits (whenever they show up in an EA build) The current EA bits are based on jdk9-b83 so they are a bit old, they should be a new EA build by the end of this

Re: RFR 9: 8139390 : Very long classname in jimage causes SIGSEGV

2015-10-28 Thread Alan Bateman
On 28/10/2015 06:40, Roger Riggs wrote: Please review an update to the jimage reader implementation to correct the case where a class name is very long causing a SEGV due to buffer overruns. The fix will be pushed to the hs-comp repo; the bug was first spotted there. Webrev:

Re: Compilation feedback and version question

2015-10-29 Thread Alan Bateman
On 29/10/2015 11:25, Stephen Colebourne wrote: : So, after about an hour yesterday, I did try that and it still didn't work. That must have been because jmod doesn't work fully. I've tried it now, and with -addmods it does find the modular jar file. However, my feedback is that the -listmods

Re: RFR: 8140336: Add @modules for exported dependencies to jdk_core tests

2015-10-27 Thread Alan Bateman
On 27/10/2015 13:36, Alexandre (Shura) Iline wrote: On Oct 27, 2015, at 12:17 AM, Mandy Chung wrote: On Oct 26, 2015, at 10:13 AM, Alexandre (Shura) Iline wrote: Hi. Could you please take a look on the suggested change in tests

  1   2   3   4   5   6   7   8   9   10   >