Regression in getImplementationVersion from Jigsaw

2017-11-08 Thread Michael D
Hi All, Hope I'm in the right place. The implementation of Jigsaw caused a regression in that Package.getImplementationVersion is unusable if no other version things are defined in the manifest. This appears to be an unintentional regression caused by a missing null check. I have prepared a patch

Re: Regression in getImplementationVersion from Jigsaw

2017-11-08 Thread Michael D
he patch looks good and I will sponsor this patch for you. > > Thanks for the regression test. It'd be good to wrap the long lines and I > will clean that up before I push. > > thanks > Mandy > > On 11/8/17 5:07 PM, Michael D wrote: >> >> Hi All, >> &g

Re: Regression in getImplementationVersion from Jigsaw

2017-11-08 Thread Michael D
ding convention. > > > Mandy > > > On 11/8/17 6:25 PM, Michael D wrote: > > Hi Mandy, > > No problem. Wasn't sure where the limit was on line lengths, so I will > watch and learn :) > > Thanks > Michael > > On 9 November 2017 at 13:22, mandy chung >