Re: RFR [9] 8168149: Examine the behavior of jmod command-line options - repeating vs last one wins

> On Jan 5, 2017, at 5:14 AM, Chris Hegarty wrote: > > >> I wonder if it would be more helpful if it fails when a non-repeating option >> is specified more than once for a packaging tool. Otherwise, the only way >> to find out if the command-line is correct is to

Re: Invoking default methods from a Proxy's InvocationHandler in JDK9

> On Jan 2, 2017, at 11:20 PM, Peter Levart wrote: > > Hi Matthew, > > On 01/03/2017 04:28 AM, Matthew Hall wrote: >> I'm a member of the JDBI [1] project, an open source SQL access library >> atop JDBC. >> >> A major part of our API provides implementations of

Re: Review Request: JDK-8168836 Minor clean up on warning/error messages on --add-exports and --add-reads

> On Jan 3, 2017, at 1:04 PM, David Holmes wrote: > > Hi Mandy, > > >> >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8168836/webrev.00/ >> >> This patch improves the warning/error message to include the option name, >> emit a warning if unknown module is

Re: RFR [9] 8168149: Examine the behavior of jmod command-line options - repeating vs last one wins

> On Dec 22, 2016, at 9:11 AM, Chris Hegarty wrote: > > Most options for the jmod tool should be last one wins, to be consistent > with the JDK tool convention, 8168149 [1]. Excludes is the only > repeatable option. > > Given the existing usage of JOpt Simple, the

Re: RFR 8170289: Re-examine entry point support in jlink

ev.02 > > Thanks, > -Sundar > > On 17/12/16, 12:33 AM, Mandy Chung wrote: >>> On Dec 16, 2016, at 8:36 AM, Sundararajan >>> Athijegannathan<sundararajan.athijegannat...@oracle.com> wrote: >>> >>> Hi, >>> >>> Please review

Re: Review Request: JDK-8168836 Minor clean up on warning/error messages on --add-exports and --add-reads

> On Dec 19, 2016, at 11:39 AM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > >> On Dec 19, 2016, at 9:45 AM, Alan Bateman <alan.bate...@oracle.com> wrote: >> >> >> >> On 19/12/2016 01:44, Mandy Chung wrote: >>> http:

Re: RFR: 8171400: Move checking of duplicate packages in the boot layer to link time

tools/launcher/modules/patch/systemmodules/PatchSystemModules.java needs to be updated since ModuleBootstrap now depends on this new method: diff --git a/test/tools/launcher/modules/patch/systemmodules/src1/java.base/jdk/internal/modules/SystemModules.java

Re: [9] Review request: JDK-8170485: Switch to building JavaFX with new module-info syntax

> On Dec 6, 2016, at 8:10 AM, Kevin Rushforth > wrote: > > Chien & Dave, > > Please review the preliminary webrev to allow building JavaFX with jdk-9+148 > and later: > > https://bugs.openjdk.java.net/browse/JDK-8170485 >

Re: RFR: 8171373: Reduce copying during initialization of ModuleHashes

s. > > /Claes > > On 2016-12-16 18:52, Mandy Chung wrote: >> >>> On Dec 16, 2016, at 8:00 AM, Claes Redestad <claes.redes...@oracle.com> >>> wrote: >>> >>> Hi, >>> >>> recent changes to split out ModuleHashes from Mo

Re: RFR 8170618: jmod should validate if any exported or open package is missing

> On Dec 21, 2016, at 4:08 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8170618/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8170618 thanks for fixing this Sundar. Minor comment on the

Re: RFR(S) : 8177374 : fix module dependency declaration in jdk_svc tests

> On Mar 23, 2017, at 1:07 PM, Igor Ignatyev wrote: > > Mandy/Daniel, > > yes, jdk.management.agent does require java.management, but not transitively. > Shura and I have discussed that and agreed that in such cases a test should > declare dependency explicitly,

Re: 8174823: Module system implementation refresh (3/2017)

> On Mar 21, 2017, at 2:42 PM, Alan Bateman wrote: > > We have been accumulating changes in the jake forest for the last few weeks > to align with the proposals in JSR 376 and also to pick up API changes and > bug fixes. It's time to bring these changes into jdk9/dev.

Review Request: JDK-8173303: Add module-subgraph images to main platform documentation

Jon and I work on this patch as the first step to enable module graphs for inclusion in the javadoc. It includes a @moduleGraph taglet, an updated GenGraphs tool, and also updates javadoc of module-info.java to include @moduleGraph. I also take the opportunity to add simple javadoc to a few

Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

uld look at all jlink tests and see what makes sense. For these new tests, I can move the helper class to jdk/tests/tools/lib/tests. Mandy > > —Andrey > >> On 22 Mar 2017, at 22:11, Mandy Chung <mandy.ch...@oracle.com> wrote: >> >> Webrev: >> http://cr.op

Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

> On Mar 23, 2017, at 11:07 AM, Mandy Chung <mandy.ch...@oracle.com> wrote: > >> Instead of "copy-paste" code to run Jlink in tests ProcessTools and >> OutputAnalyzer can be used from standard test library >> test/lib/share/classes/jdk/test/lib/pr

Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8174826/webrev.00/ This is a proposal to resolve the open issue listed in JEP 282 about jlink and service binding. jlink does not do service binding by default as it may be confusing to the users. To link in service providers, users have

Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

> On Mar 23, 2017, at 7:58 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 22/03/2017 19:11, Mandy Chung wrote: > >> Webrev: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8174826/webrev.00/ >> >> This is a proposal to resolve the o

Re: List of previously internal APIs that are now exposed publicly?

> On Mar 21, 2017, at 10:03 AM, Paul Deitel wrote: > > Is there list somewhere of APIs that used to be internal, but are now > exported from JDK 9 modules? The exported API in jdk.xml.dom module is one case where [1] promotes these subpackages be supported APIs in

Re: RFR(S) : 8177374 : fix module dependency declaration in jdk_svc tests

> On Mar 22, 2017, at 1:09 PM, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev/8177374/webrev.00/index.html >> 40 lines changed: 26 ins; 13 del; 1 mod; > > Hi all, > > could you please review this changeset which fixes in a few jdk_svc tests > which

Re: RFR(S) : 8177374 : fix module dependency declaration in jdk_svc tests

> On Mar 22, 2017, at 4:09 PM, Igor Ignatyev wrote: > > Hi Mandy, > > I've (re)sorted @modules in all the tests which I touched -- > http://cr.openjdk.java.net/~iignatyev/8177374/webrev.01/index.html >

Re: Making jdeps aware of exported API

I considered adding an option to specify the packages to be exported. It may work fine for simple cases. It may take a prefix to avoid listing the packages individually. It’s an idea on the list to implement. On the other hand, there will be cases that we would have to edit module-info.java

Re: RFR(S) : 8177374 : fix module dependency declaration in jdk_svc tests

> On Mar 23, 2017, at 7:33 AM, Daniel Fuchs wrote: > > Hi Igor, > > small nit: > > 42 * @modules java.management > 43 * jdk.attach > 44 * jdk.management.agent/jdk.internal.agent > > I don't think java.management needs to be specified as > a

hg: jigsaw/jake/jdk: jlink generated release file should not contain the date/timestamp

Changeset: 13a7d45fdf76 Author:mchung Date: 2017-03-29 10:30 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/13a7d45fdf76 jlink generated release file should not contain the date/timestamp !

hg: jigsaw/jake/hotspot: Fix Graal/JVMCI to call Module::getPackages with right signature

Changeset: c1d6cbb4a84e Author:mchung Date: 2017-03-29 13:09 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/c1d6cbb4a84e Fix Graal/JVMCI to call Module::getPackages with right signature !

Re: 8177474: Do not emit warnings when illegal access is allowed by --add-exports/--add-opens

> On Mar 23, 2017, at 12:16 PM, Alan Bateman wrote: > > I'd like to get jdk9/dev updated to align with the latest proposal for > --add-exports/--add-opens to not emit warnings. I've put the webrev with the > changes here: > >

Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

> On Mar 23, 2017, at 11:40 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 23/03/2017 17:04, Mandy Chung wrote: > >> : >> When linking with explicit providers via —-add-modules, would you think it >> may be useful to see the list of providers? >

Re: RFR [9] 8176772: jar tool support to report automatic module names

> On Mar 16, 2017, at 6:09 AM, Chris Hegarty wrote: > > Updated webrev: > http://cr.openjdk.java.net/~chegar/8176772.01/ Looks good. thanks Mandy

hg: jigsaw/jake/jdk: Minor javadoc update of Module::getPackages

Changeset: b77bacbfb8bf Author:mchung Date: 2017-03-18 14:01 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b77bacbfb8bf Minor javadoc update of Module::getPackages ! src/java.base/share/classes/java/lang/reflect/Module.java

Re: RFR [9] 8176772: jar tool support to report automatic module names

> On Mar 15, 2017, at 8:31 AM, Chris Hegarty wrote: > > >> On 15 Mar 2017, at 14:42, Alan Bateman wrote: >> >> On 15/03/2017 14:21, Chris Hegarty wrote: >> >>> : >>> >>> Webrev: >>> >>> http://cr.openjdk.java.net/~chegar/8176772.00/ >>>

Re: RFR [9] 8176772: jar tool support to report automatic module names

> On Mar 15, 2017, at 10:12 AM, Chris Hegarty wrote: > >> >> Is there any reason why this option does not print the synthesized >> descriptor? I understand that the issue is specific to show the derived >> module name. But it’d be nice for this option to print the

Review Request: JDK-8177980: ResourceBundle.getBundle throws NoClassDefFoundError when fails to define a class

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8177980/webrev.00/ This is a simple fix. ResourceBundle::getBundle should handle LinkageError that may be thrown by Class.forName when finding a class. Mandy

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

> On Apr 4, 2017, at 12:42 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 03/04/2017 19:41, Mandy Chung wrote: > >> Webrev: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8175819/webrev.00/ >> > I went through the updates to

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

> On Apr 3, 2017, at 4:10 PM, mark.reinh...@oracle.com wrote: > > 2017/4/3 14:50:52 -0700, mandy.ch...@oracle.com: >>> On Apr 3, 2017, at 2:39 PM, mark.reinh...@oracle.com wrote: >>> 2017/4/3 13:35:30 -0700, si...@cjnash.com: ... I am not sure why we would change to osx for Mac

hg: jigsaw/jake/nashorn: Update jtreg required version to 4.2 b07

Changeset: f1d6cca3853b Author:mchung Date: 2017-04-04 22:09 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/f1d6cca3853b Update jtreg required version to 4.2 b07 ! test/TEST.ROOT

hg: jigsaw/jake/langtools: Update jtreg required version to 4.2 b07

Changeset: a564c0126103 Author:mchung Date: 2017-04-04 22:09 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/a564c0126103 Update jtreg required version to 4.2 b07 ! test/TEST.ROOT

hg: jigsaw/jake/jdk: Update jtreg required version to 4.2 b07

Changeset: 3f059be20ccb Author:mchung Date: 2017-04-04 22:09 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3f059be20ccb Update jtreg required version to 4.2 b07 ! test/TEST.ROOT

hg: jigsaw/jake/jaxp: Update jtreg required version to 4.2 b07

Changeset: d44354fed774 Author:mchung Date: 2017-04-04 22:09 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/d44354fed774 Update jtreg required version to 4.2 b07 ! test/TEST.ROOT

hg: jigsaw/jake/hotspot: Update jtreg required version to 4.2 b07

Changeset: b0076c96fadc Author:mchung Date: 2017-04-04 22:09 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/b0076c96fadc Update jtreg required version to 4.2 b07 ! test/TEST.ROOT

Re: RFR 8178323: Add negative tests for bind services Jlink feature

> On Apr 10, 2017, at 12:30 PM, Andrey Nazarov > wrote: > > Mandy, thanks for review. I’ve updated patch > http://cr.openjdk.java.net/~anazarov/8178323/webrev.01/webrev/ > > I suggest to add

Re: Issue with JavaFX and Jigsaw

d probably in a couple of javafx.beans.property.adapter classes). > > Comments? > > -- Kevin > > > Mandy Chung wrote: >> >> Hi Trisha, >> >> Thanks for the report and stack trace. I created >> https://bugs.openjdk.java.net/browse/JDK-8177566 >> &

Re: jna-platform, xalan, batik-script InvalidModuleDescriptorException

> On Apr 10, 2017, at 2:49 PM, Rahman USTA wrote: > > I try to adopt my application to Java 9. It use several 3rd party > dependency from Maven. I get the following exceptions Because I'm not the > author of this libraries, how can I adopt this libraries to my Jigsaw

Re: ResourceBundle in Java 9 Module

I created a JBS issue: https://bugs.openjdk.java.net/browse/JDK-8177980 What platform are you running on? This works on linux but I can reproduce the problem on OSX (related to case-insensitive file system). Mandy > On Apr 3, 2017, at 8:54 AM, Rabea Gransberger wrote:

Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8175819/webrev.00/ This revisits the OS name and arch in packaging JDK modules to extend the module descriptor with ModuleTarget class file attribute. We considered matching with the system properties. Linux x64 JDK can run on a system

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

> On Apr 3, 2017, at 1:35 PM, Simon Nash wrote: > > On 03/04/2017 21:15, mark.reinh...@oracle.com wrote: > > I am not sure why we would change to osx for Mac when the Mac developers > have recently dropped the Mac OS X terminology and changed it to macOS. Just to be clear,

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

> On Apr 11, 2017, at 6:45 AM, Peter Levart <peter.lev...@gmail.com> wrote: > > Hi Mandy, > > On 04/03/2017 11:50 PM, Mandy Chung wrote: >>JDK 8 JDK 9 >>- - >> OS_NAMELinux

Re: 8177530: Module system implementation refresh (4/2017)

FXLauncherTest.java should fail until FX change [1] is integrated and promoted (target for jdk-9+164). I suggest to rerun the test after jdk-9+164 is promoted and sync down to jdk9/dev and jake. Mandy [1] https://bugs.openjdk.java.net/browse/JDK-8177751 > On Apr 5, 2017, at 7:35 PM, Amy Lu

Re: RFR[9] JDK-8178840: Adds FieldSetAccessibleTest.java and VerifyJimage.java to ProblemList

> On Apr 17, 2017, at 12:07 AM, Alan Bateman wrote: > > On 17/04/2017 03:52, sha.ji...@oracle.com wrote: > >> Hi, >> Because of JDK-8178776, >> java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java and >> tools/jimage/VerifyJimage.java should be added to

Re: RFR 8178323: Add negative tests for bind services Jlink feature

> On Apr 20, 2017, at 5:12 PM, Andrey Nazarov > wrote: > > HI Mandy, > > I’ve update patch > http://cr.openjdk.java.net/~anazarov/8178323/webrev.03/webrev/ > Nit: use 4-space indent e.g.

Re: RFR: 8177845: Need a mechanism to load Graal

Since jdk.internal.vm.compiler becomes an upgradeable module, it is not hashed with java.base to allow it to be upgraded and there is no integrity check. Such qualified export will be granted to any module named jdk.internal.vm.compiler at runtime. The goal is for upgradeable modules not to

Re: RFR: 8177845: Need a mechanism to load Graal

> On Apr 19, 2017, at 12:07 PM, Doug Simon <doug.si...@oracle.com> wrote: > > >> On 19 Apr 2017, at 20:01, Mandy Chung <mandy.ch...@oracle.com> wrote: >> >> We should catch this issue and detect if VM.getSavedProperty is called when >> init leve

Re: RFR: 8177845: Need a mechanism to load Graal

> On Apr 19, 2017, at 11:55 AM, Christian Thalinger <cthalin...@twitter.com> > wrote: > > >> On Apr 19, 2017, at 8:38 AM, Mandy Chung <mandy.ch...@oracle.com> wrote: >> >> Since jdk.internal.vm.compiler becomes an upgradeable module, it

hg: jigsaw/jake/jdk: Add @spec JPMS to ThreadInfo::from

Changeset: 31ed261df102 Author:mchung Date: 2017-04-20 09:00 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/31ed261df102 Add @spec JPMS to ThreadInfo::from ! src/java.management/share/classes/java/lang/management/ThreadInfo.java

Re: Review Request: 8178404: jlink --suggest-providers should list providers from observable modules

> On Apr 18, 2017, at 7:35 AM, Alan Bateman wrote: > > For the usage message then --suggest-providers might be simpler as "Suggest > service providers that implement the given service type from the module > path". The mention of `--add-modules` could confuse readers

Re: RFR: 8177845: Need a mechanism to load Graal

> On Apr 19, 2017, at 8:03 AM, Peter Levart wrote: > > Hi Alan, > > On 04/19/2017 03:41 PM, Alan Bateman wrote: >> On 19/04/2017 08:37, Peter Levart wrote: >> >>> : >>> >>> Note that Properties class is thread-safe, while HashMap isn't. But I think >>> this should

Re: Review Request: 8179025: Exclude deployment modules from FieldSetAccessibleTest.java and VerifyJimage.java

ploy.controlpanel > jdk.plugin.server > > ...which is not to much to put in a Set.of() instance. > > There's no harm if future changes forget to add/change this set, but it would > be wrong if the rule you have now, inadvertently excludes some future module > that shou

Review Request: 8179025: Exclude deployment modules from FieldSetAccessibleTest.java and VerifyJimage.java

Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8179025/webrev.00/index.html These tests failed due to IAE when loading types from the deployment modules which are expected to be defined when running with javaws or plugin. This revises the tests to exclude these modules to remove the

Re: RFR: 8159523. Fix tests depending on absence of -limitmods in VM arguments.

> On Mar 8, 2017, at 5:21 PM, Alexandre (Shura) Iline > wrote: >> Also specifying the target explicitly makes the test clearer what it does. >> >> .addExports(“java.base/jdk.internal.reflect”, “ALL-UNNAMED”) > > Makes sense. > > I hope though that you are not

Re: RFR: 8159523. Fix tests depending on absence of -limitmods in VM arguments.

> On Mar 6, 2017, at 5:27 PM, Alexandre (Shura) Iline > wrote: > > Hi, > > Could you please review the suggested fox for: > https://bugs.openjdk.java.net/browse/JDK-8159523 > > There has been a bit of discussion on jigsaw-dev, but it perhaps make sense > to

Re: java.lang.management.RuntimeMXBean not module aware

> > On Mar 7, 2017, at 12:32 AM, Volker Simonis wrote: > > Hi, > > java.lang.management.RuntimeMXBean offers methods like getClassPath(), > getLibraryPath() and even getBootClassPath() if > isBootClassPathSupported() returns true. While > isBootClassPathSupported()

Re: mysterious _imported.marker files

> On Mar 4, 2017, at 7:46 AM, Alan Bateman wrote: > > On 03/03/2017 19:34, Roman Shevchenko wrote: > >> I see them via JRT filesystem provider. Mostly javafx.*, but also in a >> couple of jdk.* modules. >> > It looks like the issue is specific to the modules imported

Re: JDK 9 RFR of JDK-8167525: update jdk tests to remove @compile --add-modules workaround

> On Mar 7, 2017, at 7:13 PM, Amy Lu wrote: > > Please review the patch to remove the @compile --add-modules workaround. > > In the past, tests added --add-modules to @compile (JDK-8169231) or to @run > (JDK-8156579) to workaround jtreg issue CODETOOLS-7901761.

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

> On Apr 3, 2017, at 2:39 PM, mark.reinh...@oracle.com wrote: > > 2017/4/3 13:35:30 -0700, si...@cjnash.com: >> On 03/04/2017 21:15, mark.reinh...@oracle.com wrote: >>> 2017/4/3 11:41:03 -0700, mandy.ch...@oracle.com: Webrev:

Re: RFR 8178323: Add negative tests for bind services Jlink feature

> On Apr 7, 2017, at 8:40 AM, Andrey Nazarov > wrote: > > Hi, > > Please review 3 negative tests for Jlink which tests new > bind-services/suggest-providers feature. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8178323 > > webrev:

Review Request JDK-8177844: Ensure non-upgradeable modules cannot be upgraded even with --patch-module

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8177844/webrev.01/ This fixes -—patch-module to do hash checking on the module being patched so that it will ensure that a non-upgradeable module remains not upgradeable. As Graal has been using —-patch-module option to disable the hash checking to

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

> On Apr 6, 2017, at 1:09 AM, Magnus Ihse Bursie > wrote: > > > Having though this over real hard, I'd realized I need to make a plea for > sanity and consistency. I thought I should lay low in this discussion, but I > can't. Choosing "amd64" as the name for

Review Request: JDK-8178286 Missing @moduleGraph in javadoc

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8178286/webrev.00/index.html This adds @moduleGraph in a few more modules that will be included in unified docs bundle. Mandy

Re: Review Request JDK-8177844: Ensure non-upgradeable modules cannot be upgraded even with --patch-module

> On Apr 8, 2017, at 12:21 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 08/04/2017 06:50, Mandy Chung wrote: > >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8177844/webrev.01/ >> >> This fixes -—patch-module to do hash checki

Re: Review Request JDK-8177844: Ensure non-upgradeable modules cannot be upgraded even with --patch-module

017, at 7:22 AM, Remi Forax <fo...@univ-mlv.fr> wrote: > > Hi Mandy, > how can I test a change in java.lang after that patch ? > > Rémi > > > On April 8, 2017 7:50:50 AM GMT+02:00, Mandy Chung <mandy.ch...@oracle.com> > wrote: > http://cr.openjdk.ja

hg: jigsaw/jake/jdk: 8177844: Ensure non-upgradeable modules cannot be upgraded even with --patch-module

Changeset: b2160414fe8c Author:mchung Date: 2017-04-08 10:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b2160414fe8c 8177844: Ensure non-upgradeable modules cannot be upgraded even with --patch-module Reviewed-by: alanb !

Re: RFR: 8177845: Need a mechanism to load Graal

> On Apr 18, 2017, at 3:13 PM, Doug Simon wrote: > > Please review these changes that make jdk.internal.vm.compiler an upgradable > compiler. > : > http://cr.openjdk.java.net/~dnsimon/8177845/ Thanks for making this change. This would simplify the way to replace JDK’s

Re: Allow ModuleInfoExtender to be used externally

On 8/9/17 7:39 AM, Oliver Siegmar wrote: Hello, I have to create a Java 9 modularized jar file programmatically. I noticed, that the compiled module-info.class file gets modified (main-class, module-version and modules-hash) by the jar command line tool (using

hg: jigsaw/jake/jdk: Replace jmod --os-name/--os-arch option with --target-platform

Changeset: c5621b8c5c91 Author:mchung Date: 2017-04-26 19:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c5621b8c5c91 Replace jmod --os-name/--os-arch option with --target-platform ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java !

hg: jigsaw/jake: Replace jmod --os-name/--os-arch option with --target-platform

Changeset: 7e790234d48f Author:mchung Date: 2017-04-26 19:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/7e790234d48f Replace jmod --os-name/--os-arch option with --target-platform ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 !

Re: RFR: 8179434: test/java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java fails due to JDK-8177845

Looks good. Mandy > On Apr 28, 2017, at 12:05 PM, Doug Simon wrote: > > Please review this small fix for a regression introduced by the change for > https://bugs.openjdk.java.net/browse/JDK-8177845. > > http://cr.openjdk.java.net/~dnsimon/8179434/ >

Re: Review Request: 8179025: Exclude deployment modules from FieldSetAccessibleTest.java and VerifyJimage.java

> On Apr 23, 2017, at 4:09 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 22/04/2017 16:42, Mandy Chung wrote: > >> Have an explicit list is another alternative. OTOH I think only deployment >> modules will name with these words though which was what

Re: RFR: 8177845: Need a mechanism to load Graal

> On Apr 27, 2017, at 2:30 PM, Doug Simon <doug.si...@oracle.com> wrote: > > >> On 27 Apr 2017, at 23:24, Mandy Chung <mandy.ch...@oracle.com> wrote: >> >> >>> On Apr 27, 2017, at 7:47 AM, Doug Simon <doug.si...@oracle.com> wrote: >&

Re: RFR: 8177845: Need a mechanism to load Graal

> On Apr 27, 2017, at 7:47 AM, Doug Simon wrote: > > [1] http://cr.openjdk.java.net/~dnsimon/8177845.02 I reviewed the top repo and jdk repo change. For hotspot change, I reviewed jdk.vm.ci.services/* and jdk.internal.vm.ci module-info.java.

Re: 8185853: Generate readability graph at link time and other startup improvements

On 8/4/17 8:48 AM, Alan Bateman wrote: This is a patch for jdk10/jdk10 to claw back some of the regression to startup performance in JDK 9 for very short lived applications. The bulk of the changes are to the "system modules" jlink plugin and the related code in the module system

Re: """error: module testng reads package test from both test and testng"""

run but my local jtreg works fine.  Jon may have jtreg debugging tip. Mandy On 8/22/17 6:18 PM, Martin Buchholz wrote: I also tried upgrading jcommander.jar to 1.72 from 1.48, but get the same error. Debugging hints? On Tue, Aug 22, 2017 at 4:28 PM, mandy chung <mandy.ch...@oracle.

Re: trySetAccessible​

As described in the javadoc [1], Module::isOpen(String pn) returns true if this module has opened a package unconditionally. It returns true only if the module declares "opens pn;" unconditionally in module-info.java.  Since java.base does not open "java.io" unconditionally, so

Re: """error: module testng reads package test from both test and testng"""

strange that the javac reports that "the unnamed module reads package xxx from ".  I will create a JBS issue on improving the error message. Mandy On 8/21/17 4:06 PM, mandy chung wrote: I can reproduce it and javac outputs the following errors.  javac compiles successfully i

Re: """error: module testng reads package test from both test and testng"""

On 8/22/17 3:52 PM, Martin Buchholz wrote: : ACTION: testng -- Failed. Unexpected exit from test [exit code: 1] REASON: User specified action: run testng/othervm test/test.Main TIME:   0.215 seconds messages: command: testng test/test.Main reason: User specified action: run testng/othervm

Re: """error: module testng reads package test from both test and testng"""

On 8/22/17 2:55 PM, Martin Buchholz wrote: On Tue, Aug 22, 2017 at 12:38 PM, mandy chung <mandy.ch...@oracle.com <mailto:mandy.ch...@oracle.com>> wrote: Does your testng.jar contain classes of package "test"?   I downloaded testng from maven which does not

hg: jigsaw/jake/jdk: Add @apiNote in ClassLoader::getPackage(s) about platform class loader

Changeset: fa1e20c4e6c1 Author:mchung Date: 2017-05-02 17:20 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/fa1e20c4e6c1 Add @apiNote in ClassLoader::getPackage(s) about platform class loader ! src/java.base/share/classes/java/lang/ClassLoader.java

Review Request: JDK-8020801: Apply the restriction of invoking MethodHandles.lookup to j.l.r.Method.invoke

Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8020801/webrev.00/ The big hammer check disallowing MethodHandles::lookup be called by system classes defined by the bootstrap class loader was added as defense-in-depth to prevent this caller-sensitive method being called from JDK

Re: 8178380: Module system implementation refresh (5/2017 update)

> On May 1, 2017, at 1:28 PM, Alan Bateman wrote: > > The webrevs with the changes is here: >http://cr.openjdk.java.net/~alanb/8178380/1/ I have reviewed all repos. Mostly looks good. This is the first round of comments. I will continue the review and plan to

hg: jigsaw/jake/jdk: Minor tweak to the api note

Changeset: 654588131ea2 Author:mchung Date: 2017-05-03 08:59 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/654588131ea2 Minor tweak to the api note ! src/java.base/share/classes/java/lang/ClassLoader.java

hg: jigsaw/jake/jdk: 2 new changesets

Changeset: f1ee71109b07 Author:mchung Date: 2017-05-03 19:01 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f1ee71109b07 Fix IntegrationTest.java test to check JAVA_FULL_VERSION ! test/tools/jlink/IntegrationTest.java Changeset: 00902040a130 Author:mchung Date:

Re: 8178380: Module system implementation refresh (5/2017 update)

> On May 1, 2017, at 1:28 PM, Alan Bateman wrote: > >http://cr.openjdk.java.net/~alanb/8178380/2/ I reviewed all repos in the new version. src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java 148 if

Re: #AddExportsInManifest

These two attributes are defined to ease migration so that executable JARs can run with java -jar command, as is today, to avoid adding command-line options to break into encapsulation. Mandy [1] http://openjdk.java.net/projects/jigsaw/spec/issues/#AddExportsInManifest > On May 11, 2017, at

Re: jdeps --generate-open-module

> On May 15, 2017, at 12:43 PM, Sander Mak wrote: > > When executing `jdeps --generate-module-info ./out `, a module > descriptor exporting all packages is created. When using > `--generate-open-module`, a module descriptor with an open module is > generated, but no

Re: Problems with non-exported split packages (for resources/files)

On May 9, 2017, at 1:33 PM, Sven Strohschein wrote: > > There is a very practical example which isn't a bad practice: Resources. > Imagine that every Java module has its own ResourceBundle properties for > multi-language support (or imagine any other file which is not a Java

Re: 8182482: Module System spec updates

> On Jun 20, 2017, at 3:20 AM, Alan Bateman wrote: > > The webrev with the proposed (docs only, no implementation) changes is here: > http://cr.openjdk.java.net/~alanb/8182482/webrev/index.html > > The ServiceLoader diffs are hard to read. It might be easier to read

hg: jigsaw/jake/jdk: Fix typo in launcher help message

Changeset: 0491912f8410 Author:mchung Date: 2017-05-25 14:43 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0491912f8410 Fix typo in launcher help message ! src/java.base/share/classes/sun/launcher/resources/launcher.properties

hg: jigsaw/jake/hotspot: 14 new changesets

Changeset: 507f8a7678b4 Author:mcberg Date: 2017-05-16 12:55 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/507f8a7678b4 8178800: compiler/c2/PolynomialRoot.java fails on Xeon Phi linux host with UseAVX=3 Summary: upper register bank support added for novl machines

hg: jigsaw/jake/nashorn: 2 new changesets

Changeset: c8d6b740f0f7 Author:lana Date: 2017-05-26 00:29 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/c8d6b740f0f7 Added tag jdk-9+171 for changeset fc416270a776 ! .hgtags Changeset: 3e76e17ddd2a Author:mchung Date: 2017-05-25 19:50 -0700 URL:

hg: jigsaw/jake/jaxws: 2 new changesets

Changeset: 8c615099f3e3 Author:lana Date: 2017-05-26 00:29 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/8c615099f3e3 Added tag jdk-9+171 for changeset 139e7c786ee4 ! .hgtags Changeset: a8760921acb7 Author:mchung Date: 2017-05-25 19:49 -0700 URL:

hg: jigsaw/jake/jdk: 15 new changesets

Changeset: 78ce7067aba9 Author:bpb Date: 2017-05-16 14:11 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/78ce7067aba9 8180431: Remove intermittent keyword from some no longer failing NIO tests Summary: Remove "intermittent" keyword from @key tag, Reviewed-by: alanb !

hg: jigsaw/jake/corba: 2 new changesets

Changeset: 95ed14547ca9 Author:lana Date: 2017-05-26 00:29 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/95ed14547ca9 Added tag jdk-9+171 for changeset c62e5964cfcf ! .hgtags Changeset: 117bfab0a8bd Author:mchung Date: 2017-05-25 19:49 -0700 URL:

hg: jigsaw/jake/langtools: 2 new changesets

Changeset: 65652f51a99a Author:lana Date: 2017-05-26 00:29 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/65652f51a99a Added tag jdk-9+171 for changeset aae59039c1f5 ! .hgtags Changeset: 88aaba14239f Author:mchung Date: 2017-05-25 19:49 -0700 URL:

<    3   4   5   6   7   8   9   10   >