JEP-282: JLink two modules exporting the same package name

2016-10-12 Thread Karl Heinz Marbaise
Hi, i have a question concerning the jlink command in JDK 9..(EA +138 build) I have created two modules lets call them module A and module B (module-info.java): module A { requires java.base; exports com.single.package; } module B { requires java.base; exports

RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

2016-10-12 Thread Sundararajan Athijegannathan
Bug: https://bugs.openjdk.java.net/browse/JDK-8167614 jdk webrev: http://cr.openjdk.java.net/~sundar/8167614/jdk/webrev.00/ nashorn webrev: http://cr.openjdk.java.net/~sundar/8167614/nashorn/webrev.00/ Thanks, -Sundar

Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

2016-10-12 Thread Sundararajan Athijegannathan
Dynalink normally uses unreflect with publicLookup to get method handles for j.l.reflect.Method objects (found reflectively). But, publicLookup can not be used to unreflect caller sensitive methods. So, dynalink uses specific Lookup object from the callsite - for example, lookup of the Nashorn

Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

2016-10-12 Thread Alan Bateman
On 12/10/2016 16:11, Sundararajan Athijegannathan wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8167614 jdk webrev: http://cr.openjdk.java.net/~sundar/8167614/jdk/webrev.00/ nashorn webrev: http://cr.openjdk.java.net/~sundar/8167614/nashorn/webrev.00/ In

Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

2016-10-12 Thread Jim Laskey (Oracle)
+1 > On Oct 12, 2016, at 12:11 PM, Sundararajan Athijegannathan > wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8167614 > > jdk webrev: http://cr.openjdk.java.net/~sundar/8167614/jdk/webrev.00/ > > nashorn webrev: >

Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

2016-10-12 Thread Sundararajan Athijegannathan
Updated nashorn webrev: http://cr.openjdk.java.net/~sundar/8167614/nashorn/webrev.01/ Changed to use Layer.boot().findModule. Thanks -Sundar On 10/12/2016 9:42 PM, Alan Bateman wrote: > On 12/10/2016 16:33, Sundararajan Athijegannathan wrote: > >> : >> >> Dynalink used to automatically add

Re: JEP-282: JLink two modules exporting the same package name

2016-10-12 Thread Alex Buckley
In general, there is no problem with modules in the image or on the modulepath that contain and export the same package. The problem comes when a single module requires two other modules which both contain and export the same package. There is no such single module in the image you're creating

Re: JEP-282: JLink two modules exporting the same package name

2016-10-12 Thread Alan Bateman
On 12/10/2016 19:17, Karl Heinz Marbaise wrote: Hi, i have a question concerning the jlink command in JDK 9..(EA +138 build) I have created two modules lets call them module A and module B (module-info.java): module A { requires java.base; exports com.single.package; } module B {

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

2016-10-12 Thread Steve Drach
Hi, Please review the latest webrev for this issue. issue: https://bugs.openjdk.java.net/browse/JDK-8156499 webrev: http://cr.openjdk.java.net/~sdrach/8156499/webrev.03/ I believe this

Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

2016-10-12 Thread Alan Bateman
On 12/10/2016 16:33, Sundararajan Athijegannathan wrote: : Dynalink used to automatically add those necessary add edges. With the current change, nashorn adds necessary read edges. CallerSensitive methods are found only in java.base, java.logging, java.sql and java.sql.rowset modules - the

Review Request: JDK-8167558 Add new JMOD section for header files and man pages

2016-10-12 Thread Mandy Chung
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8167558/webrev.00/ Header files and man pages are currently copied to the image. The header files are modularized and in the following directory: src/$MODULE/share/native/include The man page for the corresponding tool should also

Re: JEP-282: JLink two modules exporting the same package name

2016-10-12 Thread Sundararajan Athijegannathan
If you want to enforce that kind of consistency - that no two application modules should export same named package - it should be possible to implement a user defined jlink plugin to enforce the same. -Sundar On 10/13/2016 12:35 AM, Alan Bateman wrote: > On 12/10/2016 19:17, Karl Heinz Marbaise