On 14/02/2017 15:56, Sundararajan Athijegannathan wrote:
Yes - because the test module's name is "inconsistentJar" and jlink
adds module name to the error message.
-Sundar
Got it, I thought it was a typo initially.
-Alan.
+1
> On Feb 14, 2017, at 9:52 AM, Sundararajan Athijegannathan
> wrote:
>
> Please review http://cr.openjdk.java.net/~sundar/8174718/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8174718
>
> Thanks,
> -Sundar
On 14/02/2017 13:52, Sundararajan Athijegannathan wrote:
Please review http://cr.openjdk.java.net/~sundar/8174718/webrev.00/
for https://bugs.openjdk.java.net/browse/JDK-8174718
Is the output matching in the test correct to check for "Module
inconsistentJar's descriptor ..."?
-Alan
> On Feb 14, 2017, at 5:52 AM, Sundararajan Athijegannathan
> wrote:
>
> Please review http://cr.openjdk.java.net/~sundar/8174718/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8174718
JLinkNegativeTest.java - line 352 is not really needed.
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173374/webrev.00/
This is the first step to enable generating dot graph to be
included in module summary javadoc, if desired. jdeps already
supports generating the dot graph for modules. This patch
converts GenGraphs build tool to use jdeps
2017/2/13 9:17:47 -0800, Guillaume Smet :
> On Mon, Feb 13, 2017 at 6:10 PM, alan.bate...@oracle.com wrote:
>> On 13/02/2017 16:58, Guillaume Smet wrote:
>>> On Mon, Feb 13, 2017 at 5:12 PM, alan.bate...@oracle.com wrote:
I agree that @Generated is awkward but I
On 14/02/17 13:34, Doug Simon wrote:
> I don’t know how one patches a module in the middle of the module
> graph. That is, we use --patch-module and --upgrade-module-path to
> override the jdk.vm.compiler module in the JDK. I don’t know what
> that means for modules such as jdk.aot that depend on
On 14/02/2017 14:20, Andrew Haley wrote:
On 14/02/17 13:34, Doug Simon wrote:
I don’t know how one patches a module in the middle of the module
graph. That is, we use --patch-module and --upgrade-module-path to
override the jdk.vm.compiler module in the JDK. I don’t know what
that means for
On 14/02/17 14:37, Alan Bateman wrote:
> --patch-module can be used to patch any module in the boot layer. So if
> you are looking to override or add classes then --patch-module should work.
Aha! Thanks,
Andrew.