[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433636236 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -732,11 +614,8 @@ public void

[GitHub] [kafka] mjsax commented on pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check

2020-06-01 Thread GitBox
mjsax commented on pull request #8774: URL: https://github.com/apache/kafka/pull/8774#issuecomment-637291533 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] guozhangwang commented on pull request #8773: MINOR: ChangelogReader should poll for duration 0 for standby restore

2020-06-01 Thread GitBox
guozhangwang commented on pull request #8773: URL: https://github.com/apache/kafka/pull/8773#issuecomment-637287886 cherry-picked to 2.6 as well. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] guozhangwang merged pull request #8773: MINOR: ChangelogReader should poll for duration 0 for standby restore

2020-06-01 Thread GitBox
guozhangwang merged pull request #8773: URL: https://github.com/apache/kafka/pull/8773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman opened a new pull request #8775: KAFKA-10079: improve thread-level stickiness

2020-06-01 Thread GitBox
ableegoldman opened a new pull request #8775: URL: https://github.com/apache/kafka/pull/8775 Uses a similar (but slightly different) algorithm as in [KAFKA-9987](https://issues.apache.org/jira/browse/KAFKA-9987) to produce a maximally sticky -- and perfectly balanced -- assignment of

[jira] [Updated] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-01 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9800: - Summary: [KIP-580] Client Exponential Backoff Implementation (was: [KIP-580] Admin Client Exponential

[GitHub] [kafka] showuon commented on pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check

2020-06-01 Thread GitBox
showuon commented on pull request #8774: URL: https://github.com/apache/kafka/pull/8774#issuecomment-637264975 @mjsax @ableegoldman @abbccdda , could you review this PR since it keeps breaking the recent builds. This is an

[GitHub] [kafka] showuon opened a new pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check

2020-06-01 Thread GitBox
showuon opened a new pull request #8774: URL: https://github.com/apache/kafka/pull/8774 Investigate why the spotbugs failed, and find that there's a warning to an unused local variable. > Dead store to isFreshAssignment in

[jira] [Updated] (KAFKA-10081) Execution failed for task ':clients:spotbugsMain' in recent build

2020-06-01 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-10081: -- Description: : Task failed with an exception. --- * What went wrong: Execution failed for

[jira] [Created] (KAFKA-10081) Execution failed for task ':clients:spotbugsMain' in recent build

2020-06-01 Thread Luke Chen (Jira)
Luke Chen created KAFKA-10081: - Summary: Execution failed for task ':clients:spotbugsMain' in recent build Key: KAFKA-10081 URL: https://issues.apache.org/jira/browse/KAFKA-10081 Project: Kafka

[GitHub] [kafka] abbccdda commented on pull request #8421: KAFKA-9800: [KIP-580] Admin Client Exponential Backoff Implementation

2020-06-01 Thread GitBox
abbccdda commented on pull request #8421: URL: https://github.com/apache/kafka/pull/8421#issuecomment-637254109 In addition, could you run the checkstyle on local to make sure everything passes? @d8tltanc This is an

[GitHub] [kafka] abbccdda commented on a change in pull request #8421: KAFKA-9800: [KIP-580] Admin Client Exponential Backoff Implementation

2020-06-01 Thread GitBox
abbccdda commented on a change in pull request #8421: URL: https://github.com/apache/kafka/pull/8421#discussion_r433603033 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -1309,7 +1362,8 @@ private void processRequests() {

[GitHub] [kafka] chia7712 commented on a change in pull request #8759: KAFKA-10066: TestOutputTopic should pass record headers into deserializers

2020-06-01 Thread GitBox
chia7712 commented on a change in pull request #8759: URL: https://github.com/apache/kafka/pull/8759#discussion_r433596501 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -906,8 +906,8 @@ public void

[jira] [Created] (KAFKA-10080) IllegalStateException after duplicate CompleteCommit append to transaction log

2020-06-01 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10080: --- Summary: IllegalStateException after duplicate CompleteCommit append to transaction log Key: KAFKA-10080 URL: https://issues.apache.org/jira/browse/KAFKA-10080

[GitHub] [kafka] rhauch merged pull request #8746: Bump trunk to 2.7.0-SNAPSHOT

2020-06-01 Thread GitBox
rhauch merged pull request #8746: URL: https://github.com/apache/kafka/pull/8746 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mjsax commented on pull request #8706: KAFKA-10030 allow fetching a key from a single partition

2020-06-01 Thread GitBox
mjsax commented on pull request #8706: URL: https://github.com/apache/kafka/pull/8706#issuecomment-637215804 Thanks for the PR @dima5rr. Merged to `trunk` and cherry-picked to `2.6` and `2.5` branches. This is an

[jira] [Resolved] (KAFKA-10030) Throw exception while fetching a key from a single partition

2020-06-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-10030. - Resolution: Fixed > Throw exception while fetching a key from a single partition >

[GitHub] [kafka] mjsax merged pull request #8706: KAFKA-10030 allow fetching a key from a single partition

2020-06-01 Thread GitBox
mjsax merged pull request #8706: URL: https://github.com/apache/kafka/pull/8706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on a change in pull request #8759: KAFKA-10066: TestOutputTopic should pass record headers into deserializers

2020-06-01 Thread GitBox
mjsax commented on a change in pull request #8759: URL: https://github.com/apache/kafka/pull/8759#discussion_r433564798 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -906,8 +906,8 @@ public void

[GitHub] [kafka] guozhangwang commented on pull request #8773: MINOR: ChangelogReader should poll for duration 0 for standby restore

2020-06-01 Thread GitBox
guozhangwang commented on pull request #8773: URL: https://github.com/apache/kafka/pull/8773#issuecomment-637204885 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] mjsax commented on a change in pull request #8771: MINOR: Add explanation for disabling forwarding from value transformers

2020-06-01 Thread GitBox
mjsax commented on a change in pull request #8771: URL: https://github.com/apache/kafka/pull/8771#discussion_r433563327 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ForwardingDisabledProcessorContext.java ## @@ -40,6 +40,10 @@ public final

[GitHub] [kafka] mjsax commented on pull request #8771: MINOR: Add explanation for disabling forwarding from value transformers

2020-06-01 Thread GitBox
mjsax commented on pull request #8771: URL: https://github.com/apache/kafka/pull/8771#issuecomment-637203468 @astubbs -- build failed with SpotBug error This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] mjsax commented on pull request #8771: Add explanation for disabling forwarding from value transformers

2020-06-01 Thread GitBox
mjsax commented on pull request #8771: URL: https://github.com/apache/kafka/pull/8771#issuecomment-637197021 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax merged pull request #8772: MINOR: clarify exception throwing in allStorePartitionLags javadocs

2020-06-01 Thread GitBox
mjsax merged pull request #8772: URL: https://github.com/apache/kafka/pull/8772 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #8760: Kafka-10064 Add documentation for KIP-571

2020-06-01 Thread GitBox
mjsax commented on pull request #8760: URL: https://github.com/apache/kafka/pull/8760#issuecomment-637194598 Thanks for the PR @feyman2016. Merged to `trunk` and cherry-picked to `2.6` branch. This is an automated

[GitHub] [kafka] mjsax merged pull request #8760: Kafka-10064 Add documentation for KIP-571

2020-06-01 Thread GitBox
mjsax merged pull request #8760: URL: https://github.com/apache/kafka/pull/8760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (KAFKA-10064) Add documentation for KIP-571

2020-06-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-10064. - Resolution: Fixed > Add documentation for KIP-571 > - > >

[GitHub] [kafka] kkonstantine merged pull request #8762: MINOR: Remove no longer used ReflectionsUtil class

2020-06-01 Thread GitBox
kkonstantine merged pull request #8762: URL: https://github.com/apache/kafka/pull/8762 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] kkonstantine commented on pull request #8762: MINOR: Remove no longer used ReflectionsUtil class

2020-06-01 Thread GitBox
kkonstantine commented on pull request #8762: URL: https://github.com/apache/kafka/pull/8762#issuecomment-637191967 2/3 builds were green. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] kkonstantine commented on pull request #8750: MINOR: Code cleanup and assertion message fixes in Connect integration tests

2020-06-01 Thread GitBox
kkonstantine commented on pull request #8750: URL: https://github.com/apache/kafka/pull/8750#issuecomment-637189748 Merged to `trunk` and backported to `2.6` This is an automated message from the Apache Git Service. To

[GitHub] [kafka] kkonstantine merged pull request #8750: MINOR: Code cleanup and assertion message fixes in Connect integration tests

2020-06-01 Thread GitBox
kkonstantine merged pull request #8750: URL: https://github.com/apache/kafka/pull/8750 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] badaiaqrandista commented on a change in pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

2020-06-01 Thread GitBox
badaiaqrandista commented on a change in pull request #8644: URL: https://github.com/apache/kafka/pull/8644#discussion_r433548142 ## File path: clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java ## @@ -102,7 +102,7 @@ public void

[GitHub] [kafka] badaiaqrandista commented on a change in pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

2020-06-01 Thread GitBox
badaiaqrandista commented on a change in pull request #8644: URL: https://github.com/apache/kafka/pull/8644#discussion_r433547561 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientUtils.java ## @@ -108,10 +108,11 @@ public static ChannelBuilder

[GitHub] [kafka] kkonstantine commented on a change in pull request #8755: KAFKA-10069 The user-defined "predicate" and "negate" are not removed…

2020-06-01 Thread GitBox
kkonstantine commented on a change in pull request #8755: URL: https://github.com/apache/kafka/pull/8755#discussion_r433538453 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ConnectorConfigTest.java ## @@ -434,5 +436,59 @@ public void

[GitHub] [kafka] badaiaqrandista commented on a change in pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

2020-06-01 Thread GitBox
badaiaqrandista commented on a change in pull request #8644: URL: https://github.com/apache/kafka/pull/8644#discussion_r433544226 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientUtils.java ## @@ -108,10 +108,15 @@ public static ChannelBuilder

[GitHub] [kafka] badaiaqrandista commented on a change in pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

2020-06-01 Thread GitBox
badaiaqrandista commented on a change in pull request #8644: URL: https://github.com/apache/kafka/pull/8644#discussion_r433543985 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientDnsLookup.java ## @@ -22,7 +22,8 @@ DEFAULT("default"),

[GitHub] [kafka] guozhangwang commented on pull request #8668: KAFKA-9987: optimize sticky assignment algorithm for same-subscription case

2020-06-01 Thread GitBox
guozhangwang commented on pull request #8668: URL: https://github.com/apache/kafka/pull/8668#issuecomment-637175464 Cherry-picked to 2.6/2.5/2.4. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] guozhangwang merged pull request #8668: KAFKA-9987: optimize sticky assignment algorithm for same-subscription case

2020-06-01 Thread GitBox
guozhangwang merged pull request #8668: URL: https://github.com/apache/kafka/pull/8668 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on a change in pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-01 Thread GitBox
guozhangwang commented on a change in pull request #8764: URL: https://github.com/apache/kafka/pull/8764#discussion_r433531737 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/SourceNode.java ## @@ -87,10 +87,13 @@ public void init(final

[GitHub] [kafka] rodesai opened a new pull request #8773: WIP: poll for duration 0 for standby restore

2020-06-01 Thread GitBox
rodesai opened a new pull request #8773: URL: https://github.com/apache/kafka/pull/8773 polling for standby replicas should not block, so use a duration of 0. Still working on a test. This is an automated message from the

[jira] [Commented] (KAFKA-9987) Improve sticky partition assignor algorithm

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121378#comment-17121378 ] Sophie Blee-Goldman commented on KAFKA-9987: Not as far as I know. It should be in the

[GitHub] [kafka] ableegoldman commented on pull request #8668: KAFKA-9987: optimize sticky assignment algorithm for same-subscription case

2020-06-01 Thread GitBox
ableegoldman commented on pull request #8668: URL: https://github.com/apache/kafka/pull/8668#issuecomment-637154355 @twmb yeah, I should point out in the ticket that this approach drops the optimization giving preference to older-generation owners of a partition. I actually don't think it

[jira] [Commented] (KAFKA-9148) Consider forking RocksDB for Streams

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121356#comment-17121356 ] Sophie Blee-Goldman commented on KAFKA-9148: Unfortunately we still haven't been able to

[GitHub] [kafka] vvcephei commented on a change in pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-01 Thread GitBox
vvcephei commented on a change in pull request #8764: URL: https://github.com/apache/kafka/pull/8764#discussion_r433487600 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapperSerde.java ## @@ -63,9 +63,9 @@ public

[GitHub] [kafka] bellemare commented on a change in pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-01 Thread GitBox
bellemare commented on a change in pull request #8764: URL: https://github.com/apache/kafka/pull/8764#discussion_r433486855 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinMaterializationIntegrationTest.java ## @@ -94,15

[GitHub] [kafka] vvcephei commented on a change in pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-01 Thread GitBox
vvcephei commented on a change in pull request #8764: URL: https://github.com/apache/kafka/pull/8764#discussion_r433487031 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapperSerde.java ## @@ -63,9 +63,9 @@ public

[GitHub] [kafka] bellemare commented on a change in pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-01 Thread GitBox
bellemare commented on a change in pull request #8764: URL: https://github.com/apache/kafka/pull/8764#discussion_r433486418 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java ## @@ -66,10 +66,13 @@ public void init(final

[jira] [Updated] (KAFKA-10079) Improve thread-level stickiness of stateful tasks

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10079: Description: Now that KAFKA-9501 is fixed, we should make sure that KIP-441 will

[jira] [Updated] (KAFKA-10079) Improve thread-level stickiness of stateful tasks

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10079: Summary: Improve thread-level stickiness of stateful tasks (was: Support high

[jira] [Updated] (KAFKA-10068) Verify HighAvailabilityTaskAssignor performance with large clusters and topologies

2020-06-01 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10068: - Fix Version/s: 2.6.0 > Verify HighAvailabilityTaskAssignor performance with large clusters and

[jira] [Commented] (KAFKA-10068) Verify HighAvailabilityTaskAssignor performance with large clusters and topologies

2020-06-01 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121323#comment-17121323 ] John Roesler commented on KAFKA-10068: -- Thanks, [~ableegoldman] , that is indeed what I meant. >

[GitHub] [kafka] vvcephei commented on pull request #7693: MINOR: Fix Streams EOS system tests by adding clean-up of state dir

2020-06-01 Thread GitBox
vvcephei commented on pull request #7693: URL: https://github.com/apache/kafka/pull/7693#issuecomment-637093964 Cherry-picked to 1.0 (along with #6797 and #6898) ``` test_id: kafkatest.tests.streams.streams_eos_test.StreamsEosTest.test_rebalance_complex status: PASS run

[jira] [Assigned] (KAFKA-10077) Filter downstream of state-store results in suprious tombstones

2020-06-01 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Coates reassigned KAFKA-10077: --- Assignee: Andy Coates > Filter downstream of state-store results in suprious tombstones >

[GitHub] [kafka] vvcephei commented on pull request #7693: MINOR: Fix Streams EOS system tests by adding clean-up of state dir

2020-06-01 Thread GitBox
vvcephei commented on pull request #7693: URL: https://github.com/apache/kafka/pull/7693#issuecomment-637087091 Cherry-picked to 1.1 (along with #6797 and #6898 so that it's possible to actually run the test in docker) ``` test_id:

[GitHub] [kafka] guozhangwang commented on pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-01 Thread GitBox
guozhangwang commented on pull request #8764: URL: https://github.com/apache/kafka/pull/8764#issuecomment-637075135 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] junrao commented on a change in pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-06-01 Thread GitBox
junrao commented on a change in pull request #8680: URL: https://github.com/apache/kafka/pull/8680#discussion_r432781217 ## File path: core/src/main/scala/kafka/zk/ZkData.scala ## @@ -22,7 +22,7 @@ import java.util.Properties import

[jira] [Created] (KAFKA-10079) Support high availability for in-memory stores

2020-06-01 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10079: --- Summary: Support high availability for in-memory stores Key: KAFKA-10079 URL: https://issues.apache.org/jira/browse/KAFKA-10079 Project: Kafka

[GitHub] [kafka] vvcephei commented on pull request #7693: MINOR: Fix Streams EOS system tests by adding clean-up of state dir

2020-06-01 Thread GitBox
vvcephei commented on pull request #7693: URL: https://github.com/apache/kafka/pull/7693#issuecomment-637057829 Cherry-picked to 2.0 (along with #6898) ``` test_id: kafkatest.tests.streams.streams_eos_test.StreamsEosTest.test_rebalance_complex status: PASS run time:

[jira] [Commented] (KAFKA-6502) Kafka streams deserialization handler not committing offsets on error records

2020-06-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121269#comment-17121269 ] Guozhang Wang commented on KAFKA-6502: -- I think it is not fixed via KAFKA-6607 since if the

[jira] [Resolved] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-9821. Resolution: Fixed > Stream task may skip assignment with static members and

[jira] [Updated] (KAFKA-10078) Partition may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10078: Description: When static membership (KIP-345) and incremental rebalancing

[jira] [Assigned] (KAFKA-10078) Partition may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-10078: --- Assignee: (was: Sophie Blee-Goldman) > Partition may skip assignment

[jira] [Updated] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Description: When static membership (KIP-345) and incremental rebalancing (KIP-429)

[jira] [Updated] (KAFKA-10078) Stream tasks may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10078: Component/s: (was: streams) consumer > Stream tasks may skip

[jira] [Assigned] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-9821: -- Assignee: Sophie Blee-Goldman > Stream task may skip assignment with static

[jira] [Updated] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Fix Version/s: 2.6.0 > Stream task may skip assignment with static members and

[jira] [Updated] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Affects Version/s: 2.4.0 > Stream task may skip assignment with static members and

[jira] [Updated] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Summary: Stream task may skip assignment with static members and incremental

[jira] [Updated] (KAFKA-10078) Partition may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10078: Summary: Partition may skip assignment with static members and incremental

[jira] [Updated] (KAFKA-10078) Stream tasks may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10078: Fix Version/s: (was: 2.6.0) > Stream tasks may skip assignment with static

[jira] [Updated] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Labels: (was: need-kip) > Stream task may skip assignment with static members and

[jira] [Updated] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Component/s: (was: consumer) streams > Stream task may skip

[jira] [Updated] (KAFKA-9821) Partition may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Description: When static membership (KIP-345) and incremental rebalancing (KIP-429)

[jira] [Updated] (KAFKA-10078) Stream tasks may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10078: Summary: Stream tasks may skip assignment with static members and incremental

[jira] [Created] (KAFKA-10078) Partition may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10078: --- Summary: Partition may skip assignment with static members and incremental rebalances Key: KAFKA-10078 URL: https://issues.apache.org/jira/browse/KAFKA-10078

[jira] [Updated] (KAFKA-9821) Partition may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Component/s: (was: streams) > Partition may skip assignment with static members

[GitHub] [kafka] vvcephei commented on pull request #7693: MINOR: Fix Streams EOS system tests by adding clean-up of state dir

2020-06-01 Thread GitBox
vvcephei commented on pull request #7693: URL: https://github.com/apache/kafka/pull/7693#issuecomment-637046212 Cherry-picked to 2.1: ``` test_id: kafkatest.tests.streams.streams_eos_test.StreamsEosTest.test_rebalance_complex status: PASS run time: 3 minutes 41.565

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433413250 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -732,11 +614,8 @@ public void testUnsupportedCiphers()

[jira] [Comment Edited] (KAFKA-6502) Kafka streams deserialization handler not committing offsets on error records

2020-06-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121235#comment-17121235 ] Matthias J. Sax edited comment on KAFKA-6502 at 6/1/20, 6:30 PM: -

[jira] [Commented] (KAFKA-6502) Kafka streams deserialization handler not committing offsets on error records

2020-06-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121235#comment-17121235 ] Matthias J. Sax commented on KAFKA-6502: [~guozhang] I think this issue is fixed via 

[GitHub] [kafka] twmb commented on pull request #8668: KAFKA-9987: optimize sticky assignment algorithm for same-subscription case

2020-06-01 Thread GitBox
twmb commented on pull request #8668: URL: https://github.com/apache/kafka/pull/8668#issuecomment-637026123 From what I can tell, this looks good to me. This loses one mostly insignificant "optimization" that does not really affect anything in reality: prior, if an old-generation member

[jira] [Resolved] (KAFKA-10011) lockedTaskDirectories should be cleared when task gets closed dirty in HandleLostAll

2020-06-01 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-10011. - Resolution: Fixed > lockedTaskDirectories should be cleared when task gets closed dirty in >

[jira] [Resolved] (KAFKA-10010) Should make state store registration idempotent

2020-06-01 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-10010. - Resolution: Fixed > Should make state store registration idempotent >

[jira] [Commented] (KAFKA-9494) Include data type of the config in ConfigEntry

2020-06-01 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121211#comment-17121211 ] Travis Bischel commented on KAFKA-9494: --- Thanks! > Include data type of the config in ConfigEntry

[GitHub] [kafka] bdbyrne edited a comment on pull request #8717: KAFKA-10033: Throw UnknownTopicOrPartitionException when modifying a non-existent topic's config

2020-06-01 Thread GitBox
bdbyrne edited a comment on pull request #8717: URL: https://github.com/apache/kafka/pull/8717#issuecomment-637016443 > Thanks for the PR @bdbyrne, I'm curious why we don't consider fixing the `AdminZkClient#validateTopicConfig` thrown exception type, but fix its caller instead. And in

[GitHub] [kafka] bdbyrne commented on pull request #8717: KAFKA-10033: Throw UnknownTopicOrPartitionException when modifying a non-existent topic's config

2020-06-01 Thread GitBox
bdbyrne commented on pull request #8717: URL: https://github.com/apache/kafka/pull/8717#issuecomment-637016443 > Thanks for the PR @bdbyrne, I'm curious why we don't consider fixing the `AdminZkClient#validateTopicConfig` thrown exception type, but fix its caller instead. And in fact we

[GitHub] [kafka] ableegoldman commented on pull request #8772: MINOR: clarify exception throwing in allStorePartitionLags javadocs

2020-06-01 Thread GitBox
ableegoldman commented on pull request #8772: URL: https://github.com/apache/kafka/pull/8772#issuecomment-637012129 @mjsax This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] ableegoldman commented on pull request #8738: MINOR: remove unnecessary timeout for admin request

2020-06-01 Thread GitBox
ableegoldman commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-637012071 Fair enough: https://github.com/apache/kafka/pull/8772 This is an automated message from the Apache Git

[GitHub] [kafka] ableegoldman opened a new pull request #8772: MINOR: clarify exception throwing in allStorePartitionLags javadocs

2020-06-01 Thread GitBox
ableegoldman opened a new pull request #8772: URL: https://github.com/apache/kafka/pull/8772 Followup to https://github.com/apache/kafka/pull/8738, backporting the javadocs to 2.5 This is an automated message from the

[jira] [Updated] (KAFKA-10077) Filter downstream of state-store results in suprious tombstones

2020-06-01 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Coates updated KAFKA-10077: Description: Adding a `filter` call downstream of anything that has a state store, e.g. a table

[jira] [Created] (KAFKA-10077) Filter downstream of state-store results in suprious tombstones

2020-06-01 Thread Andy Coates (Jira)
Andy Coates created KAFKA-10077: --- Summary: Filter downstream of state-store results in suprious tombstones Key: KAFKA-10077 URL: https://issues.apache.org/jira/browse/KAFKA-10077 Project: Kafka

[GitHub] [kafka] chia7712 commented on a change in pull request #8759: KAFKA-10066: TestOutputTopic should pass record headers into deserializers

2020-06-01 Thread GitBox
chia7712 commented on a change in pull request #8759: URL: https://github.com/apache/kafka/pull/8759#discussion_r433364776 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -906,8 +906,8 @@ public void

[jira] [Commented] (KAFKA-9717) KafkaStreams#metrics() method randomly throws NullPointerException

2020-06-01 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121152#comment-17121152 ] Chia-Ping Tsai commented on KAFKA-9717: --- [~Bataitis] Have you tried the newer kafka? >

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433352122 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -580,7 +581,16 @@ public void testTLSDefaults()

[jira] [Commented] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

2020-06-01 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121149#comment-17121149 ] Boyang Chen commented on KAFKA-9891: [~mateuszjadczyk] If we commit keyOne, then it *should* be

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433351684 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +632,108 @@ public void

[jira] [Resolved] (KAFKA-9392) Document and add test for deleteAcls that match single/multiple resources

2020-06-01 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-9392. --- Reviewer: Manikumar Resolution: Fixed > Document and add test for deleteAcls that

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r49180 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +632,108 @@ public void

[GitHub] [kafka] vvcephei commented on pull request #7693: MINOR: Fix Streams EOS system tests by adding clean-up of state dir

2020-06-01 Thread GitBox
vvcephei commented on pull request #7693: URL: https://github.com/apache/kafka/pull/7693#issuecomment-636946808 Cherry picked to 2.2: ``` test_id:

[GitHub] [kafka] vvcephei commented on pull request #7693: MINOR: Fix Streams EOS system tests by adding clean-up of state dir

2020-06-01 Thread GitBox
vvcephei commented on pull request #7693: URL: https://github.com/apache/kafka/pull/7693#issuecomment-636933382 I'm seeing some failures on older branches, so I'm cherry-picking back. Cherry-picked to 2.3. Confirmed the test worked locally: ``` [INFO:2020-06-01 08:43:27,309]:

  1   2   >