cmccabe commented on pull request #8639:
URL: https://github.com/apache/kafka/pull/8639#issuecomment-637823813
**The KIP clearly specifies that `describeCluster` will throw a UVE in this
case:
bq. When the AdminClient is talking to a broker which does not support
KIP-430, it will fi
guozhangwang commented on a change in pull request #8782:
URL: https://github.com/apache/kafka/pull/8782#discussion_r434173517
##
File path:
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala
##
@@ -291,7 +358,7 @@ class Transactio
badaiaqrandista commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r434171589
##
File path:
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java
##
@@ -42,9 +42,11 @@
badaiaqrandista commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r434168481
##
File path: clients/src/main/java/org/apache/kafka/clients/ClientUtils.java
##
@@ -108,10 +108,15 @@ public static ChannelBuilder
createChannelBu
guozhangwang commented on a change in pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#discussion_r434158390
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -247,48 +251,75 @@ public void completeRestorat
mjsax commented on pull request #8759:
URL: https://github.com/apache/kafka/pull/8759#issuecomment-637796962
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mjsax commented on pull request #8771:
URL: https://github.com/apache/kafka/pull/8771#issuecomment-637796036
Checkstyle error:
```
> Task :streams:checkstyleMain
07:47:53 [ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk14-scala2.13/streams/src/main/java/o
[
https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124296#comment-17124296
]
Boyang Chen commented on KAFKA-9891:
[~mateuszjadczyk] that's right, so we should onl
hachikuji commented on a change in pull request #8782:
URL: https://github.com/apache/kafka/pull/8782#discussion_r434153210
##
File path:
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala
##
@@ -221,7 +221,6 @@ class TransactionMa
ijuma commented on pull request #8668:
URL: https://github.com/apache/kafka/pull/8668#issuecomment-637779000
@ableegoldman No worries, I do the same. We just need to check the PR result
before merging. Additionally, committers should run checkstyle and spotBugs
when cherry-picking to older
ijuma commented on pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#issuecomment-63879
@nizhikov These changes are pretty tricky to validate. Thanks for being
thorough on the tests. :)
This is an automa
vvcephei commented on pull request #8785:
URL: https://github.com/apache/kafka/pull/8785#issuecomment-637774810
oh, great:
```
00:14:19.016 > Task :streams:checkstyleTest
00:14:19.017 [ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/sr
nizhikov commented on pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#issuecomment-637774614
@ijuma Thanks for your time! Appreciate it.
Try my best to waste fewer rounds of review next time :)
This is a
gharris1727 commented on pull request #8630:
URL: https://github.com/apache/kafka/pull/8630#issuecomment-637772629
@kkonstantine I'd appreciate another pass when you're available, thanks!
This is an automated message from th
gharris1727 commented on a change in pull request #8630:
URL: https://github.com/apache/kafka/pull/8630#discussion_r434139998
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginUtilsTest.java
##
@@ -114,68 +90,264 @@ public void testCo
[
https://issues.apache.org/jira/browse/KAFKA-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124248#comment-17124248
]
Gregory Koshelev commented on KAFKA-10033:
--
Hi, [~ijuma],
Can you review this
John Roesler created KAFKA-10086:
Summary: Write Integration Test for
StreamsTaskAssignor/HighAvailabilityTaskAssignor
Key: KAFKA-10086
URL: https://issues.apache.org/jira/browse/KAFKA-10086
Project:
[
https://issues.apache.org/jira/browse/KAFKA-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10084:
-
Component/s: streams
> System test failure: StreamsEosTest.test_failure_and_recovery_complex
> -
hachikuji commented on a change in pull request #8784:
URL: https://github.com/apache/kafka/pull/8784#discussion_r434122555
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -89,7 +89,7 @@ class GroupMetadataManager(brokerId: Int,
pr
vvcephei commented on a change in pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#discussion_r434121892
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##
@@ -247,6 +247,9 @@ private void close(final boolean
ableegoldman commented on a change in pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#discussion_r434118800
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##
@@ -247,6 +247,9 @@ private void close(final bool
mjsax commented on a change in pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#discussion_r434117796
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -390,19 +387,17 @@ boolean tryToCompleteRestoration()
vvcephei commented on pull request #8785:
URL: https://github.com/apache/kafka/pull/8785#issuecomment-637752017
Hey @mjsax , thanks for the help on this. Can you take a look at the PR?
This is an automated message from the Ap
vvcephei commented on pull request #8785:
URL: https://github.com/apache/kafka/pull/8785#issuecomment-637751829
I ran the system tests, and they pass:
```
test_id:
kafkatest.tests.streams.streams_e
vvcephei opened a new pull request #8785:
URL: https://github.com/apache/kafka/pull/8785
Check the uncommitted end offset after the committed end offset,
so we can be sure never to miss a pending end-transaction marker.
### Committer Checklist (excluded from commit message)
- [
[
https://issues.apache.org/jira/browse/KAFKA-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124224#comment-17124224
]
John Roesler commented on KAFKA-10084:
--
Thanks to some advice from [~mjsax] , it se
Sophie Blee-Goldman created KAFKA-10085:
---
Summary: Compute lag correctly for optimized source changelogs
Key: KAFKA-10085
URL: https://issues.apache.org/jira/browse/KAFKA-10085
Project: Kafka
jsancio commented on pull request #8639:
URL: https://github.com/apache/kafka/pull/8639#issuecomment-637749796
> Well, the client can handle the `UnsupportedVersionException and stop
requesting the authorized operations.
This is not fine grain enough for all cases. There are already
abbccdda commented on a change in pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#discussion_r434107127
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##
@@ -1799,8 +1799,8 @@ public void shouldThrowIfClo
[
https://issues.apache.org/jira/browse/KAFKA-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10084:
-
Affects Version/s: 2.6.0
> System test failure: StreamsEosTest.test_failure_and_recovery_complex
[
https://issues.apache.org/jira/browse/KAFKA-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10084:
-
Affects Version/s: 2.7.0
> System test failure: StreamsEosTest.test_failure_and_recovery_complex
[
https://issues.apache.org/jira/browse/KAFKA-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10084:
-
Fix Version/s: 2.6.0
2.7.0
> System test failure: StreamsEosTest.test_failure
John Roesler created KAFKA-10084:
Summary: System test failure:
StreamsEosTest.test_failure_and_recovery_complex
Key: KAFKA-10084
URL: https://issues.apache.org/jira/browse/KAFKA-10084
Project: Kafka
mjsax commented on a change in pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#discussion_r434111426
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##
@@ -247,6 +247,9 @@ private void close(final boolean cle
mjsax commented on a change in pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#discussion_r434111426
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##
@@ -247,6 +247,9 @@ private void close(final boolean cle
mjsax commented on a change in pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#discussion_r434110314
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##
@@ -247,6 +247,9 @@ private void close(final boolean cle
hachikuji commented on a change in pull request #8782:
URL: https://github.com/apache/kafka/pull/8782#discussion_r434098545
##
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala
##
@@ -285,15 +280,16 @@ class TransactionMarkerCha
[
https://issues.apache.org/jira/browse/KAFKA-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman resolved KAFKA-9987.
Fix Version/s: 2.5.1
2.4.2
2.6.0
Resolu
[
https://issues.apache.org/jira/browse/KAFKA-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman updated KAFKA-9987:
---
Component/s: consumer
> Improve sticky partition assignor algorithm
> ---
ableegoldman commented on a change in pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#discussion_r434051190
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##
@@ -247,6 +247,9 @@ private void close(final bool
[
https://issues.apache.org/jira/browse/KAFKA-8480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio reassigned KAFKA-8480:
-
Assignee: Jose Armando Garcia Sancio (was: Anna Povzner)
> Clie
chia7712 commented on a change in pull request #8782:
URL: https://github.com/apache/kafka/pull/8782#discussion_r434038469
##
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala
##
@@ -215,8 +215,6 @@ class TransactionMarkerChanne
dongjinleekr commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-637684403
All // Sorry for being late, I just got out from my last project; I will
have a look at this PR this weekend.
---
dongjinleekr commented on pull request #8117:
URL: https://github.com/apache/kafka/pull/8117#issuecomment-637683206
@vvcephei Sorry for being late, I just got out from my last project; I will
have a look.
This is an automate
chia7712 opened a new pull request #8783:
URL: https://github.com/apache/kafka/pull/8783
https://issues.apache.org/jira/browse/KAFKA-10063
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build statu
bob-barrett opened a new pull request #8784:
URL: https://github.com/apache/kafka/pull/8784
…nsors
Sensor objects are stored in the Kafka metrics registry and keyed by name.
If a new sensor is created with the same name as an existing one, the existing
one is returned rather than a
[
https://issues.apache.org/jira/browse/KAFKA-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stanislav Kozlovski reassigned KAFKA-7940:
--
Assignee: (was: Stanislav Kozlovski)
> Flaky Test CustomQuotaCallbackTest#
[
https://issues.apache.org/jira/browse/KAFKA-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124052#comment-17124052
]
Stanislav Kozlovski commented on KAFKA-8406:
[~savulchik] are you sure? Can y
[
https://issues.apache.org/jira/browse/KAFKA-8723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stanislav Kozlovski resolved KAFKA-8723.
Resolution: Fixed
> flaky test LeaderElectionCommandTest#testAllTopicPartition
> --
hachikuji opened a new pull request #8782:
URL: https://github.com/apache/kafka/pull/8782
The method `maybeWriteTxnCompletion` is unsafe for concurrent calls. This
can cause duplicate attempts to write the completion record to the log, which
can ultimately lead to illegal state errors and
guozhangwang commented on pull request #8777:
URL: https://github.com/apache/kafka/pull/8777#issuecomment-637677433
Cherry-picked to 2.6 / 2.5 / 2.4
This is an automated message from the Apache Git Service.
To respond to the
guozhangwang merged pull request #8777:
URL: https://github.com/apache/kafka/pull/8777
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
guozhangwang commented on pull request #8779:
URL: https://github.com/apache/kafka/pull/8779#issuecomment-637676075
Cherry-picked to 2.6 / 2.5 / 2.4
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-7599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stanislav Kozlovski reassigned KAFKA-7599:
--
Assignee: (was: Stanislav Kozlovski)
> Trogdor - Allow configuration for n
[
https://issues.apache.org/jira/browse/KAFKA-8264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stanislav Kozlovski reassigned KAFKA-8264:
--
Assignee: (was: Stanislav Kozlovski)
> Flaky Test PlaintextConsumerTest#te
ableegoldman commented on a change in pull request #8668:
URL: https://github.com/apache/kafka/pull/8668#discussion_r434021704
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -65,9 +72,206 @@ public MemberData(L
ableegoldman commented on pull request #8668:
URL: https://github.com/apache/kafka/pull/8668#issuecomment-637672028
Sorry @ijuma, I think I only ever ran the local tests + checkstyle, not the
full suite. My mistake
This is a
ableegoldman commented on a change in pull request #8775:
URL: https://github.com/apache/kafka/pull/8775#discussion_r434018826
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java
##
@@ -242,8 +250,9 @@ public void addOwn
[
https://issues.apache.org/jira/browse/KAFKA-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-10063:
--
Assignee: Chia-Ping Tsai
> UnsupportedOperation when querying cleaner metrics after s
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-637668386
@junrao Could you take a look?
This is an automated message from the Apache Git Service.
To respond to the messa
vvcephei commented on a change in pull request #8775:
URL: https://github.com/apache/kafka/pull/8775#discussion_r433923120
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -938,57 +930,9 @@ private void popula
ableegoldman commented on pull request #8778:
URL: https://github.com/apache/kafka/pull/8778#issuecomment-637665071
cc @mjsax @guozhangwang , should be cherrypicked to 2.6, 2.5, and 2.4 (once
my comment above is addressed)
T
ableegoldman commented on pull request #8777:
URL: https://github.com/apache/kafka/pull/8777#issuecomment-637664149
cc @mjsax @guozhangwang , should be cherrypicked to 2.6, 2.5, and 2.4
This is an automated message from the A
ableegoldman commented on a change in pull request #8778:
URL: https://github.com/apache/kafka/pull/8778#discussion_r434008302
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -43,7 +43,7 @@
public static
mjsax merged pull request #8774:
URL: https://github.com/apache/kafka/pull/8774
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-9943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma reassigned KAFKA-9943:
--
Assignee: Nikolay Izhikov
> Enable TLSv.1.3 in system tests "run all" execution.
> ---
[
https://issues.apache.org/jira/browse/KAFKA-9943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-9943:
---
Fix Version/s: 2.6.0
> Enable TLSv.1.3 in system tests "run all" execution.
> ---
mjsax removed a comment on pull request #8774:
URL: https://github.com/apache/kafka/pull/8774#issuecomment-637655696
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
mjsax commented on pull request #8774:
URL: https://github.com/apache/kafka/pull/8774#issuecomment-637655627
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ijuma commented on pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#issuecomment-637647620
@nizhikov I think we're good to merge this after the non code suggestions
above are addressed (assuming we can get a Jenkins build, I merged your other
PR fixing the build issue).
ijuma merged pull request #8779:
URL: https://github.com/apache/kafka/pull/8779
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r433990762
##
File path: docs/upgrade.html
##
@@ -18,6 +18,10 @@
ijuma commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r433987384
##
File path: clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java
##
@@ -64,7 +66,17 @@
public static final String SSL_ENABLED_PROTOCO
ijuma commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r433987384
##
File path: clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java
##
@@ -64,7 +66,17 @@
public static final String SSL_ENABLED_PROTOCO
ijuma commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r433981892
##
File path: clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java
##
@@ -49,11 +50,12 @@
public static final String SSL_PROTOCOL_CONFI
collabH closed pull request #8781:
URL: https://github.com/apache/kafka/pull/8781
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
collabH opened a new pull request #8781:
URL: https://github.com/apache/kafka/pull/8781
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing s
collabH opened a new pull request #8780:
URL: https://github.com/apache/kafka/pull/8780
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing s
collabH closed pull request #8780:
URL: https://github.com/apache/kafka/pull/8780
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
[
https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123935#comment-17123935
]
Ismael Juma commented on KAFKA-9800:
I think you should apply the same backoff strate
[
https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123377#comment-17123377
]
Cheng Tan edited comment on KAFKA-9800 at 6/2/20, 3:12 PM:
---
Rec
d8tltanc edited a comment on pull request #8421:
URL: https://github.com/apache/kafka/pull/8421#issuecomment-637300554
@skaundinya15 @ijuma @abbccdda Thanks for all the feedback and comments.
This patch was made when I was new to Kafka. It's kind of naive to me at this
time as I gained mor
d8tltanc edited a comment on pull request #8421:
URL: https://github.com/apache/kafka/pull/8421#issuecomment-637300554
@skaundinya15 @ijuma @abbccdda Thanks for all the feedback and comments.
This patch was made when I was new to Kafka. It's kind of naive to me at this
time as I gained mor
ijuma edited a comment on pull request #8668:
URL: https://github.com/apache/kafka/pull/8668#issuecomment-637592541
@guozhangwang Looks like 2.6, 2.5 and 2.4 are broken too. You should
generally also build locally when cherry-picking.
--
ijuma commented on pull request #8668:
URL: https://github.com/apache/kafka/pull/8668#issuecomment-637592541
@guozhangwang Looks like 2.6, 2.5 and 2.4 are broken too. You should
generally build locally when cherry-picking.
T
ijuma commented on pull request #8668:
URL: https://github.com/apache/kafka/pull/8668#issuecomment-637591555
Did we check the build before merging this? It seems to have broken it:
https://github.com/apache/kafka/pull/8779
bbejeck commented on pull request #8771:
URL: https://github.com/apache/kafka/pull/8771#issuecomment-637586221
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please lo
vvcephei commented on pull request #8775:
URL: https://github.com/apache/kafka/pull/8775#issuecomment-637578416
Ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
nizhikov commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r433920350
##
File path:
clients/src/test/java/org/apache/kafka/common/network/SslVersionsTransportLayerTest.java
##
@@ -117,24 +123,51 @@ public void testTlsDefault
nizhikov commented on pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#issuecomment-637574517
I think, currently, the trunk is broken with the
c6633a157eec1712116d294eb3785a96cba4e331
I prepared oneliner fix for it - #8779
ijuma commented on pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#issuecomment-637573626
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log o
nizhikov commented on pull request #8779:
URL: https://github.com/apache/kafka/pull/8779#issuecomment-637570728
Hello @ableegoldman
It looks like your patch breaks spot bug check.
I prepared oneliner fix for it.
Can you, please, take a look?
--
chia7712 commented on pull request #8774:
URL: https://github.com/apache/kafka/pull/8774#issuecomment-637570083
```testReassignmentWithRandomSubscriptionsAndChanges``` is traced by #8778
```testMultiConsumerStickyAssignment``` is traced by #8777
+1 to merge this hotfix :)
---
nizhikov opened a new pull request #8779:
URL: https://github.com/apache/kafka/pull/8779
Fixing nit in c6633a157eec1712116d294eb3785a96cba4e331.
This commit break spotbug check with the "Dead store to isFreshAssignment in
org.apache.kafka.clients.consumer.internals.AbstractStickyAssignor
ijuma commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r433903099
##
File path:
clients/src/test/java/org/apache/kafka/common/network/SslVersionsTransportLayerTest.java
##
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache So
ijuma commented on pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#issuecomment-637569220
Oh, one more thing, let's please add an entry to `upgrade.html`.
This is an automated message from the Apache Git Se
nizhikov commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r433899761
##
File path:
clients/src/test/java/org/apache/kafka/common/network/SslVersionsTransportLayerTest.java
##
@@ -117,24 +123,51 @@ public void testTlsDefault
ijuma commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r433892269
##
File path:
clients/src/test/java/org/apache/kafka/common/network/SslVersionsTransportLayerTest.java
##
@@ -117,24 +123,51 @@ public void testTlsDefaults()
bbejeck commented on pull request #8771:
URL: https://github.com/apache/kafka/pull/8771#issuecomment-637540041
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
itantiger commented on pull request #8753:
URL: https://github.com/apache/kafka/pull/8753#issuecomment-637519467
@guozhangwang Can you take a look at this?
This is an automated message from the Apache Git Service.
To respond
101 - 200 of 227 matches
Mail list logo
