[jira] [Assigned] (KAFKA-10180) TLSv1.3 system tests should not run under Java 8

[ https://issues.apache.org/jira/browse/KAFKA-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov reassigned KAFKA-10180: --- Assignee: Nikolay Izhikov > TLSv1.3 system tests should not run under Java 8 >

[GitHub] [kafka] C0urante commented on a change in pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

C0urante commented on a change in pull request #8844: URL: https://github.com/apache/kafka/pull/8844#discussion_r443300068 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerMetricsGroup.java ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache S

[GitHub] [kafka] C0urante commented on a change in pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

C0urante commented on a change in pull request #8844: URL: https://github.com/apache/kafka/pull/8844#discussion_r443299808 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerMetricsGroup.java ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache S

[GitHub] [kafka] tonytony2020 commented on pull request #8770: Update quickstart.html

tonytony2020 commented on pull request #8770: URL: https://github.com/apache/kafka/pull/8770#issuecomment-647259828 > In the quickstart, the 1st step we described is to download V2.5.0, and the following steps work well in V2.5.0. @tonytony2020 , could you try again with V2.5.0? Thanks.

[GitHub] [kafka] rushsky518 opened a new pull request #8911: inLock is redundant in ControllerEventManager

rushsky518 opened a new pull request #8911: URL: https://github.com/apache/kafka/pull/8911 LinkedBlockingQueue is threadsafe for put, outter inLock is unnecessary. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify tes

[GitHub] [kafka] C0urante opened a new pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

C0urante opened a new pull request #8910: URL: https://github.com/apache/kafka/pull/8910 [Jira](https://issues.apache.org/jira/browse/KAFKA-10188) The general lifecycle for a sink task is: 1. Instantiate the `SinkTask` object 2. Invoke `SinkTask::initialize` 3. Invoke `Si

[GitHub] [kafka] jiameixie commented on pull request #8836: KAFKA-10124:Wrong rebalance.time.ms

jiameixie commented on pull request #8836: URL: https://github.com/apache/kafka/pull/8836#issuecomment-647240810 @guozhangwang @chia7712 Update has been made. Would you please review it? Thanks. This is an automated message

[GitHub] [kafka] jiameixie commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance

jiameixie commented on pull request #8845: URL: https://github.com/apache/kafka/pull/8845#issuecomment-647240367 @abbccdda @chia7712 Could you merge this PR please？Thanks This is an automated message from the Apache Git Servi

[GitHub] [kafka] chia7712 edited a comment on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

chia7712 edited a comment on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-647233460 > This is a second run of the system tests. http://testing.confluent.io/confluent-kafka-branch-builder-system-test-results/?prefix=2020-06-19--001.1592614513--chia7712--fix

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-647233460 > This is a second run of the system tests. http://testing.confluent.io/confluent-kafka-branch-builder-system-test-results/?prefix=2020-06-19--001.1592614513--chia7712--fix_8334_a

[GitHub] [kafka] showuon commented on pull request #8885: KAFKA-8264: decrease the record size for flaky test

showuon commented on pull request #8885: URL: https://github.com/apache/kafka/pull/8885#issuecomment-647219440 @omkreddy , could you help review this small PR? Thanks. This is an automated message from the Apache Git Service.

[GitHub] [kafka] showuon commented on pull request #8894: KAFKA-9509: Add retries for mirrorClient consume records to fix flaky test

showuon commented on pull request #8894: URL: https://github.com/apache/kafka/pull/8894#issuecomment-647219267 Thanks, @chia7712 ! This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] michael-carter-instaclustr commented on pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

michael-carter-instaclustr commented on pull request #8844: URL: https://github.com/apache/kafka/pull/8844#issuecomment-647205060 Is this something you could review @C0urante ? This is an automated message from the Apache Git

[jira] [Commented] (KAFKA-10180) TLSv1.3 system tests should not run under Java 8

[ https://issues.apache.org/jira/browse/KAFKA-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141593#comment-17141593 ] Ismael Juma commented on KAFKA-10180: - [~nizhikov] Can you please look into this? It

[GitHub] [kafka] vvcephei merged pull request #8904: KAFKA-10185: Restoration info logging (#8896)

vvcephei merged pull request #8904: URL: https://github.com/apache/kafka/pull/8904 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #8904: KAFKA-10185: Restoration info logging (#8896)

vvcephei commented on pull request #8904: URL: https://github.com/apache/kafka/pull/8904#issuecomment-647177468 The java 11 build failed on a connect integration test. This is an automated message from the Apache Git Service.

[GitHub] [kafka] vvcephei commented on a change in pull request #8905: KAFKA-10173: Directly use Arrays.equals for version comparison

vvcephei commented on a change in pull request #8905: URL: https://github.com/apache/kafka/pull/8905#discussion_r443253796 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueBuffer.java ## @@ -299,16 +311,6 @@ private void r

[GitHub] [kafka] vvcephei commented on a change in pull request #8905: KAFKA-10173: Directly use Arrays.equals for version comparison

vvcephei commented on a change in pull request #8905: URL: https://github.com/apache/kafka/pull/8905#discussion_r443253760 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueBuffer.java ## @@ -58,10 +59,12 @@ public final c

[jira] [Commented] (KAFKA-10034) Clarify Usage of "batch.size" and "max.request.size" Producer Configs

[ https://issues.apache.org/jira/browse/KAFKA-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141547#comment-17141547 ] Michael Bingham commented on KAFKA-10034: - You're right of course, [~ijuma]. I e

[jira] [Commented] (KAFKA-10034) Clarify Usage of "batch.size" and "max.request.size" Producer Configs

[ https://issues.apache.org/jira/browse/KAFKA-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141546#comment-17141546 ] Ismael Juma commented on KAFKA-10034: - This is true although it's misleading to call

[jira] [Comment Edited] (KAFKA-10034) Clarify Usage of "batch.size" and "max.request.size" Producer Configs

[ https://issues.apache.org/jira/browse/KAFKA-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141532#comment-17141532 ] Michael Bingham edited comment on KAFKA-10034 at 6/21/20, 5:18 PM: ---

[jira] [Comment Edited] (KAFKA-10034) Clarify Usage of "batch.size" and "max.request.size" Producer Configs

[ https://issues.apache.org/jira/browse/KAFKA-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141532#comment-17141532 ] Michael Bingham edited comment on KAFKA-10034 at 6/21/20, 5:11 PM: ---

[GitHub] [kafka] guozhangwang commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

guozhangwang commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443238726 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,58 +675,75 @@ private void cleanupTask(fi

[jira] [Commented] (KAFKA-10034) Clarify Usage of "batch.size" and "max.request.size" Producer Configs

[ https://issues.apache.org/jira/browse/KAFKA-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141532#comment-17141532 ] Michael Bingham commented on KAFKA-10034: - Looks like {{max.request.size}} is us

[jira] [Commented] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

[ https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141531#comment-17141531 ] Guozhang Wang commented on KAFKA-10186: --- Also cc [~hachikuji] [~bob-barrett] > Ab

[GitHub] [kafka] guozhangwang commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

guozhangwang commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443237917 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,58 +675,75 @@ private void cleanupTask(fi

[GitHub] [kafka] guozhangwang commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

guozhangwang commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443237513 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -69,7 +68,6 @@ private final ChangelogRea

[GitHub] [kafka] guozhangwang commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

guozhangwang commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443237377 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close()

[GitHub] [kafka] highluck commented on pull request #8022: KAFKA 8382: Add TimestampedSessionStore

highluck commented on pull request #8022: URL: https://github.com/apache/kafka/pull/8022#issuecomment-647141512 @mjsax Is there a possibility that the task will be reflected? We'll follow up if possible. This is an

[GitHub] [kafka] highluck edited a comment on pull request #8029: KAFKA-8147: Add changelog topic configuration to KTable suppress

highluck edited a comment on pull request #8029: URL: https://github.com/apache/kafka/pull/8029#issuecomment-647141167 @mjsax Could you please provide feedback on how to update the docs? This is an automated message from

[GitHub] [kafka] highluck commented on pull request #8029: KAFKA-8147: Add changelog topic configuration to KTable suppress

highluck commented on pull request #8029: URL: https://github.com/apache/kafka/pull/8029#issuecomment-647141167 @mjsax Could you please provide feedback on how to update the documentation? This is an automated message fro

[GitHub] [kafka] highluck removed a comment on pull request #8107: MINOR: Remove Diamond and code code Alignment

highluck removed a comment on pull request #8107: URL: https://github.com/apache/kafka/pull/8107#issuecomment-642588479 @vvcephei retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] highluck commented on pull request #8107: MINOR: Remove Diamond and code code Alignment

highluck commented on pull request #8107: URL: https://github.com/apache/kafka/pull/8107#issuecomment-647140749 @vvcephei Could you please check again? This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] chia7712 commented on pull request #8891: KAFKA-10143; Improve test coverage for throttle changes during reassignment

chia7712 commented on pull request #8891: URL: https://github.com/apache/kafka/pull/8891#issuecomment-647132155 > Possibly we don't need --alter-throttle, but the tests and improved documentation would still be useful. How to change the alter for active reassignment if ```--alter-thr

[jira] [Commented] (KAFKA-6733) Support of printing additional ConsumerRecord fields in DefaultMessageFormatter

[ https://issues.apache.org/jira/browse/KAFKA-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141481#comment-17141481 ] Badai Aqrandista commented on KAFKA-6733: - Rebased PR 4807 (https://github.com/ap

[GitHub] [kafka] badaiaqrandista opened a new pull request #8909: KAFKA-6733: Support of printing additional ConsumerRecord fields in DefaultMessageFormatter (rebased)

badaiaqrandista opened a new pull request #8909: URL: https://github.com/apache/kafka/pull/8909 See KIP-431: https://cwiki.apache.org/confluence/display/KAFKA/KIP-431%3A+Support+of+printing+additional+ConsumerRecord+fields+in+DefaultMessageFormatter *More detailed description of

[GitHub] [kafka] chia7712 commented on a change in pull request #8891: KAFKA-10143; Improve test coverage for throttle changes during reassignment

chia7712 commented on a change in pull request #8891: URL: https://github.com/apache/kafka/pull/8891#discussion_r443220535 ## File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala ## @@ -962,22 +963,18 @@ object ReassignPartitionsCommand extends Logging {

[jira] [Resolved] (KAFKA-10183) MirrorMaker creates duplicate messages in target cluster

[ https://issues.apache.org/jira/browse/KAFKA-10183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liraz Sharaby resolved KAFKA-10183. --- Resolution: Done Increasing max.tasks seems to have resolved the issue. As per documentatio

[GitHub] [kafka] omkreddy closed pull request #8877: KAFKA-9194: Missing documentation for replicaMaxWaitTimeMs config value

omkreddy closed pull request #8877: URL: https://github.com/apache/kafka/pull/8877 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] satishbellapu commented on a change in pull request #8877: KAFKA-9194: Missing documentation for replicaMaxWaitTimeMs config value

satishbellapu commented on a change in pull request #8877: URL: https://github.com/apache/kafka/pull/8877#discussion_r443200739 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -782,7 +782,7 @@ object KafkaConfig { "message.max.bytes (broker config) o

[GitHub] [kafka] vitojeng commented on pull request #8908: MINOR: fix warning of javadoc task

vitojeng commented on pull request #8908: URL: https://github.com/apache/kafka/pull/8908#issuecomment-647101928 Oops! Duplicate with #8660. Close this PR. This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] vitojeng closed pull request #8908: MINOR: fix warning of javadoc task

vitojeng closed pull request #8908: URL: https://github.com/apache/kafka/pull/8908 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] omkreddy commented on a change in pull request #8877: KAFKA-9194: Missing documentation for replicaMaxWaitTimeMs config value

omkreddy commented on a change in pull request #8877: URL: https://github.com/apache/kafka/pull/8877#discussion_r443197270 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -782,7 +782,7 @@ object KafkaConfig { "message.max.bytes (broker config) or ma

[GitHub] [kafka] omkreddy commented on a change in pull request #8877: KAFKA-9194: Missing documentation for replicaMaxWaitTimeMs config value

omkreddy commented on a change in pull request #8877: URL: https://github.com/apache/kafka/pull/8877#discussion_r443197270 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -782,7 +782,7 @@ object KafkaConfig { "message.max.bytes (broker config) or ma

[GitHub] [kafka] satishbellapu commented on pull request #8877: KAFKA-9194: Missing documentation for replicaMaxWaitTimeMs config value

satishbellapu commented on pull request #8877: URL: https://github.com/apache/kafka/pull/8877#issuecomment-647097580 @mjsax anything pending from me for the merge ? This is an automated message from the Apache Git Service. To