[GitHub] [kafka] ijuma commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-09 Thread GitBox
ijuma commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r452634516 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -239,9 +239,13 @@ class GroupMetadataManager(brokerId: Int,

[GitHub] [kafka] mjsax commented on a change in pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
mjsax commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r452622160 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -193,6 +196,26 @@ private void closeAndRevive(final

[GitHub] [kafka] mjsax commented on a change in pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
mjsax commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r452621814 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -193,6 +196,26 @@ private void closeAndRevive(final

[GitHub] [kafka] mjsax commented on a change in pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
mjsax commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r452620905 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -768,9 +770,30 @@ void runOnce() { private

[GitHub] [kafka] mjsax commented on a change in pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
mjsax commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r452620343 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -95,7 +96,7 @@ * | | Assigned

[jira] [Updated] (KAFKA-10262) StateDirectory is not thread-safe

2020-07-09 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10262: Description: As explicitly stated in the StateDirectory javadocs,  "This class is

[GitHub] [kafka] vvcephei commented on pull request #9004: KAFKA-10261: Introduce the KIP-478 apis with shims

2020-07-09 Thread GitBox
vvcephei commented on pull request #9004: URL: https://github.com/apache/kafka/pull/9004#issuecomment-656446145 Note, I didn't bother testing the shims directly, since they are very effectively tested by literally all the tests in Streams.

[GitHub] [kafka] vvcephei commented on a change in pull request #9004: KAFKA-10261: Introduce the KIP-478 apis with shims

2020-07-09 Thread GitBox
vvcephei commented on a change in pull request #9004: URL: https://github.com/apache/kafka/pull/9004#discussion_r452588767 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextReverseShim.java ## @@ -0,0 +1,244 @@ +/* + * Licensed

[GitHub] [kafka] vvcephei commented on pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
vvcephei commented on pull request #8994: URL: https://github.com/apache/kafka/pull/8994#issuecomment-656441714 Hi @abbccdda @ableegoldman @mjsax , I've rebased on trunk to resolve conflicts with Sophie's parallel fix. I also dropped a few unnecessary side-fixes. Do you mind giving

[jira] [Commented] (KAFKA-10249) In-memory stores are skipped when checkpointing but not skipped when reading the checkpoint

2020-07-09 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155039#comment-17155039 ] John Roesler commented on KAFKA-10249: -- cc [~rhauch] , I've just pushed the fix to 2.6. >

[jira] [Updated] (KAFKA-10249) In-memory stores are skipped when checkpointing but not skipped when reading the checkpoint

2020-07-09 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10249: - Fix Version/s: 2.6.0 > In-memory stores are skipped when checkpointing but not skipped when

[GitHub] [kafka] vvcephei merged pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
vvcephei merged pull request #8996: URL: https://github.com/apache/kafka/pull/8996 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vvcephei removed a comment on pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
vvcephei removed a comment on pull request #8996: URL: https://github.com/apache/kafka/pull/8996#issuecomment-656435203 Unrelated test failures: * kafka.api.TransactionsTest.testBumpTransactionalEpoch *

[GitHub] [kafka] showuon commented on pull request #8885: KAFKA-8264: decrease the record size for flaky test

2020-07-09 Thread GitBox
showuon commented on pull request #8885: URL: https://github.com/apache/kafka/pull/8885#issuecomment-656432089 @hachikuji , could you help review this small PR to fix flaky test? Thanks. This is an automated message from the

[GitHub] [kafka] ableegoldman commented on a change in pull request #9005: KAFKA-10263: Do not assign standby for revoking stateless tasks

2020-07-09 Thread GitBox
ableegoldman commented on a change in pull request #9005: URL: https://github.com/apache/kafka/pull/9005#discussion_r452570044 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -1402,9 +1404,13 @@ public

[GitHub] [kafka] ableegoldman commented on pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
ableegoldman commented on pull request #8996: URL: https://github.com/apache/kafka/pull/8996#issuecomment-656424125 Three flaky test failures: `MirrorConnectorsIntegrationTest.testOneWayReplicationWithAutorOffsetSync1` `TransactionsTest.testBumpTransactionalEpoch`

[jira] [Commented] (KAFKA-10255) Fix flaky testOneWayReplicationWithAutorOffsetSync1 test

2020-07-09 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155024#comment-17155024 ] Sophie Blee-Goldman commented on KAFKA-10255: - Failed again  h3. Stacktrace

[jira] [Created] (KAFKA-10264) Flaky Test TransactionsTest.testBumpTransactionalEpoch

2020-07-09 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10264: --- Summary: Flaky Test TransactionsTest.testBumpTransactionalEpoch Key: KAFKA-10264 URL: https://issues.apache.org/jira/browse/KAFKA-10264 Project: Kafka

[GitHub] [kafka] guozhangwang commented on a change in pull request #9005: KAFKA-10263: Do not assign standby for revoking stateless tasks

2020-07-09 Thread GitBox
guozhangwang commented on a change in pull request #9005: URL: https://github.com/apache/kafka/pull/9005#discussion_r452562468 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -1402,9 +1404,13 @@ public

[GitHub] [kafka] guozhangwang opened a new pull request #9005: KAFKA-10263: Do not assign standby for revoking stateless tasks

2020-07-09 Thread GitBox
guozhangwang opened a new pull request #9005: URL: https://github.com/apache/kafka/pull/9005 Also piggy-back a small fix to use TreeMap other than HashMap to preserve iteration ordering. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[jira] [Created] (KAFKA-10263) Do not create standbys for those revoking active tasks if it is not stateful

2020-07-09 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10263: - Summary: Do not create standbys for those revoking active tasks if it is not stateful Key: KAFKA-10263 URL: https://issues.apache.org/jira/browse/KAFKA-10263

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement KIP-584 write path

2020-07-09 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r452398464 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeFeaturesOptions.java ## @@ -0,0 +1,26 @@ +package

[GitHub] [kafka] abbccdda commented on a change in pull request #9002: MINOR: Add ApiMessageTypeGenerator

2020-07-09 Thread GitBox
abbccdda commented on a change in pull request #9002: URL: https://github.com/apache/kafka/pull/9002#discussion_r452542243 ## File path: generator/src/main/java/org/apache/kafka/message/TypeClassGenerator.java ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (KAFKA-10262) StateDirectory is not thread-safe

2020-07-09 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10262: --- Summary: StateDirectory is not thread-safe Key: KAFKA-10262 URL: https://issues.apache.org/jira/browse/KAFKA-10262 Project: Kafka Issue Type:

[GitHub] [kafka] vvcephei opened a new pull request #9004: KAFKA-10261: Introduce the KIP-478 apis with shims

2020-07-09 Thread GitBox
vvcephei opened a new pull request #9004: URL: https://github.com/apache/kafka/pull/9004 Adds the new Processor and ProcessorContext interfaces as proposed in KIP-478. To integrate in a staged fashion with the code base, shims are included to convert back and forth between the new

[jira] [Created] (KAFKA-10261) Introduce the KIP-478 processors with shims

2020-07-09 Thread John Roesler (Jira)
John Roesler created KAFKA-10261: Summary: Introduce the KIP-478 processors with shims Key: KAFKA-10261 URL: https://issues.apache.org/jira/browse/KAFKA-10261 Project: Kafka Issue Type:

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-09 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-656382338 > Do you want to rebase again so that I can run system tests one more time? sure! This is an automated

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-07-09 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r452507990 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1308,18 +1410,27 @@ class ConnectionQuotas(config: KafkaConfig, time: Time)

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-09 Thread GitBox
junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-656365594 @chia7712 : All 3 PRs you fixed above have been merged. Do you want to rebase again so that I can run system tests one more time?

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-07-09 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r452502811 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1289,15 +1311,95 @@ class ConnectionQuotas(config: KafkaConfig, time: Time)

[jira] [Updated] (KAFKA-10253) Kafka Connect gets into an infinite rebalance loop

2020-07-09 Thread Konstantin Lalafaryan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Lalafaryan updated KAFKA-10253: -- Description: Hello everyone!   We are running kafka-connect cluster  (3

[jira] [Updated] (KAFKA-10253) Kafka Connect gets into an infinite rebalance loop

2020-07-09 Thread Konstantin Lalafaryan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Lalafaryan updated KAFKA-10253: -- Description: Hello everyone!   We are running kafka-connect cluster  (3

[GitHub] [kafka] mjsax commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
mjsax commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r452494073 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -104,26 +104,27 @@ static void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
ableegoldman commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r452491173 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -104,26 +104,27 @@ static void

[GitHub] [kafka] vvcephei commented on pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
vvcephei commented on pull request #8996: URL: https://github.com/apache/kafka/pull/8996#issuecomment-656349040 It looks like the tests never ran before. This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] vvcephei commented on pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
vvcephei commented on pull request #8996: URL: https://github.com/apache/kafka/pull/8996#issuecomment-656348955 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vvcephei commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
vvcephei commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r452487075 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -222,8 +222,16 @@ void

[GitHub] [kafka] JimGalasyn commented on a change in pull request #8995: Restore stream-table duality description

2020-07-09 Thread GitBox
JimGalasyn commented on a change in pull request #8995: URL: https://github.com/apache/kafka/pull/8995#discussion_r452486723 ## File path: docs/streams/core-concepts.html ## @@ -170,13 +150,59 @@ Duality of or to run interactive queries against your

[GitHub] [kafka] vvcephei commented on pull request #8993: KAFKA-10173: Use SmokeTest for upgrade system tests (#8938)

2020-07-09 Thread GitBox
vvcephei commented on pull request #8993: URL: https://github.com/apache/kafka/pull/8993#issuecomment-656347070 The new test passed:

[GitHub] [kafka] ableegoldman commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
ableegoldman commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r452483525 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -222,8 +222,16 @@ void

[GitHub] [kafka] mjsax merged pull request #8995: Restore stream-table duality description

2020-07-09 Thread GitBox
mjsax merged pull request #8995: URL: https://github.com/apache/kafka/pull/8995 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on a change in pull request #8995: Restore stream-table duality description

2020-07-09 Thread GitBox
mjsax commented on a change in pull request #8995: URL: https://github.com/apache/kafka/pull/8995#discussion_r452481312 ## File path: docs/streams/core-concepts.html ## @@ -170,13 +150,59 @@ Duality of or to run interactive queries against your application's

[GitHub] [kafka] vvcephei commented on pull request #8993: KAFKA-10173: Use SmokeTest for upgrade system tests (#8938)

2020-07-09 Thread GitBox
vvcephei commented on pull request #8993: URL: https://github.com/apache/kafka/pull/8993#issuecomment-656341862 Just a note that this is the backport of https://github.com/apache/kafka/pull/8938 This is an automated message

[GitHub] [kafka] ableegoldman commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
ableegoldman commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r452478882 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -104,26 +104,27 @@ static void

[jira] [Commented] (KAFKA-10226) KStream without SASL information should return error in confluent cloud

2020-07-09 Thread Apurva Mehta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154913#comment-17154913 ] Apurva Mehta commented on KAFKA-10226: -- It would be good to add a `producer.send(...);

[jira] [Commented] (KAFKA-10226) KStream without SASL information should return error in confluent cloud

2020-07-09 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154909#comment-17154909 ] John Roesler commented on KAFKA-10226: -- Hi [~wdaehn] , I'm no expert on this stuff, but I think

[jira] [Assigned] (KAFKA-9584) Removing headers causes ConcurrentModificationException

2020-07-09 Thread Micah Ramos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Micah Ramos reassigned KAFKA-9584: -- Assignee: (was: Micah Ramos) > Removing headers causes ConcurrentModificationException >

[jira] [Resolved] (KAFKA-10256) Create a server gradle module for Java code needed only by servers

2020-07-09 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-10256. -- Resolution: Won't Fix > Create a server gradle module for Java code needed only by servers >

[GitHub] [kafka] dajac commented on a change in pull request #8999: MINOR; Return timed out connections as a List instead of a Set

2020-07-09 Thread GitBox
dajac commented on a change in pull request #8999: URL: https://github.com/apache/kafka/pull/8999#discussion_r452440483 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -443,13 +444,13 @@ public boolean

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r452440068 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -232,10 +232,16 @@ void

[jira] [Created] (KAFKA-10260) Streams could recover stores in a task independently

2020-07-09 Thread John Roesler (Jira)
John Roesler created KAFKA-10260: Summary: Streams could recover stores in a task independently Key: KAFKA-10260 URL: https://issues.apache.org/jira/browse/KAFKA-10260 Project: Kafka Issue

[GitHub] [kafka] omkreddy closed pull request #8937: MINOR: Create ChannelBuilder for each connection in ConnectionStressWorker workload

2020-07-09 Thread GitBox
omkreddy closed pull request #8937: URL: https://github.com/apache/kafka/pull/8937 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vvcephei commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
vvcephei commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r452433188 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -104,26 +104,27 @@ static void

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-07-09 Thread GitBox
cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r452425472 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java ## @@ -45,24 +45,23 @@ protected

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r452424595 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -232,10 +232,16 @@ void

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r452419917 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -193,6 +196,26 @@ private void

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r452423901 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -232,10 +232,16 @@ void

[GitHub] [kafka] vvcephei merged pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-07-09 Thread GitBox
vvcephei merged pull request #8902: URL: https://github.com/apache/kafka/pull/8902 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (KAFKA-10259) KIP-554: Add Broker-side SCRAM Config API

2020-07-09 Thread Ron Dagostino (Jira)
Ron Dagostino created KAFKA-10259: - Summary: KIP-554: Add Broker-side SCRAM Config API Key: KAFKA-10259 URL: https://issues.apache.org/jira/browse/KAFKA-10259 Project: Kafka Issue Type: New

[GitHub] [kafka] vvcephei commented on pull request #8993: KAFKA-10173: Use SmokeTest for upgrade system tests (#8938)

2020-07-09 Thread GitBox
vvcephei commented on pull request #8993: URL: https://github.com/apache/kafka/pull/8993#issuecomment-656291661 Testing again: the new test: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4018/ all streams tests:

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r452419917 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -193,6 +196,26 @@ private void

[GitHub] [kafka] vvcephei commented on pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-07-09 Thread GitBox
vvcephei commented on pull request #8902: URL: https://github.com/apache/kafka/pull/8902#issuecomment-656290123 Thanks, all. I think we can merge this now. This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-07-09 Thread GitBox
cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r452415850 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -103,8 +104,12 @@ public void init(final

[jira] [Commented] (KAFKA-10253) Kafka Connect gets into an infinite rebalance loop

2020-07-09 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154790#comment-17154790 ] Chris Egerton commented on KAFKA-10253: --- [~klalafaryan] can you provide the configurations for all

[GitHub] [kafka] mjsax commented on a change in pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
mjsax commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r452410965 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -95,7 +96,7 @@ * | | Assigned

[GitHub] [kafka] mjsax commented on a change in pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
mjsax commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r452408268 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -232,10 +232,16 @@ void

[jira] [Updated] (KAFKA-6453) Document timestamp propagation semantics

2020-07-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-6453: --- Description: Atm, Kafka Streams only has a defined "contract" about timestamp propagation at

[jira] [Updated] (KAFKA-6453) Document timestamp propagation semantics

2020-07-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-6453: --- Summary: Document timestamp propagation semantics (was: Reconsider timestamp propagation

[jira] [Assigned] (KAFKA-6453) Reconsider timestamp propagation semantics

2020-07-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-6453: -- Assignee: James Galasyn (was: Victoria Bialas) > Reconsider timestamp propagation

[GitHub] [kafka] dajac commented on a change in pull request #8999: MINOR; Return timed out connections as a List instead of a Set

2020-07-09 Thread GitBox
dajac commented on a change in pull request #8999: URL: https://github.com/apache/kafka/pull/8999#discussion_r452400759 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -443,13 +444,13 @@ public boolean

[GitHub] [kafka] ijuma commented on a change in pull request #8999: MINOR; Return timed out connections as a List instead of a Set

2020-07-09 Thread GitBox
ijuma commented on a change in pull request #8999: URL: https://github.com/apache/kafka/pull/8999#discussion_r452396471 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -443,13 +444,13 @@ public boolean

[GitHub] [kafka] ijuma commented on a change in pull request #8999: MINOR; Return timed out connections as a List instead of a Set

2020-07-09 Thread GitBox
ijuma commented on a change in pull request #8999: URL: https://github.com/apache/kafka/pull/8999#discussion_r452395964 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -443,13 +444,13 @@ public boolean

[GitHub] [kafka] mjsax commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-07-09 Thread GitBox
mjsax commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r452394510 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -103,8 +104,12 @@ public void init(final

[GitHub] [kafka] dajac commented on a change in pull request #8999: MINOR; Return timed out connections as a List instead of a Set

2020-07-09 Thread GitBox
dajac commented on a change in pull request #8999: URL: https://github.com/apache/kafka/pull/8999#discussion_r452393587 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -443,13 +444,13 @@ public boolean

[GitHub] [kafka] mjsax commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-07-09 Thread GitBox
mjsax commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r452391941 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java ## @@ -45,24 +45,23 @@ protected

[GitHub] [kafka] ableegoldman commented on pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-07-09 Thread GitBox
ableegoldman commented on pull request #8902: URL: https://github.com/apache/kafka/pull/8902#issuecomment-656265143 Aw...the EosBetaUpgradeIntegrationTest failed again?? :/ This is an automated message from the Apache Git

[GitHub] [kafka] cadonna commented on pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-07-09 Thread GitBox
cadonna commented on pull request #8902: URL: https://github.com/apache/kafka/pull/8902#issuecomment-656263751 Unrelated test failure: ``` org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] ```

[GitHub] [kafka] ableegoldman commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
ableegoldman commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r452372357 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java ## @@ -784,7 +784,7 @@ public void

[GitHub] [kafka] mjsax commented on pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
mjsax commented on pull request #8996: URL: https://github.com/apache/kafka/pull/8996#issuecomment-656261358 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
ableegoldman commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r452372357 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java ## @@ -784,7 +784,7 @@ public void

[GitHub] [kafka] mjsax commented on pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
mjsax commented on pull request #8996: URL: https://github.com/apache/kafka/pull/8996#issuecomment-656261242 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman commented on a change in pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
ableegoldman commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r452381474 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -232,10 +232,16 @@ void

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-09 Thread GitBox
mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r452374925 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -994,30 +1023,29 @@ public void

[GitHub] [kafka] vinothchandar commented on pull request #8948: KAFKA-10174: Prefer --bootstrap-server for configs command in ducker tests

2020-07-09 Thread GitBox
vinothchandar commented on pull request #8948: URL: https://github.com/apache/kafka/pull/8948#issuecomment-656251801 @cmccabe this PR is a sub task under KAFKA-10131, which tracks the bigger goal. I filed a new issue explicitly targetting removal of `use_zk_connection` . For this pr, the

[GitHub] [kafka] ableegoldman commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
ableegoldman commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r452372357 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java ## @@ -784,7 +784,7 @@ public void

[jira] [Created] (KAFKA-10258) Get rid of use_zk_connection flag in kafka.py public methods

2020-07-09 Thread Vinoth Chandar (Jira)
Vinoth Chandar created KAFKA-10258: -- Summary: Get rid of use_zk_connection flag in kafka.py public methods Key: KAFKA-10258 URL: https://issues.apache.org/jira/browse/KAFKA-10258 Project: Kafka

[GitHub] [kafka] vvcephei commented on pull request #8993: KAFKA-10173: Use SmokeTest for upgrade system tests (#8938)

2020-07-09 Thread GitBox
vvcephei commented on pull request #8993: URL: https://github.com/apache/kafka/pull/8993#issuecomment-656249347 Ah, and the other smoke test usages are messed up: ``` test_id: kafkatest.tests.streams.streams_eos_test.StreamsEosTest.test_rebalance_simple status: FAIL run

[GitHub] [kafka] ableegoldman commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

2020-07-09 Thread GitBox
ableegoldman commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r452370517 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -104,17 +104,16 @@ static void

[jira] [Assigned] (KAFKA-10213) Prefer --bootstrap-server in ducktape tests for Kafka clients

2020-07-09 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar reassigned KAFKA-10213: -- Assignee: Ron Dagostino (was: Vinoth Chandar) > Prefer --bootstrap-server in

[GitHub] [kafka] C0urante commented on pull request #8973: KAFKA-10218: Stop reading config topic in every subsequent tick if catchup fails once

2020-07-09 Thread GitBox
C0urante commented on pull request #8973: URL: https://github.com/apache/kafka/pull/8973#issuecomment-656247489 @gharris1727 @chia7712 @ncliang would any of you be interested in reviewing this? This is an automated message

[jira] [Updated] (KAFKA-10235) Fix flaky transactions_test.py

2020-07-09 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-10235: Fix Version/s: (was: 3.0.0) 2.7.0 > Fix flaky transactions_test.py >

[GitHub] [kafka] vvcephei commented on pull request #8993: KAFKA-10173: Use SmokeTest for upgrade system tests (#8938)

2020-07-09 Thread GitBox
vvcephei commented on pull request #8993: URL: https://github.com/apache/kafka/pull/8993#issuecomment-656247859 Looks like there was a spurious failure of the new test: ``` test_id:

[GitHub] [kafka] C0urante commented on pull request #9003: KAFKA-10240: Stop throwing WakeupExceptions during sink task shutdown

2020-07-09 Thread GitBox
C0urante commented on pull request #9003: URL: https://github.com/apache/kafka/pull/9003#issuecomment-656247517 @gharris1727 @chia7712 @ncliang would any of you be interested in reviewing this? This is an automated message

[GitHub] [kafka] C0urante opened a new pull request #9003: KAFKA-10240: Stop throwing WakeupExceptions during sink task shutdown

2020-07-09 Thread GitBox
C0urante opened a new pull request #9003: URL: https://github.com/apache/kafka/pull/9003 A benign `WakeupException` can be thrown by a sink task's consumer if it's scheduled for shutdown by the worker. This is caught and handled gracefully if the exception is thrown when calling `poll` on

[jira] [Commented] (KAFKA-10174) Prefer --bootstrap-server ducktape tests using kafka_configs.sh

2020-07-09 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154741#comment-17154741 ] Vinoth Chandar commented on KAFKA-10174: [https://github.com/apache/kafka/pull/8948]   >

[GitHub] [kafka] omkreddy commented on pull request #8878: MINOR: Generator config-specific HTML ids

2020-07-09 Thread GitBox
omkreddy commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-656246737 I agree, it's a useful fix. I think its OK to break existing links. I have not seen anywhere using those links. Lets see what others think.

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r452365162 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -232,10 +232,16 @@ void

[jira] [Commented] (KAFKA-10254) 100% cpu usage by kafkaConsumer poll , when broker can‘t be connect

2020-07-09 Thread Arvin Zheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154725#comment-17154725 ] Arvin Zheng commented on KAFKA-10254: - [~xiaotong.wang], see KAFKA-10134 > 100% cpu usage by

[GitHub] [kafka] ijuma commented on a change in pull request #8999: MINOR; Return timed out connections as a List instead of a Set

2020-07-09 Thread GitBox
ijuma commented on a change in pull request #8999: URL: https://github.com/apache/kafka/pull/8999#discussion_r452349346 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -443,13 +444,13 @@ public boolean

[jira] [Resolved] (KAFKA-10235) Fix flaky transactions_test.py

2020-07-09 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-10235. - Fix Version/s: 3.0.0 Resolution: Fixed merged the PR to trunk. > Fix flaky transactions_test.py

  1   2   >