[jira] [Comment Edited] (KAFKA-10424) MirrorMaker 2.0 does not replicates topic's "clean.policy"

2020-08-22 Thread Mikhail Grinfeld (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182581#comment-17182581 ] Mikhail Grinfeld edited comment on KAFKA-10424 at 8/23/20, 6:29 AM: --

[jira] [Commented] (KAFKA-10424) MirrorMaker 2.0 does not replicates topic's "clean.policy"

2020-08-22 Thread Mikhail Grinfeld (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182581#comment-17182581 ] Mikhail Grinfeld commented on KAFKA-10424: -- Thx for quick comment. I don't use

[jira] [Comment Edited] (KAFKA-10424) MirrorMaker 2.0 does not replicates topic's "clean.policy"

2020-08-22 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182572#comment-17182572 ] Ning Zhang edited comment on KAFKA-10424 at 8/23/20, 3:28 AM:

[jira] [Commented] (KAFKA-10424) MirrorMaker 2.0 does not replicates topic's "clean.policy"

2020-08-22 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182572#comment-17182572 ] Ning Zhang commented on KAFKA-10424: [~grinfeld] "_schemas" topic is a compacted top

[GitHub] [kafka] chia7712 commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-08-22 Thread GitBox
chia7712 commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-678722242 > Do you have any data on the improvement this achieves? I profiled (1 minute) one of servers (10 cores * 128 GB) without /without this patch. The tuple allocations is cha

[jira] [Commented] (KAFKA-8803) Stream will not start due to TimeoutException: Timeout expired after 60000milliseconds while awaiting InitProducerId

2020-08-22 Thread Eleanore Jin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182553#comment-17182553 ] Eleanore Jin commented on KAFKA-8803: - Hi [~guozhang],  I am using [Apache Beam Kaf

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-08-22 Thread GitBox
bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-678691061 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] ijuma commented on pull request #9187: MINOR: bump mockito to 3.5.0

2020-08-22 Thread GitBox
ijuma commented on pull request #9187: URL: https://github.com/apache/kafka/pull/9187#issuecomment-678682051 Looks like 3.5.2 is the latest version https://search.maven.org/artifact/org.mockito/mockito-core/3.5.2/jar This is

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-08-22 Thread GitBox
bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-678682048 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] ijuma commented on pull request #9187: MINOR: bump mockito to 3.5.0

2020-08-22 Thread GitBox
ijuma commented on pull request #9187: URL: https://github.com/apache/kafka/pull/9187#issuecomment-678681985 I don't think we use the inline mock maker. This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] ijuma commented on pull request #9187: MINOR: bump mockito to 3.5.0

2020-08-22 Thread GitBox
ijuma commented on pull request #9187: URL: https://github.com/apache/kafka/pull/9187#issuecomment-678681961 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] bbejeck removed a comment on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-08-22 Thread GitBox
bbejeck removed a comment on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-678681778 retest this please This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-08-22 Thread GitBox
bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-678681778 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-08-22 Thread GitBox
bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-678681825 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] bbejeck commented on pull request #9207: Minor remove semicolon

2020-08-22 Thread GitBox
bbejeck commented on pull request #9207: URL: https://github.com/apache/kafka/pull/9207#issuecomment-678681668 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] bbejeck commented on pull request #9208: Minor init singleton list

2020-08-22 Thread GitBox
bbejeck commented on pull request #9208: URL: https://github.com/apache/kafka/pull/9208#issuecomment-678681564 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] bbejeck commented on pull request #9209: Minor enhance copy array

2020-08-22 Thread GitBox
bbejeck commented on pull request #9209: URL: https://github.com/apache/kafka/pull/9209#issuecomment-678681457 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] ivandasch commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

2020-08-22 Thread GitBox
ivandasch commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475086583 ## File path: tests/kafkatest/services/monitor/http.py ## @@ -154,7 +154,7 @@ def do_POST(self): name = raw_metric['name'] group

[GitHub] [kafka] ijuma commented on pull request #9200: MINOR: mirror integration tests should not call System.exit

2020-08-22 Thread GitBox
ijuma commented on pull request #9200: URL: https://github.com/apache/kafka/pull/9200#issuecomment-678666729 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ijuma commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-08-22 Thread GitBox
ijuma commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-678662885 @chia7712 Do you have any data on the improvement this achieves? This is an automated message from the Apache Git Se

[GitHub] [kafka] ijuma commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-08-22 Thread GitBox
ijuma commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-678663003 Generally, the tuples allocated here (if not elided by the optimizer) would be pretty tiny compared to allocating the buffers for the record batches. --

[GitHub] [kafka] lbradstreet commented on pull request #9129: MINOR: Update jmh to 1.24 for async profiler support

2020-08-22 Thread GitBox
lbradstreet commented on pull request #9129: URL: https://github.com/apache/kafka/pull/9129#issuecomment-678660654 @ijuma the text mode output here looks good however it would be good to include instructions for producing an svg flamegraph if possible. Do you know if we can do that?

[GitHub] [kafka] lbradstreet commented on a change in pull request #9129: MINOR: Update jmh to 1.24 for async profiler support

2020-08-22 Thread GitBox
lbradstreet commented on a change in pull request #9129: URL: https://github.com/apache/kafka/pull/9129#discussion_r475106000 ## File path: README.md ## @@ -199,6 +199,27 @@ You can run spotbugs using: The spotbugs warnings will be found in `reports/spotbugs/main.html` and `r

[jira] [Resolved] (KAFKA-10367) Allow running the Streams demo app with a config file

2020-08-22 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-10367. Fix Version/s: 2.7.0 Resolution: Fixed > Allow running the Streams demo app with a

[GitHub] [kafka] mimaison merged pull request #9131: KAFKA-10367: Allow running the Streams demo app with a config file

2020-08-22 Thread GitBox
mimaison merged pull request #9131: URL: https://github.com/apache/kafka/pull/9131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (KAFKA-10211) Add DirectoryConfigProvider

2020-08-22 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-10211. Fix Version/s: 2.7.0 Resolution: Fixed > Add DirectoryConfigProvider >

[GitHub] [kafka] mimaison merged pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-22 Thread GitBox
mimaison merged pull request #9136: URL: https://github.com/apache/kafka/pull/9136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mimaison commented on pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-22 Thread GitBox
mimaison commented on pull request #9136: URL: https://github.com/apache/kafka/pull/9136#issuecomment-678651902 Test failures are not related, merging This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] badaiaqrandista commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-08-22 Thread GitBox
badaiaqrandista commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-678641314 @bbejeck Thank you for including the changes in the test. I've fixed the errors found by the test. Please test again.

[GitHub] [kafka] ivandasch commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

2020-08-22 Thread GitBox
ivandasch commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475088577 ## File path: tests/kafkatest/version.py ## @@ -49,6 +49,34 @@ def __str__(self): else: return LooseVersion.__str__(self) +def

[GitHub] [kafka] ivandasch commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

2020-08-22 Thread GitBox
ivandasch commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475086470 ## File path: tests/kafkatest/benchmarks/core/benchmark_test.py ## @@ -88,7 +88,7 @@ def test_producer_throughput(self, acks, topic, num_producers=1, mes

[GitHub] [kafka] khaireddine120 opened a new pull request #9209: Minor enhance copy array

2020-08-22 Thread GitBox
khaireddine120 opened a new pull request #9209: URL: https://github.com/apache/kafka/pull/9209 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of te

[GitHub] [kafka] khaireddine120 opened a new pull request #9208: Minor init singleton list

2020-08-22 Thread GitBox
khaireddine120 opened a new pull request #9208: URL: https://github.com/apache/kafka/pull/9208 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of te

[GitHub] [kafka] khaireddine120 opened a new pull request #9207: Minor remove semicolon

2020-08-22 Thread GitBox
khaireddine120 opened a new pull request #9207: URL: https://github.com/apache/kafka/pull/9207 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of te

[GitHub] [kafka] chia7712 opened a new pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-08-22 Thread GitBox
chia7712 opened a new pull request #9206: URL: https://github.com/apache/kafka/pull/9206 steal some memory back from hot method :) ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status