chia7712 commented on pull request #9250:
URL: https://github.com/apache/kafka/pull/9250#issuecomment-691601314
https://github.com/apache/kafka/blob/trunk/connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHeartbeatConnector.java#L64
```
@Override
chia7712 commented on pull request #9250:
URL: https://github.com/apache/kafka/pull/9250#issuecomment-691600174
Could you add unit test?
This is an automated message from the Apache Git Service.
To respond to the message,
vgvineet4 commented on pull request #9254:
URL: https://github.com/apache/kafka/pull/9254#issuecomment-691447099
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-690907900
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
bbejeck merged pull request #9207:
URL: https://github.com/apache/kafka/pull/9207
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bbejeck merged pull request #9208:
URL: https://github.com/apache/kafka/pull/9208
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on pull request #9223:
URL: https://github.com/apache/kafka/pull/9223#issuecomment-690883668
```
kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota
```
pass on my local.
ableegoldman commented on pull request #8892:
URL: https://github.com/apache/kafka/pull/8892#issuecomment-691358663
Alright this should finally be ready for a final pass and merge @vvcephei
@cadonna -- sorry for leaving this hanging for so long.
After running a few different tests,
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691058386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vvcephei commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r487170646
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -131,14 +157,15 @@ public
showuon commented on pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#issuecomment-691495483
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vvcephei merged pull request #9239:
URL: https://github.com/apache/kafka/pull/9239
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
xakassi commented on a change in pull request #9211:
URL: https://github.com/apache/kafka/pull/9211#discussion_r478325832
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java
##
@@ -733,10 +734,11 @@ public void
lct45 commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r487110043
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -131,14 +157,15 @@ public void
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486750612
##
File path: core/src/main/scala/kafka/log/LogCleaner.scala
##
@@ -203,16 +203,24 @@ class LogCleaner(initialConfig: CleanerConfig,
}
/**
- *
mjsax commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r487321249
##
File path: clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java
##
@@ -784,4 +787,39 @@ public void testCloseAllQuietly() {
big-andy-coates commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r487049443
##
File path:
clients/src/main/java/org/apache/kafka/server/authorizer/AuthorizableRequestContext.java
##
@@ -17,11 +17,12 @@
package
MicahRam edited a comment on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-691315131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
nym3r0s commented on a change in pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#discussion_r487394821
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
##
@@ -418,10 +419,14 @@ private boolean
bbejeck commented on pull request #9208:
URL: https://github.com/apache/kafka/pull/9208#issuecomment-691477247
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
guozhangwang merged pull request #9264:
URL: https://github.com/apache/kafka/pull/9264
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jeqo commented on pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#issuecomment-691045209
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
guozhangwang commented on pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#issuecomment-691389142
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vvcephei commented on pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#issuecomment-691224736
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chia7712 commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-690884676
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ableegoldman commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486750661
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KGroupedStreamImplTest.java
##
@@ -239,52 +241,81 @@ private void
mjsax commented on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-691339633
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
bbejeck commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-691481266
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tombentley commented on pull request #9266:
URL: https://github.com/apache/kafka/pull/9266#issuecomment-690954007
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
MicahRam commented on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-691315131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mjsax commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r487166164
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableAggregate.java
##
@@ -47,8 +47,10 @@
}
@Override
-
bbejeck commented on pull request #9209:
URL: https://github.com/apache/kafka/pull/9209#issuecomment-691479008
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
DOJI45 commented on a change in pull request #9247:
URL: https://github.com/apache/kafka/pull/9247#discussion_r487431539
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -662,4 +662,10 @@ public TopicPartition
chia7712 commented on pull request #9271:
URL: https://github.com/apache/kafka/pull/9271#issuecomment-691397979
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
showuon commented on pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#issuecomment-690856399
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bbejeck merged pull request #9209:
URL: https://github.com/apache/kafka/pull/9209
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ableegoldman commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691357934
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ableegoldman commented on a change in pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#discussion_r487336115
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
##
@@ -418,10 +419,14 @@ private boolean
ableegoldman commented on pull request #8892:
URL: https://github.com/apache/kafka/pull/8892#issuecomment-691358663
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
bbejeck merged pull request #9208:
URL: https://github.com/apache/kafka/pull/9208
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691058386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chia7712 commented on pull request #9223:
URL: https://github.com/apache/kafka/pull/9223#issuecomment-690883668
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vvcephei commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486742113
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -877,4 +1003,56 @@ private
showuon commented on pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#issuecomment-691495483
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
xakassi commented on a change in pull request #9211:
URL: https://github.com/apache/kafka/pull/9211#discussion_r478325832
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java
##
@@ -733,10 +734,11 @@ public void
bbejeck merged pull request #9207:
URL: https://github.com/apache/kafka/pull/9207
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vgvineet4 commented on pull request #9254:
URL: https://github.com/apache/kafka/pull/9254#issuecomment-691447099
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-690907900
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mjsax commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r487321249
##
File path: clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java
##
@@ -784,4 +787,39 @@ public void testCloseAllQuietly() {
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486747077
##
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##
@@ -354,12 +354,30 @@ private[log] class LogCleanerManager(val logDirs:
Seq[File],
big-andy-coates commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r487049443
##
File path:
clients/src/main/java/org/apache/kafka/server/authorizer/AuthorizableRequestContext.java
##
@@ -17,11 +17,12 @@
package
nym3r0s commented on a change in pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#discussion_r487394821
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
##
@@ -418,10 +419,14 @@ private boolean
MicahRam edited a comment on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-691315131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tombentley commented on pull request #9266:
URL: https://github.com/apache/kafka/pull/9266#issuecomment-690954007
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
bbejeck commented on pull request #9208:
URL: https://github.com/apache/kafka/pull/9208#issuecomment-691477247
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jeqo commented on pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#issuecomment-691045209
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
guozhangwang commented on pull request #8834:
URL: https://github.com/apache/kafka/pull/8834#issuecomment-690810983
Cherry-picked to 2.6
This is an automated message from the Apache Git Service.
To respond to the message,
guozhangwang merged pull request #9264:
URL: https://github.com/apache/kafka/pull/9264
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
guozhangwang commented on pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#issuecomment-691389142
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ableegoldman commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486750661
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KGroupedStreamImplTest.java
##
@@ -239,52 +241,81 @@ private void
chia7712 commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-690884676
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vvcephei commented on pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#issuecomment-690843020
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mjsax commented on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-691339633
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
bbejeck commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-691481266
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
MicahRam commented on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-691315131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mjsax commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r487166164
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableAggregate.java
##
@@ -47,8 +47,10 @@
}
@Override
-
bbejeck commented on pull request #9209:
URL: https://github.com/apache/kafka/pull/9209#issuecomment-691479008
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chia7712 commented on pull request #9271:
URL: https://github.com/apache/kafka/pull/9271#issuecomment-691397979
```
失敗
Build / JDK 8 /
org.apache.kafka.clients.admin.KafkaAdminClientTest.testMetadataRetries
```
it is already fixed by
DOJI45 commented on a change in pull request #9247:
URL: https://github.com/apache/kafka/pull/9247#discussion_r487431539
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -662,4 +662,10 @@ public TopicPartition
ableegoldman commented on pull request #8892:
URL: https://github.com/apache/kafka/pull/8892#issuecomment-691358663
Alright this should finally be ready for a final pass and merge @vvcephei
@cadonna -- sorry for leaving this hanging for so long.
After running a few different tests,
bbejeck merged pull request #9209:
URL: https://github.com/apache/kafka/pull/9209
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
showuon commented on pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#issuecomment-690856399
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ableegoldman commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691357934
Also, looks like there were checkstyle issues. Probably you just need to add
the license header to the new file
ableegoldman commented on a change in pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#discussion_r487336115
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
##
@@ -418,10 +419,14 @@ private boolean
bbejeck merged pull request #9208:
URL: https://github.com/apache/kafka/pull/9208
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on pull request #9223:
URL: https://github.com/apache/kafka/pull/9223#issuecomment-690883668
```
kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota
```
pass on my local.
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691058386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vvcephei merged pull request #9239:
URL: https://github.com/apache/kafka/pull/9239
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
showuon commented on pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#issuecomment-691495483
Merge the latest trunk to have auto test.
This is an automated message from the Apache Git Service.
To respond to
vvcephei commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486742113
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -877,4 +1003,56 @@ private
xakassi commented on a change in pull request #9211:
URL: https://github.com/apache/kafka/pull/9211#discussion_r478325832
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java
##
@@ -733,10 +734,11 @@ public void
lct45 commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r487110043
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -131,14 +157,15 @@ public void
DOJI45 commented on a change in pull request #9247:
URL: https://github.com/apache/kafka/pull/9247#discussion_r487431637
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -332,6 +332,15 @@ public void resume() {
DOJI45 commented on a change in pull request #9247:
URL: https://github.com/apache/kafka/pull/9247#discussion_r487431539
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -662,4 +662,10 @@ public TopicPartition
asdaraujo opened a new pull request #9281:
URL: https://github.com/apache/kafka/pull/9281
Remove the requirement for unique port numbers for the advertised.listener
parameters.
This restriction makes for the listeners parameter but there's not reason to
apply the
same logic for
showuon commented on pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#issuecomment-691495483
Merge the latest trunk to have auto test.
This is an automated message from the Apache Git Service.
To respond to
bbejeck commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-691481426
Thanks for the cleanup @khaireddine120!
This is an automated message from the Apache Git Service.
To respond to
bbejeck commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-691481266
Minor cleanup, I ran the tests locally and all passed, merging this now.
This is an automated message from the
bbejeck merged pull request #9207:
URL: https://github.com/apache/kafka/pull/9207
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bbejeck merged pull request #9209:
URL: https://github.com/apache/kafka/pull/9209
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bbejeck commented on pull request #9209:
URL: https://github.com/apache/kafka/pull/9209#issuecomment-691479180
Thanks @khaireddine120 for the clean-up!
This is an automated message from the Apache Git Service.
To respond to
bbejeck commented on pull request #9209:
URL: https://github.com/apache/kafka/pull/9209#issuecomment-691479008
This is a minor PR fix, I ran the tests locally, all passed so I'm merging
this.
This is an automated message
bbejeck commented on pull request #9208:
URL: https://github.com/apache/kafka/pull/9208#issuecomment-691477247
This PR is minor changes for streams. I ran the tests locally, so I merging
this.
This is an automated message
bbejeck commented on pull request #9208:
URL: https://github.com/apache/kafka/pull/9208#issuecomment-691477282
Thanks for the contribution @khaireddine120!
This is an automated message from the Apache Git Service.
To respond
bbejeck merged pull request #9208:
URL: https://github.com/apache/kafka/pull/9208
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691464378
@ableegoldman - you're right. I've missed out the license header. I'll also
add the tests for the change. thank you
nym3r0s commented on a change in pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#discussion_r487394821
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
##
@@ -418,10 +419,14 @@ private boolean
vgvineet4 commented on pull request #9254:
URL: https://github.com/apache/kafka/pull/9254#issuecomment-691447099
@ijuma Please have a look
This is an automated message from the Apache Git Service.
To respond to the message,
98 matches
Mail list logo
