[jira] [Commented] (KAFKA-9220) TimeoutException when using kafka-preferred-replica-election

2020-09-28 Thread Or Shemesh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203648#comment-17203648 ] Or Shemesh commented on KAFKA-9220: --- [~akumar] Go for it and take it:) Thanks!!! > TimeoutException

[GitHub] [kafka] chia7712 opened a new pull request #9349: MINOR: add proper checks to KafkaConsumer.groupMetadata

2020-09-28 Thread GitBox
chia7712 opened a new pull request #9349: URL: https://github.com/apache/kafka/pull/9349 add following checks to ```KafkaConsumer.groupMetadata``` 1. null check of coordinator (replace NPE by ```InvalidGroupIdException``` which is same to other methods) 1. concurrent check

[GitHub] [kafka] hachikuji opened a new pull request #9348: KAFKA-10527; Voters should not reinitialize as leader in same epoch

2020-09-28 Thread GitBox
hachikuji opened a new pull request #9348: URL: https://github.com/apache/kafka/pull/9348 One of the invariants that the raft replication protocol attempts to ensure is that each record is uniquely identified by leader epoch and offset. This can be violated if a leader remains elected

[jira] [Commented] (KAFKA-10513) Newly added topic or partitions are not assigned to running consumer groups using static membership

2020-09-28 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203622#comment-17203622 ] Guozhang Wang commented on KAFKA-10513: --- [~mou@ea] could you try setting the `metadata.max.age.ms`

[jira] [Commented] (KAFKA-10530) kafka-streams-application-reset misses some internal topics

2020-09-28 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203616#comment-17203616 ] John Roesler commented on KAFKA-10530: -- Thanks for the report [~oweiler] , and sorry for the

[jira] [Commented] (KAFKA-8266) Improve `testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup`

2020-09-28 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203601#comment-17203601 ] Chia-Ping Tsai commented on KAFKA-8266: --- flaky again :(

[GitHub] [kafka] chia7712 commented on a change in pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9284: URL: https://github.com/apache/kafka/pull/9284#discussion_r496340632 ## File path: docs/upgrade.html ## @@ -27,6 +27,14 @@ Notable changes in 2 default.api.timeout.ms, and Kafka Streams' new task.timeout.ms

[GitHub] [kafka] asdaraujo commented on a change in pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-09-28 Thread GitBox
asdaraujo commented on a change in pull request #8730: URL: https://github.com/apache/kafka/pull/8730#discussion_r496335557 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -201,26 +213,24 @@ public void

[GitHub] [kafka] asdaraujo commented on a change in pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-09-28 Thread GitBox
asdaraujo commented on a change in pull request #8730: URL: https://github.com/apache/kafka/pull/8730#discussion_r496326988 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -201,26 +213,24 @@ public void

[GitHub] [kafka] junrao commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-28 Thread GitBox
junrao commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496093216 ## File path: clients/src/main/resources/common/message/ApiVersionsResponse.json ## @@ -55,8 +55,8 @@ "about": "The maximum supported version for

[GitHub] [kafka] abbccdda commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-28 Thread GitBox
abbccdda commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496321312 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -1214,6 +1215,71 @@ default AlterClientQuotasResult

[jira] [Resolved] (KAFKA-10511) Fix minor behavior difference in `MockLog`

2020-09-28 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10511. - Resolution: Fixed > Fix minor behavior difference in `MockLog` >

[GitHub] [kafka] asdaraujo commented on a change in pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-09-28 Thread GitBox
asdaraujo commented on a change in pull request #8730: URL: https://github.com/apache/kafka/pull/8730#discussion_r496306777 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -283,49 +296,140 @@ public void

[GitHub] [kafka] asdaraujo commented on a change in pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-09-28 Thread GitBox
asdaraujo commented on a change in pull request #8730: URL: https://github.com/apache/kafka/pull/8730#discussion_r496306298 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -283,49 +296,140 @@ public void

[GitHub] [kafka] asdaraujo commented on a change in pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-09-28 Thread GitBox
asdaraujo commented on a change in pull request #8730: URL: https://github.com/apache/kafka/pull/8730#discussion_r496306398 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -136,10 +141,19 @@ public void

[GitHub] [kafka] rhauch commented on pull request #8134: KAFKA-9546 Allow custom tasks through configuration

2020-09-28 Thread GitBox
rhauch commented on pull request #8134: URL: https://github.com/apache/kafka/pull/8134#issuecomment-700351105 As noted on https://issues.apache.org/jira/browse/KAFKA-9546, I'm not convinced this is useful change, since it would complicate these example connectors that ship with AK and

[jira] [Commented] (KAFKA-9546) Make FileStreamSourceTask extendable with generic streams

2020-09-28 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203563#comment-17203563 ] Randall Hauch commented on KAFKA-9546: -- [~galyo], thanks for the suggestion and the PR. I've added

[GitHub] [kafka] hachikuji commented on pull request #9280: KAFKA-10186: Abort transaction with pending data with TransactionAbortedException

2020-09-28 Thread GitBox
hachikuji commented on pull request #9280: URL: https://github.com/apache/kafka/pull/9280#issuecomment-700349997 @nym3r0s Take a look at `SenderTest.testForceShutdownWithIncompleteTransaction`. I think we could add a similar test which aborts the transaction directly before the Produce

[GitHub] [kafka] hachikuji merged pull request #9332: KAFKA-10511; Ensure monotonic start epoch/offset updates in `MockLog`

2020-09-28 Thread GitBox
hachikuji merged pull request #9332: URL: https://github.com/apache/kafka/pull/9332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-9546) Make FileStreamSourceTask extendable with generic streams

2020-09-28 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9546: - Labels: connect-api needs-kip (was: connect-api) > Make FileStreamSourceTask extendable with

[GitHub] [kafka] rhauch commented on a change in pull request #9319: KAFKA-10413 Allow even distribution of lost/new tasks when more than one worker j…

2020-09-28 Thread GitBox
rhauch commented on a change in pull request #9319: URL: https://github.com/apache/kafka/pull/9319#discussion_r496296182 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java ## @@ -260,7 +259,7 @@ private

[GitHub] [kafka] rhauch commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-09-28 Thread GitBox
rhauch commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r496239771 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -138,6 +139,7 @@ public

[GitHub] [kafka] rhauch merged pull request #8973: KAFKA-10218: Stop reading config topic in every subsequent tick if catchup fails once

2020-09-28 Thread GitBox
rhauch merged pull request #8973: URL: https://github.com/apache/kafka/pull/8973 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji commented on a change in pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-28 Thread GitBox
hachikuji commented on a change in pull request #9284: URL: https://github.com/apache/kafka/pull/9284#discussion_r496287274 ## File path: docs/upgrade.html ## @@ -27,6 +27,14 @@ Notable changes in 2 default.api.timeout.ms, and Kafka Streams' new task.timeout.ms

[GitHub] [kafka] C0urante commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-09-28 Thread GitBox
C0urante commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r446490310 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -689,6 +692,10 @@ else if

[jira] [Updated] (KAFKA-10532) Do not wipe state store under EOS when closing-dirty a RESTORING active or RUNNING standby task

2020-09-28 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10532: -- Description: Today whenever we are closing-dirty a task, we always wipe out the state stores

[jira] [Updated] (KAFKA-10532) Do not wipe state store under EOS when closing-dirty a RESTORING active or RUNNING standby task

2020-09-28 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10532: -- Summary: Do not wipe state store under EOS when closing-dirty a RESTORING active or RUNNING

[jira] [Created] (KAFKA-10532) Do not wipe state store under EOS when closing a RESTORING active or RUNNING standby task

2020-09-28 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10532: - Summary: Do not wipe state store under EOS when closing a RESTORING active or RUNNING standby task Key: KAFKA-10532 URL: https://issues.apache.org/jira/browse/KAFKA-10532

[GitHub] [kafka] vvcephei commented on a change in pull request #9346: KAFKA-8410: Split ProcessorContext into Processor/StateStore/RecordContext

2020-09-28 Thread GitBox
vvcephei commented on a change in pull request #9346: URL: https://github.com/apache/kafka/pull/9346#discussion_r496227502 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java ## @@ -90,7 +90,7 @@ void register(final StateStore store,

[GitHub] [kafka] soondenana commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-09-28 Thread GitBox
soondenana commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r496275381 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java ## @@ -133,11 +134,14 @@ public void start() {

[GitHub] [kafka] rhauch commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-09-28 Thread GitBox
rhauch commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r496239771 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -138,6 +139,7 @@ public

[jira] [Assigned] (KAFKA-10455) Probing rebalances are not guaranteed to be triggered by non-leader members

2020-09-28 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-10455: --- Assignee: Leah Thomas > Probing rebalances are not guaranteed to be

[GitHub] [kafka] soondenana commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-09-28 Thread GitBox
soondenana commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r496272243 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java ## @@ -163,6 +163,18 @@ public void start() {

[GitHub] [kafka] soondenana commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-09-28 Thread GitBox
soondenana commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r496271194 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java ## @@ -536,6 +536,22 @@ public void

[GitHub] [kafka] ijuma commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-09-28 Thread GitBox
ijuma commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r496270860 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java ## @@ -133,11 +134,14 @@ public void start() { List

[GitHub] [kafka] ijuma commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-09-28 Thread GitBox
ijuma commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r496270581 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java ## @@ -163,6 +163,18 @@ public void start() {

[GitHub] [kafka] soondenana commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-09-28 Thread GitBox
soondenana commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r496267175 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java ## @@ -163,6 +163,18 @@ public void start() {

[GitHub] [kafka] soondenana commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-09-28 Thread GitBox
soondenana commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r496263965 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java ## @@ -163,6 +163,18 @@ public void start() {

[GitHub] [kafka] ijuma commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-09-28 Thread GitBox
ijuma commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r496240453 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java ## @@ -163,6 +163,18 @@ public void start() {

[GitHub] [kafka] splett2 commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-09-28 Thread GitBox
splett2 commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r496238384 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java ## @@ -536,6 +536,22 @@ public void

[jira] [Issue Comment Deleted] (KAFKA-9370) Return UNKNOWN_TOPIC_OR_PARTITION if topic deletion is in progress

2020-09-28 Thread Vikas Singh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Singh updated KAFKA-9370: --- Comment: was deleted (was: https://github.com/apache/kafka/pull/9347) > Return

[jira] [Commented] (KAFKA-9370) Return UNKNOWN_TOPIC_OR_PARTITION if topic deletion is in progress

2020-09-28 Thread Vikas Singh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203527#comment-17203527 ] Vikas Singh commented on KAFKA-9370: https://github.com/apache/kafka/pull/9347 > Return

[GitHub] [kafka] soondenana opened a new pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-09-28 Thread GitBox
soondenana opened a new pull request #9347: URL: https://github.com/apache/kafka/pull/9347 System.currentTimeMillis() is not monotonic, so using that to calculate time to sleep can result in negative values. That will throw IllegalArgumentException. This change checks for that

[GitHub] [kafka] vvcephei opened a new pull request #9346: KAFKA-8410: Split ProcessorContext into Processor/StateStore/RecordContext

2020-09-28 Thread GitBox
vvcephei opened a new pull request #9346: URL: https://github.com/apache/kafka/pull/9346 Split up the ProcessorContext into separate containers more appropriate for usage in `Processor#init` (`api.ProcessorContext`), `StateStore#init` (`StateStoreContext`), and `Processor#process`

[jira] [Updated] (KAFKA-9584) Removing headers causes ConcurrentModificationException

2020-09-28 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-9584: Fix Version/s: 2.6.1 2.5.2 2.7.0 > Removing headers causes

[GitHub] [kafka] vvcephei commented on pull request #8181: KAFKA-9584 Headers ConcurrentModificationException

2020-09-28 Thread GitBox
vvcephei commented on pull request #8181: URL: https://github.com/apache/kafka/pull/8181#issuecomment-700274192 Cherry-picked to 2.6 and 2.5. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mjsax commented on pull request #9027: KAFKA-9161: add docs for KIP-441 and KIP-613 and other configs that need fixing

2020-09-28 Thread GitBox
mjsax commented on pull request #9027: URL: https://github.com/apache/kafka/pull/9027#issuecomment-700260133 Cherry-picked to `2.6`. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] mjsax commented on pull request #9308: MINOR: streams docs fixes

2020-09-28 Thread GitBox
mjsax commented on pull request #9308: URL: https://github.com/apache/kafka/pull/9308#issuecomment-700260093 Cherry-picked to `2.6`. This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Assigned] (KAFKA-10531) KafkaBasedLog can sleep for negative values

2020-09-28 Thread Vikas Singh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Singh reassigned KAFKA-10531: --- Assignee: Vikas Singh > KafkaBasedLog can sleep for negative values >

[GitHub] [kafka] tahseen447 commented on pull request #5876: KAFKA-7509: Avoid passing most non-applicable properties to producer, consumer, and admin client

2020-09-28 Thread GitBox
tahseen447 commented on pull request #5876: URL: https://github.com/apache/kafka/pull/5876#issuecomment-700252065 just checking in, has this been resolved? This is an automated message from the Apache Git Service. To

[jira] [Created] (KAFKA-10531) KafkaBasedLog can sleep for negative values

2020-09-28 Thread Vikas Singh (Jira)
Vikas Singh created KAFKA-10531: --- Summary: KafkaBasedLog can sleep for negative values Key: KAFKA-10531 URL: https://issues.apache.org/jira/browse/KAFKA-10531 Project: Kafka Issue Type: Bug

[GitHub] [kafka] vvcephei merged pull request #8181: KAFKA-9584 Headers ConcurrentModificationException

2020-09-28 Thread GitBox
vvcephei merged pull request #8181: URL: https://github.com/apache/kafka/pull/8181 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vvcephei commented on pull request #8181: KAFKA-9584 Headers ConcurrentModificationException

2020-09-28 Thread GitBox
vvcephei commented on pull request #8181: URL: https://github.com/apache/kafka/pull/8181#issuecomment-700246317 Thanks, @MicahRam ! That failure looks unrelated: `Build / JDK 11 / kafka.network.ConnectionQuotasTest.testNoConnectionLimitsByDefault`

[GitHub] [kafka] rajinisivaram merged pull request #9317: KAFKA-10509: Added throttle connection accept rate metric (KIP-612)

2020-09-28 Thread GitBox
rajinisivaram merged pull request #9317: URL: https://github.com/apache/kafka/pull/9317 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9344: MINOR; Preserve ThrottlingQuotaExceededException when request timeouts after being retried due to a quota violation (KIP-599

2020-09-28 Thread GitBox
rajinisivaram commented on a change in pull request #9344: URL: https://github.com/apache/kafka/pull/9344#discussion_r496173659 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -1554,6 +1575,11 @@ private ConfigEntry

[GitHub] [kafka] rajinisivaram opened a new pull request #9345: KAFKA-10338; Support PEM format for SSL key and trust stores (KIP-651)

2020-09-28 Thread GitBox
rajinisivaram opened a new pull request #9345: URL: https://github.com/apache/kafka/pull/9345 Adds support for SSL key and trust stores to be specified in PEM format either as files or directly as configuration values. ### Committer Checklist (excluded from commit message) - [ ]

[jira] [Commented] (KAFKA-10493) Ktable out-of-order updates are not being ignored

2020-09-28 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203430#comment-17203430 ] John Roesler commented on KAFKA-10493: -- I've marked this for 3.0 so that we could consider adding

[jira] [Updated] (KAFKA-10493) Ktable out-of-order updates are not being ignored

2020-09-28 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10493: - Fix Version/s: 3.0.0 > Ktable out-of-order updates are not being ignored >

[jira] [Updated] (KAFKA-10493) Ktable out-of-order updates are not being ignored

2020-09-28 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10493: - Priority: Critical (was: Major) > Ktable out-of-order updates are not being ignored >

[GitHub] [kafka] rhauch commented on pull request #9306: KAFKA-10477: Enabling the same behavior of NULL JsonNodeType to MISSI…

2020-09-28 Thread GitBox
rhauch commented on pull request #9306: URL: https://github.com/apache/kafka/pull/9306#issuecomment-700182723 @shaikzakiriitm, you mentioned above: > From v2.10.0 onwards, in jackson lib, ObjectMapper.readTree(input) started to return JsonNode of type MISSING for empty input, as

[GitHub] [kafka] ramesh-muthusamy commented on pull request #9319: KAFKA-10413 Allow even distribution of lost/new tasks when more than one worker j…

2020-09-28 Thread GitBox
ramesh-muthusamy commented on pull request #9319: URL: https://github.com/apache/kafka/pull/9319#issuecomment-700171024 @kkonstantine can you help reviewing this PR This is an automated message from the Apache Git Service.

[GitHub] [kafka] chia7712 commented on pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

2020-09-28 Thread GitBox
chia7712 commented on pull request #9102: URL: https://github.com/apache/kafka/pull/9102#issuecomment-700149221 rebase to trigger new QA This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (KAFKA-10513) Newly added topic or partitions are not assigned to running consumer groups using static membership

2020-09-28 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203342#comment-17203342 ] Boyang Chen commented on KAFKA-10513: - My understanding is that the consumer was supposed to check

[GitHub] [kafka] tombentley commented on a change in pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-28 Thread GitBox
tombentley commented on a change in pull request #9266: URL: https://github.com/apache/kafka/pull/9266#discussion_r496048334 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -2061,11 +2062,12 @@ class

[GitHub] [kafka] chia7712 commented on a change in pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9284: URL: https://github.com/apache/kafka/pull/9284#discussion_r496013137 ## File path: docs/upgrade.html ## @@ -27,6 +27,14 @@ Notable changes in 2 default.api.timeout.ms, and Kafka Streams' new task.timeout.ms

[GitHub] [kafka] ijuma commented on a change in pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-28 Thread GitBox
ijuma commented on a change in pull request #9284: URL: https://github.com/apache/kafka/pull/9284#discussion_r496011734 ## File path: docs/upgrade.html ## @@ -27,6 +27,14 @@ Notable changes in 2 default.api.timeout.ms, and Kafka Streams' new task.timeout.ms

[GitHub] [kafka] scanterog commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-09-28 Thread GitBox
scanterog commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r495995224 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -199,8 +199,8 @@ protected static

[GitHub] [kafka] scanterog commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-09-28 Thread GitBox
scanterog commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r495995224 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -199,8 +199,8 @@ protected static

[GitHub] [kafka] scanterog commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-09-28 Thread GitBox
scanterog commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r495995224 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -199,8 +199,8 @@ protected static

[GitHub] [kafka] chia7712 commented on a change in pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9284: URL: https://github.com/apache/kafka/pull/9284#discussion_r495992169 ## File path: docs/upgrade.html ## @@ -27,6 +27,14 @@ Notable changes in 2 default.api.timeout.ms, and Kafka Streams' new task.timeout.ms

[GitHub] [kafka] ijuma commented on a change in pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-28 Thread GitBox
ijuma commented on a change in pull request #9284: URL: https://github.com/apache/kafka/pull/9284#discussion_r495988153 ## File path: docs/upgrade.html ## @@ -27,6 +27,14 @@ Notable changes in 2 default.api.timeout.ms, and Kafka Streams' new task.timeout.ms

[GitHub] [kafka] chia7712 commented on a change in pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9284: URL: https://github.com/apache/kafka/pull/9284#discussion_r495983768 ## File path: core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala ## @@ -327,10 +327,12 @@ class DynamicBrokerConfigTest {

[GitHub] [kafka] chia7712 commented on a change in pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9284: URL: https://github.com/apache/kafka/pull/9284#discussion_r495983283 ## File path: docs/upgrade.html ## @@ -27,6 +27,14 @@ Notable changes in 2 default.api.timeout.ms, and Kafka Streams' new task.timeout.ms

[GitHub] [kafka] ijuma commented on a change in pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-28 Thread GitBox
ijuma commented on a change in pull request #9266: URL: https://github.com/apache/kafka/pull/9266#discussion_r495975325 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -2061,11 +2062,12 @@ class PlaintextAdminIntegrationTest

[GitHub] [kafka] mimaison commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-09-28 Thread GitBox
mimaison commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r495975721 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -199,8 +199,8 @@ protected static

[GitHub] [kafka] ijuma commented on a change in pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-28 Thread GitBox
ijuma commented on a change in pull request #9284: URL: https://github.com/apache/kafka/pull/9284#discussion_r495974098 ## File path: core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala ## @@ -327,10 +327,12 @@ class DynamicBrokerConfigTest {

[GitHub] [kafka] ijuma commented on a change in pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-28 Thread GitBox
ijuma commented on a change in pull request #9284: URL: https://github.com/apache/kafka/pull/9284#discussion_r495973438 ## File path: docs/upgrade.html ## @@ -27,6 +27,14 @@ Notable changes in 2 default.api.timeout.ms, and Kafka Streams' new task.timeout.ms

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r495966600 ## File path: core/src/main/resources/common/message/GroupMetadataResponse.json ## @@ -0,0 +1,103 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r495940420 ## File path: core/src/main/resources/common/message/OffsetCommitRequest.json ## @@ -0,0 +1,37 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r495940420 ## File path: core/src/main/resources/common/message/OffsetCommitRequest.json ## @@ -0,0 +1,37 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r495932581 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -997,173 +996,45 @@ object GroupMetadataManager { val

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r495919910 ## File path: core/src/main/resources/common/message/OffsetCommitResponse.json ## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r495918349 ## File path: core/src/main/resources/common/message/GroupMetadataRequest.json ## @@ -0,0 +1,27 @@ +// Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (KAFKA-9747) No tasks created for a connector

2020-09-28 Thread Igor (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203203#comment-17203203 ] Igor commented on KAFKA-9747: - Same issue for Debezium (SqlServer connector) > No tasks created for a

[GitHub] [kafka] dajac commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-28 Thread GitBox
dajac commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r495882544 ## File path: core/src/main/resources/common/message/GroupMetadataResponse.json ## @@ -0,0 +1,103 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] scanterog commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-09-28 Thread GitBox
scanterog commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r495871017 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -199,8 +199,8 @@ protected static

[GitHub] [kafka] dajac opened a new pull request #9344: MINOR; Preserve ThrottlingQuotaExceededException when request timeouts after being retried due to a quota violation (KIP-599)

2020-09-28 Thread GitBox
dajac opened a new pull request #9344: URL: https://github.com/apache/kafka/pull/9344 KIP-599 had proposed to keep returning the `ThrottlingQuotaExceededException` to the called even when the request times out due to reaching `default.api.timeout.ms`. The current implementation does not

[GitHub] [kafka] mimaison commented on pull request #9343: KAFKA-10332: Update MM2 refreshTopicPartitions() logic

2020-09-28 Thread GitBox
mimaison commented on pull request #9343: URL: https://github.com/apache/kafka/pull/9343#issuecomment-699932205 cc @ryannedolan This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mimaison opened a new pull request #9343: KAFKA-10332: Update MM2 refreshTopicPartitions() logic

2020-09-28 Thread GitBox
mimaison opened a new pull request #9343: URL: https://github.com/apache/kafka/pull/9343 Trigger task reconfiguration when: - topic-partitions are created or deleted on source cluster - topic-partitions are missing on target cluster Co-authored-by: Mickael Maison

[jira] [Created] (KAFKA-10530) kafka-streams-application-reset misses some internal topics

2020-09-28 Thread Oliver Weiler (Jira)
Oliver Weiler created KAFKA-10530: - Summary: kafka-streams-application-reset misses some internal topics Key: KAFKA-10530 URL: https://issues.apache.org/jira/browse/KAFKA-10530 Project: Kafka

[GitHub] [kafka] edenhill commented on a change in pull request #9196: KAFKA-10402: Upgrade system tests to python3

2020-09-28 Thread GitBox
edenhill commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r495836397 ## File path: tests/docker/Dockerfile ## @@ -32,9 +32,11 @@ ARG ducker_creator=default LABEL ducker.creator=$ducker_creator # Update Linux and install

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: KAFKA-10402: Upgrade system tests to python3

2020-09-28 Thread GitBox
nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r495820772 ## File path: tests/docker/Dockerfile ## @@ -32,9 +32,11 @@ ARG ducker_creator=default LABEL ducker.creator=$ducker_creator # Update Linux and install

[GitHub] [kafka] mimaison commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-09-28 Thread GitBox
mimaison commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r495817863 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorConfigTest.java ## @@ -119,4 +120,41 @@ public void

[GitHub] [kafka] chia7712 commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-28 Thread GitBox
chia7712 commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-699902060 rebase to fix conflicts This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] edenhill commented on a change in pull request #9196: KAFKA-10402: Upgrade system tests to python3

2020-09-28 Thread GitBox
edenhill commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r495804848 ## File path: tests/docker/Dockerfile ## @@ -32,9 +32,11 @@ ARG ducker_creator=default LABEL ducker.creator=$ducker_creator # Update Linux and install

[GitHub] [kafka] manijndl7 commented on a change in pull request #9255: MINOR: Consolidate duplicated logic on reset tools

2020-09-28 Thread GitBox
manijndl7 commented on a change in pull request #9255: URL: https://github.com/apache/kafka/pull/9255#discussion_r495786493 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -1271,4 +1274,34 @@ private static byte checkRange(final byte i) {

[GitHub] [kafka] huangyiminghappy commented on pull request #9304: KAFKA-10502:TimestampRouter may occur threadlocal leak

2020-09-28 Thread GitBox
huangyiminghappy commented on pull request #9304: URL: https://github.com/apache/kafka/pull/9304#issuecomment-699862527 > Reading on the SO thread I think this fix makes sense. Merging to trunk now. thanks This is an

[GitHub] [kafka] thake commented on pull request #9338: Fixed KAFKA-10515: Serdes used within metered state stores will now be initialized with the default serdes if not already set.

2020-09-28 Thread GitBox
thake commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-699857289 The remaining failing tests do not seem to be related to this PR. This is an automated message from the Apache Git

[GitHub] [kafka] xakassi commented on pull request #9211: KAFKA-10426: Deadlock on session key update.

2020-09-28 Thread GitBox
xakassi commented on pull request #9211: URL: https://github.com/apache/kafka/pull/9211#issuecomment-699805679 Hi, guys! Hi, @kkonstantine ! This is my first PR to Kafka and I would like to clarify if there is anything else I need to do? Or should I just wait and you will take care of

[jira] [Created] (KAFKA-10529) Controller should throttle partition reassignment

2020-09-28 Thread Badai Aqrandista (Jira)
Badai Aqrandista created KAFKA-10529: Summary: Controller should throttle partition reassignment Key: KAFKA-10529 URL: https://issues.apache.org/jira/browse/KAFKA-10529 Project: Kafka

  1   2   >