[GitHub] [kafka] vamossagar12 commented on a change in pull request #9292: KAFKA-8238: adding number of messages/bytes read

2020-10-20 Thread GitBox
vamossagar12 commented on a change in pull request #9292: URL: https://github.com/apache/kafka/pull/9292#discussion_r509005854 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -670,12 +675,16 @@ class GroupMetadataManager(brokerId:

[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

2020-10-20 Thread jiamei xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218122#comment-17218122 ] jiamei xie commented on KAFKA-10136: [~chia7712] Great(y). The assignee is empty now. > Make option

[jira] [Assigned] (KAFKA-10136) Make option threads of ConsumerPerformance work

2020-10-20 Thread jiamei xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jiamei xie reassigned KAFKA-10136: -- Assignee: (was: jiamei xie) > Make option threads of ConsumerPerformance work >

[GitHub] [kafka] xakassi commented on pull request #9431: KAFKA-10426: Deadlock on session key update.

2020-10-20 Thread GitBox
xakassi commented on pull request #9431: URL: https://github.com/apache/kafka/pull/9431#issuecomment-713319694 Great! Thank you, @kkonstantine ! One more question. I'm going to resolve my ticket https://issues.apache.org/jira/browse/KAFKA-10426 So which fix version should I set?

[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

2020-10-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218117#comment-17218117 ] Chia-Ping Tsai commented on KAFKA-10136: Don’t worry. We can keep the assignee empty until

[GitHub] [kafka] ning2008wisc commented on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-10-20 Thread GitBox
ning2008wisc commented on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-713306404 @edoardocomar @rhauch given this PR does not contain functional change and have been pending over 45 days, could you please direct me to the right reviewers to take a look?

[GitHub] [kafka] thake commented on pull request #9338: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-20 Thread GitBox
thake commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-713298460 Created #9467 for branch 2.6 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] thake opened a new pull request #9467: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-20 Thread GitBox
thake opened a new pull request #9467: URL: https://github.com/apache/kafka/pull/9467 This is a cherry pick of PR #9338 on branch 2.6. Also introduced the notion of WrappingNullableSerdes (aligned to the concept of WrappingNullableSerializer and WrappingNullableDeserializer) and

[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

2020-10-20 Thread jiamei xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218103#comment-17218103 ] jiamei xie commented on KAFKA-10136: [~chia7712] Unfortunately, I was transferred to another group

[GitHub] [kafka] jiameixie commented on pull request #8489: KAFKA-9857:Failed to build image ducker-ak-openjdk-8 on arm

2020-10-20 Thread GitBox
jiameixie commented on pull request #8489: URL: https://github.com/apache/kafka/pull/8489#issuecomment-713289768 @chia7712 Thanks. I have merged it. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] kowshik commented on pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method

2020-10-20 Thread GitBox
kowshik commented on pull request #9465: URL: https://github.com/apache/kafka/pull/9465#issuecomment-713285315 Thanks @chia7712 ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] thake commented on pull request #9338: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-20 Thread GitBox
thake commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-713278824 Sounds reasonable. What is the time line for the next release on 2.6? This is an automated message from the Apache

[GitHub] [kafka] ijuma commented on pull request #9460: MINOR: Fix JDK8 compatibility issue in Snappy

2020-10-20 Thread GitBox
ijuma commented on pull request #9460: URL: https://github.com/apache/kafka/pull/9460#issuecomment-713278909 Merged to trunk and cherry-picked to 2.7 branch. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ijuma merged pull request #9460: MINOR: Fix JDK8 compatibility issue in Snappy

2020-10-20 Thread GitBox
ijuma merged pull request #9460: URL: https://github.com/apache/kafka/pull/9460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] chia7712 commented on a change in pull request #9459: MINOR: Add some class javadoc to Admin client

2020-10-20 Thread GitBox
chia7712 commented on a change in pull request #9459: URL: https://github.com/apache/kafka/pull/9459#discussion_r508960771 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -45,15 +45,76 @@ /** * The administrative client for Kafka, which

[GitHub] [kafka] chia7712 merged pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method

2020-10-20 Thread GitBox
chia7712 merged pull request #9465: URL: https://github.com/apache/kafka/pull/9465 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 commented on pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method

2020-10-20 Thread GitBox
chia7712 commented on pull request #9465: URL: https://github.com/apache/kafka/pull/9465#issuecomment-713262554 > Thanks, would you be able to merge it? I don't have permission to do it. done :) This is an automated

[GitHub] [kafka] kowshik commented on pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method

2020-10-20 Thread GitBox
kowshik commented on pull request #9465: URL: https://github.com/apache/kafka/pull/9465#issuecomment-713261852 @chia7712 Thanks, would you be able to merge it? I don't have permission to do it. This is an automated message

[GitHub] [kafka] chia7712 commented on pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method

2020-10-20 Thread GitBox
chia7712 commented on pull request #9465: URL: https://github.com/apache/kafka/pull/9465#issuecomment-713260549 > Would it be ok to merge this PR? sure. thanks for your patch. Merge it to trunk :) This is an automated

[jira] [Commented] (KAFKA-10470) zstd decompression with small batches is slow and causes excessive GC

2020-10-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218064#comment-17218064 ] Chia-Ping Tsai commented on KAFKA-10470: [~yuzawa-san] Thanks for your effort on zstd-jni. Do

[GitHub] [kafka] kowshik edited a comment on pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method

2020-10-20 Thread GitBox
kowshik edited a comment on pull request #9465: URL: https://github.com/apache/kafka/pull/9465#issuecomment-713255922 @gwenshap @chia7712: Thanks for the review. The tests have mostly passed. There is one failure in JDK 15: `kafka.api.TransactionsBounceTest.testWithGroupId` but thats not

[GitHub] [kafka] kowshik commented on pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method

2020-10-20 Thread GitBox
kowshik commented on pull request #9465: URL: https://github.com/apache/kafka/pull/9465#issuecomment-713255922 @gwenshap @chia7712: Thanks for the review. The tests have mostly passed. There is one failure in JDK 15: `kafka.api.TransactionsBounceTest.testWithGroupId` but thats related to

[GitHub] [kafka] dongjinleekr commented on pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

2020-10-20 Thread GitBox
dongjinleekr commented on pull request #9414: URL: https://github.com/apache/kafka/pull/9414#issuecomment-713251214 @vvcephei Here it is; I updated the timeout to `IntegrationTestUtils.DEFAULT_TIMEOUT` and rebased onto the latest trunk also.

[GitHub] [kafka] ableegoldman commented on pull request #9466: KAFKA-10564: fix flaky test

2020-10-20 Thread GitBox
ableegoldman commented on pull request #9466: URL: https://github.com/apache/kafka/pull/9466#issuecomment-713249434 Cherrypicked to 2.6 & 2.7 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ableegoldman commented on pull request #9466: KAFKA-10564: fix flaky test

2020-10-20 Thread GitBox
ableegoldman commented on pull request #9466: URL: https://github.com/apache/kafka/pull/9466#issuecomment-713248930 Merged to trunk This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ableegoldman merged pull request #9466: KAFKA-10564: fix flaky test

2020-10-20 Thread GitBox
ableegoldman merged pull request #9466: URL: https://github.com/apache/kafka/pull/9466 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on pull request #9466: KAFKA-10564: fix flaky test

2020-10-20 Thread GitBox
ableegoldman commented on pull request #9466: URL: https://github.com/apache/kafka/pull/9466#issuecomment-713246622 Just one test failure, the known flaky `EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta`

[GitHub] [kafka] abbccdda opened a new pull request #9103: KAFKA-10181: Use Envelope RPC to do redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-10-20 Thread GitBox
abbccdda opened a new pull request #9103: URL: https://github.com/apache/kafka/pull/9103 This PR adds support for redirections of the following RPCs: 1. AlterConfigs 2. IncrementalAlterConfigs 3. AlterClientQuotas 4. CreateTopics The specific changes include:

[GitHub] [kafka] abbccdda closed pull request #9103: KAFKA-10181: Use Envelope RPC to do redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-10-20 Thread GitBox
abbccdda closed pull request #9103: URL: https://github.com/apache/kafka/pull/9103 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] abbccdda commented on pull request #9103: KAFKA-10181: Use Envelope RPC to do redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-10-20 Thread GitBox
abbccdda commented on pull request #9103: URL: https://github.com/apache/kafka/pull/9103#issuecomment-713244123 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-8602) StreamThread Dies Because Restore Consumer is not Subscribed to Any Topic

2020-10-20 Thread SeaAndHill (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218032#comment-17218032 ] SeaAndHill commented on KAFKA-8602: --- i got it ,thanks  [~mjsax] > StreamThread Dies Because Restore

[GitHub] [kafka] guozhangwang commented on a change in pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

2020-10-20 Thread GitBox
guozhangwang commented on a change in pull request #9418: URL: https://github.com/apache/kafka/pull/9418#discussion_r508910810 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/DataOutputWritable.java ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache

[jira] [Comment Edited] (KAFKA-10515) NPE: Foreign key join serde may not be initialized with default serde if application is distributed

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218008#comment-17218008 ] Bill Bejeck edited comment on KAFKA-10515 at 10/20/20, 11:47 PM: -

[GitHub] [kafka] bbejeck commented on pull request #9461: MINOR: Clean-up streams javadoc warnings

2020-10-20 Thread GitBox
bbejeck commented on pull request #9461: URL: https://github.com/apache/kafka/pull/9461#issuecomment-713200696 cherry-picked to 2.7 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] bbejeck commented on pull request #9461: MINOR: Clean-up streams javadoc warnings

2020-10-20 Thread GitBox
bbejeck commented on pull request #9461: URL: https://github.com/apache/kafka/pull/9461#issuecomment-713200300 merged #9461 into trunk This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (KAFKA-8733) Offline partitions occur when leader's disk is slow in reads while responding to follower fetch requests.

2020-10-20 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218000#comment-17218000 ] Cheng Tan commented on KAFKA-8733: -- Hi [~satish.duggana], [~flavr], and [~mingaliu], We are actively

[GitHub] [kafka] bbejeck merged pull request #9461: MINOR: Clean-up streams javadoc warnings

2020-10-20 Thread GitBox
bbejeck merged pull request #9461: URL: https://github.com/apache/kafka/pull/9461 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] bbejeck commented on pull request #9461: MINOR: Clean-up streams javadoc warnings

2020-10-20 Thread GitBox
bbejeck commented on pull request #9461: URL: https://github.com/apache/kafka/pull/9461#issuecomment-713197394 java doc changes only, so merging this This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] bbejeck commented on pull request #9237: KAFKA-10454 / Update copartitionSourceGroups when optimization algorithm is triggered

2020-10-20 Thread GitBox
bbejeck commented on pull request #9237: URL: https://github.com/apache/kafka/pull/9237#issuecomment-713197074 @lkokhreidze I tried to cherry-pick this to 2.6.1 as well, but the `TOPOLOGY_OPITIMIZATION_CONFIG` is part of 2.7 and doesn't compile on 2.6. Can you do a separate PR targeted

[GitHub] [kafka] bbejeck commented on pull request #9237: KAFKA-10454 / Update copartitionSourceGroups when optimization algorithm is triggered

2020-10-20 Thread GitBox
bbejeck commented on pull request #9237: URL: https://github.com/apache/kafka/pull/9237#issuecomment-713189428 cherry-picked to 2.7 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (KAFKA-10454) Kafka Streams Stuck in infinite REBALANCING loop when stream <> table join partitions don't match

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-10454. - Resolution: Fixed Resolved via https://github.com/apache/kafka/pull/9237 > Kafka Streams Stuck

[jira] [Updated] (KAFKA-10454) Kafka Streams Stuck in infinite REBALANCING loop when stream <> table join partitions don't match

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10454: Fix Version/s: 2.8.0 2.6.1 2.7.0 > Kafka Streams Stuck in

[GitHub] [kafka] guozhangwang commented on pull request #9464: KAFKA-10616: Always call prepare-commit before suspending for active tasks

2020-10-20 Thread GitBox
guozhangwang commented on pull request #9464: URL: https://github.com/apache/kafka/pull/9464#issuecomment-713182527 @ableegoldman this PR is ready for review and merge. This is an automated message from the Apache Git

[GitHub] [kafka] bbejeck commented on pull request #9237: KAFKA-10454 / Update copartitionSourceGroups when optimization algorithm is triggered

2020-10-20 Thread GitBox
bbejeck commented on pull request #9237: URL: https://github.com/apache/kafka/pull/9237#issuecomment-713180604 Thanks for the contribution @lkokhreidze! This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] bbejeck commented on pull request #9237: KAFKA-10454 / Update copartitionSourceGroups when optimization algorithm is triggered

2020-10-20 Thread GitBox
bbejeck commented on pull request #9237: URL: https://github.com/apache/kafka/pull/9237#issuecomment-713180469 Merged #9237 into trunk This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] bbejeck merged pull request #9237: KAFKA-10454 / Update copartitionSourceGroups when optimization algorithm is triggered

2020-10-20 Thread GitBox
bbejeck merged pull request #9237: URL: https://github.com/apache/kafka/pull/9237 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vvcephei edited a comment on pull request #9338: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-20 Thread GitBox
vvcephei edited a comment on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-713173834 Looks like there are a bunch of merge conflicts for 2.6, probably because trunk/2.7 are post-KIP-478. I think since 2.7 is in progress right now, we could just stop

[GitHub] [kafka] vvcephei commented on pull request #9338: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-20 Thread GitBox
vvcephei commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-713173834 Looks like there are a bunch of merge conflicts for 2.6, probably because trunk/2.7 are post-KIP-478. I think since 2.7 is in progress right now, we could just stop here.

[GitHub] [kafka] vvcephei commented on pull request #9338: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-20 Thread GitBox
vvcephei commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-713172747 cherry-picked to 2.7 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vvcephei commented on pull request #9338: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-20 Thread GitBox
vvcephei commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-713167720 Merged to trunk! I'm cherry-picking to the older branches now... This is an automated message from the Apache

[GitHub] [kafka] vvcephei merged pull request #9338: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-20 Thread GitBox
vvcephei merged pull request #9338: URL: https://github.com/apache/kafka/pull/9338 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vvcephei commented on pull request #9338: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-20 Thread GitBox
vvcephei commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-713165968 Unrelated test failure: `Build / JDK 11 / org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]`

[GitHub] [kafka] vvcephei commented on a change in pull request #9446: MINOR: distinguish between missing source topics and internal assignment errors

2020-10-20 Thread GitBox
vvcephei commented on a change in pull request #9446: URL: https://github.com/apache/kafka/pull/9446#discussion_r508866077 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsRebalanceListener.java ## @@ -52,8 +53,16 @@ public void

[jira] [Updated] (KAFKA-9705) Zookeeper mutation protocols should be redirected to Controller only

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-9705: --- Fix Version/s: (was: 2.7.0) 2.8.0 > Zookeeper mutation protocols should be

[jira] [Commented] (KAFKA-9705) Zookeeper mutation protocols should be redirected to Controller only

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217956#comment-17217956 ] Bill Bejeck commented on KAFKA-9705: Since KIP-590 is not going to make the 2.7, I'm going to move

[jira] [Resolved] (KAFKA-8630) Unit testing a streams processor with a WindowStore throws a ClassCastException

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-8630. Resolution: Fixed Resolved via

[GitHub] [kafka] mikebin opened a new pull request #9466: KAFKA-10564: fix flaky test

2020-10-20 Thread GitBox
mikebin opened a new pull request #9466: URL: https://github.com/apache/kafka/pull/9466 Minor update to fix flaky state directory test, per feedback from @chia7712 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

[GitHub] [kafka] soarez commented on pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-10-20 Thread GitBox
soarez commented on pull request #9000: URL: https://github.com/apache/kafka/pull/9000#issuecomment-713147482 Seems I had forgotten to run `:streams:test-utils:unitTest`. Tests should be passing now. Please take another look @mjsax

[jira] [Commented] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217945#comment-17217945 ] Bill Bejeck commented on KAFKA-10417: - Since there's no PR for this ticket yet and the code freeze

[jira] [Updated] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10417: Fix Version/s: (was: 2.7.0) 2.7.1 2.8.0 > suppress()

[GitHub] [kafka] gwenshap commented on pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method

2020-10-20 Thread GitBox
gwenshap commented on pull request #9465: URL: https://github.com/apache/kafka/pull/9465#issuecomment-713132248 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ijuma commented on a change in pull request #9292: KAFKA-8238: adding number of messages/bytes read

2020-10-20 Thread GitBox
ijuma commented on a change in pull request #9292: URL: https://github.com/apache/kafka/pull/9292#discussion_r508812929 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -670,12 +675,16 @@ class GroupMetadataManager(brokerId: Int,

[GitHub] [kafka] bbejeck commented on a change in pull request #9461: MINOR: Clean-up streams javadoc warnings

2020-10-20 Thread GitBox
bbejeck commented on a change in pull request #9461: URL: https://github.com/apache/kafka/pull/9461#discussion_r508806985 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/CogroupedKStream.java ## @@ -184,9 +184,9 @@ * * KafkaStreams streams =

[GitHub] [kafka] jolshan commented on pull request #9454: KAFKA-10618: Add UUID class, use in protocols

2020-10-20 Thread GitBox
jolshan commented on pull request #9454: URL: https://github.com/apache/kafka/pull/9454#issuecomment-713108774 Two tests failed, but they seem to be flaky based on other open PRs. StoreQueryIntegrationTest.shouldQueryOnlyActivePartitionStoresByDefault

[GitHub] [kafka] vvcephei commented on a change in pull request #9446: MINOR: distinguish between missing source topics and internal assignment errors

2020-10-20 Thread GitBox
vvcephei commented on a change in pull request #9446: URL: https://github.com/apache/kafka/pull/9446#discussion_r508802283 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -409,9 +396,18 @@ public

[GitHub] [kafka] vvcephei commented on a change in pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

2020-10-20 Thread GitBox
vvcephei commented on a change in pull request #9414: URL: https://github.com/apache/kafka/pull/9414#discussion_r508798891 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StateDirectoryIntegrationTest.java ## @@ -0,0 +1,255 @@ +/* + * Licensed to the

[GitHub] [kafka] bbejeck commented on pull request #9463: MINOR: Clean-up client javadoc warnings

2020-10-20 Thread GitBox
bbejeck commented on pull request #9463: URL: https://github.com/apache/kafka/pull/9463#issuecomment-713102889 cherry-picked to 2.7 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] kowshik opened a new pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method

2020-10-20 Thread GitBox
kowshik opened a new pull request #9465: URL: https://github.com/apache/kafka/pull/9465 The method `TopicCommand. askToProceed()` is unused. So I've removed it in this PR. I'm relying on existing tests to report any regressions, but I code searched for the method in GitHub and it was

[GitHub] [kafka] bbejeck merged pull request #9463: MINOR: Clean-up client javadoc warnings

2020-10-20 Thread GitBox
bbejeck merged pull request #9463: URL: https://github.com/apache/kafka/pull/9463 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] bbejeck commented on pull request #9463: MINOR: Clean-up client javadoc warnings

2020-10-20 Thread GitBox
bbejeck commented on pull request #9463: URL: https://github.com/apache/kafka/pull/9463#issuecomment-713097885 Merged #9463 into trunk This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] bbejeck commented on pull request #9463: MINOR: Clean-up client javadoc warnings

2020-10-20 Thread GitBox
bbejeck commented on pull request #9463: URL: https://github.com/apache/kafka/pull/9463#issuecomment-713095564 Only javadoc changes, so merging This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] vvcephei commented on pull request #9338: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-20 Thread GitBox
vvcephei commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-713095415 Great! Thanks @thake . I'll take a look now. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dajac merged pull request #9462: MINOR; Fix UpdateMetadataRequestTest.testVersionLogic's assertions

2020-10-20 Thread GitBox
dajac merged pull request #9462: URL: https://github.com/apache/kafka/pull/9462 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dajac commented on pull request #9462: MINOR; Fix UpdateMetadataRequestTest.testVersionLogic's assertions

2020-10-20 Thread GitBox
dajac commented on pull request #9462: URL: https://github.com/apache/kafka/pull/9462#issuecomment-713085833 Test failures not related, merging to trunk. This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] dajac merged pull request #9417: MINOR: Fix flaky ControllerMutationQuotaTest.testQuotaMetric

2020-10-20 Thread GitBox
dajac merged pull request #9417: URL: https://github.com/apache/kafka/pull/9417 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dajac commented on pull request #9462: MINOR; Fix UpdateMetadataRequestTest.testVersionLogic's assertions

2020-10-20 Thread GitBox
dajac commented on pull request #9462: URL: https://github.com/apache/kafka/pull/9462#issuecomment-713070708 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] thake commented on pull request #9338: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-20 Thread GitBox
thake commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-713070979 @vvcephei everything should now be ready for a 2nd review. Your changes have been applied and the comments worked in.

[GitHub] [kafka] dajac commented on pull request #9462: MINOR; Fix UpdateMetadataRequestTest.testVersionLogic's assertions

2020-10-20 Thread GitBox
dajac commented on pull request #9462: URL: https://github.com/apache/kafka/pull/9462#issuecomment-713069657 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-10470) zstd decompression with small batches is slow and causes excessive GC

2020-10-20 Thread Robert Wagner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217836#comment-17217836 ] Robert Wagner commented on KAFKA-10470: --- sounds good > zstd decompression with small batches is

[GitHub] [kafka] guozhangwang opened a new pull request #9464: KAFKA-10616: Always call prepare-commit before suspending for active tasks

2020-10-20 Thread GitBox
guozhangwang opened a new pull request #9464: URL: https://github.com/apache/kafka/pull/9464 Today for active tasks we the following active task suspension: 1) closeAndRevive in handleTaskCorruption. 2) closeClean in assignor#onAssignment. 3) closeClean in shutdown. 4)

[GitHub] [kafka] andrewegel removed a comment on pull request #9329: Backport Jenkinsfile to 2.4 branch

2020-10-20 Thread GitBox
andrewegel removed a comment on pull request #9329: URL: https://github.com/apache/kafka/pull/9329#issuecomment-713030601 Could we cherry-pick the changes in `core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala` into 2.5 as well?

[GitHub] [kafka] andrewegel commented on pull request #9329: Backport Jenkinsfile to 2.4 branch

2020-10-20 Thread GitBox
andrewegel commented on pull request #9329: URL: https://github.com/apache/kafka/pull/9329#issuecomment-713030601 Could we cherry-pick the changes in `core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala` into 2.5 as well?

[jira] [Resolved] (KAFKA-10599) Implement basic CLI tool for feature versioning system

2020-10-20 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-10599. - Fix Version/s: 2.7.0 Resolution: Fixed Merged the PR to 2.7 and trunk. > Implement basic CLI

[GitHub] [kafka] mjsax commented on pull request #9432: KAFKA-10559: Not letting TimeoutException shutdown the app during internal topic validation

2020-10-20 Thread GitBox
mjsax commented on pull request #9432: URL: https://github.com/apache/kafka/pull/9432#issuecomment-713023808 Well, that are timeout related: they checked if we send the shut-down signal. After the change, they should check if the `TimeoutException` is thrown and only kills the local

[GitHub] [kafka] mjsax commented on pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-10-20 Thread GitBox
mjsax commented on pull request #9000: URL: https://github.com/apache/kafka/pull/9000#issuecomment-713022002 @soarez Thanks for the update. It seems that `TopologyTestDriverTest.shouldCloseProcessor` is broken. Can you fix it and update the PR?

[jira] [Commented] (KAFKA-10616) StreamThread killed by "IllegalStateException: The processor is already closed"

2020-10-20 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217813#comment-17217813 ] Guozhang Wang commented on KAFKA-10616: --- I think this is a long lurking bug caused by

[GitHub] [kafka] mjsax commented on a change in pull request #9461: MINOR: Clean-up streams javadoc warnings

2020-10-20 Thread GitBox
mjsax commented on a change in pull request #9461: URL: https://github.com/apache/kafka/pull/9461#discussion_r508705351 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/CogroupedKStream.java ## @@ -184,9 +184,9 @@ * * KafkaStreams streams =

[jira] [Commented] (KAFKA-10470) zstd decompression with small batches is slow and causes excessive GC

2020-10-20 Thread James Yuzawa (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217786#comment-17217786 ] James Yuzawa commented on KAFKA-10470: -- Ok, I'm still going to attempt to add some buffering within

[GitHub] [kafka] abbccdda commented on pull request #9103: KAFKA-10181: Use Envelope RPC to do redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-10-20 Thread GitBox
abbccdda commented on pull request #9103: URL: https://github.com/apache/kafka/pull/9103#issuecomment-713007022 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Comment Edited] (KAFKA-8602) StreamThread Dies Because Restore Consumer is not Subscribed to Any Topic

2020-10-20 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217776#comment-17217776 ] Matthias J. Sax edited comment on KAFKA-8602 at 10/20/20, 5:02 PM: ---

[jira] [Commented] (KAFKA-8602) StreamThread Dies Because Restore Consumer is not Subscribed to Any Topic

2020-10-20 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217776#comment-17217776 ] Matthias J. Sax commented on KAFKA-8602: Version 1.0.3 was never released. All available releases

[jira] [Updated] (KAFKA-9621) AdminClient listOffsets operation does not respect retries and backoff

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-9621: --- Fix Version/s: (was: 2.7.0) > AdminClient listOffsets operation does not respect retries and

[jira] [Commented] (KAFKA-9621) AdminClient listOffsets operation does not respect retries and backoff

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217775#comment-17217775 ] Bill Bejeck commented on KAFKA-9621: As part of the 2.7.0 release process, I'm clearing the fix

[jira] [Commented] (KAFKA-9397) Deprecate Direct Zookeeper access in Kafka Administrative Tools

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217773#comment-17217773 ] Bill Bejeck commented on KAFKA-9397: As part of the 2.7.0 release process, I'm clearing the fix

[jira] [Updated] (KAFKA-9397) Deprecate Direct Zookeeper access in Kafka Administrative Tools

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-9397: --- Fix Version/s: (was: 2.7.0) > Deprecate Direct Zookeeper access in Kafka Administrative Tools >

[jira] [Updated] (KAFKA-9096) Validate config inter-dependencies for KafkaConfig only after dynamic configs are loaded

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-9096: --- Fix Version/s: (was: 2.7.0) > Validate config inter-dependencies for KafkaConfig only after

[jira] [Commented] (KAFKA-9096) Validate config inter-dependencies for KafkaConfig only after dynamic configs are loaded

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217770#comment-17217770 ] Bill Bejeck commented on KAFKA-9096: As part of the 2.7.0 release process, I'm clearing the fix

[jira] [Commented] (KAFKA-8930) MM2 documentation

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217765#comment-17217765 ] Bill Bejeck commented on KAFKA-8930: As part of the 2.7.0 release process, I'm clearing the fix

[jira] [Updated] (KAFKA-8930) MM2 documentation

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-8930: --- Fix Version/s: (was: 2.7.0) > MM2 documentation > - > > Key:

[jira] [Updated] (KAFKA-9861) Process Simplification - Community Validation of Kafka Release Candidates

2020-10-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-9861: --- Fix Version/s: (was: 2.7.0) 2.8.0 > Process Simplification - Community

  1   2   >