[GitHub] [kafka] chia7712 commented on a change in pull request #9778: KAFKA-10874 Fix flaky ClientQuotasRequestTest.testAlterIpQuotasRequest

2020-12-28 Thread GitBox
chia7712 commented on a change in pull request #9778: URL: https://github.com/apache/kafka/pull/9778#discussion_r549598781 ## File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala ## @@ -212,7 +214,9 @@ class ClientQuotasRequestTest extends BaseRequestT

[GitHub] [kafka] itantiger commented on a change in pull request #9790: Some parameters will be overwritten which was configured in consumer.config.

2020-12-28 Thread GitBox
itantiger commented on a change in pull request #9790: URL: https://github.com/apache/kafka/pull/9790#discussion_r549591650 ## File path: core/src/test/scala/unit/kafka/tools/ConsumerPerformanceTest.scala ## @@ -96,6 +97,28 @@ class ConsumerPerformanceTest { assertEquals("

[GitHub] [kafka] chia7712 commented on a change in pull request #9790: Some parameters will be overwritten which was configured in consumer.config.

2020-12-28 Thread GitBox
chia7712 commented on a change in pull request #9790: URL: https://github.com/apache/kafka/pull/9790#discussion_r549589413 ## File path: core/src/test/scala/unit/kafka/tools/ConsumerPerformanceTest.scala ## @@ -96,6 +97,28 @@ class ConsumerPerformanceTest { assertEquals("t

[GitHub] [kafka] chia7712 commented on a change in pull request #9781: MINOR: Use top-level error in `UpdateFeaturesRequest.getErrorResponse`

2020-12-28 Thread GitBox
chia7712 commented on a change in pull request #9781: URL: https://github.com/apache/kafka/pull/9781#discussion_r549580987 ## File path: clients/src/main/java/org/apache/kafka/common/requests/UpdateFeaturesResponse.java ## @@ -45,16 +44,18 @@ public UpdateFeaturesResponse(Upda

[GitHub] [kafka] itantiger commented on a change in pull request #9790: Some parameters will be overwritten which was configured in consumer.config.

2020-12-28 Thread GitBox
itantiger commented on a change in pull request #9790: URL: https://github.com/apache/kafka/pull/9790#discussion_r549583876 ## File path: core/src/test/scala/unit/kafka/tools/ConsumerPerformanceTest.scala ## @@ -96,6 +97,28 @@ class ConsumerPerformanceTest { assertEquals("

[GitHub] [kafka] itantiger commented on a change in pull request #9790: Some parameters will be overwritten which was configured in consumer.config.

2020-12-28 Thread GitBox
itantiger commented on a change in pull request #9790: URL: https://github.com/apache/kafka/pull/9790#discussion_r549583198 ## File path: core/src/test/scala/unit/kafka/tools/ConsumerPerformanceTest.scala ## @@ -96,6 +97,28 @@ class ConsumerPerformanceTest { assertEquals("

[GitHub] [kafka] chia7712 commented on a change in pull request #9790: Some parameters will be overwritten which was configured in consumer.config.

2020-12-28 Thread GitBox
chia7712 commented on a change in pull request #9790: URL: https://github.com/apache/kafka/pull/9790#discussion_r549578153 ## File path: core/src/test/scala/unit/kafka/tools/ConsumerPerformanceTest.scala ## @@ -96,6 +97,28 @@ class ConsumerPerformanceTest { assertEquals("t

[GitHub] [kafka] showuon commented on pull request #9789: Force the validation control request,isolate other data requests.Prot…

2020-12-28 Thread GitBox
showuon commented on pull request #9789: URL: https://github.com/apache/kafka/pull/9789#issuecomment-751957476 > @showuon Thank you very much for your suggestions and comments,In order to meet the requirement of submitting PR, do I need to submit a PR again?I'm going to create a new jIRA I

[GitHub] [kafka] chia7712 commented on a change in pull request #9761: KAFKA-10768 Add a test for ByteBufferInputStream to ByteBufferLogInputStreamTest

2020-12-28 Thread GitBox
chia7712 commented on a change in pull request #9761: URL: https://github.com/apache/kafka/pull/9761#discussion_r549576728 ## File path: clients/src/test/java/org/apache/kafka/common/utils/ByteBufferInputStreamTest.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [kafka] chia7712 commented on pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2020-12-28 Thread GitBox
chia7712 commented on pull request #9520: URL: https://github.com/apache/kafka/pull/9520#issuecomment-751954761 @ijuma Thanks for your great reviewing. I have addressed most review comment in latest commit. > It would be good to clearly mention the cases where the translation wasn't

[GitHub] [kafka] chia7712 commented on a change in pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2020-12-28 Thread GitBox
chia7712 commented on a change in pull request #9520: URL: https://github.com/apache/kafka/pull/9520#discussion_r549569836 ## File path: connect/api/src/test/java/org/apache/kafka/connect/data/SchemaBuilderTest.java ## @@ -293,16 +295,13 @@ public void testEmptyStruct() {

[GitHub] [kafka] chia7712 commented on a change in pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2020-12-28 Thread GitBox
chia7712 commented on a change in pull request #9520: URL: https://github.com/apache/kafka/pull/9520#discussion_r549568729 ## File path: clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java ## @@ -504,20 +510,21 @@ public void writePastLimit() {

[GitHub] [kafka] chia7712 commented on a change in pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2020-12-28 Thread GitBox
chia7712 commented on a change in pull request #9520: URL: https://github.com/apache/kafka/pull/9520#discussion_r549567477 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java ## @@ -444,34 +444,30 @@ public void testAddP

[GitHub] [kafka] wenbingshen commented on pull request #9789: Force the validation control request,isolate other data requests.Prot…

2020-12-28 Thread GitBox
wenbingshen commented on pull request #9789: URL: https://github.com/apache/kafka/pull/9789#issuecomment-751941992 @showuon Thank you very much for your suggestions and comments,In order to meet the requirement of submitting PR, do I need to submit a PR again?I'm going to create a new jIR

[GitHub] [kafka] showuon commented on a change in pull request #9789: Force the validation control request,isolate other data requests.Prot…

2020-12-28 Thread GitBox
showuon commented on a change in pull request #9789: URL: https://github.com/apache/kafka/pull/9789#discussion_r549561892 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -988,60 +990,79 @@ private[kafka] class Processor(val id: Int, } } + pro

[GitHub] [kafka] showuon commented on a change in pull request #9789: Force the validation control request,isolate other data requests.Prot…

2020-12-28 Thread GitBox
showuon commented on a change in pull request #9789: URL: https://github.com/apache/kafka/pull/9789#discussion_r549561892 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -988,60 +990,79 @@ private[kafka] class Processor(val id: Int, } } + pro

[GitHub] [kafka] showuon commented on a change in pull request #9789: Force the validation control request,isolate other data requests.Prot…

2020-12-28 Thread GitBox
showuon commented on a change in pull request #9789: URL: https://github.com/apache/kafka/pull/9789#discussion_r549561892 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -988,60 +990,79 @@ private[kafka] class Processor(val id: Int, } } + pro

[GitHub] [kafka] showuon edited a comment on pull request #9789: Force the validation control request,isolate other data requests.Prot…

2020-12-28 Thread GitBox
showuon edited a comment on pull request #9789: URL: https://github.com/apache/kafka/pull/9789#issuecomment-751936350 @wenbingshen , thanks for the PR. Some comments left, but most importantly, we don't know which JIRA ticket you're fixing. Please check the [contributing code change](http

[GitHub] [kafka] showuon commented on a change in pull request #9789: Force the validation control request,isolate other data requests.Prot…

2020-12-28 Thread GitBox
showuon commented on a change in pull request #9789: URL: https://github.com/apache/kafka/pull/9789#discussion_r549561892 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -988,60 +990,79 @@ private[kafka] class Processor(val id: Int, } } + pro

[GitHub] [kafka] showuon commented on a change in pull request #9789: Force the validation control request,isolate other data requests.Prot…

2020-12-28 Thread GitBox
showuon commented on a change in pull request #9789: URL: https://github.com/apache/kafka/pull/9789#discussion_r549558749 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -988,60 +990,79 @@ private[kafka] class Processor(val id: Int, } } + pro

[GitHub] [kafka] showuon commented on a change in pull request #9789: Force the validation control request,isolate other data requests.Prot…

2020-12-28 Thread GitBox
showuon commented on a change in pull request #9789: URL: https://github.com/apache/kafka/pull/9789#discussion_r549558597 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -988,60 +990,79 @@ private[kafka] class Processor(val id: Int, } } + pro

[GitHub] [kafka] showuon commented on a change in pull request #9789: Force the validation control request,isolate other data requests.Prot…

2020-12-28 Thread GitBox
showuon commented on a change in pull request #9789: URL: https://github.com/apache/kafka/pull/9789#discussion_r549558489 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -988,60 +990,79 @@ private[kafka] class Processor(val id: Int, } } + pro

[GitHub] [kafka] showuon commented on a change in pull request #9789: Force the validation control request,isolate other data requests.Prot…

2020-12-28 Thread GitBox
showuon commented on a change in pull request #9789: URL: https://github.com/apache/kafka/pull/9789#discussion_r549557939 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -988,60 +990,79 @@ private[kafka] class Processor(val id: Int, } } + pro

[GitHub] [kafka] showuon commented on pull request #9789: Force the validation control request,isolate other data requests.Prot…

2020-12-28 Thread GitBox
showuon commented on pull request #9789: URL: https://github.com/apache/kafka/pull/9789#issuecomment-751936350 @wenbingshen , thanks for the PR. Some comments left, but most importantly, we don't know which JIRA ticket you're fixing. Please check the [contributing code change](https://cwi

[GitHub] [kafka] mjsax commented on a change in pull request #9107: KAFKA-5488: Add type-safe branch() operator

2020-12-28 Thread GitBox
mjsax commented on a change in pull request #9107: URL: https://github.com/apache/kafka/pull/9107#discussion_r549555914 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/BranchedInternal.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] mjsax commented on a change in pull request #9744: KAFKA-10062: Add a method to retrieve the current timestamp as known by the Streams app

2020-12-28 Thread GitBox
mjsax commented on a change in pull request #9744: URL: https://github.com/apache/kafka/pull/9744#discussion_r549546234 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java ## @@ -289,4 +289,17 @@ Cancellable schedule(final Duration inte

[GitHub] [kafka] mjsax commented on pull request #9107: KAFKA-5488: Add type-safe branch() operator

2020-12-28 Thread GitBox
mjsax commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-751926120 @inponomarev -- Can you also update the docs for Kafka Streams and the 2.8 upgrade guide in this PR. This is an aut

[GitHub] [kafka] hachikuji merged pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-28 Thread GitBox
hachikuji merged pull request #9553: URL: https://github.com/apache/kafka/pull/9553 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji commented on pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-28 Thread GitBox
hachikuji commented on pull request #9553: URL: https://github.com/apache/kafka/pull/9553#issuecomment-751924971 I manually reran tests since it has been a week since the last update. Here is a link to the results since they have not been automatically linked: https://ci-builds.apache.org/

[GitHub] [kafka] g1geordie commented on a change in pull request #9778: KAFKA-10874 Fix flaky ClientQuotasRequestTest.testAlterIpQuotasRequest

2020-12-28 Thread GitBox
g1geordie commented on a change in pull request #9778: URL: https://github.com/apache/kafka/pull/9778#discussion_r549545680 ## File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala ## @@ -212,7 +214,10 @@ class ClientQuotasRequestTest extends BaseReques

[GitHub] [kafka] mjsax commented on pull request #9107: KAFKA-5488: Add type-safe branch() operator

2020-12-28 Thread GitBox
mjsax commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-751922810 About the original comment: https://github.com/apache/kafka/pull/9107#issuecomment-666749809 I am fine with those changes. About https://github.com/apache/kafka/pull/91

[jira] [Updated] (KAFKA-10890) Broker just stated Ignoring LeaderAndIsr request from controller

2020-12-28 Thread GeoffreyStark (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] GeoffreyStark updated KAFKA-10890: -- Description: In auto.leader.rebalance.enabled=true  Taking a Broker 1013 (with many leader pa

[GitHub] [kafka] mjsax commented on a change in pull request #9107: KAFKA-5488: Add type-safe branch() operator

2020-12-28 Thread GitBox
mjsax commented on a change in pull request #9107: URL: https://github.com/apache/kafka/pull/9107#discussion_r549543943 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/Branched.java ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [kafka] mjsax commented on a change in pull request #9107: KAFKA-5488: Add type-safe branch() operator

2020-12-28 Thread GitBox
mjsax commented on a change in pull request #9107: URL: https://github.com/apache/kafka/pull/9107#discussion_r549543247 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/BranchedKStreamImpl.java ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache So

[GitHub] [kafka] mjsax commented on a change in pull request #9107: KAFKA-5488: Add type-safe branch() operator

2020-12-28 Thread GitBox
mjsax commented on a change in pull request #9107: URL: https://github.com/apache/kafka/pull/9107#discussion_r549542995 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/BranchedKStreamImpl.java ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache So

[GitHub] [kafka] mjsax commented on a change in pull request #9107: KAFKA-5488: Add type-safe branch() operator

2020-12-28 Thread GitBox
mjsax commented on a change in pull request #9107: URL: https://github.com/apache/kafka/pull/9107#discussion_r549542855 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/BranchedKStreamImpl.java ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache So

[jira] [Assigned] (KAFKA-10779) Reassignment tool sets throttles incorrectly when overriding a reassignment

2020-12-28 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-10779: -- Assignee: dengziming > Reassignment tool sets throttles incorrectly when overriding a reassig

[GitHub] [kafka] mjsax commented on a change in pull request #9107: KAFKA-5488: Add type-safe branch() operator

2020-12-28 Thread GitBox
mjsax commented on a change in pull request #9107: URL: https://github.com/apache/kafka/pull/9107#discussion_r547605439 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/BranchedKStreamImpl.java ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache So

[GitHub] [kafka] mjsax commented on a change in pull request #9107: KAFKA-5488: Add type-safe branch() operator

2020-12-28 Thread GitBox
mjsax commented on a change in pull request #9107: URL: https://github.com/apache/kafka/pull/9107#discussion_r547602314 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/BranchedInternal.java ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] mjsax commented on a change in pull request #9107: KAFKA-5488: Add type-safe branch() operator

2020-12-28 Thread GitBox
mjsax commented on a change in pull request #9107: URL: https://github.com/apache/kafka/pull/9107#discussion_r547599107 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/BranchedKStream.java ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] mjsax commented on a change in pull request #9107: KAFKA-5488: Add type-safe branch() operator

2020-12-28 Thread GitBox
mjsax commented on a change in pull request #9107: URL: https://github.com/apache/kafka/pull/9107#discussion_r549538598 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/BranchedKStream.java ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] mjsax commented on a change in pull request #9107: KAFKA-5488: Add type-safe branch() operator

2020-12-28 Thread GitBox
mjsax commented on a change in pull request #9107: URL: https://github.com/apache/kafka/pull/9107#discussion_r547591511 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/BranchedKStream.java ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] mjsax commented on a change in pull request #9107: KAFKA-5488: Add type-safe branch() operator

2020-12-28 Thread GitBox
mjsax commented on a change in pull request #9107: URL: https://github.com/apache/kafka/pull/9107#discussion_r547597683 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/Branched.java ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [kafka] hachikuji commented on a change in pull request #9781: MINOR: Use top-level error in `UpdateFeaturesRequest.getErrorResponse`

2020-12-28 Thread GitBox
hachikuji commented on a change in pull request #9781: URL: https://github.com/apache/kafka/pull/9781#discussion_r549426896 ## File path: clients/src/main/java/org/apache/kafka/common/requests/UpdateFeaturesRequest.java ## @@ -56,19 +54,11 @@ public UpdateFeaturesRequest(Updat

[GitHub] [kafka] ijuma commented on a change in pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2020-12-28 Thread GitBox
ijuma commented on a change in pull request #9520: URL: https://github.com/apache/kafka/pull/9520#discussion_r549419585 ## File path: clients/src/test/java/org/apache/kafka/common/memory/GarbageCollectedMemoryPoolTest.java ## @@ -23,68 +23,74 @@ import org.junit.Assert; impo

[GitHub] [kafka] ijuma commented on a change in pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2020-12-28 Thread GitBox
ijuma commented on a change in pull request #9520: URL: https://github.com/apache/kafka/pull/9520#discussion_r549417155 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -192,11 +192,12 @@ public void testConstructorWithSerializ

[GitHub] [kafka] bertber commented on a change in pull request #9761: KAFKA-10768 Add a test for ByteBufferInputStream to ByteBufferLogInputStreamTest

2020-12-28 Thread GitBox
bertber commented on a change in pull request #9761: URL: https://github.com/apache/kafka/pull/9761#discussion_r549409531 ## File path: clients/src/test/java/org/apache/kafka/common/utils/ByteBufferInputStreamTest.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] bertber commented on a change in pull request #9761: KAFKA-10768 Add a test for ByteBufferInputStream to ByteBufferLogInputStreamTest

2020-12-28 Thread GitBox
bertber commented on a change in pull request #9761: URL: https://github.com/apache/kafka/pull/9761#discussion_r549409289 ## File path: clients/src/test/java/org/apache/kafka/common/record/ByteBufferLogInputStreamTest.java ## @@ -119,5 +119,4 @@ public void iteratorRaisesOnToo

[GitHub] [kafka] wenbingshen commented on pull request #9789: Force the validation control request,isolate other data requests.Prot…

2020-12-28 Thread GitBox
wenbingshen commented on pull request #9789: URL: https://github.com/apache/kafka/pull/9789#issuecomment-751748730 @showuon This is my first time to submit pr to the community.Could you give me some suggestions?Thank you very much! -

[jira] [Commented] (KAFKA-10889) The log cleaner is not working for topic partitions

2020-12-28 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255618#comment-17255618 ] Wenbing Shen commented on KAFKA-10889: -- [~becket_qin]  Why not isolate the message

[jira] [Commented] (KAFKA-10889) The log cleaner is not working for topic partitions

2020-12-28 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255527#comment-17255527 ] Jiangjie Qin commented on KAFKA-10889: -- It looks that the broker is working as desi

[GitHub] [kafka] itantiger commented on pull request #9790: Some parameters will be overwritten which was configured in consumer.config.

2020-12-28 Thread GitBox
itantiger commented on pull request #9790: URL: https://github.com/apache/kafka/pull/9790#issuecomment-751673393 > @itantiger Thanks for your patch. Could you revise the title? Finished. When will this patch merge to trunk?

[GitHub] [kafka] itantiger commented on pull request #9790: Some parameters will be overwritten which was configured in consumer.config.

2020-12-28 Thread GitBox
itantiger commented on pull request #9790: URL: https://github.com/apache/kafka/pull/9790#issuecomment-751665759 > @itantiger Thanks for your patch. Could you revise the title? Also thank you very much for your guidance :) . --

[GitHub] [kafka] chia7712 commented on pull request #9790: Some parameters will be overwritten which was configured in consumer.config where running "ConsumerPerformance.scala". Linked https://issues

2020-12-28 Thread GitBox
chia7712 commented on pull request #9790: URL: https://github.com/apache/kafka/pull/9790#issuecomment-751664539 @itantiger Thanks for your patch. Could you revise the title? This is an automated message from the Apache Git Se

[GitHub] [kafka] itantiger commented on pull request #9790: Some parameters will be overwritten which was configured in consumer.config where running "ConsumerPerformance.scala". Linked https://issue

2020-12-28 Thread GitBox
itantiger commented on pull request #9790: URL: https://github.com/apache/kafka/pull/9790#issuecomment-751664125 > > what should I do next :) > > please take a look at the report and fix the error. https://github.com/apache/kafka/pull/9790/checks?check_run_id=1616222522 I fixe

[jira] [Comment Edited] (KAFKA-10889) The log cleaner is not working for topic partitions

2020-12-28 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255491#comment-17255491 ] Wenbing Shen edited comment on KAFKA-10889 at 12/28/20, 9:43 AM: -

[jira] [Comment Edited] (KAFKA-10889) The log cleaner is not working for topic partitions

2020-12-28 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255491#comment-17255491 ] Wenbing Shen edited comment on KAFKA-10889 at 12/28/20, 9:43 AM: -

[jira] [Commented] (KAFKA-10889) The log cleaner is not working for topic partitions

2020-12-28 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255491#comment-17255491 ] Wenbing Shen commented on KAFKA-10889: -- [~becket_qin] [~junrao] > The log cleaner

[GitHub] [kafka] showuon commented on pull request #9792: KAFKA-10870: handle REBALANCE_IN_PROGRESS error in JoinGroup

2020-12-28 Thread GitBox
showuon commented on pull request #9792: URL: https://github.com/apache/kafka/pull/9792#issuecomment-751647364 @hachikuji , please help review this PR. Thanks. This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] showuon opened a new pull request #9792: KAFKA-10870: handle REBALANCE_IN_PROGRESS error in JoinGroup

2020-12-28 Thread GitBox
showuon opened a new pull request #9792: URL: https://github.com/apache/kafka/pull/9792 handle REBALANCE_IN_PROGRESS error in JoinGroup to log correct info and request a rejoin. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

[jira] [Comment Edited] (KAFKA-10889) The log cleaner is not working for topic partitions

2020-12-28 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255480#comment-17255480 ] Wenbing Shen edited comment on KAFKA-10889 at 12/28/20, 9:24 AM: -

[jira] [Assigned] (KAFKA-10870) Consumer should handle REBALANCE_IN_PROGRESS from JoinGroup

2020-12-28 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-10870: - Assignee: Luke Chen > Consumer should handle REBALANCE_IN_PROGRESS from JoinGroup > ---

[jira] [Commented] (KAFKA-10889) The log cleaner is not working for topic partitions

2020-12-28 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255480#comment-17255480 ] Wenbing Shen commented on KAFKA-10889: -- [https://cwiki.apache.org/confluence/displa

[jira] [Updated] (KAFKA-10890) Broker just stated Ignoring LeaderAndIsr request from controller

2020-12-28 Thread GeoffreyStark (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] GeoffreyStark updated KAFKA-10890: -- Description: In auto.leader.rebalance.enabled=true  Taking a Broker 1013 (with many leader pa

[jira] [Updated] (KAFKA-10890) Broker just stated Ignoring LeaderAndIsr request from controller

2020-12-28 Thread GeoffreyStark (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] GeoffreyStark updated KAFKA-10890: -- Attachment: image-2020-12-28-16-59-03-492.png > Broker just stated Ignoring LeaderAndIsr requ

[jira] [Commented] (KAFKA-10890) Broker just stated Ignoring LeaderAndIsr request from controller

2020-12-28 Thread GeoffreyStark (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255473#comment-17255473 ] GeoffreyStark commented on KAFKA-10890: --- controller log has been follow text   !

[jira] [Commented] (KAFKA-10890) Broker just stated Ignoring LeaderAndIsr request from controller

2020-12-28 Thread GeoffreyStark (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255472#comment-17255472 ] GeoffreyStark commented on KAFKA-10890: --- It looks like the controller failed to se

[jira] [Created] (KAFKA-10890) Broker just stated Ignoring LeaderAndIsr request from controller

2020-12-28 Thread GeoffreyStark (Jira)
GeoffreyStark created KAFKA-10890: - Summary: Broker just stated Ignoring LeaderAndIsr request from controller Key: KAFKA-10890 URL: https://issues.apache.org/jira/browse/KAFKA-10890 Project: Kafka