[GitHub] [kafka] rondagostino commented on a change in pull request #10090: Upstream BrokerMetadataListener and related classes

rondagostino commented on a change in pull request #10090: URL: https://github.com/apache/kafka/pull/10090#discussion_r573925637 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala ## @@ -0,0 +1,260 @@ +/** + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

dajac commented on pull request #9430: URL: https://github.com/apache/kafka/pull/9430#issuecomment-776888665 Triggered another system test: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4364/ This is an

[GitHub] [kafka] vvcephei commented on a change in pull request #10096: KAFKA-12268: Make early poll return opt-in

vvcephei commented on a change in pull request #10096: URL: https://github.com/apache/kafka/pull/10096#discussion_r573924978 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java ## @@ -71,6 +71,21 @@ /** max.poll.interval.ms */

[GitHub] [kafka] junrao commented on pull request #10041: MINOR: Prevent creating partition.metadata until ID can be written

junrao commented on pull request #10041: URL: https://github.com/apache/kafka/pull/10041#issuecomment-776872795 @jolshan Could you rebase the PR for trunk? Also, I am not sure if the PR ports to 2.8 cleanly, if not, could you submit a separate PR for 2.8? Thanks.

[GitHub] [kafka] rondagostino commented on a change in pull request #10069: MINOR: Add RaftReplicaManager

rondagostino commented on a change in pull request #10069: URL: https://github.com/apache/kafka/pull/10069#discussion_r573916465 ## File path: core/src/main/scala/kafka/server/RaftReplicaManager.scala ## @@ -0,0 +1,397 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [kafka] chia7712 commented on pull request #10099: MINOR: Updated the package name to correct one.

chia7712 commented on pull request #10099: URL: https://github.com/apache/kafka/pull/10099#issuecomment-776867882 @kamalcph Thanks for your patch. 1.

[GitHub] [kafka] vcrfxia commented on a change in pull request #10091: KAFKA-9524: increase retention time for window and grace periods longer than one day

vcrfxia commented on a change in pull request #10091: URL: https://github.com/apache/kafka/pull/10091#discussion_r573909774 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/TimeWindowedKStreamImplTest.java ## @@ -91,6 +92,47 @@ public void

[GitHub] [kafka] EduardoFLima commented on pull request #5876: KAFKA-7509: Avoid passing most non-applicable properties to producer, consumer, and admin client

EduardoFLima commented on pull request #5876: URL: https://github.com/apache/kafka/pull/5876#issuecomment-776865779 Should [KAFKA-10090](https://issues.apache.org/jira/browse/KAFKA-10090) also fix this ? This is an

[GitHub] [kafka] cmccabe commented on a change in pull request #10069: MINOR: Add RaftReplicaManager

cmccabe commented on a change in pull request #10069: URL: https://github.com/apache/kafka/pull/10069#discussion_r573910513 ## File path: core/src/main/scala/kafka/server/RaftReplicaManager.scala ## @@ -0,0 +1,397 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] rondagostino commented on a change in pull request #10095: MINOR: Introduce the KIP-500 Broker lifecycle manager

rondagostino commented on a change in pull request #10095: URL: https://github.com/apache/kafka/pull/10095#discussion_r573862043 ## File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala ## @@ -0,0 +1,457 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [kafka] mumrah commented on a change in pull request #10095: MINOR: Introduce the KIP-500 Broker lifecycle manager

mumrah commented on a change in pull request #10095: URL: https://github.com/apache/kafka/pull/10095#discussion_r573877692 ## File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala ## @@ -0,0 +1,457 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mumrah commented on a change in pull request #10095: MINOR: Introduce the KIP-500 Broker lifecycle manager

mumrah commented on a change in pull request #10095: URL: https://github.com/apache/kafka/pull/10095#discussion_r573845682 ## File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala ## @@ -0,0 +1,457 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kamalcph commented on pull request #10099: MINOR: Updated the package name to correct one.

kamalcph commented on pull request #10099: URL: https://github.com/apache/kafka/pull/10099#issuecomment-776833592 How to resolve this issue in IntelliJ? I've invalidated the IntelliJ cache and built it again but couldn't resolve this one.

[GitHub] [kafka] kamalcph opened a new pull request #10099: MINOR: Updated the package name to correct one.

kamalcph opened a new pull request #10099: URL: https://github.com/apache/kafka/pull/10099 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] ijuma commented on a change in pull request #10096: KAFKA-12268: Make early poll return opt-in

ijuma commented on a change in pull request #10096: URL: https://github.com/apache/kafka/pull/10096#discussion_r573860208 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java ## @@ -71,6 +71,21 @@ /** max.poll.interval.ms */

[GitHub] [kafka] rondagostino commented on a change in pull request #10069: MINOR: Add RaftReplicaManager

rondagostino commented on a change in pull request #10069: URL: https://github.com/apache/kafka/pull/10069#discussion_r573855674 ## File path: core/src/main/scala/kafka/server/RaftReplicaManager.scala ## @@ -0,0 +1,397 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [kafka] vvcephei commented on a change in pull request #10096: KAFKA-12268: Make early poll return opt-in

vvcephei commented on a change in pull request #10096: URL: https://github.com/apache/kafka/pull/10096#discussion_r573855741 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -1236,7 +1243,17 @@ public void assign(Collection

[GitHub] [kafka] vvcephei commented on a change in pull request #10096: KAFKA-12268: Make early poll return opt-in

vvcephei commented on a change in pull request #10096: URL: https://github.com/apache/kafka/pull/10096#discussion_r573853644 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1201,6 +1201,9 @@ private void

[GitHub] [kafka] vvcephei commented on a change in pull request #10096: KAFKA-12268: Make early poll return opt-in

vvcephei commented on a change in pull request #10096: URL: https://github.com/apache/kafka/pull/10096#discussion_r573852813 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java ## @@ -71,6 +71,21 @@ /** max.poll.interval.ms */

[GitHub] [kafka] chia7712 opened a new pull request #10098: KAFKA-12321 the comparison function for uuid type should be 'equals' …

chia7712 opened a new pull request #10098: URL: https://github.com/apache/kafka/pull/10098 issue: https://issues.apache.org/jira/browse/KAFKA-12321 ### current comparison ```java if (this.taggedUuid != Uuid.fromString("H3KKO4NTRPaCWtEmm3vW7A")) ``` ### fixed

[GitHub] [kafka] ijuma commented on a change in pull request #10095: MINOR: Introduce the KIP-500 Broker lifecycle manager

ijuma commented on a change in pull request #10095: URL: https://github.com/apache/kafka/pull/10095#discussion_r573849465 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1497,6 +1509,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:

[jira] [Commented] (KAFKA-12322) Why https://downloads.apache.org/kafka/ it doesnot download older version only 2.7.0 and 2.6.1 ,is there any changes done ?

[ https://issues.apache.org/jira/browse/KAFKA-12322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282522#comment-17282522 ] Tom Bentley commented on KAFKA-12322: - Older versions are available from

[GitHub] [kafka] ijuma commented on a change in pull request #10095: MINOR: Introduce the KIP-500 Broker lifecycle manager

ijuma commented on a change in pull request #10095: URL: https://github.com/apache/kafka/pull/10095#discussion_r573839484 ## File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala ## @@ -0,0 +1,457 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mumrah commented on pull request #9577: KAFKA-9837: KIP-589 new RPC for notifying controller log dir failure

mumrah commented on pull request #9577: URL: https://github.com/apache/kafka/pull/9577#issuecomment-776805631 @dengziming, thanks for the patch! We are rather busy at the moment merging all the KIP-500 related work into trunk for the 2.8 release. After things settle down with that I will

[jira] [Created] (KAFKA-12322) Why https://downloads.apache.org/kafka/ it doesnot download older version only 2.7.0 and 2.6.1 ,is there any changes done ?

suman tripathi created KAFKA-12322: -- Summary: Why https://downloads.apache.org/kafka/ it doesnot download older version only 2.7.0 and 2.6.1 ,is there any changes done ? Key: KAFKA-12322 URL:

[GitHub] [kafka] ijuma commented on a change in pull request #10084: MINOR: Rename DecommissionBrokers to UnregisterBrokers

ijuma commented on a change in pull request #10084: URL: https://github.com/apache/kafka/pull/10084#discussion_r573823788 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -1486,41 +1486,46 @@ default DescribeFeaturesResult describeFeatures()

[jira] [Assigned] (KAFKA-12321) the comparison function for uuid type should be 'equals' rather than '=='

[ https://issues.apache.org/jira/browse/KAFKA-12321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-12321: -- Assignee: Chia-Ping Tsai > the comparison function for uuid type should be 'equals'

[jira] [Created] (KAFKA-12321) the comparison function for uuid type should be 'equals' rather than '=='

Chia-Ping Tsai created KAFKA-12321: -- Summary: the comparison function for uuid type should be 'equals' rather than '==' Key: KAFKA-12321 URL: https://issues.apache.org/jira/browse/KAFKA-12321

[GitHub] [kafka] ijuma commented on a change in pull request #10096: KAFKA-12268: Make early poll return opt-in

ijuma commented on a change in pull request #10096: URL: https://github.com/apache/kafka/pull/10096#discussion_r573812058 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java ## @@ -71,6 +71,21 @@ /** max.poll.interval.ms */

[GitHub] [kafka] ijuma commented on a change in pull request #10096: KAFKA-12268: Make early poll return opt-in

ijuma commented on a change in pull request #10096: URL: https://github.com/apache/kafka/pull/10096#discussion_r573811199 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java ## @@ -71,6 +71,21 @@ /** max.poll.interval.ms */

[GitHub] [kafka] ijuma merged pull request #10080: MINOR: KafkaBroker.brokerState should be volatile instead of AtomicReference

ijuma merged pull request #10080: URL: https://github.com/apache/kafka/pull/10080 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ijuma commented on a change in pull request #10080: MINOR: KafkaBroker.brokerState should be volatile instead of AtomicReference

ijuma commented on a change in pull request #10080: URL: https://github.com/apache/kafka/pull/10080#discussion_r573809578 ## File path: core/src/main/scala/kafka/server/KafkaBroker.scala ## @@ -90,7 +92,7 @@ trait KafkaBroker extends KafkaMetricsGroup {

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-776772272 Rebased onto the latest trunk, with including [KIP-676](https://cwiki.apache.org/confluence/display/KAFKA/KIP-676%3A+Respect+logging+hierarchy) and

[jira] [Commented] (KAFKA-10340) Source connectors should report error when trying to produce records to non-existent topics instead of hanging forever

[ https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282498#comment-17282498 ] Goltseva Taisiia commented on KAFKA-10340: -- Hi, guys! According to

[jira] [Comment Edited] (KAFKA-12305) Flatten SMT fails on arrays

[ https://issues.apache.org/jira/browse/KAFKA-12305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282492#comment-17282492 ] Chris Egerton edited comment on KAFKA-12305 at 2/10/21, 2:50 PM: - I

[jira] [Commented] (KAFKA-12305) Flatten SMT fails on arrays

[ https://issues.apache.org/jira/browse/KAFKA-12305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282492#comment-17282492 ] Chris Egerton commented on KAFKA-12305: --- I think the fact that the documentation doesn't call out

[GitHub] [kafka] urbandan commented on pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

urbandan commented on pull request #9430: URL: https://github.com/apache/kafka/pull/9430#issuecomment-776732944 @dajac I think I found the issue, pushed the fix. There was a typo in the command arg names. Could not get to execute the tests locally yet.

[GitHub] [kafka] rondagostino commented on a change in pull request #10093: MINOR: Support Raft-based metadata quorums in system tests

rondagostino commented on a change in pull request #10093: URL: https://github.com/apache/kafka/pull/10093#discussion_r573747683 ## File path: config/raft-broker.properties ## @@ -0,0 +1,125 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[jira] [Created] (KAFKA-12320) Provide JSON vulnerability data

Shivam Sandbhor created KAFKA-12320: --- Summary: Provide JSON vulnerability data Key: KAFKA-12320 URL: https://issues.apache.org/jira/browse/KAFKA-12320 Project: Kafka Issue Type:

[GitHub] [kafka] rondagostino commented on a change in pull request #10093: MINOR: Support Raft-based metadata quorums in system tests

rondagostino commented on a change in pull request #10093: URL: https://github.com/apache/kafka/pull/10093#discussion_r573744601 ## File path: config/raft-broker.properties ## @@ -0,0 +1,125 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [kafka] rondagostino commented on a change in pull request #10093: MINOR: Support Raft-based metadata quorums in system tests

rondagostino commented on a change in pull request #10093: URL: https://github.com/apache/kafka/pull/10093#discussion_r573743587 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -171,35 +347,79 @@ def __init__(self, context, num_nodes, zk,

[jira] [Updated] (KAFKA-12320) Provide structured vulnerability data

[ https://issues.apache.org/jira/browse/KAFKA-12320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivam Sandbhor updated KAFKA-12320: Summary: Provide structured vulnerability data (was: Provide YAML vulnerability data )

[jira] [Updated] (KAFKA-12320) Provide YAML vulnerability data

[ https://issues.apache.org/jira/browse/KAFKA-12320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivam Sandbhor updated KAFKA-12320: Summary: Provide YAML vulnerability data (was: Provide JSON vulnerability data ) >

[GitHub] [kafka] dengziming commented on pull request #10097: MINOR: Add FetchSnapshot API doc in KafkaRaftClient

dengziming commented on pull request #10097: URL: https://github.com/apache/kafka/pull/10097#issuecomment-776667671 @jsancio @hachikuji , trivial changes, PTAL. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dengziming commented on a change in pull request #10097: MINOR: Add FetchSnapshot API doc in KafkaRaftClient

dengziming commented on a change in pull request #10097: URL: https://github.com/apache/kafka/pull/10097#discussion_r573679151 ## File path: raft/src/main/java/org/apache/kafka/raft/NetworkChannel.java ## @@ -30,10 +30,8 @@ int newCorrelationId(); /** - * Send

[GitHub] [kafka] dengziming opened a new pull request #10097: MINOR: Add FetchSnapshot API doc in KafkaRaftClient

dengziming opened a new pull request #10097: URL: https://github.com/apache/kafka/pull/10097 *More detailed description of your change* Currently, we have added FetchSnapshot API in raft, so improve the docs in `KafkaRaftClient` ### Committer Checklist (excluded from commit

[GitHub] [kafka] dajac commented on pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

dajac commented on pull request #9430: URL: https://github.com/apache/kafka/pull/9430#issuecomment-776661447 @urbandan It seems that most of the get offset system tests failed:

[jira] [Commented] (KAFKA-5146) Kafka Streams: remove compile dependency on connect-json

[ https://issues.apache.org/jira/browse/KAFKA-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282398#comment-17282398 ] Marco Lotz commented on KAFKA-5146: --- [~ableegoldman] sounds good. Would you suggest to create a module

[GitHub] [kafka] urbandan commented on pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

urbandan commented on pull request #9430: URL: https://github.com/apache/kafka/pull/9430#issuecomment-776654342 @dajac Really appreciate your review, fixed the last couple of comments. This is an automated message from the

[GitHub] [kafka] urbandan commented on a change in pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

urbandan commented on a change in pull request #9430: URL: https://github.com/apache/kafka/pull/9430#discussion_r573661432 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -20,102 +20,131 @@ package kafka.tools import java.util.Properties import

[GitHub] [kafka] MarcoLotz commented on pull request #10091: KAFKA-9524: increase retention time for window and grace periods longer than one day

MarcoLotz commented on pull request #10091: URL: https://github.com/apache/kafka/pull/10091#issuecomment-776643166 @vcrfxia I see your point. IMHO usually I refrain from having get() and set() (or equivalent methods) doing tasks other than just accessing fields. In the scenario of some

[GitHub] [kafka] rajinisivaram merged pull request #9865: Fill in the 2.8 release note for Authorizer

rajinisivaram merged pull request #9865: URL: https://github.com/apache/kafka/pull/9865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (KAFKA-12312) kafka_2.13:2.6.1 throws NoSuchMethodError when running against scala-sdk-2.13.4

[ https://issues.apache.org/jira/browse/KAFKA-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282352#comment-17282352 ] Luke Chen commented on KAFKA-12312: --- > this feels more like a Scala compiler issue than a Kafka one.

[GitHub] [kafka] rajinisivaram merged pull request #10067: KAFKA-12193: Re-resolve IPs after a client disconnects

rajinisivaram merged pull request #10067: URL: https://github.com/apache/kafka/pull/10067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] rajinisivaram merged pull request #10065: KAFKA-12193: Re-resolve IPs after a client disconnects

rajinisivaram merged pull request #10065: URL: https://github.com/apache/kafka/pull/10065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] rajinisivaram merged pull request #10064: KAFKA-12193: Re-resolve IPs after a client disconnects

rajinisivaram merged pull request #10064: URL: https://github.com/apache/kafka/pull/10064 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (KAFKA-12312) kafka_2.13:2.6.1 throws NoSuchMethodError when running against scala-sdk-2.13.4

[ https://issues.apache.org/jira/browse/KAFKA-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282327#comment-17282327 ] Tamas Kornai commented on KAFKA-12312: -- [~showuon] what makes this issue a bit worse than the one

[jira] [Commented] (KAFKA-12312) kafka_2.13:2.6.1 throws NoSuchMethodError when running against scala-sdk-2.13.4

[ https://issues.apache.org/jira/browse/KAFKA-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282318#comment-17282318 ] Luke Chen commented on KAFKA-12312: --- [~tkornai], after some investigation, I think this might not be a

[GitHub] [kafka] bob-barrett commented on pull request #10067: KAFKA-12193: Re-resolve IPs after a client disconnects

bob-barrett commented on pull request #10067: URL: https://github.com/apache/kafka/pull/10067#issuecomment-776535274 Test failures appear to be in unrelated code This is an automated message from the Apache Git Service. To

[GitHub] [kafka] bob-barrett commented on pull request #10065: KAFKA-12193: Re-resolve IPs after a client disconnects

bob-barrett commented on pull request #10065: URL: https://github.com/apache/kafka/pull/10065#issuecomment-776534697 Test failures are in unrelated code and look like timing flakes This is an automated message from the

<    1   2