[GitHub] [kafka] lamberken commented on a change in pull request #10469: KAFKA-12611: Fix using random payload in ProducerPerformance incorrectly

lamberken commented on a change in pull request #10469: URL: https://github.com/apache/kafka/pull/10469#discussion_r610999261 ## File path: tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java ## @@ -127,15 +122,22 @@ public static void main(String[] args)

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610995466 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2154,8 +2182,14 @@ private boolean maybeCompleteShutdown(long

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610995406 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -326,6 +336,14 @@ private void updateListenersProgress(List

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610995402 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -326,6 +336,14 @@ private void updateListenersProgress(List

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610995361 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java ## @@ -68,20 +70,65 @@ public synchronized void increment() {

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610995276 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java ## @@ -68,20 +70,65 @@ public synchronized void increment() {

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610995276 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java ## @@ -68,20 +70,65 @@ public synchronized void increment() {

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610995124 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -355,24 +373,29 @@ private void fireHandleResign(int epoch) { }

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610995053 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/RecordsBatchReader.java ## @@ -163,48 +85,46 @@ public OptionalLong lastOffset() {

[GitHub] [kafka] jsancio commented on pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on pull request #10085: URL: https://github.com/apache/kafka/pull/10085#issuecomment-817076435 @mumrah @hachikuji @dengziming thanks for the feedback. I should have addressed all of your suggestions. Let me know if I missed anything. -- This is an automated message

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r610990019 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -202,6 +203,25 @@ private void completeCurrentBatch() {

[GitHub] [kafka] hachikuji merged pull request #10510: KAFKA-12607: Test case for resigned state vote granting

hachikuji merged pull request #10510: URL: https://github.com/apache/kafka/pull/10510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] dengziming commented on pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

dengziming commented on pull request #9769: URL: https://github.com/apache/kafka/pull/9769#issuecomment-817051364 @rajinisivaram @jolshan , Currently we have startd merge pr for 3.0, so it's time to take a look at this again, also #9684 since part of it has been reverted, thank you. --

[GitHub] [kafka] junrao commented on a change in pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

junrao commented on a change in pull request #10478: URL: https://github.com/apache/kafka/pull/10478#discussion_r610968190 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -255,19 +261,21 @@ case object SnapshotGenerated extends LogStartOffsetIncrementReason {

[GitHub] [kafka] tang7526 closed pull request #10515: MINOR: Remove deprecated checksum method

tang7526 closed pull request #10515: URL: https://github.com/apache/kafka/pull/10515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] ableegoldman commented on pull request #10411: KAFKA-7606: Remove deprecated options from StreamsResetter

ableegoldman commented on pull request #10411: URL: https://github.com/apache/kafka/pull/10411#issuecomment-817046460 Unrelated test failure in `InternalTopicManagerTest.shouldOnlyRetryNotSuccessfulFuturesDuringSetup()` (filed https://issues.apache.org/jira/browse/KAFKA-12650) -- This

[jira] [Commented] (KAFKA-12650) NPE in InternalTopicManager#cleanUpCreatedTopics

[ https://issues.apache.org/jira/browse/KAFKA-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318404#comment-17318404 ] A. Sophie Blee-Goldman commented on KAFKA-12650: This was from

[GitHub] [kafka] ableegoldman commented on a change in pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

ableegoldman commented on a change in pull request #10512: URL: https://github.com/apache/kafka/pull/10512#discussion_r610966015 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignorTest.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to

[jira] [Updated] (KAFKA-12650) NPE in InternalTopicManager#cleanUpCreatedTopics

[ https://issues.apache.org/jira/browse/KAFKA-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12650: --- Fix Version/s: 3.0.0 > NPE in InternalTopicManager#cleanUpCreatedTopics >

[jira] [Updated] (KAFKA-12650) NPE in InternalTopicManager#cleanUpCreatedTopics

[ https://issues.apache.org/jira/browse/KAFKA-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12650: --- Priority: Blocker (was: Major) > NPE in

[jira] [Commented] (KAFKA-12650) NPE in InternalTopicManager#cleanUpCreatedTopics

[ https://issues.apache.org/jira/browse/KAFKA-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318403#comment-17318403 ] A. Sophie Blee-Goldman commented on KAFKA-12650: cc [~cadonna] can you take a look at

[jira] [Created] (KAFKA-12650) NPE in InternalTopicManager#cleanUpCreatedTopics

A. Sophie Blee-Goldman created KAFKA-12650: -- Summary: NPE in InternalTopicManager#cleanUpCreatedTopics Key: KAFKA-12650 URL: https://issues.apache.org/jira/browse/KAFKA-12650 Project: Kafka

[GitHub] [kafka] dengziming commented on a change in pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

dengziming commented on a change in pull request #10512: URL: https://github.com/apache/kafka/pull/10512#discussion_r610965340 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignorTest.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to the

[GitHub] [kafka] showuon edited a comment on pull request #10409: KAFKA-9295: increase heartbeat interval to avoid unneeded rebalance

showuon edited a comment on pull request #10409: URL: https://github.com/apache/kafka/pull/10409#issuecomment-817043654 @ableegoldman , thanks for your comment. I know what your concern is, and it makes sense we merge other improvement first. I'll update the PR. Thank you. -- This is an

[GitHub] [kafka] showuon commented on pull request #10409: KAFKA-9295: increase heartbeat interval to avoid unneeded rebalance

showuon commented on pull request #10409: URL: https://github.com/apache/kafka/pull/10409#issuecomment-817043654 @ableegoldman , thanks for your comment. I know what your concern, and it makes sense we merge other improvement first. I'll update the PR. Thank you. -- This is an automated

[jira] [Assigned] (KAFKA-12649) Expose cache resizer for dynamic memory allocation

[ https://issues.apache.org/jira/browse/KAFKA-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Chen reassigned KAFKA-12649: Assignee: Ben Chen > Expose cache resizer for dynamic memory allocation >

[jira] [Created] (KAFKA-12649) Expose cache resizer for dynamic memory allocation

A. Sophie Blee-Goldman created KAFKA-12649: -- Summary: Expose cache resizer for dynamic memory allocation Key: KAFKA-12649 URL: https://issues.apache.org/jira/browse/KAFKA-12649 Project: Kafka

[GitHub] [kafka] hachikuji commented on a change in pull request #10483: KAFKA-12586; Add `DescribeTransactions` Admin API

hachikuji commented on a change in pull request #10483: URL: https://github.com/apache/kafka/pull/10483#discussion_r610962235 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeTransactionsResult.java ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] ableegoldman commented on a change in pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

ableegoldman commented on a change in pull request #10512: URL: https://github.com/apache/kafka/pull/10512#discussion_r610959238 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignorTest.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to

[GitHub] [kafka] ableegoldman commented on a change in pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

ableegoldman commented on a change in pull request #10512: URL: https://github.com/apache/kafka/pull/10512#discussion_r610959058 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignorTest.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to

[GitHub] [kafka] ableegoldman commented on pull request #10409: KAFKA-9295: increase heartbeat interval to avoid unneeded rebalance

ableegoldman commented on pull request #10409: URL: https://github.com/apache/kafka/pull/10409#issuecomment-817035420 Thanks @showuon . I guess my question is really this: why is it that this test, and no others, is frequently flaky due to dropping out on the session interval? There's

[GitHub] [kafka] hachikuji commented on a change in pull request #10483: KAFKA-12586; Add `DescribeTransactions` Admin API

hachikuji commented on a change in pull request #10483: URL: https://github.com/apache/kafka/pull/10483#discussion_r610956477 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DescribeTransactionsHandler.java ## @@ -0,0 +1,181 @@ +/* + * Licensed to

[GitHub] [kafka] dengziming commented on a change in pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

dengziming commented on a change in pull request #10512: URL: https://github.com/apache/kafka/pull/10512#discussion_r610955990 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignorTest.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to the

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610955955 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/SerdeRecordsIterator.java ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ableegoldman commented on a change in pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

ableegoldman commented on a change in pull request #10512: URL: https://github.com/apache/kafka/pull/10512#discussion_r610954191 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignorTest.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to

[GitHub] [kafka] ableegoldman commented on a change in pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

ableegoldman commented on a change in pull request #10512: URL: https://github.com/apache/kafka/pull/10512#discussion_r610954191 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignorTest.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610952440 ## File path: raft/src/test/java/org/apache/kafka/raft/MockLog.java ## @@ -418,48 +414,49 @@ public RawSnapshotWriter createSnapshot(OffsetAndEpoch

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610951347 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/SerdeRecordsIterator.java ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] MarcoLotz commented on pull request #10042: KAFKA-9527: fix NPE when using time-based argument for Stream Resetter

MarcoLotz commented on pull request #10042: URL: https://github.com/apache/kafka/pull/10042#issuecomment-817024578 @mjsax thanks! Rebased with the hotfix. Now should build as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610949543 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/SerdeRecordsIterator.java ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dengziming commented on a change in pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

dengziming commented on a change in pull request #10512: URL: https://github.com/apache/kafka/pull/10512#discussion_r610949055 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignorTest.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to the

[GitHub] [kafka] satishd commented on pull request #10489: MINOR Moved tiered storage API classes from clients module to a new storage-api module.

satishd commented on pull request #10489: URL: https://github.com/apache/kafka/pull/10489#issuecomment-817022234 Thanks @ijuma for bringing this up. Discussed earlier having api as the suffix for the API related classes. New package name in `storage:api` module becomes

[jira] [Updated] (KAFKA-12648) Experiment with resilient isomorphic topologies

[ https://issues.apache.org/jira/browse/KAFKA-12648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12648: --- Description: We're not ready to make this a public feature yet, but I want

[GitHub] [kafka] kkonstantine commented on a change in pull request #10503: KAFKA-9988: Suppress uncaught exceptions in log messages during task shutdown

kkonstantine commented on a change in pull request #10503: URL: https://github.com/apache/kafka/pull/10503#discussion_r610945519 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java ## @@ -185,8 +185,16 @@ private void doRun() throws

[GitHub] [kafka] dengziming commented on a change in pull request #10510: KAFKA-12607: Test case for resigned state vote granting

dengziming commented on a change in pull request #10510: URL: https://github.com/apache/kafka/pull/10510#discussion_r610945674 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -137,6 +137,65 @@ public void

[jira] [Created] (KAFKA-12648) Experiment with resilient isomorphic topologies

A. Sophie Blee-Goldman created KAFKA-12648: -- Summary: Experiment with resilient isomorphic topologies Key: KAFKA-12648 URL: https://issues.apache.org/jira/browse/KAFKA-12648 Project: Kafka

[GitHub] [kafka] satishd commented on pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

satishd commented on pull request #10218: URL: https://github.com/apache/kafka/pull/10218#issuecomment-817018916 Thanks @junrao for the comment, addressed with the commit [317be7a](https://github.com/apache/kafka/pull/10218/commits/317be7abe50264b6ed09bb85f36eacdc6b09599f). -- This is

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610944855 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,316 @@ +/* + *

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610944539 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java ## @@ -68,20 +70,65 @@ public synchronized void increment() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

ableegoldman commented on a change in pull request #10512: URL: https://github.com/apache/kafka/pull/10512#discussion_r610944206 ## File path: docs/upgrade.html ## @@ -49,8 +49,10 @@ Notable changes in 3 were removed. These methods were not intended to be public

[GitHub] [kafka] ableegoldman commented on a change in pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

ableegoldman commented on a change in pull request #10512: URL: https://github.com/apache/kafka/pull/10512#discussion_r610943138 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignor.java ## @@ -254,4 +258,41 @@ public static

[GitHub] [kafka] ableegoldman commented on a change in pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

ableegoldman commented on a change in pull request #10512: URL: https://github.com/apache/kafka/pull/10512#discussion_r610942845 ## File path: docs/upgrade.html ## @@ -49,8 +49,9 @@ Notable changes in 3 were removed. These methods were not intended to be public

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610942230 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java ## @@ -68,20 +70,65 @@ public synchronized void increment() {

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610940434 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java ## @@ -0,0 +1,174 @@ +/* + *

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610940157 ## File path: storage/src/test/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteStorageManagerTest.java ## @@ -0,0 +1,246 @@ +/* + *

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610939585 ## File path: raft/src/main/java/org/apache/kafka/snapshot/RawSnapshotReader.java ## @@ -37,17 +36,21 @@ * * @throws IOException for any IO

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610939450 ## File path: raft/src/main/java/org/apache/kafka/raft/metadata/MetaLogRaftShim.java ## @@ -124,6 +125,11 @@ public void handleCommit(BatchReader

[jira] [Created] (KAFKA-12647) Implement loading snapshot in the broker

Jose Armando Garcia Sancio created KAFKA-12647: -- Summary: Implement loading snapshot in the broker Key: KAFKA-12647 URL: https://issues.apache.org/jira/browse/KAFKA-12647 Project: Kafka

[jira] [Created] (KAFKA-12646) Implement loading snapshot in the controller

Jose Armando Garcia Sancio created KAFKA-12646: -- Summary: Implement loading snapshot in the controller Key: KAFKA-12646 URL: https://issues.apache.org/jira/browse/KAFKA-12646 Project:

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610934045 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/SerdeRecordsIterator.java ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dengziming commented on a change in pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

dengziming commented on a change in pull request #10512: URL: https://github.com/apache/kafka/pull/10512#discussion_r610932197 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignorTest.java ## @@ -0,0 +1,83 @@ +/* + * Licensed to the

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r61098 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/SerdeRecordsIterator.java ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r610933083 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/SerdeRecordsIterator.java ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] mjsax commented on pull request #10042: KAFKA-9527: fix NPE when using time-based argument for Stream Resetter

mjsax commented on pull request #10042: URL: https://github.com/apache/kafka/pull/10042#issuecomment-816995678 Hotfix merged. Retriggered Jenkins for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] mjsax merged pull request #10517: HOTFIX: delete removed WindowedStore.put() method

mjsax merged pull request #10517: URL: https://github.com/apache/kafka/pull/10517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] spena commented on pull request #10429: KAFKA-10847: Add new RocksDBPrefixRangeIterator class

spena commented on pull request #10429: URL: https://github.com/apache/kafka/pull/10429#issuecomment-816987077 Thanks @cadonna for the feedback. I decided not to use the prefix iterator. I will call the `all()` method, which will return the records ordered by time, and then I will delete

[GitHub] [kafka] spena closed pull request #10429: KAFKA-10847: Add new RocksDBPrefixRangeIterator class

spena closed pull request #10429: URL: https://github.com/apache/kafka/pull/10429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] mjsax commented on pull request #10042: KAFKA-9527: fix NPE when using time-based argument for Stream Resetter

mjsax commented on pull request #10042: URL: https://github.com/apache/kafka/pull/10042#issuecomment-816981220 Not your fault... `trunk` is broken: https://github.com/apache/kafka/pull/10517 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] abbccdda commented on a change in pull request #10482: KAFKA-12499: add transaction timeout verification

abbccdda commented on a change in pull request #10482: URL: https://github.com/apache/kafka/pull/10482#discussion_r610912167 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1014,6 +1015,23 @@ protected StreamsConfig(final Map props,

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610910922 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -601,6 +601,9 @@ private[log] object LogCleanerManager extends Logging {

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r610911015 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1859,15 +1819,15 @@ private void appendBatch(

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610910922 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -601,6 +601,9 @@ private[log] object LogCleanerManager extends Logging {

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610908966 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -601,6 +601,9 @@ private[log] object LogCleanerManager extends Logging {

[GitHub] [kafka] mjsax opened a new pull request #10517: HOTFIX: delete removed WindowedStore.put() method

mjsax opened a new pull request #10517: URL: https://github.com/apache/kafka/pull/10517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] jolshan edited a comment on pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan edited a comment on pull request #9944: URL: https://github.com/apache/kafka/pull/9944#issuecomment-814408153 ~currently blocked on https://github.com/apache/kafka/pull/10492 (Need to add topic IDs to the metadata topic for fetching)~ No longer blocked -- This is an

[GitHub] [kafka] mjsax commented on a change in pull request #10042: KAFKA-9527: fix NPE when using time-based argument for Stream Resetter

mjsax commented on a change in pull request #10042: URL: https://github.com/apache/kafka/pull/10042#discussion_r610904483 ## File path: streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java ## @@ -247,6 +278,32 @@ public void

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610893784 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -161,7 +181,7 @@ public void process(final K

[GitHub] [kafka] MarcoLotz commented on pull request #10042: KAFKA-9527: fix NPE when using time-based argument for Stream Resetter

MarcoLotz commented on pull request #10042: URL: https://github.com/apache/kafka/pull/10042#issuecomment-816957853 updated the PR and rebased with trunk. Build seems to be failing on trunk due to RocksDBTimeOrderedWindowStore.java -- This is an automated message from the Apache Git

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610891690 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -102,14 +127,98 @@ public void process(final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610891590 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -92,6 +113,10 @@ public void process(final K

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610891253 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -38,20 +45,32 @@ private final String

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610891116 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -118,20 +132,40 @@ final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610890964 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -211,6 +246,66 @@ private void

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610890414 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/KeyAndJoinSide.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] MarcoLotz commented on a change in pull request #10042: KAFKA-9527: fix NPE when using time-based argument for Stream Resetter

MarcoLotz commented on a change in pull request #10042: URL: https://github.com/apache/kafka/pull/10042#discussion_r610879225 ## File path: streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java ## @@ -76,6 +78,35 @@ public void

[GitHub] [kafka] MarcoLotz commented on a change in pull request #10042: KAFKA-9527: fix NPE when using time-based argument for Stream Resetter

MarcoLotz commented on a change in pull request #10042: URL: https://github.com/apache/kafka/pull/10042#discussion_r610877439 ## File path: streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java ## @@ -247,6 +278,32 @@ public void

[GitHub] [kafka] vvcephei merged pull request #10381: KAFKA-8410: Migrating KStream Stateless operators to new Processor API

vvcephei merged pull request #10381: URL: https://github.com/apache/kafka/pull/10381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] mjsax commented on pull request #10301: KAFKA-9831: increase max.poll.interval.ms to avoid unexpected rebalance

mjsax commented on pull request #10301: URL: https://github.com/apache/kafka/pull/10301#issuecomment-816928393 Thanks for the PR @showuon! -- Hope we get this test finally stable! Merged to `trunk` and cherry-picked to `2.8` and `2.7` branches. -- This is an automated message from

[jira] [Issue Comment Deleted] (KAFKA-9988) Connect incorrectly logs that task has failed when one takes too long to shutdown

[ https://issues.apache.org/jira/browse/KAFKA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel updated KAFKA-9988: - Comment: was deleted (was: https://github.com/apache/kafka/pull/10503/) > Connect incorrectly

[GitHub] [kafka] C0urante commented on a change in pull request #10503: KAFKA-9988: Suppress uncaught exceptions in log messages during task shutdown

C0urante commented on a change in pull request #10503: URL: https://github.com/apache/kafka/pull/10503#discussion_r610857776 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java ## @@ -185,8 +185,12 @@ private void doRun() throws

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10503: KAFKA-9988: Suppress uncaught exceptions in log messages during task shutdown

kpatelatwork commented on a change in pull request #10503: URL: https://github.com/apache/kafka/pull/10503#discussion_r610857516 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java ## @@ -185,8 +185,12 @@ private void doRun() throws

[GitHub] [kafka] mjsax merged pull request #10301: KAFKA-9831: increase max.poll.interval.ms to avoid unexpected rebalance

mjsax merged pull request #10301: URL: https://github.com/apache/kafka/pull/10301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (KAFKA-12566) Flaky Test MirrorConnectorsIntegrationSSLTest#testReplication

[ https://issues.apache.org/jira/browse/KAFKA-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318218#comment-17318218 ] Matthias J. Sax commented on KAFKA-12566: -

[GitHub] [kafka] mjsax commented on pull request #10423: MINOR website quickstart, fix typo

mjsax commented on pull request #10423: URL: https://github.com/apache/kafka/pull/10423#issuecomment-816904214 Thanks @Alee4738! Merged both PRs. (Cherry-picked this one also to `2.8` branch.) -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] mjsax merged pull request #10423: MINOR website quickstart, fix typo

mjsax merged pull request #10423: URL: https://github.com/apache/kafka/pull/10423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] mjsax commented on a change in pull request #10042: KAFKA-9527: fix NPE when using time-based argument for Stream Resetter

mjsax commented on a change in pull request #10042: URL: https://github.com/apache/kafka/pull/10042#discussion_r610849890 ## File path: streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java ## @@ -76,6 +78,35 @@ public void

[jira] [Updated] (KAFKA-12449) Remove deprecated WindowStore#put

[ https://issues.apache.org/jira/browse/KAFKA-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12449: Parent: KAFKA-12419 Issue Type: Sub-task (was: Task) > Remove deprecated

[jira] [Resolved] (KAFKA-12449) Remove deprecated WindowStore#put

[ https://issues.apache.org/jira/browse/KAFKA-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-12449. - Fix Version/s: 3.0.0 Resolution: Fixed > Remove deprecated WindowStore#put >

[GitHub] [kafka] mjsax commented on pull request #10293: KAFKA-12449: Remove deprecated WindowStore#put

mjsax commented on pull request #10293: URL: https://github.com/apache/kafka/pull/10293#issuecomment-816888464 Thanks @jeqo! Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mjsax merged pull request #10293: KAFKA-12449: Remove deprecated WindowStore#put

mjsax merged pull request #10293: URL: https://github.com/apache/kafka/pull/10293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

  1   2   >