[GitHub] [kafka] ewencp commented on a change in pull request #10915: Enable connecting VS Code remote debugger

2021-06-23 Thread GitBox
ewencp commented on a change in pull request #10915: URL: https://github.com/apache/kafka/pull/10915#discussion_r657638116 ## File path: tests/README.md ## @@ -51,6 +51,40 @@ bash tests/docker/ducker-ak up -j 'openjdk:11'; tests/docker/run_tests.sh ``` REBUILD="t" bash

[GitHub] [kafka] stan-confluent commented on a change in pull request #10915: Enable connecting VS Code remote debugger

2021-06-23 Thread GitBox
stan-confluent commented on a change in pull request #10915: URL: https://github.com/apache/kafka/pull/10915#discussion_r657636156 ## File path: tests/README.md ## @@ -51,6 +51,40 @@ bash tests/docker/ducker-ak up -j 'openjdk:11'; tests/docker/run_tests.sh ``` REBUILD="t"

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

2021-06-23 Thread GitBox
skaundinya15 commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r657611619 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DeleteConsumerGroupsResult.java ## @@ -29,9 +32,9 @@ */

[jira] [Commented] (KAFKA-12987) kafka用户无密码防暴力破解功能

2021-06-23 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368600#comment-17368600 ] Luke Chen commented on KAFKA-12987: --- [~ohye3166], thanks for your report. Could you translate into

[GitHub] [kafka] jolshan commented on pull request #10923: KAFKA-12976: Remove UNSUPPORTED_VERSION error from delete and describe topics calls

2021-06-23 Thread GitBox
jolshan commented on pull request #10923: URL: https://github.com/apache/kafka/pull/10923#issuecomment-867292878 I don't think we need to support unsupported version errors in the client. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Created] (KAFKA-12987) kafka用户无密码防暴力破解功能

2021-06-23 Thread chenzongyi (Jira)
chenzongyi created KAFKA-12987: -- Summary: kafka用户无密码防暴力破解功能 Key: KAFKA-12987 URL: https://issues.apache.org/jira/browse/KAFKA-12987 Project: Kafka Issue Type: Improvement Components:

[GitHub] [kafka] hachikuji commented on a change in pull request #10900: KAFKA-12967; KRaft broker should forward DescribeQuorum to controller

2021-06-23 Thread GitBox
hachikuji commented on a change in pull request #10900: URL: https://github.com/apache/kafka/pull/10900#discussion_r657576935 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -217,6 +227,7 @@ class KafkaApis(val requestChannel: RequestChannel, case

[GitHub] [kafka] g1geordie commented on pull request #10190: KAFKA-12336 Custom stream naming does not work while calling stream[K…

2021-06-23 Thread GitBox
g1geordie commented on pull request #10190: URL: https://github.com/apache/kafka/pull/10190#issuecomment-867277063 @bbejeck Failed test also appear in other issues. I think it's unrelated. ``` org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2,

[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-23 Thread GitBox
ccding commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r657558091 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -167,21 +245,14 @@ object LogLoader extends Logging { * in place of existing

[GitHub] [kafka] ccding commented on pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-23 Thread GitBox
ccding commented on pull request #10763: URL: https://github.com/apache/kafka/pull/10763#issuecomment-867273158 @junrao Thanks for the review. Addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] tombentley commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

2021-06-23 Thread GitBox
tombentley commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r657570794 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DeleteConsumerGroupsResult.java ## @@ -29,9 +32,9 @@ */

[GitHub] [kafka] ableegoldman commented on a change in pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-23 Thread GitBox
ableegoldman commented on a change in pull request #10840: URL: https://github.com/apache/kafka/pull/10840#discussion_r657560587 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1558,12 +1607,45 @@ private void processStreamThread(final

[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-23 Thread GitBox
ccding commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r657560081 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -106,7 +174,17 @@ object LogLoader extends Logging { loadSegmentFiles(params)

[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-23 Thread GitBox
ccding commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r657559556 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -90,11 +90,79 @@ object LogLoader extends Logging { *

[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-23 Thread GitBox
ccding commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r657558091 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -167,21 +245,14 @@ object LogLoader extends Logging { * in place of existing

[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-23 Thread GitBox
ccding commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r657558091 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -167,21 +245,14 @@ object LogLoader extends Logging { * in place of existing

[jira] [Commented] (KAFKA-12984) Cooperative sticky assignor can get stuck with invalid SubscriptionState input metadata

2021-06-23 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368542#comment-17368542 ] A. Sophie Blee-Goldman commented on KAFKA-12984: [~mjsax] Technically yes, the issue

[GitHub] [kafka] cmccabe commented on a change in pull request #10887: MINOR: Refactor the MetadataCache interface

2021-06-23 Thread GitBox
cmccabe commented on a change in pull request #10887: URL: https://github.com/apache/kafka/pull/10887#discussion_r657531976 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -1352,8 +1370,7 @@ class ReplicaManagerTest { Optional.of(1))

[GitHub] [kafka] cmccabe commented on a change in pull request #10887: MINOR: Refactor the MetadataCache interface

2021-06-23 Thread GitBox
cmccabe commented on a change in pull request #10887: URL: https://github.com/apache/kafka/pull/10887#discussion_r657531588 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -62,17 +46,22 @@ trait MetadataCache { def getAllTopics():

[GitHub] [kafka] cmccabe commented on a change in pull request #10887: MINOR: Refactor the MetadataCache interface

2021-06-23 Thread GitBox
cmccabe commented on a change in pull request #10887: URL: https://github.com/apache/kafka/pull/10887#discussion_r657530812 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2886,7 +2885,7 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10887: MINOR: Refactor the MetadataCache interface

2021-06-23 Thread GitBox
cmccabe commented on a change in pull request #10887: URL: https://github.com/apache/kafka/pull/10887#discussion_r657530674 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1164,7 +1164,7 @@ class KafkaApis(val requestChannel: RequestChannel, var

[GitHub] [kafka] IgnacioAcunaF commented on pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

2021-06-23 Thread GitBox
IgnacioAcunaF commented on pull request #10858: URL: https://github.com/apache/kafka/pull/10858#issuecomment-867206422 Hi @dajac, thanks again for your comments. I've updated the PR with them in consideration. What do you think? best regards -- This is an automated message from

[GitHub] [kafka] junrao commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-23 Thread GitBox
junrao commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r657507051 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -106,7 +174,17 @@ object LogLoader extends Logging { loadSegmentFiles(params)

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

2021-06-23 Thread GitBox
IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r657507129 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +62,92 @@ class ConsumerGroupServiceTest {

[GitHub] [kafka] izzyacademy commented on pull request #10740: Kafka 8613 kip 633 drop default grace period streams

2021-06-23 Thread GitBox
izzyacademy commented on pull request #10740: URL: https://github.com/apache/kafka/pull/10740#issuecomment-867189274 I rebased and created a brand new branch with the new changes. A new PR has been created https://github.com/apache/kafka/pull/10924/ Please take a look when

[GitHub] [kafka] izzyacademy commented on pull request #10924: KAFKA-8613: KIP-633 New APIs for Controlling Grace Period for Windowed Operations

2021-06-23 Thread GitBox
izzyacademy commented on pull request #10924: URL: https://github.com/apache/kafka/pull/10924#issuecomment-867188534 @ableegoldman @mjsax @showuon @cadonna When you have a moment, please take a look. This is an update based on the feedback from PR #10740 -- This is an

[GitHub] [kafka] izzyacademy opened a new pull request #10924: KAFKA-8613: KIP-633 New APIs for Controlling Grace Period for Windowed Operations

2021-06-23 Thread GitBox
izzyacademy opened a new pull request #10924: URL: https://github.com/apache/kafka/pull/10924 KIP-633 New APIs for Controlling Grace Period for Windowed Operations - Added API changes by KIP-633 for JoinWindows, SessionWindows, TimeWindows and SlidingWindows - Renamed

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

2021-06-23 Thread GitBox
IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r657483179 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +62,92 @@ class ConsumerGroupServiceTest {

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

2021-06-23 Thread GitBox
IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r657481603 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +62,92 @@ class ConsumerGroupServiceTest {

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

2021-06-23 Thread GitBox
IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r657479764 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +62,92 @@ class ConsumerGroupServiceTest {

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

2021-06-23 Thread GitBox
skaundinya15 commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r657473433 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DeleteConsumerGroupsResult.java ## @@ -29,9 +32,9 @@ */

[GitHub] [kafka] omkreddy commented on a change in pull request #10915: Enable connecting VS Code remote debugger

2021-06-23 Thread GitBox
omkreddy commented on a change in pull request #10915: URL: https://github.com/apache/kafka/pull/10915#discussion_r657466048 ## File path: tests/README.md ## @@ -51,6 +51,40 @@ bash tests/docker/ducker-ak up -j 'openjdk:11'; tests/docker/run_tests.sh ``` REBUILD="t" bash

[jira] [Commented] (KAFKA-12559) Add a top-level Streams config for bounding off-heap memory

2021-06-23 Thread Martin Sundeqvist (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368464#comment-17368464 ] Martin Sundeqvist commented on KAFKA-12559: --- [~ableegoldman] [~simplyamuthan] Hi, I can see

[GitHub] [kafka] izzyacademy commented on pull request #10740: Kafka 8613 kip 633 drop default grace period streams

2021-06-23 Thread GitBox
izzyacademy commented on pull request #10740: URL: https://github.com/apache/kafka/pull/10740#issuecomment-867140579 > Hey @izzyacademy , I'm taking a look but just a quick heads up: the build failed to compile, looks like the problem is some of the demo classes use one of the

[GitHub] [kafka] jolshan opened a new pull request #10923: KAFKA-12976: Remove UNSUPPORTED_VERSION error from delete and describe topics calls

2021-06-23 Thread GitBox
jolshan opened a new pull request #10923: URL: https://github.com/apache/kafka/pull/10923 Removed the condition to throw the error. Now we only throw when we didn't find the topic ID. Updated the test for IBP < 2.8 that tries to delete topics using ID. ### Committer Checklist

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

2021-06-23 Thread GitBox
IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r657421072 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +62,92 @@ class ConsumerGroupServiceTest {

[GitHub] [kafka] rondagostino commented on pull request #10918: KAFKA-12756: Update ZooKeeper to v3.6.3

2021-06-23 Thread GitBox
rondagostino commented on pull request #10918: URL: https://github.com/apache/kafka/pull/10918#issuecomment-86780 System test results before making the jar test dependency:

[GitHub] [kafka] g1geordie commented on pull request #10190: KAFKA-12336 Custom stream naming does not work while calling stream[K…

2021-06-23 Thread GitBox
g1geordie commented on pull request #10190: URL: https://github.com/apache/kafka/pull/10190#issuecomment-867105129 @bbejeck Thanks for the review. You are right Please help me review again. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (KAFKA-12984) Cooperative sticky assignor can get stuck with invalid SubscriptionState input metadata

2021-06-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368353#comment-17368353 ] Matthias J. Sax commented on KAFKA-12984: - [~ableegoldman] – is KS affected by this issue? Even

[jira] [Commented] (KAFKA-12984) Cooperative sticky assignor can get stuck with invalid SubscriptionState input metadata

2021-06-23 Thread Michael Bingham (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368354#comment-17368354 ] Michael Bingham commented on KAFKA-12984: - Does this issue potentially apply to

[jira] [Issue Comment Deleted] (KAFKA-12984) Cooperative sticky assignor can get stuck with invalid SubscriptionState input metadata

2021-06-23 Thread Michael Bingham (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bingham updated KAFKA-12984: Comment: was deleted (was: Does this issue potentially apply to

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

2021-06-23 Thread GitBox
jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r657306351 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TopicCollection.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (KAFKA-12986) Throttled Replicas validator should validate that the proposed value is parseable

2021-06-23 Thread David Mao (Jira)
David Mao created KAFKA-12986: - Summary: Throttled Replicas validator should validate that the proposed value is parseable Key: KAFKA-12986 URL: https://issues.apache.org/jira/browse/KAFKA-12986 Project:

[GitHub] [kafka] nnordrum closed pull request #2664: MINOR: Added additional -start/-stop files for consistency

2021-06-23 Thread GitBox
nnordrum closed pull request #2664: URL: https://github.com/apache/kafka/pull/2664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] nnordrum closed pull request #3518: WIP: SimpleRegexAclAuthorizer

2021-06-23 Thread GitBox
nnordrum closed pull request #3518: URL: https://github.com/apache/kafka/pull/3518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] guozhangwang commented on a change in pull request #10683: KAFKA-12648: Pt. 2 - Introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies

2021-06-23 Thread GitBox
guozhangwang commented on a change in pull request #10683: URL: https://github.com/apache/kafka/pull/10683#discussion_r657231704 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1200,7 +1179,7 @@ private long getCacheSizePerThread(final int

[GitHub] [kafka] feyman2016 commented on pull request #10593: KAFKA-10800 Enhance the test for validation when the state machine creates a snapshot

2021-06-23 Thread GitBox
feyman2016 commented on pull request #10593: URL: https://github.com/apache/kafka/pull/10593#issuecomment-866954962 @jsancio Thanks! @mumrah Hi, could you kindly help to review and merge? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mumrah commented on a change in pull request #10900: KAFKA-12967; KRaft broker should forward DescribeQuorum to controller

2021-06-23 Thread GitBox
mumrah commented on a change in pull request #10900: URL: https://github.com/apache/kafka/pull/10900#discussion_r657234456 ## File path: core/src/test/scala/unit/kafka/server/DescribeQuorumRequestTest.scala ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] vamossagar12 edited a comment on pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

2021-06-23 Thread GitBox
vamossagar12 edited a comment on pull request #10798: URL: https://github.com/apache/kafka/pull/10798#issuecomment-866823035 @guozhangwang / @cadonna I made some tweaks to the code and also started testing with 1M keys. Now I see differences in terms of throughput for both range and

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10683: KAFKA-12648: Pt. 2 - Introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies

2021-06-23 Thread GitBox
wcarlson5 commented on a change in pull request #10683: URL: https://github.com/apache/kafka/pull/10683#discussion_r657217991 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -16,10 +16,294 @@ */ package

[GitHub] [kafka] C0urante commented on a change in pull request #10854: KAFKA-12717: Remove internal Connect converter properties (KIP-738)

2021-06-23 Thread GitBox
C0urante commented on a change in pull request #10854: URL: https://github.com/apache/kafka/pull/10854#discussion_r657202256 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java ## @@ -361,55 +324,23 @@ protected static ConfigDef

[GitHub] [kafka] C0urante commented on a change in pull request #10854: KAFKA-12717: Remove internal Connect converter properties (KIP-738)

2021-06-23 Thread GitBox
C0urante commented on a change in pull request #10854: URL: https://github.com/apache/kafka/pull/10854#discussion_r657197034 ## File path: docs/upgrade.html ## @@ -76,6 +76,12 @@ Notable changes in 3 understood by brokers or version 2.5 or higher, so you must upgrade

[GitHub] [kafka] bbejeck commented on pull request #10190: KAFKA-12336 Custom stream naming does not work while calling stream[K…

2021-06-23 Thread GitBox
bbejeck commented on pull request #10190: URL: https://github.com/apache/kafka/pull/10190#issuecomment-866910927 @g1geordie apologies for letting this go for so long. I'm looking now and let's see if we can't get this in over the next few days. -- This is an automated message from the

[GitHub] [kafka] rhauch commented on pull request #10854: KAFKA-12717: Remove internal Connect converter properties (KIP-738)

2021-06-23 Thread GitBox
rhauch commented on pull request #10854: URL: https://github.com/apache/kafka/pull/10854#issuecomment-866908588 For the record, mostly green builds with only some builds having only failures unrelated to this PR. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] dajac commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

2021-06-23 Thread GitBox
dajac commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r657158355 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +62,92 @@ class ConsumerGroupServiceTest { verify(admin,

[GitHub] [kafka] rhauch commented on a change in pull request #10854: KAFKA-12717: Remove internal Connect converter properties (KIP-738)

2021-06-23 Thread GitBox
rhauch commented on a change in pull request #10854: URL: https://github.com/apache/kafka/pull/10854#discussion_r657156175 ## File path: docs/upgrade.html ## @@ -76,6 +76,12 @@ Notable changes in 3 understood by brokers or version 2.5 or higher, so you must upgrade

[jira] [Resolved] (KAFKA-12482) Remove deprecated rest.host.name and rest.port Connect worker configs

2021-06-23 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-12482. --- Reviewer: Randall Hauch Resolution: Fixed Merged to `trunk`. > Remove deprecated

[GitHub] [kafka] rhauch merged pull request #10841: KAFKA-12482 Remove deprecated rest.host.name and rest.port configs

2021-06-23 Thread GitBox
rhauch merged pull request #10841: URL: https://github.com/apache/kafka/pull/10841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

2021-06-23 Thread GitBox
kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r657148983 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/RestartPlan.java ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jlprat commented on pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-23 Thread GitBox
jlprat commented on pull request #10840: URL: https://github.com/apache/kafka/pull/10840#issuecomment-866870832 @ableegoldman and @cadonna thanks a lot for your reviews! I think I addressed all of your comments. Let me know what do you think about them. -- This is an automated message

[GitHub] [kafka] jlprat commented on a change in pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-23 Thread GitBox
jlprat commented on a change in pull request #10840: URL: https://github.com/apache/kafka/pull/10840#discussion_r657138308 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskMetadataImplTest.java ## @@ -0,0 +1,141 @@ +/* + * Licensed to the

[GitHub] [kafka] jlprat commented on pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-23 Thread GitBox
jlprat commented on pull request #10840: URL: https://github.com/apache/kafka/pull/10840#issuecomment-866866991 Needed to rebase as there were some conflicts with trunk, hence the force push. I applied the changes in separate commits: - One for method renames, formattings and

[GitHub] [kafka] jlprat commented on a change in pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-23 Thread GitBox
jlprat commented on a change in pull request #10840: URL: https://github.com/apache/kafka/pull/10840#discussion_r657134887 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ThreadMetadataImpl.java ## @@ -57,7 +57,11 @@ public

[GitHub] [kafka] jlprat commented on a change in pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-23 Thread GitBox
jlprat commented on a change in pull request #10840: URL: https://github.com/apache/kafka/pull/10840#discussion_r657132576 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1478,8 +1499,36 @@ public void cleanUp() { * @param storeName

[GitHub] [kafka] jlprat commented on a change in pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-23 Thread GitBox
jlprat commented on a change in pull request #10840: URL: https://github.com/apache/kafka/pull/10840#discussion_r657132064 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1558,12 +1607,45 @@ private void processStreamThread(final Consumer

[GitHub] [kafka] jlprat commented on a change in pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-23 Thread GitBox
jlprat commented on a change in pull request #10840: URL: https://github.com/apache/kafka/pull/10840#discussion_r657131881 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1458,8 +1457,30 @@ public void cleanUp() { * Note: this is a

[GitHub] [kafka] rhauch commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

2021-06-23 Thread GitBox
rhauch commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r657118416 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/RestartPlan.java ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rhauch commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

2021-06-23 Thread GitBox
rhauch commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655779197 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/RestartRequest.java ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache

[jira] [Commented] (KAFKA-12790) Fix SslTransportLayerTest.testUnsupportedTlsVersion with JDK 16 and recent versions of 8 and 11

2021-06-23 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368114#comment-17368114 ] Ismael Juma commented on KAFKA-12790: - [~ueisele] I submitted a fix. Thanks once again for the help!

[GitHub] [kafka] rondagostino commented on a change in pull request #10918: KAFKA-12756: Update ZooKeeper to v3.6.3

2021-06-23 Thread GitBox
rondagostino commented on a change in pull request #10918: URL: https://github.com/apache/kafka/pull/10918#discussion_r657107216 ## File path: gradle/dependencies.gradle ## @@ -61,6 +61,7 @@ versions += [ bcpkix: "1.66", checkstyle: "8.36.2", commonsCli: "1.4", +

[GitHub] [kafka] rondagostino commented on a change in pull request #10918: KAFKA-12756: Update ZooKeeper to v3.6.3

2021-06-23 Thread GitBox
rondagostino commented on a change in pull request #10918: URL: https://github.com/apache/kafka/pull/10918#discussion_r657104600 ## File path: docs/upgrade.html ## @@ -21,6 +21,13 @@ Notable changes in 3.0.0 +ZooKeeper has been upgraded to 3.6.3, and that version has

[jira] [Resolved] (KAFKA-12786) Getting SslTransportLayerTest error

2021-06-23 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-12786. - Resolution: Duplicate Since it's the same root cause as KAFKA-12790, marking as a duplicate of

[jira] [Updated] (KAFKA-12790) Fix SslTransportLayerTest.testUnsupportedTlsVersion with JDK 16 and recent versions of 8 and 11

2021-06-23 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12790: Description: Support for TLS 1.0 and 1.1 was disabled in recent versions of Java 8/11 and all

[jira] [Assigned] (KAFKA-12790) Fix SslTransportLayerTest.testUnsupportedTlsVersion with JDK 16 and recent versions of 8 and 11

2021-06-23 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-12790: --- Reviewer: Rajini Sivaram Assignee: Ismael Juma (was: Rajini Sivaram) > Fix

[jira] [Updated] (KAFKA-12790) Fix SslTransportLayerTest.testUnsupportedTlsVersion with JDK 16 and recent versions of 8 and 11

2021-06-23 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12790: Summary: Fix SslTransportLayerTest.testUnsupportedTlsVersion with JDK 16 and recent versions of 8

[jira] [Updated] (KAFKA-12790) Fix SslTransportLayerTest.testUnsupportedTlsVersion with JDK 16 and recent versions of 8 and 11

2021-06-23 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12790: Description: [|https://github.com/apache/kafka/pull/10415#issuecomment-808230478] (was: Details

[GitHub] [kafka] ijuma opened a new pull request #10922: KAFKA-12790: Fix SslTransportLayerTest.testUnsupportedTlsVersion with recent JDKs

2021-06-23 Thread GitBox
ijuma opened a new pull request #10922: URL: https://github.com/apache/kafka/pull/10922 Support for TLS 1.0 and 1.1 was disabled in recent versions of Java 8/11 and all versions of 16. Re-enable it in this test so that we can verify the server behavior when it establishes connections

[GitHub] [kafka] vamossagar12 commented on pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

2021-06-23 Thread GitBox
vamossagar12 commented on pull request #10798: URL: https://github.com/apache/kafka/pull/10798#issuecomment-866823035 @guozhangwang / @cadonna I made some tweaks to the code and also started testing with 1M keys. Now I see differences in terms of throughput for both range and putAll

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

2021-06-23 Thread GitBox
thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r657052453 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java ## @@ -54,9 +55,11 @@ public static Builder

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

2021-06-23 Thread GitBox
thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r657052063 ## File path: clients/src/main/resources/common/message/ListOffsetsResponse.json ## @@ -29,7 +29,9 @@ // Version 5 adds a new error code,

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

2021-06-23 Thread GitBox
thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r657051441 ## File path: core/src/test/scala/unit/kafka/server/LogOffsetTest.scala ## @@ -149,6 +179,21 @@ class LogOffsetTest extends BaseRequestTest {

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

2021-06-23 Thread GitBox
thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r657051339 ## File path: core/src/test/scala/unit/kafka/server/LogOffsetTest.scala ## @@ -93,16 +87,52 @@ class LogOffsetTest extends BaseRequestTest { }

[GitHub] [kafka] vitojeng edited a comment on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

2021-06-23 Thread GitBox
vitojeng edited a comment on pull request #10825: URL: https://github.com/apache/kafka/pull/10825#issuecomment-866794585 update PR & rebase trunk. Remove: ``` KafkaStreams streams(); ``` Add ``` KafkaStreams.State streamsState(); ``` -- This is an automated

[GitHub] [kafka] guozhangwang commented on a change in pull request #10683: KAFKA-12648: Pt. 2 - Introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies

2021-06-23 Thread GitBox
guozhangwang commented on a change in pull request #10683: URL: https://github.com/apache/kafka/pull/10683#discussion_r657029488 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -799,41 +795,41 @@ public KafkaStreams(final Topology topology,

[GitHub] [kafka] vitojeng commented on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

2021-06-23 Thread GitBox
vitojeng commented on pull request #10825: URL: https://github.com/apache/kafka/pull/10825#issuecomment-866794585 update PR & rebase trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

2021-06-23 Thread GitBox
thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r657032428 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java ## @@ -54,9 +55,11 @@ public static Builder

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

2021-06-23 Thread GitBox
thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r657007472 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -1444,43 +1450,63 @@ private

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

2021-06-23 Thread GitBox
thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r657007220 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -302,10 +302,16 @@ public void

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

2021-06-23 Thread GitBox
thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r657007003 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4298,6 +4296,39 @@ void handleFailure(Throwable

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

2021-06-23 Thread GitBox
thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r657004623 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4298,6 +4296,39 @@ void handleFailure(Throwable

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

2021-06-23 Thread GitBox
thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r656955014 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -4226,6 +4235,124 @@ public void

[GitHub] [kafka] cadonna commented on a change in pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-23 Thread GitBox
cadonna commented on a change in pull request #10840: URL: https://github.com/apache/kafka/pull/10840#discussion_r656890122 ## File path: streams/src/main/java/org/apache/kafka/streams/TaskMetadata.java ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] PhilHardwick opened a new pull request #10921: MINOR: Ensure queryable store providers is up to date after adding stream thread

2021-06-23 Thread GitBox
PhilHardwick opened a new pull request #10921: URL: https://github.com/apache/kafka/pull/10921 When a new thread is added the queryable store providers continues to use the store providers it was given when KafkaStreams was instantiated. I wanted to keep QueryableStoreProviders

[jira] [Commented] (KAFKA-12984) Cooperative sticky assignor can get stuck with invalid SubscriptionState input metadata

2021-06-23 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367967#comment-17367967 ] Luke Chen commented on KAFKA-12984: --- Good root cause analysis! And I agree the solution (a) that the

[jira] [Comment Edited] (KAFKA-12984) Cooperative sticky assignor can get stuck with invalid SubscriptionState input metadata

2021-06-23 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367967#comment-17367967 ] Luke Chen edited comment on KAFKA-12984 at 6/23/21, 8:42 AM: - Good root

[GitHub] [kafka] cadonna commented on pull request #10897: MINOR: Reduced severity for "skipping records" falling out of time windows

2021-06-23 Thread GitBox
cadonna commented on pull request #10897: URL: https://github.com/apache/kafka/pull/10897#issuecomment-866637956 FYI: I opened PR #10920 to improve the unit tests for the log messages for the other types of dropped records. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] cadonna commented on pull request #10920: MINOR: Improve test of log messages for dropped records

2021-06-23 Thread GitBox
cadonna commented on pull request #10920: URL: https://github.com/apache/kafka/pull/10920#issuecomment-866636831 Call for review: @xdgrulez @mjsax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] cadonna opened a new pull request #10920: MINOR: Improve test of log messages for dropped records

2021-06-23 Thread GitBox
cadonna opened a new pull request #10920: URL: https://github.com/apache/kafka/pull/10920 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] dongjinleekr opened a new pull request #10919: KAFKA-12985: CVE-2021-28169 - Upgrade jetty to 9.4.41

2021-06-23 Thread GitBox
dongjinleekr opened a new pull request #10919: URL: https://github.com/apache/kafka/pull/10919 [Jetty 9.4.41.v20210516](https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.41.v20210516) resolves following security vulnerabilities. -

[jira] [Created] (KAFKA-12985) CVE-2021-28169 - Upgrade jetty to 9.4.41

2021-06-23 Thread Dongjin Lee (Jira)
Dongjin Lee created KAFKA-12985: --- Summary: CVE-2021-28169 - Upgrade jetty to 9.4.41 Key: KAFKA-12985 URL: https://issues.apache.org/jira/browse/KAFKA-12985 Project: Kafka Issue Type: Task

  1   2   >