tombentley commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r657570794
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DeleteConsumerGroupsResult.java
##########
@@ -29,9 +32,9 @@
*/
@InterfaceStability.Evolving
public class DeleteConsumerGroupsResult {
- private final Map<String, KafkaFuture<Void>> futures;
+ private final Map<CoordinatorKey, KafkaFutureImpl<Void>> futures;
- DeleteConsumerGroupsResult(final Map<String, KafkaFuture<Void>> futures) {
+ DeleteConsumerGroupsResult(Map<CoordinatorKey, KafkaFutureImpl<Void>>
futures) {
Review comment:
@skaundinya15 those methods in `KafkaFuture` are intentionally not
`public` because a user receiving an instance should _never_ need to complete
the future (they're always completed by the admin client). Making them `public`
would thus make the API less type safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
