[GitHub] [kafka] vvcephei commented on a change in pull request #11003: KAFKA-12360: Document new time semantics

2021-07-08 Thread GitBox
vvcephei commented on a change in pull request #11003: URL: https://github.com/apache/kafka/pull/11003#discussion_r666504937 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -427,8 +427,18 @@ /** {@code max.task.idle.ms} */

[GitHub] [kafka] JimGalasyn commented on a change in pull request #11003: KAFKA-12360: Document new time semantics

2021-07-08 Thread GitBox
JimGalasyn commented on a change in pull request #11003: URL: https://github.com/apache/kafka/pull/11003#discussion_r666504127 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -427,8 +427,18 @@ /** {@code max.task.idle.ms} */

[GitHub] [kafka] vvcephei commented on a change in pull request #11003: KAFKA-12360: Document new time semantics

2021-07-08 Thread GitBox
vvcephei commented on a change in pull request #11003: URL: https://github.com/apache/kafka/pull/11003#discussion_r666503862 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -600,8 +613,34 @@ default.windowed.value.serde.innermax.task.idle.ms

[GitHub] [kafka] JimGalasyn commented on a change in pull request #11003: KAFKA-12360: Document new time semantics

2021-07-08 Thread GitBox
JimGalasyn commented on a change in pull request #11003: URL: https://github.com/apache/kafka/pull/11003#discussion_r666503902 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -427,8 +427,18 @@ /** {@code max.task.idle.ms} */

[GitHub] [kafka] JimGalasyn commented on a change in pull request #11003: KAFKA-12360: Document new time semantics

2021-07-08 Thread GitBox
JimGalasyn commented on a change in pull request #11003: URL: https://github.com/apache/kafka/pull/11003#discussion_r666502845 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -600,8 +613,34 @@ default.windowed.value.serde.innermax.task.idle.ms

[GitHub] [kafka] vvcephei commented on a change in pull request #11003: KAFKA-12360: Document new time semantics

2021-07-08 Thread GitBox
vvcephei commented on a change in pull request #11003: URL: https://github.com/apache/kafka/pull/11003#discussion_r666502523 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -241,8 +241,21 @@ bootstrap.serversmax.task.idle.ms Medium -

[GitHub] [kafka] vvcephei commented on pull request #11003: KAFKA-12360: Document new time semantics

2021-07-08 Thread GitBox
vvcephei commented on pull request #11003: URL: https://github.com/apache/kafka/pull/11003#issuecomment-876730215 Note that I'll need to cherry-pick this PR to AK 3.0 once it's merged (cc @kkonstantine ) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] JimGalasyn commented on a change in pull request #11003: KAFKA-12360: Document new time semantics

2021-07-08 Thread GitBox
JimGalasyn commented on a change in pull request #11003: URL: https://github.com/apache/kafka/pull/11003#discussion_r666502139 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -241,8 +241,21 @@ bootstrap.serversmax.task.idle.ms Medium -

[jira] [Commented] (KAFKA-12360) Improve documentation of max.task.idle.ms (kafka-streams)

2021-07-08 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377583#comment-17377583 ] John Roesler commented on KAFKA-12360: -- Ok, now that KIP-695 is implemented (for AK 3.0), the

[GitHub] [kafka] vvcephei commented on pull request #11003: KAFKA-12360: Document new time semantics

2021-07-08 Thread GitBox
vvcephei commented on pull request #11003: URL: https://github.com/apache/kafka/pull/11003#issuecomment-876725691 Here are the rendered docs (just the sections I changed):

[GitHub] [kafka] vvcephei opened a new pull request #11003: KAFKA-12360: Document new time semantics

2021-07-08 Thread GitBox
vvcephei opened a new pull request #11003: URL: https://github.com/apache/kafka/pull/11003 Update the docs for task idling, since the semantics have changed in 3.0. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify

[GitHub] [kafka] ableegoldman commented on pull request #11001: MINOR: fix typo in config for eos-v2 docs of the upgrade guide

2021-07-08 Thread GitBox
ableegoldman commented on pull request #11001: URL: https://github.com/apache/kafka/pull/11001#issuecomment-876693316 Merged to trunk and cherrypicked to 3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] ableegoldman merged pull request #11001: MINOR: fix typo in config for eos-v2 docs of the upgrade guide

2021-07-08 Thread GitBox
ableegoldman merged pull request #11001: URL: https://github.com/apache/kafka/pull/11001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #11001: MINOR: fix typo in config for eos-v2 docs of the upgrade guide

2021-07-08 Thread GitBox
ableegoldman commented on pull request #11001: URL: https://github.com/apache/kafka/pull/11001#issuecomment-876690866 Alright I'm just going to merge this since it's a trivial typo fix. Ran the streams tests locally as a sanity check and we're all good -- This is an automated message

[jira] [Created] (KAFKA-13052) Replace uses of SerDes in the docs with Serdes

2021-07-08 Thread Leah Thomas (Jira)
Leah Thomas created KAFKA-13052: --- Summary: Replace uses of SerDes in the docs with Serdes Key: KAFKA-13052 URL: https://issues.apache.org/jira/browse/KAFKA-13052 Project: Kafka Issue Type:

[GitHub] [kafka] lct45 commented on pull request #10988: KAFKA-9559: add docs for changing default serde to null

2021-07-08 Thread GitBox
lct45 commented on pull request #10988: URL: https://github.com/apache/kafka/pull/10988#issuecomment-876679764 Thanks @ableegoldman ! created the follow-up here: https://issues.apache.org/jira/browse/KAFKA-13052 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] d8tltanc opened a new pull request #11002: KAFKA-13026: Idempotent producer (KAFKA-10619) follow-up testings

2021-07-08 Thread GitBox
d8tltanc opened a new pull request #11002: URL: https://github.com/apache/kafka/pull/11002 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* We modified the

[jira] [Resolved] (KAFKA-12931) KIP-746: Revise KRaft Metadata Records

2021-07-08 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-12931. Resolution: Fixed > KIP-746: Revise KRaft Metadata Records >

[jira] [Updated] (KAFKA-13026) Idempotent producer (KAFKA-10619) follow-up testings

2021-07-08 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-13026: -- Summary: Idempotent producer (KAFKA-10619) follow-up testings (was: Idempotent producer

[GitHub] [kafka] ableegoldman opened a new pull request #11001: MINOR: fix typo in config for eos-v2 docs of the upgrade guide

2021-07-08 Thread GitBox
ableegoldman opened a new pull request #11001: URL: https://github.com/apache/kafka/pull/11001 One of the configs has a typo and should have been `exactly_once _v2` rather than just `exactly_once` -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] cmccabe commented on a change in pull request #10753: KAFKA-12803: Support reassigning partitions when in KRaft mode

2021-07-08 Thread GitBox
cmccabe commented on a change in pull request #10753: URL: https://github.com/apache/kafka/pull/10753#discussion_r665799816 ## File path: metadata/src/main/java/org/apache/kafka/controller/RemovingAndAddingReplicas.java ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rondagostino commented on pull request #10991: MINOR: system test fix for 3 co-located KRaft controllers

2021-07-08 Thread GitBox
rondagostino commented on pull request #10991: URL: https://github.com/apache/kafka/pull/10991#issuecomment-876658421 In case we want to stick with the current solution: ``` SESSION REPORT (ALL TESTS)

[GitHub] [kafka] skaundinya15 commented on pull request #11000: KAFKA-13045: Adding a test for batched offsetFetch requests with one group repeating

2021-07-08 Thread GitBox
skaundinya15 commented on pull request #11000: URL: https://github.com/apache/kafka/pull/11000#issuecomment-876657667 @rajinisivaram I have opened this PR as a follow up to the request/response implementations in KIP-709. Please take a look whenever you get a chance - thanks! -- This

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10962: KAFKA-12234: Implement request/response for offsetFetch batching (KIP-709)

2021-07-08 Thread GitBox
skaundinya15 commented on a change in pull request #10962: URL: https://github.com/apache/kafka/pull/10962#discussion_r666432011 ## File path: clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java ## @@ -174,6 +315,28 @@ public boolean

[GitHub] [kafka] ableegoldman commented on pull request #10988: KAFKA-9559: add docs for changing default serde to null

2021-07-08 Thread GitBox
ableegoldman commented on pull request #10988: URL: https://github.com/apache/kafka/pull/10988#issuecomment-876657026 Merged to trunk and cherrypicked to 3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] skaundinya15 opened a new pull request #11000: KAFKA-13045: Adding a test for batched offsetFetch requests with one group repeating

2021-07-08 Thread GitBox
skaundinya15 opened a new pull request #11000: URL: https://github.com/apache/kafka/pull/11000 This PR follows up on the implementation in https://github.com/apache/kafka/pull/10962 to add an additional test for batched `offsetFetch` requests where we have a group that is repeating with a

[GitHub] [kafka] ableegoldman merged pull request #10988: KAFKA-9559: add docs for changing default serde to null

2021-07-08 Thread GitBox
ableegoldman merged pull request #10988: URL: https://github.com/apache/kafka/pull/10988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on a change in pull request #10988: [KAFKA-9559] add docs for changing default serde to null

2021-07-08 Thread GitBox
ableegoldman commented on a change in pull request #10988: URL: https://github.com/apache/kafka/pull/10988#discussion_r666428748 ## File path: docs/streams/developer-guide/datatypes.html ## @@ -34,7 +34,7 @@ Data Types and Serialization Every Kafka Streams

[GitHub] [kafka] ableegoldman commented on pull request #10996: MINOR: StreamsPartitionAssignor should log the individual members of each client

2021-07-08 Thread GitBox
ableegoldman commented on pull request #10996: URL: https://github.com/apache/kafka/pull/10996#issuecomment-876650325 Merged to trunk and cherrypicked to 3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] hachikuji commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-07-08 Thread GitBox
hachikuji commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r666420857 ## File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java ## @@ -167,21 +167,9 @@ public void ensureValid() { *

[jira] [Created] (KAFKA-13051) Require Principal Serde to be defined for 3.0

2021-07-08 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-13051: - Summary: Require Principal Serde to be defined for 3.0 Key: KAFKA-13051 URL: https://issues.apache.org/jira/browse/KAFKA-13051 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-12360) Improve documentation of max.task.idle.ms (kafka-streams)

2021-07-08 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-12360: - Parent: KAFKA-10091 Issue Type: Sub-task (was: Improvement) > Improve documentation of

[jira] [Assigned] (KAFKA-12360) Improve documentation of max.task.idle.ms (kafka-streams)

2021-07-08 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-12360: Assignee: John Roesler > Improve documentation of max.task.idle.ms (kafka-streams) >

[jira] [Resolved] (KAFKA-8478) Poll for more records before forced processing

2021-07-08 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-8478. - Resolution: Fixed > Poll for more records before forced processing >

[jira] [Updated] (KAFKA-8478) Poll for more records before forced processing

2021-07-08 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-8478: Fix Version/s: 3.0.0 > Poll for more records before forced processing >

[jira] [Commented] (KAFKA-8478) Poll for more records before forced processing

2021-07-08 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377549#comment-17377549 ] John Roesler commented on KAFKA-8478: - Hello again, all, this issue should be resolved in 3.0, via

[GitHub] [kafka] ableegoldman merged pull request #10996: MINOR: StreamsPartitionAssignor should log the individual members of each client

2021-07-08 Thread GitBox
ableegoldman merged pull request #10996: URL: https://github.com/apache/kafka/pull/10996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #10996: MINOR: StreamsPartitionAssignor should log the individual members of each client

2021-07-08 Thread GitBox
ableegoldman commented on pull request #10996: URL: https://github.com/apache/kafka/pull/10996#issuecomment-876642593 All test failures unrelated, in `kafka.server`, `kafka.api`, or `kafka.raft`. Will merge -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (KAFKA-8315) Historical join issues

2021-07-08 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-8315: Fix Version/s: 3.0.0 > Historical join issues > -- > > Key:

[jira] [Commented] (KAFKA-8315) Historical join issues

2021-07-08 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377546#comment-17377546 ] John Roesler commented on KAFKA-8315: - Hello again, all, this issue should be resolved in 3.0, via

[jira] [Resolved] (KAFKA-8315) Historical join issues

2021-07-08 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-8315. - Resolution: Fixed > Historical join issues > -- > > Key:

[GitHub] [kafka] cmccabe merged pull request #10982: MINOR: Update dropwizard metrics to 4.1.12.1

2021-07-08 Thread GitBox
cmccabe merged pull request #10982: URL: https://github.com/apache/kafka/pull/10982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-07-08 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r666406571 ## File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java ## @@ -156,13 +161,27 @@ public void ensureValid() {

[GitHub] [kafka] jolshan commented on pull request #10999: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name (for 3.0)

2021-07-08 Thread GitBox
jolshan commented on pull request #10999: URL: https://github.com/apache/kafka/pull/10999#issuecomment-876629791 I realized I can change the target of the original. I'll open a new PR for the revised trunk version. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] jolshan closed pull request #10999: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name (for 3.0)

2021-07-08 Thread GitBox
jolshan closed pull request #10999: URL: https://github.com/apache/kafka/pull/10999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jolshan opened a new pull request #10999: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name (for 3.0)

2021-07-08 Thread GitBox
jolshan opened a new pull request #10999: URL: https://github.com/apache/kafka/pull/10999 Opening a version of https://github.com/apache/kafka/pull/10952 for the 3.0 branch Store topic ID info in consumer metadata. We will always take the topic ID from the latest metadata response

[GitHub] [kafka] jolshan commented on pull request #10998: MINOR: fix quoted boolean in FetchRequest.json

2021-07-08 Thread GitBox
jolshan commented on pull request #10998: URL: https://github.com/apache/kafka/pull/10998#issuecomment-876625362 Ah this should be fine. I don't think I should have put that in quotes in the first place. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (KAFKA-12660) Do not update offset commit sensor after append failure

2021-07-08 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12660. - Fix Version/s: 3.0.0 Resolution: Fixed > Do not update offset commit sensor

[GitHub] [kafka] hachikuji merged pull request #10560: KAFKA-12660: Do not update offset commit sensor after append failure

2021-07-08 Thread GitBox
hachikuji merged pull request #10560: URL: https://github.com/apache/kafka/pull/10560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] kamalcph commented on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails

2021-07-08 Thread GitBox
kamalcph commented on pull request #10995: URL: https://github.com/apache/kafka/pull/10995#issuecomment-876604684 @cmccabe Updated #10499, can you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] junrao commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-07-08 Thread GitBox
junrao commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r666372073 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -0,0 +1,432 @@ +/*

[GitHub] [kafka] hachikuji commented on a change in pull request #10794: KAFKA-12677: return not_controller error in envelope response itself

2021-07-08 Thread GitBox
hachikuji commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r666364712 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ApiError.java ## @@ -36,10 +38,21 @@ private final String message;

[GitHub] [kafka] cmccabe merged pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails

2021-07-08 Thread GitBox
cmccabe merged pull request #10995: URL: https://github.com/apache/kafka/pull/10995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails

2021-07-08 Thread GitBox
cmccabe commented on pull request #10995: URL: https://github.com/apache/kafka/pull/10995#issuecomment-876596528 > There is also a tip to run the command with --no-cache flag on error. Why isn't it exposed? I agree `--no-cache` should probably appear in the help output somewhere.

[GitHub] [kafka] cmccabe commented on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails

2021-07-08 Thread GitBox
cmccabe commented on pull request #10995: URL: https://github.com/apache/kafka/pull/10995#issuecomment-876593643 > PR: #10499 @kamalcph: Thanks for that. Can you make a more minimal PR that just changes `ducker.type` to `ducker.creator`? We're getting so close to the release,

[GitHub] [kafka] 0x1991babe opened a new pull request #10998: MINOR: fix quoted boolean in FetchRequest.json

2021-07-08 Thread GitBox
0x1991babe opened a new pull request #10998: URL: https://github.com/apache/kafka/pull/10998 Hi, I'm working on maintaining an implementation of the protocol written in Rust: https://github.com/0x1991babe/kafka-protocol-rs. A recent change in 2b8aff58b5 breaks my deserialization logic for

[GitHub] [kafka] cmccabe commented on a change in pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails

2021-07-08 Thread GitBox
cmccabe commented on a change in pull request #10995: URL: https://github.com/apache/kafka/pull/10995#discussion_r666362458 ## File path: tests/docker/ducker-ak ## @@ -185,6 +185,12 @@ must_popd() { popd &> /dev/null || die "failed to popd" } +echo_and_do() { +

[GitHub] [kafka] kamalcph commented on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails

2021-07-08 Thread GitBox
kamalcph commented on pull request #10995: URL: https://github.com/apache/kafka/pull/10995#issuecomment-876590746 > @kamalcph : Thanks, that is a good find. I agree we should update the label from ducker.type to ducker.creator. Can you make a separate PR for that? I can review it quickly.

[GitHub] [kafka] cmccabe commented on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails

2021-07-08 Thread GitBox
cmccabe commented on pull request #10995: URL: https://github.com/apache/kafka/pull/10995#issuecomment-876590217 @kamalcph : Thanks, that is a good find. I agree we should update the label from ducker.type to ducker.creator. Can you make a separate PR for that? I can review it quickly.

[GitHub] [kafka] hachikuji commented on a change in pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails

2021-07-08 Thread GitBox
hachikuji commented on a change in pull request #10995: URL: https://github.com/apache/kafka/pull/10995#discussion_r666360055 ## File path: tests/docker/ducker-ak ## @@ -185,6 +185,12 @@ must_popd() { popd &> /dev/null || die "failed to popd" } +echo_and_do() { +

[GitHub] [kafka] kamalcph edited a comment on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails

2021-07-08 Thread GitBox
kamalcph edited a comment on pull request #10995: URL: https://github.com/apache/kafka/pull/10995#issuecomment-876589345 Also, can you update the label from `ducker.type` to `ducker.creator`

[GitHub] [kafka] kamalcph commented on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails

2021-07-08 Thread GitBox
kamalcph commented on pull request #10995: URL: https://github.com/apache/kafka/pull/10995#issuecomment-876589345 Also, can you update the label from `ducker.type` to `ducker.creator`

[GitHub] [kafka] cmccabe commented on a change in pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails

2021-07-08 Thread GitBox
cmccabe commented on a change in pull request #10995: URL: https://github.com/apache/kafka/pull/10995#discussion_r666358707 ## File path: tests/docker/ducker-ak ## @@ -185,6 +185,12 @@ must_popd() { popd &> /dev/null || die "failed to popd" } +echo_and_do() { +

[GitHub] [kafka] kamalcph commented on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails

2021-07-08 Thread GitBox
kamalcph commented on pull request #10995: URL: https://github.com/apache/kafka/pull/10995#issuecomment-876588345 There is also a tip to run the command with `--no-cache` flag on error. Why isn't it exposed? -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (KAFKA-13050) Race between controller creating snapshot and snapshot cleaning

2021-07-08 Thread David Arthur (Jira)
David Arthur created KAFKA-13050: Summary: Race between controller creating snapshot and snapshot cleaning Key: KAFKA-13050 URL: https://issues.apache.org/jira/browse/KAFKA-13050 Project: Kafka

[GitHub] [kafka] kirktrue commented on pull request #10980: KAFKA-12989: MockClient should respect the request matcher passed to prepareUnsupportedVersionResponse

2021-07-08 Thread GitBox
kirktrue commented on pull request #10980: URL: https://github.com/apache/kafka/pull/10980#issuecomment-876583510 @cmccabe - could you take a look at this and/or assign a reviewer for this? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] kirktrue commented on pull request #10951: KAFKA-12841: NPE from the provided metadata in client callback in case of ApiException

2021-07-08 Thread GitBox
kirktrue commented on pull request #10951: URL: https://github.com/apache/kafka/pull/10951#issuecomment-876583460 @cmccabe - could you take a look at this and/or assign a reviewer for this? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] hachikuji commented on a change in pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails

2021-07-08 Thread GitBox
hachikuji commented on a change in pull request #10995: URL: https://github.com/apache/kafka/pull/10995#discussion_r666348755 ## File path: tests/docker/ducker-ak ## @@ -185,6 +185,12 @@ must_popd() { popd &> /dev/null || die "failed to popd" } +echo_and_do() { +

[GitHub] [kafka] junrao commented on a change in pull request #10753: KAFKA-12803: Support reassigning partitions when in KRaft mode

2021-07-08 Thread GitBox
junrao commented on a change in pull request #10753: URL: https://github.com/apache/kafka/pull/10753#discussion_r666339593 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1204,6 +1317,298 @@ void

[GitHub] [kafka] cmccabe commented on pull request #10990: MINOR: the broker should use metadata.log.max.record.bytes.between.snapshots

2021-07-08 Thread GitBox
cmccabe commented on pull request #10990: URL: https://github.com/apache/kafka/pull/10990#issuecomment-876562610 That one build failure looks like some kind of Jenkins weirdness. ``` [2021-07-08T00:12:38.900Z] > requirement failed: Source file '/tmp/sbt_8c62b7b4/META-INF/MANIFEST.MF'

[GitHub] [kafka] lbradstreet commented on pull request #10995: MINOR: fix ducker-ak Dockerfile issue

2021-07-08 Thread GitBox
lbradstreet commented on pull request #10995: URL: https://github.com/apache/kafka/pull/10995#issuecomment-876549710 I hit this same problem and was able to resolve it with `docker system prune -a` to make sure it grabbed a later openjdk image where this is not a problem. See the

[GitHub] [kafka] lbradstreet commented on pull request #10661: MINOR: upgrade pip from 20.2.2 to 21.1.1

2021-07-08 Thread GitBox
lbradstreet commented on pull request #10661: URL: https://github.com/apache/kafka/pull/10661#issuecomment-876535817 @chia7712 sorry for the false alarm and thanks for checking that it worked on your side. The problem was that I should have run `docker system prune -a` rather than `docker

[GitHub] [kafka] lbradstreet commented on pull request #10661: MINOR: upgrade pip from 20.2.2 to 21.1.1

2021-07-08 Thread GitBox
lbradstreet commented on pull request #10661: URL: https://github.com/apache/kafka/pull/10661#issuecomment-876533410 > > @lbradstreet Could you share the ID of `openjdk:8` to me? the image id of `openjdk:8` in my env is `d61c96e2d100` > > I ran docker system prune before reporting

[GitHub] [kafka] lbradstreet commented on pull request #10661: MINOR: upgrade pip from 20.2.2 to 21.1.1

2021-07-08 Thread GitBox
lbradstreet commented on pull request #10661: URL: https://github.com/apache/kafka/pull/10661#issuecomment-876532382 > @lbradstreet Could you share the ID of `openjdk:8` to me? the image id of `openjdk:8` in my env is `d61c96e2d100` I ran docker system prune before reporting this in

[GitHub] [kafka] chia7712 commented on pull request #10661: MINOR: upgrade pip from 20.2.2 to 21.1.1

2021-07-08 Thread GitBox
chia7712 commented on pull request #10661: URL: https://github.com/apache/kafka/pull/10661#issuecomment-876529435 @lbradstreet Could you share the ID of `openjdk:8` to me? the image id of `openjdk:8` in my env is `d61c96e2d100` -- This is an automated message from the Apache Git

[GitHub] [kafka] lbradstreet commented on pull request #10661: MINOR: upgrade pip from 20.2.2 to 21.1.1

2021-07-08 Thread GitBox
lbradstreet commented on pull request #10661: URL: https://github.com/apache/kafka/pull/10661#issuecomment-876523777 @chia7712 thanks for checking. Yes, my dockerfile was a bit modified. The unmodified run is: ``` Sending build context to Docker daemon 43.52kB Step 1/54 : ARG

[GitHub] [kafka] mumrah opened a new pull request #10997: MINOR: Fix flaky deleteSnapshots test

2021-07-08 Thread GitBox
mumrah opened a new pull request #10997: URL: https://github.com/apache/kafka/pull/10997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jolshan commented on pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-08 Thread GitBox
jolshan commented on pull request #10952: URL: https://github.com/apache/kafka/pull/10952#issuecomment-876521556 Yup. This merge conflict was caused by my other PR  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Resolved] (KAFKA-13041) Support debugging system tests with ducker-ak

2021-07-08 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-13041. --- Fix Version/s: 3.0.0 Resolution: Fixed > Support debugging system tests with ducker-ak >

[GitHub] [kafka] omkreddy merged pull request #10915: KAFKA-13041: Enable connecting VS Code remote debugger

2021-07-08 Thread GitBox
omkreddy merged pull request #10915: URL: https://github.com/apache/kafka/pull/10915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] chia7712 commented on pull request #10661: MINOR: upgrade pip from 20.2.2 to 21.1.1

2021-07-08 Thread GitBox
chia7712 commented on pull request #10661: URL: https://github.com/apache/kafka/pull/10661#issuecomment-876514001 ## build image on MacBook Air M1 https://user-images.githubusercontent.com/6234750/124944605-09b02680-e040-11eb-9a97-14daa986e397.png;> ## build image on iMac 27 intel

[GitHub] [kafka] chia7712 commented on pull request #10661: MINOR: upgrade pip from 20.2.2 to 21.1.1

2021-07-08 Thread GitBox
chia7712 commented on pull request #10661: URL: https://github.com/apache/kafka/pull/10661#issuecomment-876500588 > are you using a different jdk base docker image version on your m1? IIRC, I was using `openjdk:8`. Will retry it later :( -- This is an automated message from the

[GitHub] [kafka] dongjinleekr commented on pull request #9404: KAFKA-10589 replica verification tool changes for KIP-629

2021-07-08 Thread GitBox
dongjinleekr commented on pull request #9404: URL: https://github.com/apache/kafka/pull/9404#issuecomment-876498811 Hi @xvrl, How it is going? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] dongjinleekr commented on pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

2021-07-08 Thread GitBox
dongjinleekr commented on pull request #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-876498696 Hi @tombentley, Sorry for missing your comment on

[GitHub] [kafka] lbradstreet commented on pull request #10661: MINOR: upgrade pip from 20.2.2 to 21.1.1

2021-07-08 Thread GitBox
lbradstreet commented on pull request #10661: URL: https://github.com/apache/kafka/pull/10661#issuecomment-876496847 This is failing for me with: ``` Step 10/68 : RUN python3 -m pip install -U pip==21.1.1;

[GitHub] [kafka] lct45 commented on a change in pull request #10988: [KAFKA-9559] add docs for changing default serde to null

2021-07-08 Thread GitBox
lct45 commented on a change in pull request #10988: URL: https://github.com/apache/kafka/pull/10988#discussion_r666177495 ## File path: docs/streams/developer-guide/datatypes.html ## @@ -34,7 +34,7 @@ Data Types and Serialization Every Kafka Streams application

[GitHub] [kafka] showuon commented on pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-08 Thread GitBox
showuon commented on pull request #10952: URL: https://github.com/apache/kafka/pull/10952#issuecomment-876418475 Also, please remember to rebase with the latest `trunk` branch. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] showuon commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-08 Thread GitBox
showuon commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r666157068 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -367,7 +386,8 @@ else if (metadata.error() ==

[GitHub] [kafka] dongjinleekr removed a comment on pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-07-08 Thread GitBox
dongjinleekr removed a comment on pull request #10428: URL: https://github.com/apache/kafka/pull/10428#issuecomment-876395486 Retest this please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] dongjinleekr commented on pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-07-08 Thread GitBox
dongjinleekr commented on pull request #10428: URL: https://github.com/apache/kafka/pull/10428#issuecomment-876395486 Retest this please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dongjinleekr commented on pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-07-08 Thread GitBox
dongjinleekr commented on pull request #10428: URL: https://github.com/apache/kafka/pull/10428#issuecomment-876395308 Rebased onto the latest trunk. Also, I reflected the recent project structure change (i.e., `storage` → `storage/api`) by updating `suppressions.xml`. cc/ @cadonna

[GitHub] [kafka] showuon commented on pull request #10338: KAFKA-10251: wait for consumer rebalance completed before consuming records

2021-07-08 Thread GitBox
showuon commented on pull request #10338: URL: https://github.com/apache/kafka/pull/10338#issuecomment-876394407 @mumrah , it failed frequently these days. I think we should merge this fix soon. Please help have a 2nd review when available. Thank you. -- This is an automated message

[GitHub] [kafka] edoardocomar commented on pull request #10649: KAFKA-12762: Use connection timeout when polling the network for new …

2021-07-08 Thread GitBox
edoardocomar commented on pull request #10649: URL: https://github.com/apache/kafka/pull/10649#issuecomment-876392990 Thanks @rajinisivaram made minor changes and rebased -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Resolved] (KAFKA-13048) Update vulnerable dependencies in 2.8.0

2021-07-08 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjin Lee resolved KAFKA-13048. - Resolution: Duplicate > Update vulnerable dependencies in 2.8.0 >

[GitHub] [kafka] edoardocomar commented on a change in pull request #10649: KAFKA-12762: Use connection timeout when polling the network for new …

2021-07-08 Thread GitBox
edoardocomar commented on a change in pull request #10649: URL: https://github.com/apache/kafka/pull/10649#discussion_r666134747 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -105,11 +105,13 @@ public boolean

[GitHub] [kafka] edoardocomar commented on a change in pull request #10649: KAFKA-12762: Use connection timeout when polling the network for new …

2021-07-08 Thread GitBox
edoardocomar commented on a change in pull request #10649: URL: https://github.com/apache/kafka/pull/10649#discussion_r666133904 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -273,6 +276,7 @@ public void

[jira] [Created] (KAFKA-13049) Log recovery threads use default thread pool naming

2021-07-08 Thread Tom Bentley (Jira)
Tom Bentley created KAFKA-13049: --- Summary: Log recovery threads use default thread pool naming Key: KAFKA-13049 URL: https://issues.apache.org/jira/browse/KAFKA-13049 Project: Kafka Issue

[jira] [Created] (KAFKA-13048) Update vulnerable dependencies in 2.8.0

2021-07-08 Thread Pavel Kuznetsov (Jira)
Pavel Kuznetsov created KAFKA-13048: --- Summary: Update vulnerable dependencies in 2.8.0 Key: KAFKA-13048 URL: https://issues.apache.org/jira/browse/KAFKA-13048 Project: Kafka Issue Type:

[GitHub] [kafka] kamalcph edited a comment on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-07-08 Thread GitBox
kamalcph edited a comment on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-876277111 @vvcephei Resolved the conflicts. Ran the below tests: ``` ./gradlew :streams:testAll TC_PATHS="tests/kafkatest/tests/streams/streams_upgrade_test.py"

[jira] [Created] (KAFKA-13047) KafkaConsumer is unable to consume messages from a topic created by confluent-kafka-python client

2021-07-08 Thread Prashanto (Jira)
Prashanto created KAFKA-13047: - Summary: KafkaConsumer is unable to consume messages from a topic created by confluent-kafka-python client Key: KAFKA-13047 URL: https://issues.apache.org/jira/browse/KAFKA-13047

<    1   2   3   >