[GitHub] [kafka] dielhennr removed a comment on pull request #11141: KAFKA-13142: Validate dynamic config alterations prior to forwarding them to the KRaft controller.

2021-08-03 Thread GitBox
dielhennr removed a comment on pull request #11141: URL: https://github.com/apache/kafka/pull/11141#issuecomment-892359084 @hachikuji @rajinisivaram since this build is green I’m fairly confident that dynamic configs in a zk cluster haven’t changed behavior. I am wondering if it would be

[GitHub] [kafka] dielhennr edited a comment on pull request #11141: KAFKA-13142: Validate dynamic config alterations prior to forwarding them to the KRaft controller.

2021-08-03 Thread GitBox
dielhennr edited a comment on pull request #11141: URL: https://github.com/apache/kafka/pull/11141#issuecomment-892359084 @hachikuji @rajinisivaram since this build is green I’m fairly confident that dynamic configs in a zk cluster haven’t changed behavior. I am wondering if it would be

[GitHub] [kafka] dielhennr commented on pull request #11141: KAFKA-13142: Validate dynamic config alterations prior to forwarding them to the KRaft controller.

2021-08-03 Thread GitBox
dielhennr commented on pull request #11141: URL: https://github.com/apache/kafka/pull/11141#issuecomment-892359084 @hachikuji @rajinisivaram since this build is green I’m fairly confident that dynamic configs in a zk cluster haven’t changed behavior. I am wondering if it would be better

[GitHub] [kafka] ccding commented on a change in pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-08-03 Thread GitBox
ccding commented on a change in pull request #0: URL: https://github.com/apache/kafka/pull/0#discussion_r682281792 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1434,6 +1434,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:

[GitHub] [kafka] vvcephei commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-08-03 Thread GitBox
vvcephei commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-892354449 I went ahead and kicked off a full system test build to evaluate the other tests that got changed in this PR:

[GitHub] [kafka] vvcephei commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-08-03 Thread GitBox
vvcephei commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-892354208 Ok, I figured it out. The problem was that this change was adding the new version(s) to the _metadata_ upgrade test, but there isn't a metadata upgrade between 2.x and 3.0.

[GitHub] [kafka] vvcephei commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-08-03 Thread GitBox
vvcephei commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r682270517 ## File path: streams/upgrade-system-tests-28/src/test/java/org/apache/kafka/streams/tests/SmokeTestUtil.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to

[GitHub] [kafka] vvcephei commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-08-03 Thread GitBox
vvcephei commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r682270266 ## File path: streams/upgrade-system-tests-28/src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java ## @@ -0,0 +1,299 @@ +/* + * Licensed

[GitHub] [kafka] dengziming commented on pull request #11173: MINOR: Support max timestamp in GetOffsetShell

2021-08-03 Thread GitBox
dengziming commented on pull request #11173: URL: https://github.com/apache/kafka/pull/11173#issuecomment-892334259 cc @dajac @thomaskwscott .欄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] dengziming opened a new pull request #11173: MINOR: Support max timestamp in GetOffsetShell

2021-08-03 Thread GitBox
dengziming opened a new pull request #11173: URL: https://github.com/apache/kafka/pull/11173 *More detailed description of your change* Support max timestamp in GetOffsetShell which we added in KIP-734 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] ijuma commented on a change in pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-08-03 Thread GitBox
ijuma commented on a change in pull request #0: URL: https://github.com/apache/kafka/pull/0#discussion_r682253716 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1434,6 +1434,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-03 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r682238334 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -248,12 +249,29 @@ public

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-03 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r682237513 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -53,44 +56,162 @@ private static

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-03 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r682235008 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -935,6 +944,14 @@ void shutdown(final

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-03 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r682234726 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -53,44 +56,162 @@ private static

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-03 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r682233727 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -53,44 +56,162 @@ private static

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-03 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r682231789 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java ## @@ -105,31

[GitHub] [kafka] showuon commented on a change in pull request #11124: KAFKA-12839: Let SlidingWindows aggregation support window size of 0

2021-08-03 Thread GitBox
showuon commented on a change in pull request #11124: URL: https://github.com/apache/kafka/pull/11124#discussion_r682231711 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -100,17 +99,79 @@

[GitHub] [kafka] ccding commented on pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-08-03 Thread GitBox
ccding commented on pull request #0: URL: https://github.com/apache/kafka/pull/0#issuecomment-892299485 Included the motivation and updated the PR. PTAL @ijuma @junrao @kowshik @satishd -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-03 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r682230209 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java ## @@ -64,6 +65,9 @@ private final Map

[jira] [Resolved] (KAFKA-13145) Renaming the time interval window for better understanding

2021-08-03 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13145. --- Resolution: Won't Fix > Renaming the time interval window for better understanding >

[jira] [Commented] (KAFKA-13145) Renaming the time interval window for better understanding

2021-08-03 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392626#comment-17392626 ] Luke Chen commented on KAFKA-13145: --- I'm good. I'll close this ticket and add `SlidingWindow` class

[GitHub] [kafka] hachikuji commented on a change in pull request #11171: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0 (part 2)

2021-08-03 Thread GitBox
hachikuji commented on a change in pull request #11171: URL: https://github.com/apache/kafka/pull/11171#discussion_r682206623 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -313,14 +313,20 @@ class Partition(val topicPartition: TopicPartition, }

[GitHub] [kafka] ableegoldman commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-08-03 Thread GitBox
ableegoldman commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-892279085 1) Possibly -- you can check out the [Streams upgrade guide](https://kafka.apache.org/28/documentation/streams/upgrade-guide), which describes any public API changes in

[jira] [Updated] (KAFKA-13160) Fix the code that calls the broker’s config handler to pass the expected default resource name when using KRaft.

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Summary: Fix the code that calls the broker’s config handler to pass the expected default

[jira] [Updated] (KAFKA-13160) Fix the code the calls the broker’s config handler to pass the expected default resource name for dynamic broker configs

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Summary: Fix the code the calls the broker’s config handler to pass the expected default

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682020580 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -628,26 +634,43 @@ private[log] class Cleaner(val id: Int, * @param

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682018753 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -270,7 +270,8 @@ class Log(@volatile private var _dir: File, val

[jira] [Commented] (KAFKA-13145) Renaming the time interval window for better understanding

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392615#comment-17392615 ] A. Sophie Blee-Goldman commented on KAFKA-13145: Fine with me. FWIW the

[jira] [Commented] (KAFKA-13150) How is Kafkastream configured to consume data from a specified offset ?

2021-08-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392612#comment-17392612 ] Matthias J. Sax commented on KAFKA-13150: - To subscribe, follow instruction on the webpage:

[GitHub] [kafka] codefactor commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-08-03 Thread GitBox
codefactor commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-892269776 @ableegoldman , Thanks a lot - do you have any links where I can find out the following: 1. are there any breaking changes if I upgrade from version 2.6 to 3.0? 2.

[jira] [Updated] (KAFKA-13152) Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-08-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13152: Labels: needs-kip (was: ) > Replace "buffered.records.per.partition" with

[jira] [Commented] (KAFKA-13145) Renaming the time interval window for better understanding

2021-08-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392611#comment-17392611 ] Matthias J. Sax commented on KAFKA-13145: - Personally, I am not a fan on

[jira] [Commented] (KAFKA-12559) Add a top-level Streams config for bounding off-heap memory

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392610#comment-17392610 ] A. Sophie Blee-Goldman commented on KAFKA-12559: [~brz] I'd say give [~msundeq] another

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682020580 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -628,26 +634,43 @@ private[log] class Cleaner(val id: Int, * @param

[GitHub] [kafka] mjsax commented on a change in pull request #11124: KAFKA-12839: Let SlidingWindows aggregation support window size of 0

2021-08-03 Thread GitBox
mjsax commented on a change in pull request #11124: URL: https://github.com/apache/kafka/pull/11124#discussion_r682192656 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/TimeWindow.java ## @@ -19,33 +19,24 @@ import

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682018753 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -270,7 +270,8 @@ class Log(@volatile private var _dir: File, val

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode

[jira] [Created] (KAFKA-13162) ElectLeader API must be forwarded to Controller

2021-08-03 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13162: --- Summary: ElectLeader API must be forwarded to Controller Key: KAFKA-13162 URL: https://issues.apache.org/jira/browse/KAFKA-13162 Project: Kafka Issue

[GitHub] [kafka] mjsax commented on pull request #11157: MINOR: Replace EasyMock with Mockito in test-utils module

2021-08-03 Thread GitBox
mjsax commented on pull request #11157: URL: https://github.com/apache/kafka/pull/11157#issuecomment-892262404 Thanks for the PR @dengziming! Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] mjsax merged pull request #11157: MINOR: Replace EasyMock with Mockito in test-utils module

2021-08-03 Thread GitBox
mjsax merged pull request #11157: URL: https://github.com/apache/kafka/pull/11157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-13161) Follower leader and ISR state not updated after partition change in KRaft

2021-08-03 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13161: --- Summary: Follower leader and ISR state not updated after partition change in KRaft Key: KAFKA-13161 URL: https://issues.apache.org/jira/browse/KAFKA-13161

[GitHub] [kafka] mjsax commented on pull request #11172: MINOR: update stream-stream join docs

2021-08-03 Thread GitBox
mjsax commented on pull request #11172: URL: https://github.com/apache/kafka/pull/11172#issuecomment-892239651 \cc @kkonstantine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] mjsax opened a new pull request #11172: MINOR: update stream-stream join docs

2021-08-03 Thread GitBox
mjsax opened a new pull request #11172: URL: https://github.com/apache/kafka/pull/11172 Call for review @JimGalasyn @spena @ableegoldman (cf https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Streams+Join+Semantics) Must be cherry-picked to `3.0` branch. -- This is an

[GitHub] [kafka] guozhangwang commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-03 Thread GitBox
guozhangwang commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r682090255 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTaskCreator.java ## @@ -66,14 +72,26 @@ ); }

[GitHub] [kafka] ableegoldman commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-08-03 Thread GitBox
ableegoldman commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-892231916 @codefactor it will be released in 3.0, which is currently in the final stages of testing and preparing for release. -- This is an automated message from the Apache Git

[GitHub] [kafka] cmccabe commented on pull request #11168: KAFKA-13160: Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread GitBox
cmccabe commented on pull request #11168: URL: https://github.com/apache/kafka/pull/11168#issuecomment-892230644 I don't think this is the right place to make this change. BrokerMetadataPublisher should be calling `processConfigChanges` with the expected name, instead. -- This is an

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682164477 ## File path: clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java ## @@ -483,6 +486,49 @@ public void

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode

[GitHub] [kafka] jolshan opened a new pull request #11171: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0 (part 2)

2021-08-03 Thread GitBox
jolshan opened a new pull request #11171: URL: https://github.com/apache/kafka/pull/11171 Most of [KAFKA-13132](https://issues.apache.org/jira/browse/KAFKA-13132) has been resolved, but there is one part of one case not covered. From the ticket: `2. We only assign the topic ID when

[GitHub] [kafka] codefactor commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-08-03 Thread GitBox
codefactor commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-892207657 Any plans that this will be released? It looks like this upgrade happens to include the following issue fix in rocksdb:

[jira] [Assigned] (KAFKA-12395) Drop topic mapKey in DeleteTopics response

2021-08-03 Thread Hiro Kuwabara (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiro Kuwabara reassigned KAFKA-12395: - Assignee: Hiro Kuwabara > Drop topic mapKey in DeleteTopics response >

[GitHub] [kafka] mjsax commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-08-03 Thread GitBox
mjsax commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r682120783 ## File path: streams/upgrade-system-tests-28/src/test/java/org/apache/kafka/streams/tests/SmokeTestUtil.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the

[GitHub] [kafka] jolshan opened a new pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-03 Thread GitBox
jolshan opened a new pull request #11170: URL: https://github.com/apache/kafka/pull/11170 Before we used the metadata cache to determine whether or not to use topic IDs. Unfortunately, metadata cache updates with ZK controllers are in a separate request and may be too slow for the fetcher

[GitHub] [kafka] mjsax commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-08-03 Thread GitBox
mjsax commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r682119892 ## File path: streams/upgrade-system-tests-28/src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java ## @@ -0,0 +1,299 @@ +/* + * Licensed to

[GitHub] [kafka] mjsax commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-08-03 Thread GitBox
mjsax commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r682119041 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -25,15 +25,17 @@ from kafkatest.services.zookeeper import ZookeeperService from

[jira] [Reopened] (KAFKA-13132) Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-08-03 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reopened KAFKA-13132: Found an issue where we don't sufficiently cover case 2. I have a plan to properly cover.

[GitHub] [kafka] Borzoo opened a new pull request #11169: KAFKA-10859: Add test annotation to FileStreamSourceTaskTest.testInvalidFile and speed up the test

2021-08-03 Thread GitBox
Borzoo opened a new pull request #11169: URL: https://github.com/apache/kafka/pull/11169 *More detailed description of your change, Added the missing @Test annotation to a test in FileStreamSourceTaskTest. The test used to loop 100 times, each time blocking for 1 second. Checking the

[jira] [Updated] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12994: --- Labels: kip-633 newbie newbie++ (was: kip kip-633) > Migrate all Tests to

[jira] [Assigned] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12994: -- Assignee: A. Sophie Blee-Goldman > Migrate all Tests to New API and

[jira] [Assigned] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12994: -- Assignee: (was: Israel Ekpo) > Migrate all Tests to New API and

[jira] [Assigned] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12994: -- Assignee: (was: A. Sophie Blee-Goldman) > Migrate all Tests to

[jira] [Commented] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392530#comment-17392530 ] A. Sophie Blee-Goldman commented on KAFKA-12994: Hey [~iekpo], I'm unassigning this in

[jira] [Updated] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12994: --- Fix Version/s: (was: 3.0.0) 3.1.0 > Migrate all

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode

[GitHub] [kafka] mumrah edited a comment on pull request #11166: KAFKA-13159 Enable additional transaction system tests in KRaft

2021-08-03 Thread GitBox
mumrah edited a comment on pull request #11166: URL: https://github.com/apache/kafka/pull/11166#issuecomment-892069170 Streams smoke test: ~https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4630/~ https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4631/

[jira] [Resolved] (KAFKA-12646) Implement snapshot generation on brokers

2021-08-03 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio resolved KAFKA-12646. Resolution: Fixed > Implement snapshot generation on brokers >

[jira] [Resolved] (KAFKA-12647) Implement loading snapshot in the broker

2021-08-03 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio resolved KAFKA-12647. Resolution: Fixed > Implement loading snapshot in the broker >

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682020580 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -628,26 +634,43 @@ private[log] class Cleaner(val id: Int, * @param

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode

[GitHub] [kafka] dielhennr opened a new pull request #11168: KAFKA-13160: Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread GitBox
dielhennr opened a new pull request #11168: URL: https://github.com/apache/kafka/pull/11168 The KRaft brokers are throwing NumberFormatException when processing dynamic default broker config updates because they expect the default entity name that was used in zookeeper to be the resource

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682018753 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -270,7 +270,8 @@ class Log(@volatile private var _dir: File, val

[GitHub] [kafka] wycccccc opened a new pull request #11167: Kafka-13158 Replace EasyMock and PowerMock with Mockito for ConnectClusterStateImpl Test and ConnectorPluginsResourceTest

2021-08-03 Thread GitBox
wycc opened a new pull request #11167: URL: https://github.com/apache/kafka/pull/11167 Development of EasyMock and PowerMock has stagnated while Mockito continues to be actively developed. With the new Java cadence, it's a problem to depend on libraries that do bytecode generation and

[jira] [Created] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-13160: - Summary: Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft Key: KAFKA-13160 URL:

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682012434 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -628,26 +634,43 @@ private[log] class Cleaner(val id: Int, * @param

[jira] [Updated] (KAFKA-13159) Enable system tests for transactions in KRaft mode

2021-08-03 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-13159: - Fix Version/s: 3.1.0 > Enable system tests for transactions in KRaft mode >

[GitHub] [kafka] rondagostino commented on a change in pull request #11166: KAFKA-13159 Enable additional transaction system tests in KRaft

2021-08-03 Thread GitBox
rondagostino commented on a change in pull request #11166: URL: https://github.com/apache/kafka/pull/11166#discussion_r682008773 ## File path: tests/kafkatest/tests/core/replication_test.py ## @@ -122,14 +122,16 @@ def min_cluster_size(self):

[jira] [Commented] (KAFKA-13159) Enable system tests for transactions in KRaft mode

2021-08-03 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392468#comment-17392468 ] David Arthur commented on KAFKA-13159: -- The main transactions_test.py were enabled on 3.0 branch

[jira] [Created] (KAFKA-13159) Enable system tests for transactions in KRaft mode

2021-08-03 Thread David Arthur (Jira)
David Arthur created KAFKA-13159: Summary: Enable system tests for transactions in KRaft mode Key: KAFKA-13159 URL: https://issues.apache.org/jira/browse/KAFKA-13159 Project: Kafka Issue

[jira] [Resolved] (KAFKA-12997) Expose log record append time to the controller/broker

2021-08-03 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio resolved KAFKA-12997. Resolution: Fixed > Expose log record append time to the

[jira] [Created] (KAFKA-13158) Replace EasyMock and PowerMock with Mockito for ConnectClusterStateImpl Test and ConnectorPluginsResourceTest

2021-08-03 Thread YI-CHEN WANG (Jira)
YI-CHEN WANG created KAFKA-13158: Summary: Replace EasyMock and PowerMock with Mockito for ConnectClusterStateImpl Test and ConnectorPluginsResourceTest Key: KAFKA-13158 URL:

[GitHub] [kafka] mumrah commented on pull request #11166: MINOR Enable additional transaction system tests in KRaft

2021-08-03 Thread GitBox
mumrah commented on pull request #11166: URL: https://github.com/apache/kafka/pull/11166#issuecomment-892069170 Streams smoke test: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4630/ -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mumrah commented on pull request #11166: MINOR Enable additional transaction system tests in KRaft

2021-08-03 Thread GitBox
mumrah commented on pull request #11166: URL: https://github.com/apache/kafka/pull/11166#issuecomment-892068893 Group mode transactions: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4629/ -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Assigned] (KAFKA-12973) Update KIP and dev mailing list

2021-08-03 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-12973: -- Assignee: Jose Armando Garcia Sancio > Update KIP and dev

[GitHub] [kafka] mumrah commented on pull request #11166: MINOR Enable additional transaction system tests in KRaft

2021-08-03 Thread GitBox
mumrah commented on pull request #11166: URL: https://github.com/apache/kafka/pull/11166#issuecomment-892068421 Produce bench: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4628/ -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mumrah commented on pull request #11166: MINOR Enable additional transaction system tests in KRaft

2021-08-03 Thread GitBox
mumrah commented on pull request #11166: URL: https://github.com/apache/kafka/pull/11166#issuecomment-892067696 Replication test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4627/ -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mumrah opened a new pull request #11166: MINOR Enable additional transaction system tests in KRaft

2021-08-03 Thread GitBox
mumrah opened a new pull request #11166: URL: https://github.com/apache/kafka/pull/11166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mumrah commented on pull request #11165: MINOR Enable transaction system tests for KRaft in 3.0

2021-08-03 Thread GitBox
mumrah commented on pull request #11165: URL: https://github.com/apache/kafka/pull/11165#issuecomment-892065979 Opening a follow-on PR for the additional tests mentioned by @rondagostino -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mumrah merged pull request #11165: MINOR Enable transaction system tests for KRaft in 3.0

2021-08-03 Thread GitBox
mumrah merged pull request #11165: URL: https://github.com/apache/kafka/pull/11165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-13157) Kafka-dump-log needs to support snapshot records

2021-08-03 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-13157: -- Summary: Kafka-dump-log needs to support snapshot records Key: KAFKA-13157 URL: https://issues.apache.org/jira/browse/KAFKA-13157 Project:

[GitHub] [kafka] hachikuji commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
hachikuji commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r681961452 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java ## @@ -80,6 +80,7 @@ public void write(int b) {

[GitHub] [kafka] dielhennr commented on a change in pull request #11159: MINOR: Change default node id in kraft broker properties

2021-08-03 Thread GitBox
dielhennr commented on a change in pull request #11159: URL: https://github.com/apache/kafka/pull/11159#discussion_r681972655 ## File path: metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java ## @@ -239,11 +239,11 @@ public void

  1   2   >