jasonyanwenl opened a new pull request #11241:
URL: https://github.com/apache/kafka/pull/11241
Currently in both `KStreamMap` and `KStreamFlatMap` classes, they will throw
NPE if the call to `KeyValueMapper#apply` return Null. We should check whether
the result of that call is Null and
yangdaixai opened a new pull request #11240:
URL: https://github.com/apache/kafka/pull/11240
test
Signed-off-by: yangdaixai
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
vvcephei commented on pull request #11236:
URL: https://github.com/apache/kafka/pull/11236#issuecomment-902407705
Thanks, @ableegoldman !
I agree it might be overkill, and I wouldn't fault the conservative approach.
The reason I went for a blanket approach is that it seems
[
https://issues.apache.org/jira/browse/KAFKA-13212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13212:
--
Summary: fetch/findSessions queries with open endpoints for SessionStore
(was: findSessions queries
[
https://issues.apache.org/jira/browse/KAFKA-13212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-13212:
-
Assignee: Luke Chen
> findSessions queries with open endpoints for SessionStore
>
[
https://issues.apache.org/jira/browse/KAFKA-13211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-13211:
-
Assignee: Luke Chen
> fetch queries with open endpoints for WindowStore
>
vvcephei commented on pull request #11236:
URL: https://github.com/apache/kafka/pull/11236#issuecomment-902390477
System test results:
[
https://issues.apache.org/jira/browse/KAFKA-13218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401943#comment-17401943
]
Haruki Okada commented on KAFKA-13218:
--
One possible cause I can imagine is because logs are rolled
[
https://issues.apache.org/jira/browse/KAFKA-13216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401940#comment-17401940
]
Matthias J. Sax edited comment on KAFKA-13216 at 8/20/21, 1:04 AM:
---
We
[
https://issues.apache.org/jira/browse/KAFKA-13216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401940#comment-17401940
]
Matthias J. Sax commented on KAFKA-13216:
-
We disabled the feature in 3.0.0, and will fix
[
https://issues.apache.org/jira/browse/KAFKA-13216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13216:
Fix Version/s: (was: 3.0.0)
3.1.0
> Streams left/outer joins cause
[
https://issues.apache.org/jira/browse/KAFKA-13216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13216:
Priority: Critical (was: Blocker)
> Streams left/outer joins cause new internal
[
https://issues.apache.org/jira/browse/KAFKA-13216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13216:
Affects Version/s: (was: 3.0.0)
> Streams left/outer joins cause new internal
rondagostino commented on a change in pull request #11239:
URL: https://github.com/apache/kafka/pull/11239#discussion_r692561636
##
File path: core/src/main/scala/kafka/server/KafkaBroker.scala
##
@@ -85,7 +85,8 @@ trait KafkaBroker extends KafkaMetricsGroup {
rondagostino commented on a change in pull request #11239:
URL: https://github.com/apache/kafka/pull/11239#discussion_r692561312
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -84,6 +84,8 @@ class BrokerServer(
val supportedFeatures:
ableegoldman commented on a change in pull request #11215:
URL: https://github.com/apache/kafka/pull/11215#discussion_r692546162
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/TimeWindowsTest.java
##
@@ -95,27 +91,19 @@ public void
ableegoldman commented on pull request #11215:
URL: https://github.com/apache/kafka/pull/11215#issuecomment-902302847
Yep don't worry about it, that test is known to be flaky and unrelated. And
yeah, the ability to set reviewers is restricted to committers. You can just
ping people in a
ijuma commented on a change in pull request #11239:
URL: https://github.com/apache/kafka/pull/11239#discussion_r692520138
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -84,6 +84,8 @@ class BrokerServer(
val supportedFeatures: util.Map[String,
ijuma commented on a change in pull request #11239:
URL: https://github.com/apache/kafka/pull/11239#discussion_r692520138
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -84,6 +84,8 @@ class BrokerServer(
val supportedFeatures: util.Map[String,
ijuma commented on a change in pull request #11239:
URL: https://github.com/apache/kafka/pull/11239#discussion_r692518398
##
File path: core/src/main/scala/kafka/server/KafkaBroker.scala
##
@@ -85,7 +85,8 @@ trait KafkaBroker extends KafkaMetricsGroup {
izzyacademy commented on a change in pull request #11235:
URL: https://github.com/apache/kafka/pull/11235#discussion_r692514791
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/RawKeyAccessor.java
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the
rondagostino opened a new pull request #11239:
URL: https://github.com/apache/kafka/pull/11239
The BrokerState metric always has a value of 0, for NOT_RUNNING, in KRaft
clusters. This patch fixes it and adds a test.
### Committer Checklist (excluded from commit message)
- [ ]
hachikuji merged pull request #11237:
URL: https://github.com/apache/kafka/pull/11237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Israel Ekpo updated KAFKA-8613:
---
Description:
Currently, the grace period is set to retention time if the grace period is not
Ron Dagostino created KAFKA-13219:
-
Summary: BrokerState metric not working for KRaft clusters
Key: KAFKA-13219
URL: https://issues.apache.org/jira/browse/KAFKA-13219
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Israel Ekpo updated KAFKA-8613:
---
Summary: Make Grace Period Mandatory for Windowed Operations in Streams
(was: Make Grace Period
[
https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Israel Ekpo updated KAFKA-8613:
---
Summary: Make Grace Period Mandatory in Windowed Operations (was: Make
grace period mandatory)
>
rondagostino opened a new pull request #11238:
URL: https://github.com/apache/kafka/pull/11238
I noticed that a system test using a KRaft cluster with 3 brokers but only 1
co-located controller did not force-kill the second and third broker after
shutting down the first broker (the one
jsancio opened a new pull request #11237:
URL: https://github.com/apache/kafka/pull/11237
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
[
https://issues.apache.org/jira/browse/KAFKA-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401818#comment-17401818
]
Yiming Zang edited comment on KAFKA-9320 at 8/19/21, 6:45 PM:
--
We have seen
[
https://issues.apache.org/jira/browse/KAFKA-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401818#comment-17401818
]
Yiming Zang commented on KAFKA-9320:
We have seen some regression after enabling and upgraded to
[
https://issues.apache.org/jira/browse/KAFKA-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12984:
---
Fix Version/s: 2.8.1
> Cooperative sticky assignor can get stuck with
jolshan commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r692343425
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig,
jolshan commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r692338540
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig,
vvcephei commented on a change in pull request #11236:
URL: https://github.com/apache/kafka/pull/11236#discussion_r692335138
##
File path: tests/kafkatest/services/streams.py
##
@@ -686,12 +691,13 @@ def prop_file(self):
streams_property.KAFKA_SERVERS:
vvcephei commented on a change in pull request #11236:
URL: https://github.com/apache/kafka/pull/11236#discussion_r692334950
##
File path: tests/kafkatest/services/streams.py
##
@@ -659,14 +663,15 @@ def __init__(self, test_context, kafka):
def prop_file(self):
vvcephei commented on a change in pull request #11236:
URL: https://github.com/apache/kafka/pull/11236#discussion_r692334355
##
File path: tests/kafkatest/services/streams.py
##
@@ -569,16 +572,17 @@ def __init__(self, test_context, kafka):
def prop_file(self):
vvcephei commented on pull request #11236:
URL: https://github.com/apache/kafka/pull/11236#issuecomment-902094127
system test run:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4657/
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401763#comment-17401763
]
Sagar Rao commented on KAFKA-13152:
---
Thanks [~mjsax]/[~guozhang]. I will start writing a KIP and send
officialpatterson commented on pull request #11215:
URL: https://github.com/apache/kafka/pull/11215#issuecomment-902088249
Doesn't look like I have permissions to assign reviewers to this PR
@ableegoldman.
Also, fairly new to this, but it looks like these test failures are down to
vvcephei opened a new pull request #11236:
URL: https://github.com/apache/kafka/pull/11236
We increased the default session timeout to 30s in KIP-735:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-735%3A+Increase+default+consumer+session+timeout
Since then, we are
mjsax commented on a change in pull request #11235:
URL: https://github.com/apache/kafka/pull/11235#discussion_r692305627
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/TimeOrderedKeySchema.java
##
@@ -72,27 +74,47 @@ public long
mjsax commented on a change in pull request #11235:
URL: https://github.com/apache/kafka/pull/11235#discussion_r692305287
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/TimeOrderedKeySchema.java
##
@@ -43,12 +45,12 @@
@Override
public
[
https://issues.apache.org/jira/browse/KAFKA-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401736#comment-17401736
]
BurningIce commented on KAFKA-4669:
---
I'm using kafka-clients 2.5.0, also encountering this issue at
spena commented on a change in pull request #11235:
URL: https://github.com/apache/kafka/pull/11235#discussion_r692180473
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java
##
@@ -214,6 +223,128 @@ public void
dajac commented on pull request #11229:
URL: https://github.com/apache/kafka/pull/11229#issuecomment-902020042
> Thanks for the PR. It makes sense to me. Would it be possible to add a
test for the case when a late `DelayedJoin` completes?
Yeah, let me see if I can add something.
dajac commented on a change in pull request #11229:
URL: https://github.com/apache/kafka/pull/11229#discussion_r692245978
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -1391,78 +1392,92 @@ class GroupCoordinator(val brokerId: Int,
akatona84 commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-902006686
> Thanks for the PR, it looks good. Is it possible to add a test for it?
@mimaison , Thanks for the review, unfortunately that code part where the
restclient is used,
andricDu commented on pull request #8103:
URL: https://github.com/apache/kafka/pull/8103#issuecomment-902003678
Bump.
Status update on this feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dajac commented on pull request #11230:
URL: https://github.com/apache/kafka/pull/11230#issuecomment-901980004
Let me check those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lbradstreet commented on pull request #11230:
URL: https://github.com/apache/kafka/pull/11230#issuecomment-901975481
@dajac the updated changes look good to me overall. It seems like we're
hitting some gradle executor errors across multiple runs, so it may not be a
coincidence.
--
This
vvcephei commented on pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#issuecomment-901975557
Thanks @hachikuji !
FYI: I ran three full batches of system tests on your PR branch, and did not
see a failure in that test or any other consistent test failure:
dajac commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r692175152
##
File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala
##
@@ -82,7 +82,7 @@ class AbstractFetcherThreadTest {
// add
dajac commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r692175152
##
File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala
##
@@ -82,7 +82,7 @@ class AbstractFetcherThreadTest {
// add
dajac commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r692169643
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig,
dajac commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r692168365
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig,
dajac commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r692166774
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig,
dajac commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r692165645
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig,
dajac commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r692164654
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1544,7 +1554,7 @@ class ReplicaManager(val config: KafkaConfig,
//
dajac commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r692164057
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1420,6 +1423,10 @@ class ReplicaManager(val config: KafkaConfig,
}
dajac commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r692162163
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig,
dajac commented on a change in pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#discussion_r692154377
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -476,7 +476,6 @@ boolean
dajac commented on pull request #11230:
URL: https://github.com/apache/kafka/pull/11230#issuecomment-901717039
@lbradstreet I have updated the PR based on your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dengziming commented on a change in pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#discussion_r691845925
##
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##
@@ -224,9 +227,14 @@ object GetOffsetShell {
/**
* Return the partition
[
https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401493#comment-17401493
]
Christo Lolov commented on KAFKA-12994:
---
Great, thanks for the reply! [~officialandyp], I will
65 matches
Mail list logo
