dongjinleekr commented on a change in pull request #11431:
URL: https://github.com/apache/kafka/pull/11431#discussion_r738940752
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
##
@@ -183,12 +187,18 @@ public
dongjinleekr commented on a change in pull request #11431:
URL: https://github.com/apache/kafka/pull/11431#discussion_r738939808
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
##
@@ -183,12 +187,18 @@ public
dongjinleekr commented on pull request #11430:
URL: https://github.com/apache/kafka/pull/11430#issuecomment-954434181
Here is the update. I improved the parsing rule documentation as @showuon
pointed out and also subdivided the test cases like @bvn13 suggested.
--
This is an automated
dongjinleekr commented on a change in pull request #11430:
URL: https://github.com/apache/kafka/pull/11430#discussion_r738930580
##
File path:
clients/src/test/java/org/apache/kafka/common/security/JaasContextTest.java
##
@@ -172,14 +172,42 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-13294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjin Lee reassigned KAFKA-13294:
---
Assignee: Dongjin Lee (was: Utkarsh Khare)
> Upgrade Netty to 4.1.68 for CVE fixes
>
[
https://issues.apache.org/jira/browse/KAFKA-13294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjin Lee resolved KAFKA-13294.
-
Resolution: Fixed
[~mimaison] Here it is.
> Upgrade Netty to 4.1.68 for CVE fixes
>
socutes commented on pull request #11207:
URL: https://github.com/apache/kafka/pull/11207#issuecomment-954360311
> @socutes thanks for the PR. This looks good but I think we should add unit
tests in `QuorumControllerTest` for `SnapshotLagSize` and
`SnapshotSizeBytesSize`. The histogram
showuon commented on a change in pull request #11403:
URL: https://github.com/apache/kafka/pull/11403#discussion_r738891900
##
File path: clients/src/main/java/org/apache/kafka/common/TopicIdPartition.java
##
@@ -47,7 +58,7 @@ public Uuid topicId() {
}
/**
- *
bdesert commented on pull request #11401:
URL: https://github.com/apache/kafka/pull/11401#issuecomment-954337582
@mimaison Added a test case for exclude filter. Note, even though I could
add only some param with random name to exclude, I decided to keep all the
values from default filter
ableegoldman commented on a change in pull request #11433:
URL: https://github.com/apache/kafka/pull/11433#discussion_r738872895
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -292,12 +327,20 @@ public void
ableegoldman commented on a change in pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#discussion_r738863140
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1221,13 +1236,27 @@ private long getCacheSizePerThread(final
ableegoldman commented on pull request #11439:
URL: https://github.com/apache/kafka/pull/11439#issuecomment-954321511
Well, "soon" -- I just saw the notice about feature freeze coming up, so
it's not a rush exactly, but just wanted to give a heads up in case if you're
like me and didn't
showuon commented on pull request #11439:
URL: https://github.com/apache/kafka/pull/11439#issuecomment-954320699
Oh, I didn't notice the v3.1.0 is going to code freeze soon. I thought I can
still wait for the Andrei's test. Thanks for reminding, @ableegoldman . I'll
clean it up today.
shylaja kokoori created KAFKA-13418:
---
Summary: Brokers disconnect intermittently with TLS1.3
Key: KAFKA-13418
URL: https://issues.apache.org/jira/browse/KAFKA-13418
Project: Kafka
Issue
hachikuji commented on pull request #11449:
URL: https://github.com/apache/kafka/pull/11449#issuecomment-954276201
The main thing I am interested in here is disconnects when there are
inflight requests, so we can probably be more selective about the logging if
there are any concerns.
--
[
https://issues.apache.org/jira/browse/KAFKA-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435681#comment-17435681
]
Randall Hauch commented on KAFKA-9887:
--
Backported to the `3.0` branch, so it will be included in
[
https://issues.apache.org/jira/browse/KAFKA-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-9887:
-
Fix Version/s: 3.0.1
> failed-task-count JMX metric not updated if task fails during startup
>
[
https://issues.apache.org/jira/browse/KAFKA-13118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch resolved KAFKA-13118.
---
Resolution: Fixed
Backported to the `3.0` branch. Will be in the 3.0.1 release.
> Backport
ijuma commented on a change in pull request #11403:
URL: https://github.com/apache/kafka/pull/11403#discussion_r738812162
##
File path: clients/src/main/java/org/apache/kafka/common/TopicIdPartition.java
##
@@ -47,7 +58,7 @@ public Uuid topicId() {
}
/**
- *
[
https://issues.apache.org/jira/browse/KAFKA-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435676#comment-17435676
]
Matthias J. Sax commented on KAFKA-13400:
-
[~pbiradar] Could you share the code of
hachikuji opened a new pull request #11449:
URL: https://github.com/apache/kafka/pull/11449
Client disconnects are crucial events for debugging. The fact that we only
log them at DEBUG/TRACE means we rarely have them available outside of a
testing context. This patch therefore increases
hachikuji commented on pull request #11448:
URL: https://github.com/apache/kafka/pull/11448#issuecomment-954220239
Note I am planning to add some additional test cases here. We should cover
all of the `DynamicThreadPool` configurations and unclean leader election at a
minimum.
--
This
hachikuji opened a new pull request #11448:
URL: https://github.com/apache/kafka/pull/11448
This patch fixes a bug in `DynamicBrokerConfig` which causes some
configuration changes to be ignored. In particular, the bug is the result of
the reference to the old configuration getting
ableegoldman commented on pull request #11439:
URL: https://github.com/apache/kafka/pull/11439#issuecomment-954215056
@showuon something like this would be a good fix for 3.1, especially since
it's quick and code freeze is coming up. I also feel it is low-risk, for one
thing this
Jason Gustafson created KAFKA-13417:
---
Summary: Dynamic thread pool re-configurations may not get
processed
Key: KAFKA-13417
URL: https://issues.apache.org/jira/browse/KAFKA-13417
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435633#comment-17435633
]
prabhu commented on KAFKA-13400:
DefaultStateStoreManager - This Class contains methods that manage
[
https://issues.apache.org/jira/browse/KAFKA-13202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-13202.
-
Fix Version/s: 3.1.0
Resolution: Fixed
merged the PR to trunk.
> KIP-768: Extend
junrao merged pull request #11284:
URL: https://github.com/apache/kafka/pull/11284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-8941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435612#comment-17435612
]
Luiz Fonseca commented on KAFKA-8941:
-
Hello [~cadonna].
The pull request is ready to be reviewed.
Luizfrf3 commented on pull request #11441:
URL: https://github.com/apache/kafka/pull/11441#issuecomment-954094430
Hello @cadonna.
The pull request is ready to be reviewed.
Best regards,
--
This is an automated message from the Apache Git Service.
To respond to the message,
Ge opened a new pull request #11447:
URL: https://github.com/apache/kafka/pull/11447
Right now, the `repartition` operator always filters out `null` keys. This
behavior is not correct and is a regression compared to the deprecated
`through` operator.
This patch fixes the issue
rhauch commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r738528766
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache
OmniaGM commented on a change in pull request #11431:
URL: https://github.com/apache/kafka/pull/11431#discussion_r737584380
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
##
@@ -183,12 +187,18 @@ public MirrorClientConfig
Omnia Ibrahim created KAFKA-13416:
-
Summary: Add topic ids to any metrics that has topic and partition
tags
Key: KAFKA-13416
URL: https://issues.apache.org/jira/browse/KAFKA-13416
Project: Kafka
Omnia Ibrahim created KAFKA-13415:
-
Summary: Track topic deletion state without ZK
Key: KAFKA-13415
URL: https://issues.apache.org/jira/browse/KAFKA-13415
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435406#comment-17435406
]
Gary Russell commented on KAFKA-13400:
--
[~mjsax] It's hard to say without seeing code, but stack
[
https://issues.apache.org/jira/browse/KAFKA-13414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-13414:
---
Summary: Replace Powermock/EasyMock by Mockito in connect.storage package
(was: Remove
Mickael Maison created KAFKA-13414:
--
Summary: Remove Powermock from connect.storage package
Key: KAFKA-13414
URL: https://issues.apache.org/jira/browse/KAFKA-13414
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-13294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435395#comment-17435395
]
Mickael Maison commented on KAFKA-13294:
I see https://github.com/apache/kafka/pull/11324 has
[
https://issues.apache.org/jira/browse/KAFKA-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435384#comment-17435384
]
shizhenzhen edited comment on KAFKA-13226 at 10/28/21, 1:03 PM:
When I
[
https://issues.apache.org/jira/browse/KAFKA-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435384#comment-17435384
]
shizhenzhen edited comment on KAFKA-13226 at 10/28/21, 1:02 PM:
When I
[
https://issues.apache.org/jira/browse/KAFKA-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435384#comment-17435384
]
shizhenzhen commented on KAFKA-13226:
-
When I tried to repair it, I found that even if I repaired
[
https://issues.apache.org/jira/browse/KAFKA-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435385#comment-17435385
]
shizhenzhen commented on KAFKA-13226:
-
我在尝试修复它的时候,
[
https://issues.apache.org/jira/browse/KAFKA-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435380#comment-17435380
]
shizhenzhen commented on KAFKA-13226:
-
I hava push a PR, please review it
[
https://issues.apache.org/jira/browse/KAFKA-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shizhenzhen updated KAFKA-13226:
Affects Version/s: 2.8.1
3.0.0
> Partition expansion may cause uneven
dengziming commented on pull request #11446:
URL: https://github.com/apache/kafka/pull/11446#issuecomment-953811763
Hello @cmccabe , maybe you added this file by accident when reviewing #10956
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shizhenzhen updated KAFKA-13226:
Reviewer: Guozhang Wang (was: Zhanxiang (Patrick) Huang)
> Partition expansion may cause uneven
dengziming opened a new pull request #11446:
URL: https://github.com/apache/kafka/pull/11446
*More detailed description of your change*
This file must be added by accident.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
shirenchuang opened a new pull request #11445:
URL: https://github.com/apache/kafka/pull/11445
fix KAFKA-13226
*More detailed description of your change,
if not sort the brokerMetaData
Partition expansion may cause uneven distribution
*Summary of testing strategy
OmniaGM commented on a change in pull request #11431:
URL: https://github.com/apache/kafka/pull/11431#discussion_r737592730
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
##
@@ -183,12 +187,18 @@ public MirrorClientConfig
OmniaGM commented on a change in pull request #11431:
URL: https://github.com/apache/kafka/pull/11431#discussion_r737592730
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
##
@@ -183,12 +187,18 @@ public MirrorClientConfig
[
https://issues.apache.org/jira/browse/KAFKA-12505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435335#comment-17435335
]
Igor Soarez commented on KAFKA-12505:
-
Is this question/issue still valid? StorageTool [does not
[
https://issues.apache.org/jira/browse/KAFKA-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435296#comment-17435296
]
Evan Williams commented on KAFKA-9119:
--
What is the plan/goal for KRaft to come out of early access
shankarb27 commented on pull request #11443:
URL: https://github.com/apache/kafka/pull/11443#issuecomment-953675965
The Sasl.createSaslClient for locating and selecting a SaslClient
implementationobtains an ordered list of SaslClientFactory instances from the
registered security providers
[
https://issues.apache.org/jira/browse/KAFKA-13413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dominique Mongelli resolved KAFKA-13413.
Resolution: Abandoned
Bad clone from KAFKA-13294
> Upgrade Netty to 4.1.68 for
Dominique Mongelli created KAFKA-13413:
--
Summary: Upgrade Netty to 4.1.68 for CVE fixes
Key: KAFKA-13413
URL: https://issues.apache.org/jira/browse/KAFKA-13413
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-13406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435249#comment-17435249
]
Luke Chen commented on KAFKA-13406:
---
Awesome! Thank you!
> Cooperative sticky assignor got stuck due
mimaison commented on pull request #11401:
URL: https://github.com/apache/kafka/pull/11401#issuecomment-953622891
Thanks for the PR. Can you add a test for this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-13406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435243#comment-17435243
]
Andrei Yu commented on KAFKA-13406:
---
[~showuon] Thank you, I'll try to re-test it in a couple of days
[
https://issues.apache.org/jira/browse/KAFKA-13406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435239#comment-17435239
]
Luke Chen commented on KAFKA-13406:
---
[~Andy_Dufresne], I understand, but I'm afraid we have to fix it
showuon opened a new pull request #11444:
URL: https://github.com/apache/kafka/pull/11444
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
[
https://issues.apache.org/jira/browse/KAFKA-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435214#comment-17435214
]
Matthias J. Sax commented on KAFKA-13400:
-
[~grussell] – thanks for chiming in! – I agree that
dajac merged pull request #11427:
URL: https://github.com/apache/kafka/pull/11427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
63 matches
Mail list logo
