[GitHub] [kafka] showuon commented on a change in pull request #11504: KAFKA-13457: socketChannel in Acceptor#accept is not closed upon IOException

2021-11-15 Thread GitBox
showuon commented on a change in pull request #11504: URL: https://github.com/apache/kafka/pull/11504#discussion_r749936830 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -734,6 +734,10 @@ private[kafka] class Acceptor(val endPoint: EndPoint,

[GitHub] [kafka] showuon commented on a change in pull request #11504: KAFKA-13457: socketChannel in Acceptor#accept is not closed upon IOException

2021-11-15 Thread GitBox
showuon commented on a change in pull request #11504: URL: https://github.com/apache/kafka/pull/11504#discussion_r749936830 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -734,6 +734,10 @@ private[kafka] class Acceptor(val endPoint: EndPoint,

[GitHub] [kafka] ableegoldman commented on a change in pull request #11490: KAFKA-13439: Deprecate eager rebalance protocol in kafka stream

2021-11-15 Thread GitBox
ableegoldman commented on a change in pull request #11490: URL: https://github.com/apache/kafka/pull/11490#discussion_r749923117 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java ## @@ -105,13 +105,15 @@

[GitHub] [kafka] RivenSun2 commented on pull request #11505: KAFKA-13449: Comment optimization for parameter log.cleaner.delete.retention.ms

2021-11-15 Thread GitBox
RivenSun2 commented on pull request #11505: URL: https://github.com/apache/kafka/pull/11505#issuecomment-969861680 @showuon Sure, luke. please help to review changes when available. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (KAFKA-13406) Cooperative sticky assignor got stuck due to assignment validation failed

2021-11-15 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13406: --- Fix Version/s: 2.8.2 > Cooperative sticky assignor got stuck due to

[GitHub] [kafka] ableegoldman commented on pull request #11439: KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor

2021-11-15 Thread GitBox
ableegoldman commented on pull request #11439: URL: https://github.com/apache/kafka/pull/11439#issuecomment-969761211 Merged to trunk and ported back to 3.0 and 2.8, just waiting for David's approval before cherrypicking to the 3.1 branch -- This is an automated message from the Apache

[jira] [Commented] (KAFKA-13406) Cooperative sticky assignor got stuck due to assignment validation failed

2021-11-15 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444245#comment-17444245 ] Luke Chen commented on KAFKA-13406: --- [~ableegoldman] , thank you very much! :) > Cooperative sticky

[jira] [Updated] (KAFKA-13406) Cooperative sticky assignor got stuck due to assignment validation failed

2021-11-15 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13406: --- Fix Version/s: 3.1.0 (was: 3.2.0) > Cooperative

[jira] [Commented] (KAFKA-13406) Cooperative sticky assignor got stuck due to assignment validation failed

2021-11-15 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444241#comment-17444241 ] A. Sophie Blee-Goldman commented on KAFKA-13406: Yes, we should definitely get this fix

[GitHub] [kafka] ableegoldman merged pull request #11439: KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor

2021-11-15 Thread GitBox
ableegoldman merged pull request #11439: URL: https://github.com/apache/kafka/pull/11439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #11439: KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor

2021-11-15 Thread GitBox
ableegoldman commented on pull request #11439: URL: https://github.com/apache/kafka/pull/11439#issuecomment-969744052 Failure is unrelated, merging to trunk. Will also need to cherrypick back to 3.1 cc @dajac -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (KAFKA-13406) Cooperative sticky assignor got stuck due to assignment validation failed

2021-11-15 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444229#comment-17444229 ] Luke Chen commented on KAFKA-13406: --- [~ableegoldman] , I think this issue should fix into v3.1.0.

[jira] [Commented] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-11-15 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444226#comment-17444226 ] A. Sophie Blee-Goldman commented on KAFKA-13128: [~wcarlson5]  unassigning you in case

[jira] [Updated] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-11-15 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13128: --- Fix Version/s: 3.2.0 (was: 3.1.0) > Flaky Test >

[jira] [Updated] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-11-15 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13128: --- Priority: Critical (was: Blocker) > Flaky Test >

[jira] [Assigned] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-11-15 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-13128: -- Assignee: (was: Walker Carlson) > Flaky Test >

[jira] [Commented] (KAFKA-13449) Comment optimization for parameter log.cleaner.delete.retention.ms

2021-11-15 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444223#comment-17444223 ] RivenSun commented on KAFKA-13449: -- Hi [~showuon]  please help review this PR linked in 'Issue Links'

[GitHub] [kafka] RivenSun2 opened a new pull request #11505: KAFKA-13449: Comment optimization for parameter log.cleaner.delete.retention.ms

2021-11-15 Thread GitBox
RivenSun2 opened a new pull request #11505: URL: https://github.com/apache/kafka/pull/11505 Story JIRA: https://issues.apache.org/jira/browse/KAFKA-13449 Author: RivenSun2 riven@zoom.us Reviewers: Luke Chen show...@gmail.com -- This is an automated message from

[GitHub] [kafka] jsancio commented on a change in pull request #11503: KAFKA-13456: controller.listener.names required in KRaft

2021-11-15 Thread GitBox
jsancio commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r749838162 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -2007,8 +2007,13 @@ class KafkaConfig private(doLog: Boolean, val props:

[GitHub] [kafka] functioner opened a new pull request #11504: KAFKA-13457: socketChannel in Acceptor#accept is not closed upon IOException

2021-11-15 Thread GitBox
functioner opened a new pull request #11504: URL: https://github.com/apache/kafka/pull/11504 A patch for [KAFKA-13457](https://issues.apache.org/jira/browse/KAFKA-13457) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] hachikuji commented on a change in pull request #11503: KAFKA-13456: controller.listener.names required in KRaft

2021-11-15 Thread GitBox
hachikuji commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r749827016 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -2007,8 +2007,13 @@ class KafkaConfig private(doLog: Boolean, val props:

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

2021-11-15 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444212#comment-17444212 ] RivenSun commented on KAFKA-13422: --  hi [~rajinisiva...@gmail.com] , [~ijuma] , [~hachikuji] and

[jira] [Created] (KAFKA-13457) socketChannel in Acceptor#accept is not closed upon IOException

2021-11-15 Thread Haoze Wu (Jira)
Haoze Wu created KAFKA-13457: Summary: socketChannel in Acceptor#accept is not closed upon IOException Key: KAFKA-13457 URL: https://issues.apache.org/jira/browse/KAFKA-13457 Project: Kafka

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

2021-11-15 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444209#comment-17444209 ] RivenSun commented on KAFKA-13422: -- [~showuon] , I'm very sorry to bother you, but the author of this

[jira] [Commented] (KAFKA-13437) Broker parameter optimization: security.inter.broker.protocol and num.network.threads

2021-11-15 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444207#comment-17444207 ] RivenSun commented on KAFKA-13437: -- [~showuon]  Hi luke, please browse this issue when available. What

[GitHub] [kafka] junrao merged pull request #11487: KAFKA-13445: Add ECDSA test for JWT validation

2021-11-15 Thread GitBox
junrao merged pull request #11487: URL: https://github.com/apache/kafka/pull/11487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jsancio commented on a change in pull request #11503: KAFKA-13456: controller.listener.names required in KRaft

2021-11-15 Thread GitBox
jsancio commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r749777697 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -2007,8 +2007,13 @@ class KafkaConfig private(doLog: Boolean, val props:

[jira] [Commented] (KAFKA-13444) Fix OAuthCompatibilityTool help and add SSL options

2021-11-15 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444186#comment-17444186 ] Kirk True commented on KAFKA-13444: --- [~dajac] - can we get this into 3.1.0 release too? Otherwise

[GitHub] [kafka] junrao commented on pull request #11486: KAFKA-13444: Fix OAuthCompatibilityTool help and add SSL options

2021-11-15 Thread GitBox
junrao commented on pull request #11486: URL: https://github.com/apache/kafka/pull/11486#issuecomment-969447178 @kirktrue : Could you let David Jacot know if this needs to be in 3.1.0? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] hachikuji commented on a change in pull request #11503: KAFKA-13456: controller.listener.names required in KRaft

2021-11-15 Thread GitBox
hachikuji commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r749765601 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -2007,8 +2007,13 @@ class KafkaConfig private(doLog: Boolean, val props:

[GitHub] [kafka] hachikuji commented on a change in pull request #11503: KAFKA-13456: controller.listener.names required in KRaft

2021-11-15 Thread GitBox
hachikuji commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r749765601 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -2007,8 +2007,13 @@ class KafkaConfig private(doLog: Boolean, val props:

[GitHub] [kafka] junrao merged pull request #11486: KAFKA-13444: Fix OAuthCompatibilityTool help and add SSL options

2021-11-15 Thread GitBox
junrao merged pull request #11486: URL: https://github.com/apache/kafka/pull/11486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-12226) High-throughput source tasks fail to commit offsets

2021-11-15 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-12226: -- Fix Version/s: 3.0.1 3.2.0 > High-throughput source tasks fail to commit

[GitHub] [kafka] dongjinleekr commented on pull request #11472: TRIVIAL: Remove unused parameters, exceptions, comments, etc.

2021-11-15 Thread GitBox
dongjinleekr commented on pull request #11472: URL: https://github.com/apache/kafka/pull/11472#issuecomment-969438136 @mimaison Here is the fix; redundant parameters to call `DumpLogSegments#[dumpLog, dumpTimeIndex]` in `DumpLogSegments#main` also had to be removed. After removing it, it

[GitHub] [kafka] guozhangwang commented on a change in pull request #11499: [WIP] KAFKA-10199: Add interface for state updater

2021-11-15 Thread GitBox
guozhangwang commented on a change in pull request #11499: URL: https://github.com/apache/kafka/pull/11499#discussion_r749758167 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -246,4 +246,11 @@ default boolean

[GitHub] [kafka] kirktrue commented on pull request #11484: KAFKA-13443: Kafka broker exits when OAuth enabled and certain configuration not specified

2021-11-15 Thread GitBox
kirktrue commented on pull request #11484: URL: https://github.com/apache/kafka/pull/11484#issuecomment-969380314 > @kirktrue Should we add or extend tests in KafkaConfigTest to cover them? They're already present on lines 780 and 781 in `KafkaConfigTest.scala`: ```scala

[jira] [Commented] (KAFKA-13294) Upgrade Netty to 4.1.68 for CVE fixes

2021-11-15 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444139#comment-17444139 ] Dongjin Lee commented on KAFKA-13294: - [~mimaison] +1. > Upgrade Netty to 4.1.68 for CVE fixes >

[GitHub] [kafka] kirktrue commented on a change in pull request #11486: KAFKA-13444: Fix OAuthCompatibilityTool help and add SSL options

2021-11-15 Thread GitBox
kirktrue commented on a change in pull request #11486: URL: https://github.com/apache/kafka/pull/11486#discussion_r749722788 ## File path: tools/src/main/java/org/apache/kafka/tools/OAuthCompatibilityTool.java ## @@ -208,71 +170,217 @@ public static void main(String[] args) {

[GitHub] [kafka] kirktrue commented on a change in pull request #11487: KAFKA-13445: Add ECDSA test for JWT validation

2021-11-15 Thread GitBox
kirktrue commented on a change in pull request #11487: URL: https://github.com/apache/kafka/pull/11487#discussion_r749721422 ## File path: clients/src/test/java/org/apache/kafka/common/security/oauthbearer/secured/AccessTokenBuilder.java ## @@ -49,22 +49,24 @@ private

[GitHub] [kafka] kirktrue commented on a change in pull request #11487: KAFKA-13445: Add ECDSA test for JWT validation

2021-11-15 Thread GitBox
kirktrue commented on a change in pull request #11487: URL: https://github.com/apache/kafka/pull/11487#discussion_r749721059 ## File path: clients/src/test/java/org/apache/kafka/common/security/oauthbearer/secured/ValidatorAccessTokenValidatorTest.java ## @@ -38,14 +40,35 @@

[GitHub] [kafka] rondagostino opened a new pull request #11503: KAFKA-13456: controller.listener.names required in KRaft

2021-11-15 Thread GitBox
rondagostino opened a new pull request #11503: URL: https://github.com/apache/kafka/pull/11503 The `controller.listener.names` config is currently checked for existence when the `process.roles` contains the controller role (i.e. `process.roles=controller` or

[GitHub] [kafka] C0urante commented on pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

2021-11-15 Thread GitBox
C0urante commented on pull request #10528: URL: https://github.com/apache/kafka/pull/10528#issuecomment-969330955 I've rebased onto the latest trunk. I think with the latest changes (especially [these logging

[GitHub] [kafka] jolshan commented on a change in pull request #11004: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name (trunk)

2021-11-15 Thread GitBox
jolshan commented on a change in pull request #11004: URL: https://github.com/apache/kafka/pull/11004#discussion_r749683412 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -1206,7 +1205,8 @@ private void

[GitHub] [kafka] hachikuji commented on a change in pull request #11004: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name (trunk)

2021-11-15 Thread GitBox
hachikuji commented on a change in pull request #11004: URL: https://github.com/apache/kafka/pull/11004#discussion_r749668458 ## File path: clients/src/test/java/org/apache/kafka/clients/MetadataTest.java ## @@ -372,6 +379,49 @@ public void testUpdateLastEpoch() {

[GitHub] [kafka] hachikuji commented on pull request #11502: KAFKA-13071; Deprecate support for changing acls through the authorizer

2021-11-15 Thread GitBox
hachikuji commented on pull request #11502: URL: https://github.com/apache/kafka/pull/11502#issuecomment-969291197 cc @dajac It would be nice to do this in 3.1 if possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] hachikuji opened a new pull request #11502: KAFKA-13071; Deprecate support for changing acls through the authorizer

2021-11-15 Thread GitBox
hachikuji opened a new pull request #11502: URL: https://github.com/apache/kafka/pull/11502 This patch marks the following arguments as deprecated in kafka-acls.sh as documented in

[jira] [Resolved] (KAFKA-10104) Remove deprecated --zookeeper flags as specified in KIP-604

2021-11-15 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10104. - Resolution: Duplicate > Remove deprecated --zookeeper flags as specified in KIP-604 >

[GitHub] [kafka] jolshan opened a new pull request #11501: MINOR: Fix FetchSessionBenchmark

2021-11-15 Thread GitBox
jolshan opened a new pull request #11501: URL: https://github.com/apache/kafka/pull/11501 There were a few small things I didn't clean up in KAFKA-13111. Clean up here. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify

[jira] [Updated] (KAFKA-13456) controller.listener.names is required for all KRaft nodes, not just controllers

2021-11-15 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-13456: -- Description: The controller.listener.names config is currently checked for existence when the

[GitHub] [kafka] junrao merged pull request #11480: MINOR: fix comment in TimingWheel

2021-11-15 Thread GitBox
junrao merged pull request #11480: URL: https://github.com/apache/kafka/pull/11480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] junrao commented on pull request #11482: KAFKA-13448: Align behaviour for producer callbacks with documented behaviour

2021-11-15 Thread GitBox
junrao commented on pull request #11482: URL: https://github.com/apache/kafka/pull/11482#issuecomment-969213761 @soceanainn : Thanks for the KIP. Making ProducerBatch accept InterceptorCallback seems fine since it's an internal class. -- This is an automated message from the Apache Git

[jira] [Updated] (KAFKA-12257) Consumer mishandles topics deleted and recreated with the same name

2021-11-15 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-12257: Fix Version/s: 2.8.2 > Consumer mishandles topics deleted and recreated with the same

[jira] [Assigned] (KAFKA-13071) Deprecate and remove --authorizer option in kafka-acls.sh

2021-11-15 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-13071: --- Assignee: Jason Gustafson (was: HaiyuanZhao) > Deprecate and remove --authorizer

[jira] [Commented] (KAFKA-13071) Deprecate and remove --authorizer option in kafka-acls.sh

2021-11-15 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444032#comment-17444032 ] Jason Gustafson commented on KAFKA-13071: - [~zhaohaidao] I'm going to pick this up so that we

[jira] [Commented] (KAFKA-13407) Kafka controller out of service after ZK leader restart

2021-11-15 Thread Daniel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444014#comment-17444014 ] Daniel commented on KAFKA-13407: Thanks, [~vinsonZhang] when declaring what we had in the JAAS file in

[GitHub] [kafka] junrao commented on a change in pull request #11487: KAFKA-13445: Add ECDSA test for JWT validation

2021-11-15 Thread GitBox
junrao commented on a change in pull request #11487: URL: https://github.com/apache/kafka/pull/11487#discussion_r749554644 ## File path: clients/src/test/java/org/apache/kafka/common/security/oauthbearer/secured/AccessTokenBuilder.java ## @@ -49,22 +49,24 @@ private

[GitHub] [kafka] mkandaswamy commented on pull request #11494: MINOR: Improve KafkaStreamsTest: testInitializesAndDestroysMetricsReporters

2021-11-15 Thread GitBox
mkandaswamy commented on pull request #11494: URL: https://github.com/apache/kafka/pull/11494#issuecomment-969156394 Test failures: org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testSourceTaskNotBlockedOnShutdownWithNonExistentTopic and

[GitHub] [kafka] junrao commented on a change in pull request #11486: KAFKA-13444: Fix OAuthCompatibilityTool help and add SSL options

2021-11-15 Thread GitBox
junrao commented on a change in pull request #11486: URL: https://github.com/apache/kafka/pull/11486#discussion_r749549502 ## File path: tools/src/main/java/org/apache/kafka/tools/OAuthCompatibilityTool.java ## @@ -208,71 +170,217 @@ public static void main(String[] args) {

[jira] [Commented] (KAFKA-12226) High-throughput source tasks fail to commit offsets

2021-11-15 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443975#comment-17443975 ] Randall Hauch commented on KAFKA-12226: --- Thanks for catching this, [~dajac]. I did miss merging

[jira] [Assigned] (KAFKA-13455) The Apache Kafka quickstart guide does not contain any steps for running Kafka Connect

2021-11-15 Thread Kate Stanley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kate Stanley reassigned KAFKA-13455: Assignee: Kate Stanley > The Apache Kafka quickstart guide does not contain any steps

[GitHub] [kafka] katheris opened a new pull request #11500: KAFKA-13455: Add steps to run Kafka Connect to quickstart

2021-11-15 Thread GitBox
katheris opened a new pull request #11500: URL: https://github.com/apache/kafka/pull/11500 Signed-off-by: Katherine Stanley <11195226+kathe...@users.noreply.github.com> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Created] (KAFKA-13456) controller.listener.names is required for all KRaft nodes, not just controllers

2021-11-15 Thread Ron Dagostino (Jira)
Ron Dagostino created KAFKA-13456: - Summary: controller.listener.names is required for all KRaft nodes, not just controllers Key: KAFKA-13456 URL: https://issues.apache.org/jira/browse/KAFKA-13456

[jira] [Created] (KAFKA-13455) The Apache Kafka quickstart guide does not contain any steps for running Kafka Connect

2021-11-15 Thread Kate Stanley (Jira)
Kate Stanley created KAFKA-13455: Summary: The Apache Kafka quickstart guide does not contain any steps for running Kafka Connect Key: KAFKA-13455 URL: https://issues.apache.org/jira/browse/KAFKA-13455

[GitHub] [kafka] cadonna commented on a change in pull request #11499: [WIP] KAFKA-10199: Add interface for state updater

2021-11-15 Thread GitBox
cadonna commented on a change in pull request #11499: URL: https://github.com/apache/kafka/pull/11499#discussion_r749486443 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateUpdater.java ## @@ -0,0 +1,50 @@ +package

[GitHub] [kafka] cadonna commented on a change in pull request #11499: [WIP] KAFKA-10199: Add interface for state updater

2021-11-15 Thread GitBox
cadonna commented on a change in pull request #11499: URL: https://github.com/apache/kafka/pull/11499#discussion_r749480160 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateUpdater.java ## @@ -0,0 +1,50 @@ +package

[GitHub] [kafka] cadonna commented on a change in pull request #11499: [WIP] KAFKA-10199: Add interface for state updater

2021-11-15 Thread GitBox
cadonna commented on a change in pull request #11499: URL: https://github.com/apache/kafka/pull/11499#discussion_r749478922 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateUpdater.java ## @@ -0,0 +1,50 @@ +package

[GitHub] [kafka] cadonna commented on a change in pull request #11499: [WIP] KAFKA-10199: Add interface for state updater

2021-11-15 Thread GitBox
cadonna commented on a change in pull request #11499: URL: https://github.com/apache/kafka/pull/11499#discussion_r749476568 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateUpdater.java ## @@ -0,0 +1,50 @@ +package

[GitHub] [kafka] cadonna commented on a change in pull request #11499: [WIP] KAFKA-10199: Add interface for state updater

2021-11-15 Thread GitBox
cadonna commented on a change in pull request #11499: URL: https://github.com/apache/kafka/pull/11499#discussion_r749468726 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateUpdater.java ## @@ -0,0 +1,50 @@ +package

[GitHub] [kafka] cadonna opened a new pull request #11499: [WIP] KAFKA-10199: Add interface for state updater

2021-11-15 Thread GitBox
cadonna opened a new pull request #11499: URL: https://github.com/apache/kafka/pull/11499 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] mimaison merged pull request #11466: :memo: Update Docs

2021-11-15 Thread GitBox
mimaison merged pull request #11466: URL: https://github.com/apache/kafka/pull/11466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison commented on a change in pull request #11467: MINOR: fix java doc in kafkaProducer

2021-11-15 Thread GitBox
mimaison commented on a change in pull request #11467: URL: https://github.com/apache/kafka/pull/11467#discussion_r749454721 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -117,15 +115,16 @@ * as well as a background I/O

[jira] [Commented] (KAFKA-13294) Upgrade Netty to 4.1.68 for CVE fixes

2021-11-15 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443906#comment-17443906 ] Mickael Maison commented on KAFKA-13294: Thanks [~dongjin] I've updated the fix version field.

[jira] [Updated] (KAFKA-13294) Upgrade Netty to 4.1.68 for CVE fixes

2021-11-15 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13294: --- Fix Version/s: 3.1.0 > Upgrade Netty to 4.1.68 for CVE fixes >

[jira] [Comment Edited] (KAFKA-13294) Upgrade Netty to 4.1.68 for CVE fixes

2021-11-15 Thread Dominique Mongelli (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443874#comment-17443874 ] Dominique Mongelli edited comment on KAFKA-13294 at 11/15/21, 3:01 PM:

[jira] [Commented] (KAFKA-13294) Upgrade Netty to 4.1.68 for CVE fixes

2021-11-15 Thread Dominique Mongelli (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443874#comment-17443874 ] Dominique Mongelli commented on KAFKA-13294: Hi, what will be the target version of this fix

[jira] [Comment Edited] (KAFKA-13140) KRaft brokers do not expose kafka.controller metrics, breaking backwards compatibility

2021-11-15 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443850#comment-17443850 ] Ron Dagostino edited comment on KAFKA-13140 at 11/15/21, 2:25 PM: -- No

[GitHub] [kafka] rondagostino commented on pull request #11133: KAFKA-13140: KRaft brokers do not expose kafka.controller metrics

2021-11-15 Thread GitBox
rondagostino commented on pull request #11133: URL: https://github.com/apache/kafka/pull/11133#issuecomment-968959242 Closing as [KIP-771: KRaft brokers without the "controller" role should not expose controller

[GitHub] [kafka] rondagostino closed pull request #11133: KAFKA-13140: KRaft brokers do not expose kafka.controller metrics

2021-11-15 Thread GitBox
rondagostino closed pull request #11133: URL: https://github.com/apache/kafka/pull/11133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] GuoPhilipse commented on pull request #11483: KAFKA-13441: improve upgrade doc

2021-11-15 Thread GitBox
GuoPhilipse commented on pull request #11483: URL: https://github.com/apache/kafka/pull/11483#issuecomment-968928642 > For tiny fixes like this you don't need to open a JIRA, just submit a PR. Thanks Thanks @mimaison for your kind advice, will pay more attention in future. --

[GitHub] [kafka] edoardocomar commented on pull request #11476: KAFKA-13407: Always start controller when broker wins election

2021-11-15 Thread GitBox
edoardocomar commented on pull request #11476: URL: https://github.com/apache/kafka/pull/11476#issuecomment-968925912 Hi @mimaison ! so we managed to reproduce using 3.0 in our cloud clusters - not locally on a laptop with 3ZK and 3 Kafkas. So latencies may play a part ? As for

[GitHub] [kafka] mimaison commented on pull request #11472: TRIVIAL: Remove unused parameters, exceptions, comments, etc.

2021-11-15 Thread GitBox
mimaison commented on pull request #11472: URL: https://github.com/apache/kafka/pull/11472#issuecomment-968910011 Thanks @dongjinleekr for the cleanup. It looks like you missed some changes in `DumpLogSegments.scala`: ``` [Error]

[GitHub] [kafka] mimaison commented on pull request #11483: KAFKA-13441: improve upgrade doc

2021-11-15 Thread GitBox
mimaison commented on pull request #11483: URL: https://github.com/apache/kafka/pull/11483#issuecomment-968903648 For tiny fixes like this you don't need to open a JIRA, just submit a PR. Thanks -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Assigned] (KAFKA-13441) improve upgrade doc

2021-11-15 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-13441: -- Assignee: guo > improve upgrade doc > --- > > Key:

[GitHub] [kafka] mimaison merged pull request #11483: KAFKA-13441: improve upgrade doc

2021-11-15 Thread GitBox
mimaison merged pull request #11483: URL: https://github.com/apache/kafka/pull/11483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-13441) improve upgrade doc

2021-11-15 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-13441. Fix Version/s: 3.2.0 Resolution: Fixed > improve upgrade doc > ---

[GitHub] [kafka] mimaison commented on pull request #11476: KAFKA-13407: Always start controller when broker wins election

2021-11-15 Thread GitBox
mimaison commented on pull request #11476: URL: https://github.com/apache/kafka/pull/11476#issuecomment-968895925 Is this also an issue on trunk? If so let's fix trunk first then we can backport it to older branches. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] mimaison commented on pull request #11491: KAFKA-13442: REST API endpoint for fetching a connector's config def

2021-11-15 Thread GitBox
mimaison commented on pull request #11491: URL: https://github.com/apache/kafka/pull/11491#issuecomment-968892334 That looks similar to the KIP I proposed a few weeks ago:

[GitHub] [kafka] ocadaruma commented on a change in pull request #11422: KAFKA-9648: Add configuration to adjust listen backlog size for Acceptor

2021-11-15 Thread GitBox
ocadaruma commented on a change in pull request #11422: URL: https://github.com/apache/kafka/pull/11422#discussion_r749271976 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -660,7 +662,7 @@ private[kafka] class Acceptor(val endPoint: EndPoint,

[jira] [Commented] (KAFKA-13407) Kafka controller out of service after ZK leader restart

2021-11-15 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443781#comment-17443781 ] Edoardo Comar commented on KAFKA-13407: --- [~vinsonZhang] are you suggesting loss of connection with

[jira] [Comment Edited] (KAFKA-13407) Kafka controller out of service after ZK leader restart

2021-11-15 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443780#comment-17443780 ] Edoardo Comar edited comment on KAFKA-13407 at 11/15/21, 11:44 AM: --- Hi

[jira] [Commented] (KAFKA-13407) Kafka controller out of service after ZK leader restart

2021-11-15 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443780#comment-17443780 ] Edoardo Comar commented on KAFKA-13407: --- [~vinsonZhang]the zookeeper "Auth failed" error in the

[jira] [Comment Edited] (KAFKA-13454) kafka has duplicate configuration information log information printing during startup

2021-11-15 Thread zhangzhanchang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443769#comment-17443769 ] zhangzhanchang edited comment on KAFKA-13454 at 11/15/21, 11:21 AM:

[GitHub] [kafka] zzccctv commented on pull request #11496: KAFKA-13454: kafka has duplicate configuration information log information printin…

2021-11-15 Thread GitBox
zzccctv commented on pull request #11496: URL: https://github.com/apache/kafka/pull/11496#issuecomment-968806449 @ijuma @guozhangwang Can you help me look at this problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-13454) kafka has duplicate configuration information log information printing during startup

2021-11-15 Thread zhangzhanchang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443769#comment-17443769 ] zhangzhanchang commented on KAFKA-13454: HI,[~ijuma]  Can you help me look at this problem? >

[jira] [Updated] (KAFKA-13454) kafka has duplicate configuration information log information printing during startup

2021-11-15 Thread zhangzhanchang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangzhanchang updated KAFKA-13454: --- Reviewer: Ismael Juma (was: Guozhang Wang) > kafka has duplicate configuration information

[jira] [Updated] (KAFKA-13454) kafka has duplicate configuration information log information printing during startup

2021-11-15 Thread zhangzhanchang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangzhanchang updated KAFKA-13454: --- Description: kafka has duplicate configuration information log information printing during

[GitHub] [kafka] mimaison commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-11-15 Thread GitBox
mimaison commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r749214261 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig

[jira] [Assigned] (KAFKA-13255) Mirrormaker config property config.properties.exclude is not working as expected

2021-11-15 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-13255: -- Assignee: Ed Berezitsky > Mirrormaker config property config.properties.exclude is

[jira] [Resolved] (KAFKA-13255) Mirrormaker config property config.properties.exclude is not working as expected

2021-11-15 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-13255. Fix Version/s: 3.2.0 Resolution: Fixed > Mirrormaker config property

[GitHub] [kafka] mimaison merged pull request #11401: KAFKA-13255: use exclude filter for new topics

2021-11-15 Thread GitBox
mimaison merged pull request #11401: URL: https://github.com/apache/kafka/pull/11401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >