showuon commented on pull request #11564:
URL: https://github.com/apache/kafka/pull/11564#issuecomment-985262463
@hachikuji , could you help review this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
showuon commented on a change in pull request #11564:
URL: https://github.com/apache/kafka/pull/11564#discussion_r761686373
##
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##
@@ -146,62 +146,71 @@ object ConsoleProducer {
.describedAs("size")
showuon commented on a change in pull request #11564:
URL: https://github.com/apache/kafka/pull/11564#discussion_r761685896
##
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##
@@ -146,62 +146,71 @@ object ConsoleProducer {
.describedAs("size")
showuon commented on a change in pull request #11564:
URL: https://github.com/apache/kafka/pull/11564#discussion_r761685301
##
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##
@@ -146,62 +146,71 @@ object ConsoleProducer {
.describedAs("size")
showuon opened a new pull request #11564:
URL: https://github.com/apache/kafka/pull/11564
`kafka-console-producer.sh` provides users some options to configure. But
some of them are ambiguous to users to map the option to a specific producer
config. Ex: `timeout` option, is actually
[
https://issues.apache.org/jira/browse/KAFKA-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452759#comment-17452759
]
Omnia Ibrahim edited comment on KAFKA-13415 at 12/3/21, 5:16 AM:
-
Hey
[
https://issues.apache.org/jira/browse/KAFKA-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452759#comment-17452759
]
Omnia Ibrahim commented on KAFKA-13415:
---
Hey Colin, I don't believe this is resolved yet. If you
[
https://issues.apache.org/jira/browse/KAFKA-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452728#comment-17452728
]
loboxu commented on KAFKA-10900:
[~jagsancio] The PR has been submitted here, and it seems that there
cmccabe commented on a change in pull request #11416:
URL: https://github.com/apache/kafka/pull/11416#discussion_r761588451
##
File path:
core/src/main/scala/kafka/server/ControllerConfigurationValidator.scala
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software
Colin McCabe created KAFKA-13503:
Summary: Validate broker configs for KRaft
Key: KAFKA-13503
URL: https://issues.apache.org/jira/browse/KAFKA-13503
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-12505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452681#comment-17452681
]
Colin McCabe commented on KAFKA-12505:
--
We did change over the internal logic to handle clusterId
[
https://issues.apache.org/jira/browse/KAFKA-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-12682.
--
Fix Version/s: 3.0.0
Assignee: Colin McCabe (was: Justine Olshan)
Resolution:
prat0318 commented on pull request #11552:
URL: https://github.com/apache/kafka/pull/11552#issuecomment-985139109
@hachikuji Made the suggested changes. Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-12712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-12712.
--
Fix Version/s: 3.0.0
(was: 3.2.0)
Assignee: Jason Gustafson
[
https://issues.apache.org/jira/browse/KAFKA-12712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452679#comment-17452679
]
Colin McCabe commented on KAFKA-12712:
--
This now fails with:
[
https://issues.apache.org/jira/browse/KAFKA-12714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452678#comment-17452678
]
Colin McCabe commented on KAFKA-12714:
--
Does this still happen on 3.0?
> Kafka 2.8 server not
[
https://issues.apache.org/jira/browse/KAFKA-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452677#comment-17452677
]
Colin McCabe commented on KAFKA-12801:
--
Does this still happen with 3.0?
> High CPU load after
[
https://issues.apache.org/jira/browse/KAFKA-13019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-13019.
--
Resolution: Fixed
> Add MetadataImage and MetadataDelta classes for KRaft Snapshots
>
[
https://issues.apache.org/jira/browse/KAFKA-12853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-12853.
--
Resolution: Fixed
> Implement broker-side KRaft snapshots
>
[
https://issues.apache.org/jira/browse/KAFKA-12853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-12853:
-
Fix Version/s: 3.0.0
> Implement broker-side KRaft snapshots
>
[
https://issues.apache.org/jira/browse/KAFKA-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-13502:
-
Labels: kip-500 (was: )
> Support configuring BROKER_LOGGER on controller-only KRaft nodes
>
[
https://issues.apache.org/jira/browse/KAFKA-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-13415.
--
Resolution: Not A Problem
> Track topic deletion state without ZK
>
[
https://issues.apache.org/jira/browse/KAFKA-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452676#comment-17452676
]
Colin McCabe commented on KAFKA-13415:
--
There is no "topic deleting" state when using KRaft, so
cmccabe commented on a change in pull request #11416:
URL: https://github.com/apache/kafka/pull/11416#discussion_r761580433
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java
##
@@ -122,19 +126,13 @@ private void
Colin McCabe created KAFKA-13502:
Summary: Support configuring BROKER_LOGGER on controller-only
KRaft nodes
Key: KAFKA-13502
URL: https://issues.apache.org/jira/browse/KAFKA-13502
Project: Kafka
cmccabe commented on a change in pull request #11416:
URL: https://github.com/apache/kafka/pull/11416#discussion_r761580186
##
File path:
core/src/main/scala/kafka/server/ControllerConfigurationValidator.scala
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452673#comment-17452673
]
Ryan Leslie commented on KAFKA-13435:
-
That's an interesting idea. Each member of the group is
hachikuji commented on a change in pull request #11416:
URL: https://github.com/apache/kafka/pull/11416#discussion_r761564392
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java
##
@@ -122,19 +126,13 @@ private void
Matthias J. Sax created KAFKA-13501:
---
Summary: Avoid state restore via rebalance if standbys are enabled
Key: KAFKA-13501
URL: https://issues.apache.org/jira/browse/KAFKA-13501
Project: Kafka
vvcephei commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r761510761
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java
##
@@ -110,17 +121,28 @@ public
Matthias J. Sax created KAFKA-13500:
---
Summary: Consider adding a dedicated standby consumer
Key: KAFKA-13500
URL: https://issues.apache.org/jira/browse/KAFKA-13500
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-13490:
-
Description:
For CreateTopics, fix a bug where if one createTopics in a batch failed, they
[
https://issues.apache.org/jira/browse/KAFKA-13461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram resolved KAFKA-13461.
Fix Version/s: 3.1.0
3.0.1
Reviewer: Jun Rao
rajinisivaram merged pull request #11563:
URL: https://github.com/apache/kafka/pull/11563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rajinisivaram commented on pull request #11563:
URL: https://github.com/apache/kafka/pull/11563#issuecomment-985041476
@junrao Thanks for the review, merging to trunk, 3.1 and 3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cmccabe commented on a change in pull request #11416:
URL: https://github.com/apache/kafka/pull/11416#discussion_r761500264
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ConfigurationValidator.java
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software
Matthias J. Sax created KAFKA-13499:
---
Summary: Avoid restoring outdated records
Key: KAFKA-13499
URL: https://issues.apache.org/jira/browse/KAFKA-13499
Project: Kafka
Issue Type:
cmccabe commented on a change in pull request #11416:
URL: https://github.com/apache/kafka/pull/11416#discussion_r761495515
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -388,7 +389,12 @@ public void
cmccabe commented on a change in pull request #11416:
URL: https://github.com/apache/kafka/pull/11416#discussion_r761494119
##
File path:
metadata/src/test/java/org/apache/kafka/controller/ConfigurationControlManagerTest.java
##
@@ -72,6 +73,14 @@
define("ghi",
rajinisivaram opened a new pull request #11563:
URL: https://github.com/apache/kafka/pull/11563
If JAAS configuration does not contain a Client section for ZK clients, an
auth failure event is generated. If this occurs after the connection is setup
in the controller, we schedule
[
https://issues.apache.org/jira/browse/KAFKA-13461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson reassigned KAFKA-13461:
---
Assignee: Rajini Sivaram (was: Jason Gustafson)
> KafkaController stops
omkreddy commented on a change in pull request #11539:
URL: https://github.com/apache/kafka/pull/11539#discussion_r761300641
##
File path: docs/upgrade.html
##
@@ -36,8 +78,52 @@ Notable changes in 3
Those applications will need to go through a bridge release, by
dajac commented on pull request #11539:
URL: https://github.com/apache/kafka/pull/11539#issuecomment-984822393
@omkreddy Thanks for the review. I have addressed your comments. Could you
have another look?
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452494#comment-17452494
]
David Jacot commented on KAFKA-13435:
-
Yeah, I do agree that this solution does not fly if we can't
vvcephei commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r761242697
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java
##
@@ -246,4 +246,4 @@ public TaskType
tolgadur opened a new pull request #11562:
URL: https://github.com/apache/kafka/pull/11562
In the new NamedTopology API being worked on, state store names and their
uniqueness requirement is going to be scoped only to the owning topology,
rather than to the entire app. In other words, two
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r755285644
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java
##
@@ -246,4 +246,4 @@ public TaskType
soarez commented on a change in pull request #9577:
URL: https://github.com/apache/kafka/pull/9577#discussion_r760091660
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -2443,6 +2443,117 @@ class KafkaController(val config: KafkaConfig,
}
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r761142526
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/ConsistencyVectorIntegrationTest.java
##
@@ -0,0 +1,236 @@
+/*
+ * Licensed to
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r761141392
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -312,6 +318,11 @@ public synchronized void
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r761140618
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -106,10 +111,13 @@
private final
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r761138847
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStore.java
##
@@ -76,6 +87,10 @@ public long
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r761135387
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java
##
@@ -216,6 +226,11 @@ public
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r760099865
##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##
@@ -947,6 +947,11 @@
// Private API used to control the emit
cadonna commented on pull request #11561:
URL: https://github.com/apache/kafka/pull/11561#issuecomment-984654510
Call for review: @ijuma @lbradstreet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cadonna opened a new pull request #11561:
URL: https://github.com/apache/kafka/pull/11561
grgit 4.1.0 caused unsupported version error during gradle builds.
The reason was that grgit 4.1.0 uses always the latest JGit version
internally. Unfortunately, the latest JGit version was
[
https://issues.apache.org/jira/browse/KAFKA-13016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452377#comment-17452377
]
loboxu commented on KAFKA-13016:
[~Niket Goel] Is there a more detailed description of this requirement?
omkreddy commented on a change in pull request #11539:
URL: https://github.com/apache/kafka/pull/11539#discussion_r760946183
##
File path: docs/upgrade.html
##
@@ -19,6 +19,48 @@
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-984477740
@cadonna no worries and thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cadonna commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-984453564
@lkokhreidze I am really sorry that I haven't found the time to look at your
updated PR. I will put it on my list for next week.
--
This is an automated message from the
florin-akermann commented on pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#issuecomment-984412937
@dajac Ok thanks, good to know it is queued.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452158#comment-17452158
]
Igor Shipenkov edited comment on KAFKA-13474 at 12/2/21, 8:36 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Shipenkov updated KAFKA-13474:
---
Summary: Regression in dynamic update of broker certificate (was:
Regression in dynamic
63 matches
Mail list logo
