[jira] [Created] (KAFKA-13645) Support the TopologyTestDriver with modular topologies

2022-02-03 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-13645: -- Summary: Support the TopologyTestDriver with modular topologies Key: KAFKA-13645 URL: https://issues.apache.org/jira/browse/KAFKA-13645 Project:

[GitHub] [kafka] showuon commented on pull request #5407: KAFKA-7109: Close cached fetch sessions in the broker on consumer close

2022-02-03 Thread GitBox
showuon commented on pull request #5407: URL: https://github.com/apache/kafka/pull/5407#issuecomment-1029737477 @stanislavkozlovski , encountered similar errors and I agree we should close the incremental fetch sessions when consumer closed. Are you able to complete this PR? If not, I can

[GitHub] [kafka] dajac commented on pull request #11720: KAFKA-13625: Fix inconsistency in dynamic application log levels

2022-02-03 Thread GitBox
dajac commented on pull request #11720: URL: https://github.com/apache/kafka/pull/11720#issuecomment-1029736633 @dongjinleekr Thanks for the explanation. I missed KIP-817 in the mailing list. Let's continue the discussion there and see what the community think about this. -- This is an

[jira] [Created] (KAFKA-13644) Support global state stores with modular topologies

2022-02-03 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-13644: -- Summary: Support global state stores with modular topologies Key: KAFKA-13644 URL: https://issues.apache.org/jira/browse/KAFKA-13644 Project:

[jira] [Created] (KAFKA-13643) Replace "NamedTopology" with "ModularTopology" in the codebase

2022-02-03 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-13643: -- Summary: Replace "NamedTopology" with "ModularTopology" in the codebase Key: KAFKA-13643 URL: https://issues.apache.org/jira/browse/KAFKA-13643

[jira] [Commented] (KAFKA-13534) Upgrade Log4j to 2.15.0 - CVE-2021-44228

2022-02-03 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486845#comment-17486845 ] Luke Chen commented on KAFKA-13534: --- [~noonbs] , thanks for the comment. I've set duplicate with

[jira] [Resolved] (KAFKA-13534) Upgrade Log4j to 2.15.0 - CVE-2021-44228

2022-02-03 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13534. --- Resolution: Duplicate > Upgrade Log4j to 2.15.0 - CVE-2021-44228 >

[GitHub] [kafka] showuon edited a comment on pull request #11631: KAFKA-13563: clear FindCoordinatorFuture for non consumer group mode

2022-02-03 Thread GitBox
showuon edited a comment on pull request #11631: URL: https://github.com/apache/kafka/pull/11631#issuecomment-1029613788 @guozhangwang , thanks for your comments. Sorry for confusing you! And it makes sense to remove the `WIP` out from the PR title. I'll let you know when I complete

[GitHub] [kafka] showuon commented on pull request #11631: KAFKA-13563: clear FindCoordinatorFuture for non consumer group mode

2022-02-03 Thread GitBox
showuon commented on pull request #11631: URL: https://github.com/apache/kafka/pull/11631#issuecomment-1029613788 @guozhangwang , thanks for your comments. Sorry for confusing you! And it makes sense to remove the `KIP` out from the PR title. I'll let you know when I complete the PR.

[jira] [Commented] (KAFKA-13600) Rebalances while streams is in degraded state can cause stores to be reassigned and restore from scratch

2022-02-03 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486808#comment-17486808 ] Guozhang Wang commented on KAFKA-13600: --- Thanks guys for the great discussion here. I think just

[jira] [Commented] (KAFKA-13641) Kafka Streams Scala: Add `Option` to `ValueJoiner` parameters

2022-02-03 Thread Mohammad Yousuf Minhaj Zia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486807#comment-17486807 ] Mohammad Yousuf Minhaj Zia commented on KAFKA-13641: Going a step further maybe we

[jira] [Commented] (KAFKA-13641) Kafka Streams Scala: Add `Option` to `ValueJoiner` parameters

2022-02-03 Thread Mohammad Yousuf Minhaj Zia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486804#comment-17486804 ] Mohammad Yousuf Minhaj Zia commented on KAFKA-13641: [~mjsax] The backwards

[GitHub] [kafka] jsancio opened a new pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-03 Thread GitBox
jsancio opened a new pull request #11733: URL: https://github.com/apache/kafka/pull/11733 TODO: Add a description for this PR!! ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [

[GitHub] [kafka] jasonk000 commented on a change in pull request #11722: KAFKA-13630: reduce amount of time that producer network thread holds batch queue lock

2022-02-03 Thread GitBox
jasonk000 commented on a change in pull request #11722: URL: https://github.com/apache/kafka/pull/11722#discussion_r799138886 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -578,41 +587,45 @@ private boolean

[GitHub] [kafka] guozhangwang commented on pull request #11631: [WIP] KAFKA-13563: clear FindCoordinatorFuture for non consumer group mode

2022-02-03 Thread GitBox
guozhangwang commented on pull request #11631: URL: https://github.com/apache/kafka/pull/11631#issuecomment-1029600849 @showuon Sorry for getting late on this -- I thought it was not ready since the title still has `WIP` in it. I will re-title and continue reviewing it. -- This is an

[GitHub] [kafka] showuon commented on pull request #11631: [WIP] KAFKA-13563: clear FindCoordinatorFuture for non consumer group mode

2022-02-03 Thread GitBox
showuon commented on pull request #11631: URL: https://github.com/apache/kafka/pull/11631#issuecomment-1029598488 @guozhangwang @ableegoldman @hachikuji , please take a look when available. This issue blocks some users when upgrading Kafka-clients. I think this should be fixed soon.

[GitHub] [kafka] guozhangwang commented on a change in pull request #11703: KAFKA-13588: consolidate `changelogFor` methods to simplify the generation of internal topic names

2022-02-03 Thread GitBox
guozhangwang commented on a change in pull request #11703: URL: https://github.com/apache/kafka/pull/11703#discussion_r799128273 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -171,42 +169,24 @@ private void

[GitHub] [kafka] showuon commented on pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

2022-02-03 Thread GitBox
showuon commented on pull request #11691: URL: https://github.com/apache/kafka/pull/11691#issuecomment-1029590837 @hachikuji , I've updated the KIP to add tests. Please take a look again. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

2022-02-03 Thread GitBox
showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r799127097 ## File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala ## @@ -168,7 +168,7 @@ object ConsoleProducer { .withRequiredArg

[GitHub] [kafka] ijuma commented on a change in pull request #11722: KAFKA-13630: reduce amount of time that producer network thread holds batch queue lock

2022-02-03 Thread GitBox
ijuma commented on a change in pull request #11722: URL: https://github.com/apache/kafka/pull/11722#discussion_r799125694 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -578,41 +587,45 @@ private boolean

[GitHub] [kafka] ijuma commented on a change in pull request #11722: KAFKA-13630: reduce amount of time that producer network thread holds batch queue lock

2022-02-03 Thread GitBox
ijuma commented on a change in pull request #11722: URL: https://github.com/apache/kafka/pull/11722#discussion_r799125694 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -578,41 +587,45 @@ private boolean

[GitHub] [kafka] ijuma commented on a change in pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-03 Thread GitBox
ijuma commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r799124172 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -392,12 +392,33 @@ public static void writeDouble(double value,

[GitHub] [kafka] artemlivshits commented on a change in pull request #11722: KAFKA-13630: reduce amount of time that producer network thread holds batch queue lock

2022-02-03 Thread GitBox
artemlivshits commented on a change in pull request #11722: URL: https://github.com/apache/kafka/pull/11722#discussion_r799117854 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -578,41 +587,45 @@ private boolean

[GitHub] [kafka] artemlivshits commented on a change in pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-03 Thread GitBox
artemlivshits commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r799111359 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double

[GitHub] [kafka] jasonk000 commented on a change in pull request #11722: KAFKA-13630: reduce amount of time that producer network thread holds batch queue lock

2022-02-03 Thread GitBox
jasonk000 commented on a change in pull request #11722: URL: https://github.com/apache/kafka/pull/11722#discussion_r799107208 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -578,41 +587,45 @@ private boolean

[jira] [Commented] (KAFKA-7572) Producer should not send requests with negative partition id

2022-02-03 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486780#comment-17486780 ] Guozhang Wang commented on KAFKA-7572: -- Thanks for pinging me. I've just made a pass on the PR. >

[GitHub] [kafka] guozhangwang commented on pull request #10525: KAFKA-7572: Producer should not send requests with negative partition id

2022-02-03 Thread GitBox
guozhangwang commented on pull request #10525: URL: https://github.com/apache/kafka/pull/10525#issuecomment-1029565310 @predatorray Thanks for the PR. Just following @showuon 's comment, I thought about the existing `InvalidPartitionsException`, but that has some issues to be used by the

[GitHub] [kafka] guozhangwang closed pull request #5858: KAFKA-7572: Producer should not send requests with negative partition id

2022-02-03 Thread GitBox
guozhangwang closed pull request #5858: URL: https://github.com/apache/kafka/pull/5858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ahuang98 opened a new pull request #11732: MINOR: enable KRaft in ConfigCommandTest

2022-02-03 Thread GitBox
ahuang98 opened a new pull request #11732: URL: https://github.com/apache/kafka/pull/11732 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] jasonk000 commented on a change in pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-03 Thread GitBox
jasonk000 commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r799084697 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double value,

[GitHub] [kafka] jasonk000 commented on a change in pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-03 Thread GitBox
jasonk000 commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r799082813 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double value,

[GitHub] [kafka] jasonk000 commented on a change in pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-03 Thread GitBox
jasonk000 commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r799082813 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double value,

[GitHub] [kafka] jasonk000 commented on a change in pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-03 Thread GitBox
jasonk000 commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r799082813 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double value,

[jira] [Closed] (KAFKA-13619) zookeeper.sync.time.ms is no longer used

2022-02-03 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita closed KAFKA-13619. -- > zookeeper.sync.time.ms is no longer used > > >

[jira] [Commented] (KAFKA-13600) Rebalances while streams is in degraded state can cause stores to be reassigned and restore from scratch

2022-02-03 Thread Tim Patterson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486744#comment-17486744 ] Tim Patterson commented on KAFKA-13600: --- Thanks  [~cadonna] yeah I had a bit of a think and I

[GitHub] [kafka] jasonk000 commented on a change in pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-03 Thread GitBox
jasonk000 commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r799031745 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double value,

[GitHub] [kafka] jasonk000 commented on a change in pull request #11722: KAFKA-13630: reduce amount of time that producer network thread holds batch queue lock

2022-02-03 Thread GitBox
jasonk000 commented on a change in pull request #11722: URL: https://github.com/apache/kafka/pull/11722#discussion_r799030101 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -578,41 +587,45 @@ private boolean

[GitHub] [kafka] dongjinleekr commented on pull request #11720: KAFKA-13625: Fix inconsistency in dynamic application log levels

2022-02-03 Thread GitBox
dongjinleekr commented on pull request #11720: URL: https://github.com/apache/kafka/pull/11720#issuecomment-1029440873 Hi @dajac, Oh yes. As I mentioned in [KIP-817](https://cwiki.apache.org/confluence/display/KAFKA/KIP-817%3A+Fix+inconsistency+in+dynamic+application+log+levels), I

[GitHub] [kafka] artemlivshits commented on a change in pull request #11722: KAFKA-13630: reduce amount of time that producer network thread holds batch queue lock

2022-02-03 Thread GitBox
artemlivshits commented on a change in pull request #11722: URL: https://github.com/apache/kafka/pull/11722#discussion_r798988451 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -448,40 +448,48 @@ public

[jira] [Commented] (KAFKA-13600) Rebalances while streams is in degraded state can cause stores to be reassigned and restore from scratch

2022-02-03 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486714#comment-17486714 ] John Roesler commented on KAFKA-13600: -- Hi [~tim.patterson] , thanks for the report and the patch!

[GitHub] [kafka] dajac commented on pull request #11720: KAFKA-13625: Fix inconsistency in dynamic application log levels

2022-02-03 Thread GitBox
dajac commented on pull request #11720: URL: https://github.com/apache/kafka/pull/11720#issuecomment-1029400036 @dongjinleekr Thanks for the PR. It seems that OFF was intentionally left out in

[GitHub] [kafka] guozhangwang commented on pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2022-02-03 Thread GitBox
guozhangwang commented on pull request #11424: URL: https://github.com/apache/kafka/pull/11424#issuecomment-1029397689 > If by "first place" you mean https://github.com/apache/kafka/pull/11424#discussion_r796139442, then no, other way around actually. The TopologyConfig bug is the one

[GitHub] [kafka] mimaison commented on pull request #11672: KAFKA-13577: Replace easymock with mockito in kafka:core - part 1

2022-02-03 Thread GitBox
mimaison commented on pull request #11672: URL: https://github.com/apache/kafka/pull/11672#issuecomment-1029397144 Thanks @tombentley. I've pushed an update that improves coverage of all mocks whenever possible. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] mimaison commented on a change in pull request #11672: KAFKA-13577: Replace easymock with mockito in kafka:core - part 1

2022-02-03 Thread GitBox
mimaison commented on a change in pull request #11672: URL: https://github.com/apache/kafka/pull/11672#discussion_r798964433 ## File path: core/src/test/scala/kafka/common/InterBrokerSendThreadTest.scala ## @@ -134,36 +129,33 @@ class InterBrokerSendThreadTest { val

[jira] [Assigned] (KAFKA-13600) Rebalances while streams is in degraded state can cause stores to be reassigned and restore from scratch

2022-02-03 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-13600: Assignee: (was: John Roesler) > Rebalances while streams is in degraded state can

[jira] [Assigned] (KAFKA-13600) Rebalances while streams is in degraded state can cause stores to be reassigned and restore from scratch

2022-02-03 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-13600: Assignee: John Roesler > Rebalances while streams is in degraded state can cause stores

[jira] [Updated] (KAFKA-13600) Rebalances while streams is in degraded state can cause stores to be reassigned and restore from scratch

2022-02-03 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13600: - Affects Version/s: 3.1.0 > Rebalances while streams is in degraded state can cause stores to be

[GitHub] [kafka] guozhangwang commented on pull request #11447: KAFKA-13024

2022-02-03 Thread GitBox
guozhangwang commented on pull request #11447: URL: https://github.com/apache/kafka/pull/11447#issuecomment-1029335322 > I might be missing the full picture here as I am a bit new to the project, but, as I see it, the algorithm I described above does not suffer from this issue. There, we

[GitHub] [kafka] guozhangwang commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2022-02-03 Thread GitBox
guozhangwang commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r798901691 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -329,7 +330,7 @@ private

[jira] [Created] (KAFKA-13642) We should have a command-line tool + API to display fenced / unfenced / etc. brokers

2022-02-03 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-13642: Summary: We should have a command-line tool + API to display fenced / unfenced / etc. brokers Key: KAFKA-13642 URL: https://issues.apache.org/jira/browse/KAFKA-13642

[jira] [Comment Edited] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-03 Thread Ulrik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486529#comment-17486529 ] Ulrik edited comment on KAFKA-13638 at 2/3/22, 6:28 PM: Hi [~cadonna], I forked

[GitHub] [kafka] cmccabe merged pull request #11729: MINOR: fix control plane listener + kraft error message

2022-02-03 Thread GitBox
cmccabe merged pull request #11729: URL: https://github.com/apache/kafka/pull/11729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-13641) Kafka Streams Scala: Add `Option` to `ValueJoiner` parameters

2022-02-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486584#comment-17486584 ] Matthias J. Sax commented on KAFKA-13641: - The Java API faces the same issue – it's hard from a

[jira] [Updated] (KAFKA-13641) Kafka Streams Scala: Add `Option` to `ValueJoiner` parameters

2022-02-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13641: Language: scala needs-kip (was: scala) > Kafka Streams Scala: Add `Option` to

[jira] [Commented] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-03 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486578#comment-17486578 ] Bruno Cadonna commented on KAFKA-13638: --- [~Lejon]Thank you a lot for the testing! I think we can

[jira] [Commented] (KAFKA-12635) Mirrormaker 2 offset sync is incorrect if the target partition is empty

2022-02-03 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486576#comment-17486576 ] Federico Valeri commented on KAFKA-12635: - I was able to reproduce the issue on Kafka 2.7.2 and

[GitHub] [kafka] mimaison commented on pull request #10907: KAFKA-10000: Exactly-once support for source connectors (KIP-618)

2022-02-03 Thread GitBox
mimaison commented on pull request #10907: URL: https://github.com/apache/kafka/pull/10907#issuecomment-1029158871 @C0urante Thanks for the PR! It's really massive! Can we try to cut it in smaller chunks? That would make it a lot easier to review and allow merging bit by bit. -- This

[jira] [Commented] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-03 Thread Ulrik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486565#comment-17486565 ] Ulrik commented on KAFKA-13638: --- [~cadonna] Done. Average time for the test was the same as the other

[jira] [Comment Edited] (KAFKA-13293) Support client reload of JKS/PEM certificates

2022-02-03 Thread Elliot West (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486563#comment-17486563 ] Elliot West edited comment on KAFKA-13293 at 2/3/22, 4:15 PM: -- FWIW we've

[jira] [Commented] (KAFKA-13293) Support client reload of JKS/PEM certificates

2022-02-03 Thread Elliot West (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486563#comment-17486563 ] Elliot West commented on KAFKA-13293: - FWIW we've implemented a custom {{SslEngineFactory}} here:

[GitHub] [kafka] teabot opened a new pull request #11731: KAFKA-13293: Reloading engine factory

2022-02-03 Thread GitBox
teabot opened a new pull request #11731: URL: https://github.com/apache/kafka/pull/11731 This PR adds an optional `SslEngineFactory` implementation that decorates and manages a delegate. It is able to recreate the delegate either on a schedule, or in response to a SSL configuration patch

[jira] [Commented] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-03 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486557#comment-17486557 ] Bruno Cadonna commented on KAFKA-13638: --- [~Lejon] Could you also try with

[jira] [Comment Edited] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-03 Thread Ulrik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486529#comment-17486529 ] Ulrik edited comment on KAFKA-13638 at 2/3/22, 3:05 PM: Hi [~cadonna], I forked

[GitHub] [kafka] tombentley commented on a change in pull request #11672: KAFKA-13577: Replace easymock with mockito in kafka:core - part 1

2022-02-03 Thread GitBox
tombentley commented on a change in pull request #11672: URL: https://github.com/apache/kafka/pull/11672#discussion_r796754101 ## File path: core/src/test/scala/unit/kafka/controller/PartitionStateMachineTest.scala ## @@ -85,19 +84,17 @@ class PartitionStateMachineTest {

[jira] [Commented] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-03 Thread Ulrik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486529#comment-17486529 ] Ulrik commented on KAFKA-13638: --- Hi [~cadonna], I forked the repo and added a test. Here's the commit:

[jira] [Comment Edited] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-03 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486510#comment-17486510 ] Bruno Cadonna edited comment on KAFKA-13638 at 2/3/22, 2:09 PM: Hi

[jira] [Commented] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-03 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486510#comment-17486510 ] Bruno Cadonna commented on KAFKA-13638: --- Hi [~Lejon], Could you try to run your test with on the

[GitHub] [kafka] Indupa edited a comment on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-03 Thread GitBox
Indupa edited a comment on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1028979162 Sure @dongjinleekr .Thank you so much for sharing documentation ,Sorry I was not aware that -Dlog4j.configuration is VM parameter its pointing to in this ,so was confused

[GitHub] [kafka] Indupa edited a comment on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-03 Thread GitBox
Indupa edited a comment on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1028979162 Sure @dongjinleekr .Thank you so much for sharing documentation ,Sorry I was not aware that -Dlog4j.configuration is VM parameter its pointing to ,so was confused with

[GitHub] [kafka] Indupa edited a comment on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-03 Thread GitBox
Indupa edited a comment on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1028979162 Sure @dongjinleekr .Thank you so much for sharing documentation ,Sorry I was not aware that -Dlog4j.configuration is VM parameter ,so was confused with that Comment. I got

[GitHub] [kafka] Indupa commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-03 Thread GitBox
Indupa commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1028979162 Sure @dongjinleekr .Thank you so much for sharing documentation ,let me through the changes what i have made to use log4j2 properties by setting KAFKA_LOG4J_OPTS in

[GitHub] [kafka] Indupa removed a comment on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-03 Thread GitBox
Indupa removed a comment on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1028932370 Where I could find it @dongjinleekr ..? And can you help me what is the use of VM parameter and why is it required? Because i Haven't heard of

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-03 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1028965316 @Indupa Please refer [the documentation](https://cwiki.apache.org/confluence/display/KAFKA/KIP-653%3A+Upgrade+log4j+to+log4j2) and the log messages. -- This is an

[jira] [Comment Edited] (KAFKA-9366) Upgrade log4j to log4j2

2022-02-03 Thread Indupriya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486434#comment-17486434 ] Indupriya edited comment on KAFKA-9366 at 2/3/22, 12:46 PM: Hi [~dongjin] 

[jira] [Commented] (KAFKA-9366) Upgrade log4j to log4j2

2022-02-03 Thread Indupriya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486434#comment-17486434 ] Indupriya commented on KAFKA-9366: -- Hi [~dongjin]  Could you please help us any approximate dates for

[jira] (KAFKA-9366) Upgrade log4j to log4j2

2022-02-03 Thread Indupriya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366 ] Indupriya deleted comment on KAFKA-9366: -- was (Author: JIRAUSER284624): Hi [~dongjin] , Con you please confirm. this issue  KAFKA-12399 will resolve all the critical vulnerabilities along with

[jira] [Comment Edited] (KAFKA-9366) Upgrade log4j to log4j2

2022-02-03 Thread Indupriya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486380#comment-17486380 ] Indupriya edited comment on KAFKA-9366 at 2/3/22, 12:34 PM: Hi [~dongjin] ,

[jira] [Comment Edited] (KAFKA-9366) Upgrade log4j to log4j2

2022-02-03 Thread Indupriya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486380#comment-17486380 ] Indupriya edited comment on KAFKA-9366 at 2/3/22, 12:31 PM: Hi [~dongjin] , 

[jira] [Comment Edited] (KAFKA-9366) Upgrade log4j to log4j2

2022-02-03 Thread Indupriya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486380#comment-17486380 ] Indupriya edited comment on KAFKA-9366 at 2/3/22, 12:29 PM: Hi [~dongjin] ,

[jira] [Commented] (KAFKA-13641) Kafka Streams Scala: Add `Option` to `ValueJoiner` parameters

2022-02-03 Thread Mohammad Yousuf Minhaj Zia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486427#comment-17486427 ] Mohammad Yousuf Minhaj Zia commented on KAFKA-13641: If I am not wrong, the

[GitHub] [kafka] Indupa commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-03 Thread GitBox
Indupa commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1028932370 Where I could find it @dongjinleekr ..? And can you help me what is the use of VM parameter and why is it required? Because i Haven't heard of this Vm

[GitHub] [kafka] dajac merged pull request #11730: MINOR: Use ducktape version 0.7.17

2022-02-03 Thread GitBox
dajac merged pull request #11730: URL: https://github.com/apache/kafka/pull/11730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-03 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1028885839 @Indupa Which VM paramater are you using? -Dlog4j.configuration or -Dlog4j.configuration**File**? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] ableegoldman commented on pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2022-02-03 Thread GitBox
ableegoldman commented on pull request #11424: URL: https://github.com/apache/kafka/pull/11424#issuecomment-1028879209 > My read on the code is that we only need to change the TopologyTestDriver, while the first place seems fine to me. Did I miss anything? If by "first place" you

[GitHub] [kafka] Indupa commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-03 Thread GitBox
Indupa commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1028876857 Hi @dongjinleekr , Yeah I refered this article earlier,but didn't get to know the soluton what they are suggesting like Dlog4j.configuration in VM Arguments.I have not seen where

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2022-02-03 Thread GitBox
vamossagar12 commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r798456223 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -329,7 +330,7 @@ private

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2022-02-03 Thread GitBox
vamossagar12 commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r798454215 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java ## @@ -116,14 +123,30 @@ public

[jira] [Commented] (KAFKA-9366) Upgrade log4j to log4j2

2022-02-03 Thread Indupriya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486380#comment-17486380 ] Indupriya commented on KAFKA-9366: -- Can Anyone suggests fix for this vulnerabilities in kafka by the use

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-03 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1028870380 Hi @Indupa, Please refer [here](https://stackoverflow.com/questions/66545546/error-statuslogger-reconfiguration-failed-no-configuration-found-for-73d16e93). --

[jira] [Commented] (KAFKA-13641) Kafka Streams Scala: Add `Option` to `ValueJoiner` parameters

2022-02-03 Thread Kvicii.Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486378#comment-17486378 ] Kvicii.Yu commented on KAFKA-13641: --- [~yzia2000]  hi, I didn't understand what you mean, or you can

[GitHub] [kafka] Indupa commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-03 Thread GitBox
Indupa commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1028865528 Hi @dongjinleekr , yeah I already have made changes to use log4j2 properties, set KAFKA_LOG4J_OPTS. But after that as well, as I sent in my previous comment, iam getting this

[GitHub] [kafka] ableegoldman commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2022-02-03 Thread GitBox
ableegoldman commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r798443526 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -329,7 +330,7 @@ private

[GitHub] [kafka] ableegoldman commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2022-02-03 Thread GitBox
ableegoldman commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r798399133 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java ## @@ -116,14 +123,30 @@ public

[jira] [Resolved] (KAFKA-13583) Fix FetchRequestBetweenDifferentIbpTest flaky tests

2022-02-03 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13583. - Fix Version/s: 3.2.0 3.1.1 Reviewer: David Jacot Resolution:

[GitHub] [kafka] dajac merged pull request #11699: Fix FetchRequestBetweenDifferentIbpTest flaky tests

2022-02-03 Thread GitBox
dajac merged pull request #11699: URL: https://github.com/apache/kafka/pull/11699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac merged pull request #11710: MINOR: MiniTrogdorCluster mutates objects from other threads

2022-02-03 Thread GitBox
dajac merged pull request #11710: URL: https://github.com/apache/kafka/pull/11710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac merged pull request #11727: MINOR:fix AbstractStickyAssignor doc

2022-02-03 Thread GitBox
dajac merged pull request #11727: URL: https://github.com/apache/kafka/pull/11727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-13637) User default.api.timeout.ms config as default timeout for KafkaConsumer.endOffsets

2022-02-03 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13637. - Fix Version/s: 3.0.1 3.2.0 3.1.1 Reviewer: David

[GitHub] [kafka] dajac merged pull request #11726: KAFKA-13637: Use default.api.timeout.ms as default timeout value for KafkaConsumer.endOffsets

2022-02-03 Thread GitBox
dajac merged pull request #11726: URL: https://github.com/apache/kafka/pull/11726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-9366) Upgrade log4j to log4j2

2022-02-03 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486321#comment-17486321 ] Dongjin Lee commented on KAFKA-9366: Hi [~noonbs], this issue will be resolved with KAFKA-12399. I

  1   2   >