[jira] [Comment Edited] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2022-03-01 Thread Guram Savinov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499939#comment-17499939 ] Guram Savinov edited comment on KAFKA-7500 at 3/2/22, 7:48 AM: --- The

[jira] [Commented] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2022-03-01 Thread Guram Savinov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499939#comment-17499939 ] Guram Savinov commented on KAFKA-7500: -- The question is: does mm2 use target topic offsets to infer

[GitHub] [kafka] ableegoldman commented on a change in pull request #11813: KAFKA-12648: fix #add/removeNamedTopology blocking behavior when app is in CREATED

2022-03-01 Thread GitBox
ableegoldman commented on a change in pull request #11813: URL: https://github.com/apache/kafka/pull/11813#discussion_r817412782 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java ## @@ -230,53

[GitHub] [kafka] ableegoldman commented on pull request #11823: MINOR: set log4j.logger.kafka and all Config logger levels to ERROR for Streams tests

2022-03-01 Thread GitBox
ableegoldman commented on pull request #11823: URL: https://github.com/apache/kafka/pull/11823#issuecomment-1056310081 Merged to trunk -- thanks @showuon and @guozhangwang ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] ableegoldman merged pull request #11823: MINOR: set log4j.logger.kafka and all Config logger levels to ERROR for Streams tests

2022-03-01 Thread GitBox
ableegoldman merged pull request #11823: URL: https://github.com/apache/kafka/pull/11823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on a change in pull request #11802: [RFC][1/N]add new RocksDBTimeOrderedWindowStore

2022-03-01 Thread GitBox
guozhangwang commented on a change in pull request #11802: URL: https://github.com/apache/kafka/pull/11802#discussion_r817311291 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/PrefixedWindowKeySchemas.java ## @@ -0,0 +1,311 @@ +/* + * Licensed to

[GitHub] [kafka] guozhangwang commented on a change in pull request #11802: [RFC][1/N]add new RocksDBTimeOrderedWindowStore

2022-03-01 Thread GitBox
guozhangwang commented on a change in pull request #11802: URL: https://github.com/apache/kafka/pull/11802#discussion_r817302405 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/PrefixedWindowKeySchemas.java ## @@ -0,0 +1,311 @@ +/* + * Licensed to

[GitHub] [kafka] vvcephei merged pull request #11828: MINOR: Improve test assertions for IQv2

2022-03-01 Thread GitBox
vvcephei merged pull request #11828: URL: https://github.com/apache/kafka/pull/11828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #11828: MINOR: Improve test assertions for IQv2

2022-03-01 Thread GitBox
vvcephei commented on pull request #11828: URL: https://github.com/apache/kafka/pull/11828#issuecomment-1056073684 The test failures were unrelated: ``` Build / ARM /

[GitHub] [kafka] C0urante commented on pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-01 Thread GitBox
C0urante commented on pull request #11773: URL: https://github.com/apache/kafka/pull/11773#issuecomment-1056069349 Thanks @tombentley! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (KAFKA-8951) Avoid unnecessary rebalances and downtime for "safe" partitions

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-8951: - Labels: new-rebalance-should-fix (was: ) > Avoid unnecessary rebalances and downtime for "safe"

[GitHub] [kafka] C0urante commented on a change in pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-01 Thread GitBox
C0urante commented on a change in pull request #11773: URL: https://github.com/apache/kafka/pull/11773#discussion_r817294374 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,46 @@ protected

[GitHub] [kafka] C0urante commented on a change in pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-01 Thread GitBox
C0urante commented on a change in pull request #11773: URL: https://github.com/apache/kafka/pull/11773#discussion_r817294240 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/TransactionContext.java ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a change in pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-01 Thread GitBox
C0urante commented on a change in pull request #11773: URL: https://github.com/apache/kafka/pull/11773#discussion_r817294047 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/TransactionContext.java ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a change in pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-01 Thread GitBox
C0urante commented on a change in pull request #11773: URL: https://github.com/apache/kafka/pull/11773#discussion_r817293215 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,46 @@ protected

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

2022-03-01 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499849#comment-17499849 ] RivenSun commented on KAFKA-13694: -- Hi [~guozhang] Thanks for your reply. I will create a PR later,

[GitHub] [kafka] C0urante commented on pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-03-01 Thread GitBox
C0urante commented on pull request #11777: URL: https://github.com/apache/kafka/pull/11777#issuecomment-1056061959 Thanks for taking a look, @tombentley. Ready for another pass when you have time. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] C0urante commented on a change in pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-03-01 Thread GitBox
C0urante commented on a change in pull request #11777: URL: https://github.com/apache/kafka/pull/11777#discussion_r817289657 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/FenceProducersResult.java ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] showuon commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-01 Thread GitBox
showuon commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r817287946 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -205,25 +208,31 @@ /** metric.reporters */

[GitHub] [kafka] C0urante commented on a change in pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-03-01 Thread GitBox
C0urante commented on a change in pull request #11777: URL: https://github.com/apache/kafka/pull/11777#discussion_r817287679 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -6281,6 +6284,30 @@ public void

[jira] [Commented] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2022-03-01 Thread Ryanne Dolan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499835#comment-17499835 ] Ryanne Dolan commented on KAFKA-7500: - [~gsavinov] mm2 cannot guarantee that the downstream topics

[jira] [Updated] (KAFKA-7996) KafkaStreams does not pass timeout when closing Producer

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-7996: - Labels: needs-kip new-streams-runtime-should-fix (was: needs-kip) > KafkaStreams does not pass

[jira] [Updated] (KAFKA-10563) Make sure task directories don't remain locked by dead threads

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10563: -- Labels: new-streams-runtime-should-fix (was: ) > Make sure task directories don't remain

[jira] [Updated] (KAFKA-9062) Handle stalled writes to RocksDB

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-9062: - Labels: new-streams-runtime-should-fix (was: ) > Handle stalled writes to RocksDB >

[jira] [Updated] (KAFKA-13295) Long restoration times for new tasks can lead to transaction timeouts

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13295: -- Labels: eos new-streams-runtime-should-fix (was: eos) > Long restoration times for new tasks

[jira] [Updated] (KAFKA-12738) Improved error handling for better at-least-once semantics and faster EOS

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-12738: -- Labels: new-streams-runtime-should-fix (was: ) > Improved error handling for better

[jira] [Updated] (KAFKA-10263) Do not create standbys for those revoking active tasks if it is not stateful

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10263: -- Labels: new-streams-runtime-should-fix (was: ) > Do not create standbys for those revoking

[jira] [Updated] (KAFKA-10294) Consider whether some of ProcessorStateException should be auto-handled by Streams

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10294: -- Labels: new-streams-runtime-should-fix (was: ) > Consider whether some of

[jira] [Updated] (KAFKA-12693) Consecutive rebalances with zombie instances may cause corrupted changelogs

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-12693: -- Labels: new-streams-runtime-should-fix streams (was: streams) > Consecutive rebalances with

[jira] [Updated] (KAFKA-10688) Handle accidental truncation of repartition topics as exceptional failure

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10688: -- Labels: new-streams-runtime-should-fix (was: ) > Handle accidental truncation of repartition

[jira] [Updated] (KAFKA-12812) Consider refactoring state store registration path

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-12812: -- Labels: new-streams-runtime-should-fix (was: ) > Consider refactoring state store

[jira] [Commented] (KAFKA-8023) Improve global state store restoration by using multiple update threads

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499831#comment-17499831 ] Guozhang Wang commented on KAFKA-8023: -- One idea I'm having at the moment is that when we have

[jira] [Updated] (KAFKA-8037) KTable restore may load bad data

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-8037: - Labels: new-streams-runtime-should-fix pull-request-available (was: pull-request-available) >

[GitHub] [kafka] C0urante commented on a change in pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-03-01 Thread GitBox
C0urante commented on a change in pull request #11777: URL: https://github.com/apache/kafka/pull/11777#discussion_r817276211 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -1415,4 +1415,21 @@ public static boolean isBlank(String str) {

[jira] [Updated] (KAFKA-8023) Improve global state store restoration by using multiple update threads

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-8023: - Labels: new-streams-runtime-should-fix performance (was: performance) > Improve global state

[jira] [Updated] (KAFKA-7663) Custom Processor supplied on addGlobalStore is not used when restoring state from topic

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-7663: - Labels: new-streams-runtime-should-fix (was: ) > Custom Processor supplied on addGlobalStore is

[jira] [Updated] (KAFKA-10410) OnRestoreStart disappeared from StateRestoreCallback in 2.6.0 and reappeared in a useless place

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10410: -- Labels: new-streams-runtime-should-fix (was: ) > OnRestoreStart disappeared from

[jira] [Updated] (KAFKA-10829) Kafka Streams handle produce exception improvement

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10829: -- Labels: new-streams-runtime-should-fix (was: ) > Kafka Streams handle produce exception

[jira] [Updated] (KAFKA-10575) StateRestoreListener#onRestoreEnd should always be triggered

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10575: -- Labels: new-streams-runtime-should-fix (was: ) > StateRestoreListener#onRestoreEnd should

[jira] [Updated] (KAFKA-12370) Refactor KafkaStreams exposed metadata hierarchy

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-12370: -- Labels: needs-kip new-streams-runtime-should-fix (was: needs-kip) > Refactor KafkaStreams

[jira] [Updated] (KAFKA-10357) Handle accidental deletion of repartition-topics as exceptional failure

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10357: -- Labels: needs-kip new-streams-runtime-should-fix (was: needs-kip) > Handle accidental

[GitHub] [kafka] C0urante commented on a change in pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-03-01 Thread GitBox
C0urante commented on a change in pull request #11777: URL: https://github.com/apache/kafka/pull/11777#discussion_r817274558 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/FenceProducersHandler.java ## @@ -0,0 +1,148 @@ +/* + * Licensed to the

[jira] [Updated] (KAFKA-10199) Separate state restoration into separate threads

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10199: -- Labels: new-streams-runtime-should-fix (was: ) > Separate state restoration into separate

[jira] [Updated] (KAFKA-10532) Do not wipe state store under EOS when closing-dirty a RESTORING active or RUNNING standby task

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10532: -- Labels: new-streams-runtime-should-fix newbie++ (was: newbie++) > Do not wipe state store

[GitHub] [kafka] C0urante commented on a change in pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-03-01 Thread GitBox
C0urante commented on a change in pull request #11777: URL: https://github.com/apache/kafka/pull/11777#discussion_r817270150 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/FenceProducersHandler.java ## @@ -0,0 +1,148 @@ +/* + * Licensed to the

[GitHub] [kafka] lihaosky opened a new pull request #11829: [RFC][3/N] add processor metadata to be committed with offset

2022-03-01 Thread GitBox
lihaosky opened a new pull request #11829: URL: https://github.com/apache/kafka/pull/11829 Add processor metadata to be committed with offset to broker. Adding this so that we can store last processed window time gracefully. ### Committer Checklist (excluded from commit message)

[GitHub] [kafka] rhauch commented on a change in pull request #11797: KAFKA-12879: Revert changes from KAFKA-12339 and instead add retry capability to KafkaBasedLog

2022-03-01 Thread GitBox
rhauch commented on a change in pull request #11797: URL: https://github.com/apache/kafka/pull/11797#discussion_r816108391 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vvcephei opened a new pull request #11828: MINOR: Improve test assertions for IQv2

2022-03-01 Thread GitBox
vvcephei opened a new pull request #11828: URL: https://github.com/apache/kafka/pull/11828 I saw one isolated test failure for these tests, but I couldn't confirm whether the result was missing a whole partition or whether the iterator for the partition was empty, so I'm adding the actual

[GitHub] [kafka] ableegoldman commented on pull request #11827: MINOR: fix flaky shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing

2022-03-01 Thread GitBox
ableegoldman commented on pull request #11827: URL: https://github.com/apache/kafka/pull/11827#issuecomment-1055939422 Call for review @guozhangwang @wcarlson5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] ableegoldman opened a new pull request #11827: MINOR: fix flaky shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing

2022-03-01 Thread GitBox
ableegoldman opened a new pull request #11827: URL: https://github.com/apache/kafka/pull/11827 This test has been failing somewhat regularly due to going into the ERROR state before reaching RUNNING during the startup phase. The problem is that we are reusing the `DELAYED_INPUT_STREAM`

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499791#comment-17499791 ] Guozhang Wang commented on KAFKA-13694: --- Actually my previous suggestion has a flaw: even when one

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499777#comment-17499777 ] Guozhang Wang commented on KAFKA-13694: --- [~RivenSun] I think that's a good point, I agree with you

[GitHub] [kafka] ableegoldman commented on a change in pull request #11823: MINOR: set log4j.logger.kafka and all Config logger levels to ERROR for Streams tests

2022-03-01 Thread GitBox
ableegoldman commented on a change in pull request #11823: URL: https://github.com/apache/kafka/pull/11823#discussion_r817148861 ## File path: streams/src/test/resources/log4j.properties ## @@ -18,9 +18,18 @@ log4j.appender.stdout=org.apache.log4j.ConsoleAppender

[GitHub] [kafka] ableegoldman commented on pull request #11824: KAFKA-12648: standardize startup timeout to fix some flaky NamedTopologyIntegrationTest tests

2022-03-01 Thread GitBox
ableegoldman commented on pull request #11824: URL: https://github.com/apache/kafka/pull/11824#issuecomment-1055865706 Merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ableegoldman merged pull request #11824: KAFKA-12648: standardize startup timeout to fix some flaky NamedTopologyIntegrationTest tests

2022-03-01 Thread GitBox
ableegoldman merged pull request #11824: URL: https://github.com/apache/kafka/pull/11824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #11824: KAFKA-12648: standardize startup timeout to fix some flaky NamedTopologyIntegrationTest tests

2022-03-01 Thread GitBox
ableegoldman commented on pull request #11824: URL: https://github.com/apache/kafka/pull/11824#issuecomment-1055862814 All test failures are unrelated, with no failures of the highly-flaky NamedTopologyIntegrationTests -- will merge -- This is an automated message from the Apache Git

[GitHub] [kafka] ableegoldman commented on pull request #11812: KAFKA-12738: address minor followup and consolidate integration tests of PR #11787

2022-03-01 Thread GitBox
ableegoldman commented on pull request #11812: URL: https://github.com/apache/kafka/pull/11812#issuecomment-1055862672 Merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ableegoldman commented on pull request #10311: KAFKA-12462: proceed with task revocation in case of thread in PENDING_SHUTDOWN

2022-03-01 Thread GitBox
ableegoldman commented on pull request #10311: URL: https://github.com/apache/kafka/pull/10311#issuecomment-1055859746 > Can we cherry pick with back to 2.6 as well? Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ableegoldman merged pull request #11812: KAFKA-12738: address minor followup and consolidate integration tests of PR #11787

2022-03-01 Thread GitBox
ableegoldman merged pull request #11812: URL: https://github.com/apache/kafka/pull/11812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #11812: KAFKA-12738: address minor followup and consolidate integration tests of PR #11787

2022-03-01 Thread GitBox
ableegoldman commented on pull request #11812: URL: https://github.com/apache/kafka/pull/11812#issuecomment-1055850357 Test failures are unrelated, will merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2022-03-01 Thread Guram Savinov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499755#comment-17499755 ] Guram Savinov commented on KAFKA-7500: -- [~ryannedolan] could you explain, why the KIP-382 requires:

[jira] [Comment Edited] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2022-03-01 Thread Guram Savinov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499755#comment-17499755 ] Guram Savinov edited comment on KAFKA-7500 at 3/1/22, 8:45 PM: ---

[jira] [Commented] (KAFKA-13678) 2nd punctuation using STREAM_TIME does not respect scheduled interval

2022-03-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499753#comment-17499753 ] Matthias J. Sax commented on KAFKA-13678: - We have a different use case in mind: punctuation are

[jira] [Updated] (KAFKA-12462) Threads in PENDING_SHUTDOWN entering a rebalance can cause an illegal state exception

2022-03-01 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-12462: --- Affects Version/s: 2.6.0 > Threads in PENDING_SHUTDOWN entering a rebalance can cause an

[jira] [Commented] (KAFKA-12462) Threads in PENDING_SHUTDOWN entering a rebalance can cause an illegal state exception

2022-03-01 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499736#comment-17499736 ] Walker Carlson commented on KAFKA-12462: This also affects 2.6 > Threads in PENDING_SHUTDOWN

[GitHub] [kafka] mimaison commented on pull request #11572: KAFKA-13510: Connect APIs to list all connector plugins and retrieve …

2022-03-01 Thread GitBox
mimaison commented on pull request #11572: URL: https://github.com/apache/kafka/pull/11572#issuecomment-1055821359 @rhauch Can you take a look? It would be great to get this in 3.2. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] wcarlson5 commented on pull request #10311: KAFKA-12462: proceed with task revocation in case of thread in PENDING_SHUTDOWN

2022-03-01 Thread GitBox
wcarlson5 commented on pull request #10311: URL: https://github.com/apache/kafka/pull/10311#issuecomment-1055820659 Can we cherry pick with back to 2.6 as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-8659) SetSchemaMetadata SMT fails on records with null value and schema

2022-03-01 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499697#comment-17499697 ] Bill Bejeck commented on KAFKA-8659: Merged to trunk, 3.1, and 3.0 branches > SetSchemaMetadata SMT

[GitHub] [kafka] bbejeck commented on pull request #7082: KAFKA-8659: SetSchemaMetadata SMT fails on records with null value and schema

2022-03-01 Thread GitBox
bbejeck commented on pull request #7082: URL: https://github.com/apache/kafka/pull/7082#issuecomment-1055767958 Merged to trunk, 3.0 and 3.1 branches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] junrao merged pull request #11814: MINOR: Ensure LocalLog.flush() is immune to recoveryPoint change by different thread

2022-03-01 Thread GitBox
junrao merged pull request #11814: URL: https://github.com/apache/kafka/pull/11814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-13699) ProcessorContext does not expose Stream Time

2022-03-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499691#comment-17499691 ] Matthias J. Sax commented on KAFKA-13699: - That's my understanding, too. Seems we missed to add

[GitHub] [kafka] guozhangwang commented on a change in pull request #11796: Kip 770

2022-03-01 Thread GitBox
guozhangwang commented on a change in pull request #11796: URL: https://github.com/apache/kafka/pull/11796#discussion_r817035430 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java ## @@ -116,14 +123,30 @@ public

[jira] [Commented] (KAFKA-13699) ProcessorContext does not expose Stream Time

2022-03-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499683#comment-17499683 ] Guozhang Wang commented on KAFKA-13699: --- Hi [~lqxshay] thanks for filing the ticket. Just to

[GitHub] [kafka] wcarlson5 commented on a change in pull request #11813: KAFKA-12648: fix #add/removeNamedTopology blocking behavior when app is in CREATED

2022-03-01 Thread GitBox
wcarlson5 commented on a change in pull request #11813: URL: https://github.com/apache/kafka/pull/11813#discussion_r816411304 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/NamedTopologyTest.java ## @@ -149,7 +149,7 @@ public void

[GitHub] [kafka] bfncs commented on pull request #7082: KAFKA-8659: SetSchemaMetadata SMT fails on records with null value and schema

2022-03-01 Thread GitBox
bfncs commented on pull request #7082: URL: https://github.com/apache/kafka/pull/7082#issuecomment-1055715698 Thanks for reviewing, merging and adding me to Jira, @bbejeck.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] ijuma commented on pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-01 Thread GitBox
ijuma commented on pull request #11788: URL: https://github.com/apache/kafka/pull/11788#issuecomment-1055690966 @mimaison @showuon I left a couple more minor comments that should hopefully be easy to address. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-01 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r816997743 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -202,25 +208,31 @@ /** metric.reporters */

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-01 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r816997743 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -202,25 +208,31 @@ /** metric.reporters */

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-01 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r816996953 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -205,25 +208,31 @@ /** metric.reporters */

[GitHub] [kafka] bbejeck commented on pull request #7082: KAFKA-8659: SetSchemaMetadata SMT fails on records with null value and schema

2022-03-01 Thread GitBox
bbejeck commented on pull request #7082: URL: https://github.com/apache/kafka/pull/7082#issuecomment-1055684585 @bfncs I've also added you as a contributor on Jira so you'll be able to assign tickets to yourself in the future -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] guozhangwang commented on a change in pull request #11823: MINOR: set log4j.logger.kafka and all Config logger levels to ERROR for Streams tests

2022-03-01 Thread GitBox
guozhangwang commented on a change in pull request #11823: URL: https://github.com/apache/kafka/pull/11823#discussion_r816990985 ## File path: streams/src/test/resources/log4j.properties ## @@ -18,9 +18,18 @@ log4j.appender.stdout=org.apache.log4j.ConsoleAppender

[GitHub] [kafka] guozhangwang commented on pull request #11813: KAFKA-12648: fix #add/removeNamedTopology blocking behavior when app is in CREATED

2022-03-01 Thread GitBox
guozhangwang commented on pull request #11813: URL: https://github.com/apache/kafka/pull/11813#issuecomment-1055679613 @ableegoldman I took another look at the latest commit, and LGTM. The jenkins build timeout seems consistent though, and maybe related; after your investigation on

[GitHub] [kafka] mimaison commented on pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-01 Thread GitBox
mimaison commented on pull request #11788: URL: https://github.com/apache/kafka/pull/11788#issuecomment-1055678947 @ijuma Can you take another look? I'm just waiting on this before getting started on 3.0.1. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (KAFKA-13142) KRaft brokers do not validate dynamic configs before forwarding them to controller

2022-03-01 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13142: --- Fix Version/s: (was: 3.0.1) > KRaft brokers do not validate dynamic configs before

[jira] [Commented] (KAFKA-13142) KRaft brokers do not validate dynamic configs before forwarding them to controller

2022-03-01 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499667#comment-17499667 ] Mickael Maison commented on KAFKA-13142: No reply so I'm moving this out of 3.0.1 > KRaft

[jira] [Commented] (KAFKA-13159) Enable system tests for transactions in KRaft mode

2022-03-01 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499666#comment-17499666 ] Mickael Maison commented on KAFKA-13159: No reply so I'm moving it out of 3.0.1 > Enable system

[jira] [Updated] (KAFKA-13159) Enable system tests for transactions in KRaft mode

2022-03-01 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13159: --- Fix Version/s: (was: 3.0.1) > Enable system tests for transactions in KRaft mode >

[jira] [Commented] (KAFKA-13658) Upgrade vulnerable dependencies jan 2022

2022-03-01 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499662#comment-17499662 ] Mickael Maison commented on KAFKA-13658: Back ported to 3.0 and 3.1. Can we resolve this ticket

[jira] [Updated] (KAFKA-13579) Upgrade vulnerable dependencies

2022-03-01 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13579: --- Fix Version/s: 3.0.1 3.1.1 > Upgrade vulnerable dependencies >

[jira] [Updated] (KAFKA-13658) Upgrade vulnerable dependencies jan 2022

2022-03-01 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13658: --- Fix Version/s: 3.0.1 3.1.1 > Upgrade vulnerable dependencies jan 2022 >

[jira] [Assigned] (KAFKA-8659) SetSchemaMetadata SMT fails on records with null value and schema

2022-03-01 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck reassigned KAFKA-8659: -- Assignee: Marc Löhe > SetSchemaMetadata SMT fails on records with null value and schema >

[jira] [Updated] (KAFKA-8659) SetSchemaMetadata SMT fails on records with null value and schema

2022-03-01 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-8659: --- Fix Version/s: 3.0.1 3.1.1 > SetSchemaMetadata SMT fails on records with null

[jira] [Assigned] (KAFKA-8659) SetSchemaMetadata SMT fails on records with null value and schema

2022-03-01 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck reassigned KAFKA-8659: -- Assignee: Bill Bejeck > SetSchemaMetadata SMT fails on records with null value and schema >

[jira] [Assigned] (KAFKA-8659) SetSchemaMetadata SMT fails on records with null value and schema

2022-03-01 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck reassigned KAFKA-8659: -- Assignee: (was: Bill Bejeck) > SetSchemaMetadata SMT fails on records with null value and

[jira] [Resolved] (KAFKA-8659) SetSchemaMetadata SMT fails on records with null value and schema

2022-03-01 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-8659. Resolution: Fixed Resovled via https://github.com/apache/kafka/pull/7082 > SetSchemaMetadata SMT

[jira] [Updated] (KAFKA-8659) SetSchemaMetadata SMT fails on records with null value and schema

2022-03-01 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-8659: --- Fix Version/s: 3.2.0 > SetSchemaMetadata SMT fails on records with null value and schema >

[jira] [Commented] (KAFKA-13658) Upgrade vulnerable dependencies jan 2022

2022-03-01 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499627#comment-17499627 ] Mickael Maison commented on KAFKA-13658: As far as I can tell we're only missing the jackson

[jira] [Commented] (KAFKA-13658) Upgrade vulnerable dependencies jan 2022

2022-03-01 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499618#comment-17499618 ] Bruno Cadonna commented on KAFKA-13658: --- [~mimaison] Are you going to do that or should

[GitHub] [kafka] mimaison commented on pull request #11803: KAFKA-13691: Rename target topic to custom name

2022-03-01 Thread GitBox
mimaison commented on pull request #11803: URL: https://github.com/apache/kafka/pull/11803#issuecomment-1055584957 Hi @ecararus, thanks for the PR. As this is changing public APIs, this type of change requires following the KIP process:

[jira] [Commented] (KAFKA-13658) Upgrade vulnerable dependencies jan 2022

2022-03-01 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499610#comment-17499610 ] Mickael Maison commented on KAFKA-13658: [~cadonna] Thanks for heads up. Yeah we want to update

  1   2   >